On Wed, Nov 10, 2021 at 11:16 AM Bharath Rupireddy
wrote:
>
> On Tue, Nov 9, 2021 at 9:27 PM vignesh C wrote:
> > Attached v12 version is rebased on top of Head.
>
> Thanks for the patch. Here are some comments on v12:
>
> 1) I think ERRCODE_TOO_MANY_ARGUMENTS isn't the right error code, the
> ER
On Sat, Nov 13, 2021 at 4:32 PM Japin Li wrote:
> When I try to insert an Unicode "\u", there is an error $subject.
>
> postgres=# CREATE TABLE tbl (s varchar(10));
> CREATE TABLE
> postgres=# INSERT INTO tbl VALUES (E'\u');
> ERROR: invalid Unicode escape value at or near "\u"
> LINE
On Fri, Nov 12, 2021 at 6:44 PM Alvaro Herrera wrote:
>
> On 2021-Nov-11, Masahiko Sawada wrote:
>
> > On Thu, Nov 11, 2021 at 12:53 PM Amit Kapila
> > wrote:
> > >
> > > On Thu, Nov 11, 2021 at 9:11 AM Andres Freund wrote:
>
> > > > This seems like an unnecessary optimization.
> > > > ProcArr
On Sat, Nov 13, 2021 at 8:18 AM Tomas Vondra
wrote:
>
> On 11/12/21 23:58, Nikolay Samokhvalov wrote:
> > Re-reading the thread [1] (cannot answer there – don't have those emails
> > in my box anymore),
>
> You can download the message as mbox and import it into your client
> (pretty much any clie
On Sat, Nov 13, 2021 at 11:00 AM Bharath Rupireddy
wrote:
>
> Users will always be optimistic and set a recovery target and try to
> reach it, but somehow the few of the WAL files haven't arrived (for
> whatever the reasons) the PITR target server, imagine if their primary
> isn't available too, t
Hi, hackers
When I try to insert an Unicode "\u", there is an error $subject.
postgres=# CREATE TABLE tbl (s varchar(10));
CREATE TABLE
postgres=# INSERT INTO tbl VALUES (E'\u');
ERROR: invalid Unicode escape value at or near "\u"
LINE 1: INSERT INTO tbl VALUES (E'\u');
Hi, hackers
When I try to create table that has a varchar(n) data type, I find an
inconsistent error message for it.
postgres=# CREATE TABLE tbl (s varchar(2147483647));
ERROR: length for type varchar cannot exceed 10485760
LINE 1: CREATE TABLE tbl (s varchar(2147483647));
On Sat, Nov 13, 2021 at 12:06 AM Euler Taveira wrote:
> > Here's a rebased v8 patch. Please review it.
>
> This improves the user experience by increasing the granularity of error
> reporting, and maps well with the precedent set in 81d5995b4. I'm marking
> this
> Ready for Committer and will go
On Fri, Nov 12, 2021 at 4:09 PM Julien Rouhaud wrote:
>
> On Fri, Nov 12, 2021 at 6:14 PM Bharath Rupireddy
> wrote:
> >
> > Currently, the server shuts down with a FATAL error (added by commit
> > [1]) when the recovery target isn't reached. This can cause a server
> > availability problem, espe
On Fri, Nov 12, 2021 at 9:58 AM Alvaro Herrera
wrote:
> Here's a new version. Many of the old complaints have been fixed;
> particularly, the handling of partitioned tables is now much cleaner and
> straightforward. Amit Langote helped considerably in getting this part
> to shape -- thanks for
On Fri, Nov 12, 2021 at 3:13 PM Alvaro Herrera
wrote:
> On 2021-Nov-12, Zhihong Yu wrote:
>
> > Hi,
> >
> > + skipped_path = total - insert_path - update_path -
> delete_path;
> >
> > Should there be an assertion that skipped_path is not negative ?
>
> Hm, yeah, added.
>
> > +* We m
On 11/12/21 11:58 PM, Nikolay Samokhvalov wrote:
> Re-reading the thread [1] (cannot answer there – don't have those emails in
> my box anymore), I see that there was strong support for enabling BUFFERS
> in EXPLAIN ANALYZE by default. And there were patches. Commitfest entry [2]
> was marked Rejec
On Fri, Nov 12, 2021 at 3:27 PM Tom Lane wrote:
> I wasn't aware of $SUBJECT ... were you?
I wasn't aware of this particular example, but I didn't spend much
time worrying about it, because DDL interleaved with DML generally
isn't serializable anyway. If you issue "SELECT * FROM
some_previously_u
On 11/12/21 23:58, Nikolay Samokhvalov wrote:
Re-reading the thread [1] (cannot answer there – don't have those emails
in my box anymore),
You can download the message as mbox and import it into your client
(pretty much any client supports that, I think).
regards
--
Tomas Vondra
Enterpr
On 11/10/21 16:54, Andrey Borodin wrote:
Daniel Gustafsson writes:
2773: libpq compression
===
This patch intended to provide libpq connection compression to "replace SSL
compression" which was doomed when the patch was written, and have since been
removed altogether. Th
On Sat, Nov 13, 2021 at 11:47 AM Ilya Anfimov wrote:
> Currently for glibc the version looks like glibc version at
> initdb, and that doesn't seem very reliable, but that could be a
> different task (to find LC_COLLATE file and put hash of the
> usuable data into version string, for e
On 11/10/21 00:21, Bruce Momjian wrote:
On Tue, Nov 9, 2021 at 12:43:20PM -0500, Stephen Frost wrote:
* Tom Lane (t...@sss.pgh.pa.us) wrote:
Daniel Gustafsson writes:
I'm not Robert, but I still have an opinion here, and that it's that this
feature would at best be an attractive nuisance.
Alvaro Herrera writes:
> I understand that the behavior is not fully correct, but given the way
> most people are going to use this (which is that they're no longer
> terribly interested in the data of the partition being detached/dropped)
> and the severity of the penalties if we implement a full
On 2021-Nov-12, Zhihong Yu wrote:
> Hi,
>
> + skipped_path = total - insert_path - update_path - delete_path;
>
> Should there be an assertion that skipped_path is not negative ?
Hm, yeah, added.
> +* We maintain separate transaction tables for UPDATE/INSERT/DELETE since
> +*
On 2021-Nov-12, Tom Lane wrote:
> I wasn't aware of $SUBJECT ... were you?
Yeah, I remember pointing out that DETACH and DROP and not fully correct
for serializability, but I can't find any thread where I said it in so
many words. At the time I had no ideas on how to fix it; the idea of
waiting
Re-reading the thread [1] (cannot answer there – don't have those emails in
my box anymore), I see that there was strong support for enabling BUFFERS
in EXPLAIN ANALYZE by default. And there were patches. Commitfest entry [2]
was marked Rejected because there were questions to the implementation
ba
On Thu, Nov 11, 2021 at 09:52:52AM -0500, Tom Lane wrote:
> Robert Haas writes:
> > I'm not really convinced that ICU is better, either. I think it's more
> > that it isn't used as much.
>
> Well, at least ICU has a notion of attaching versions to collations.
> How mindful they are of bumping the
Corey Huinker writes:
> Attached is an attempt at an explanation of the edge cases I was
> encountering, as well as some examples. If nothing else, the examples will
> draw eyes and searches to the explanations that were already there.
I looked this over and have a few thoughts:
* I don't think
On Tue, Nov 9, 2021 at 7:02 AM Tom Lane wrote:
> Daniel Gustafsson writes:
> > 2773: libpq compression
> > ===
> > This patch intended to provide libpq connection compression to "replace
> SSL
> > compression" which was doomed when the patch was written, and have since
> been
On Fri, Nov 12, 2021 at 9:58 AM Alvaro Herrera
wrote:
> Here's a new version. Many of the old complaints have been fixed;
> particularly, the handling of partitioned tables is now much cleaner and
> straightforward. Amit Langote helped considerably in getting this part
> to shape -- thanks for
> On 12 Nov 2021, at 16:21, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Attached is a small addition mentioning PG_TEST_NOCLEAN
>
> Maybe could use a bit of copy-editing, say
>
> Data directories will also be left behind for analysis when a test fails;
> they are named according to the te
On Mon, Nov 8, 2021 at 8:20 AM Amul Sul wrote:
> Attached is the rebased version of refactoring as well as the
> pg_prohibit_wal feature patches for the latest master head (commit #
> 39a3105678a).
I spent a lot of time today studying 0002, and specifically the
question of whether EndOfLog must b
Amit Langote writes:
> On Fri, Nov 12, 2021 at 8:19 AM Tom Lane wrote:
>> Anyway, I think that (1) we should write some more test cases around
>> this behavior, (2) you need to establish the snapshot to use in two
>> different ways for the RI_FKey_check and ri_Check_Pk_Match cases,
>> and (3) som
On Fri, Nov 12, 2021 at 11:29 AM Peter Geoghegan wrote:
> We compensate here precisely because we are not running in VACUUM (it
> has to be an opportunistic prune in practice).
> If we're not running in VACUUM, and have to make a statistics
> collector call, then we don't want to forget about DEA
On Wed, Nov 10, 2021 at 12:45 PM Bossart, Nathan wrote:
>
> On 11/8/21, 2:19 PM, "Joshua Brindle" wrote:
> > Thanks for the review, attached is an update with that comment fixed
> > and also sgml documentation changes that I missed earlier.
>
> I think there are a number of documentation changes
I wasn't aware of $SUBJECT ... were you?
Here's a demonstration:
drop table if exists pk, fk, pk1, pk2;
create table pk (f1 int primary key) partition by list(f1);
create table pk1 partition of pk for values in (1);
create table pk2 partition of pk for values in (2);
insert into pk values(1);
ins
On 11/12/21, 11:58 AM, "Tom Lane" wrote:
> "Bossart, Nathan" writes:
>> I haven't started on the SIGINT stuff yet, but I did extract the
>> PQuser() fix so that we can hopefully get that one out of the way. I
>> made some small adjustments in an attempt to keep the branching in
>> this function
"Bossart, Nathan" writes:
> I haven't started on the SIGINT stuff yet, but I did extract the
> PQuser() fix so that we can hopefully get that one out of the way. I
> made some small adjustments in an attempt to keep the branching in
> this function from getting too complicated.
Right, it makes s
On Fri, Nov 12, 2021 at 10:45 AM Peter Geoghegan wrote:
> Let's assume that somehow I have it wrong. Even then, why should we
> compensate like this for the stats collector, but not for VACUUM?
> There's certainly no corresponding code in vacuumlazy.c that does a
> similar transformation with ndel
On Fri, Nov 12, 2021, at 3:10 AM, houzj.f...@fujitsu.com wrote:
> On Fri, Nov 12, 2021 1:33 PM Amit Kapila wrote:
> > On Fri, Nov 12, 2021 at 10:50 AM Amit Kapila
> > wrote:
> > > But won't that generate invalidation for the rel twice in the case
> > > (change Replica Identity from Nothing to so
The following code appears at the end of heap_page_prune():
/*
* If requested, report the number of tuples reclaimed to pgstats. This is
* ndeleted minus ndead, because we don't want to count a now-DEAD root
* item as a deletion for this purpose.
*/
if (report_stats &&
On Wed, Oct 13, 2021 at 05:28:30PM +0300, Ekaterina Sokolova wrote:
> Hi, hackers!
>
> • pg_query_state is contrib with 2 patches for core (I hope someday
> Community will support adding this patches to PostgreSQL). It contains
I reviewed this version of the patch - I have some language fixes
On Fri, Nov 12, 2021, at 9:41 AM, Daniel Gustafsson wrote:
> > On 4 Nov 2021, at 05:24, Bharath Rupireddy
> > wrote:
> >
> > On Wed, Nov 3, 2021 at 6:21 PM Daniel Gustafsson wrote:
> >>
> >>> On 26 Jul 2021, at 09:33, Bharath Rupireddy
> >>> wrote:
> >>
> >>> PSA v7.
> >>
> >> This patch n
On 2021-Nov-12, Tomas Vondra wrote:
> On 11/12/21 18:57, Alvaro Herrera wrote:
> > Secondarily, and I'm now not sure that I really want to do it, is change
> > the representation for executor: instead of creating a fake join between
> > target and source, perhaps we should have just source, and g
On Mon, Nov 1, 2021 at 02:24:36PM -0400, Stephen Frost wrote:
> I can understand the general idea that we should be sure to engineer
> this in a way that multiple methods can be used, as surely one day folks
> will say that AES128 isn't acceptable any more. In terms of what we'll
> do from the st
On 11/12/21 18:57, Alvaro Herrera wrote:
Here's a new version. Many of the old complaints have been fixed;
particularly, the handling of partitioned tables is now much cleaner and
straightforward. Amit Langote helped considerably in getting this part
to shape -- thanks for that. Amit also help
Hi,
I think this is ready to go. I was wondering why it merely doubles the
number of buffers, as described by previous comments. That seems like a
very tiny increase, so considering how much the hardware grew over the
last few years it'd probably fail to help some of the large boxes.
But it
On Mon, Nov 02, 2020 at 01:50:57PM +1300, David Rowley wrote:
> On Tue, 27 Oct 2020 at 19:40, Amit Langote wrote:
> > Some comments:
>
> Thanks for having a look at this.
>
> I've made some adjustments to those comments and pushed.
commit a929e17e5 doesn't appear in the v14 release notes, but I
I made a mistake in the configuration of my test script, in fact I cannot
reproduce the problem at the moment.
Yes, on the original environment there is physical replication, that's why
for the lab I configured 2 nodes with physical replication.
I'll try new tests next week
Regards
On Fri, Nov 12,
The combination of these two statements in a transaction hits an
Assert in heapam.c at line 4770 on REL_14_STABLE
BEGIN;
SELECT * FROM queue LIMIT 1 FOR UPDATE SKIP LOCKED;
...
UPDATE queue SET status = 'UPDATED' WHERE id = :id;
COMMIT;
pgbench reliably finds this, running from inside a PL/pgSQL
"Dian M Fay" writes:
> Eminently reasonable all around! `git apply` insisted that the v8 patch
> didn't (apply, that is), but `patch -p1` liked it fine. I've put it
> through a few paces and it seems good; what needs to happen next?
I don't see anything else to do except shove it out into the lig
> On 9 Nov 2021, at 18:43, Stephen Frost wrote:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>> Daniel Gustafsson writes:
>>> 2773: libpq compression
>>> ===
>>> This patch intended to provide libpq connection compression to "replace SSL
>>> compression" which was doomed when the
On 11/12/21 10:05, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 11/11/21 15:44, Tom Lane wrote:
>>> Yeah ... configure is already checking those versions, so maybe we could
>>> make it print them out along the way? I'd been thinking of doing exactly
>>> this just for documentation purposes, s
On Thu, Nov 11, 2021 at 6:07 PM Alvaro Herrera
wrote:
> On 2021-Nov-10, Bossart, Nathan wrote:
>
> > On 11/10/21, 9:43 AM, "Bharath Rupireddy" <
> bharath.rupireddyforpostg...@gmail.com> wrote:
> > > As discussed in [1], isn't it a better idea to add some of activity
> > > messages [2] such as re
On 11/12/21 7:51 AM, Daniel Gustafsson wrote:
It should be a free-form textfield, and only apply to new submissions to avoid
a need to backfill. The field should, IMHO, be mandatory. The implementation
can be left to discussion on -www iff this list agrees that it would be a good
thing.
+1.
Peter Eisentraut writes:
> On 11.11.21 21:04, Andrew Dunstan wrote:
>> But I'd really like it if we could shift the goalposts a bit and require
>> 0.96. subtests would be really nice to have available. Unfortunately I
>> don't have any idea what versions of Test::More are actually in use.
> My in
On 11/11/21, 9:20 AM, "Robert Haas" wrote:
> memory, and not much is lost if they are set up and not used. So, in
> 0001, I propose to move the call to InitXLogInsert() from
> InitXLOGAccess() to BaseInit(). That means every backend will do it
> the first time it starts up. It also means that Crea
Daniel Gustafsson writes:
> Attached is a small addition mentioning PG_TEST_NOCLEAN
Maybe could use a bit of copy-editing, say
Data directories will also be left behind for analysis when a test fails;
they are named according to the test filename. But if the environment
variable PG_TEST_NOCLEAN
> On 31 Oct 2021, at 23:13, Tom Lane wrote:
> Done that way; feel free to add more material to perl/README.
Attached is a small addition mentioning PG_TEST_NOCLEAN
--
Daniel Gustafsson https://vmware.com/
readme_retaindir.diff
Description: Binary data
Andrew Dunstan writes:
> On 11/11/21 15:44, Tom Lane wrote:
>> Yeah ... configure is already checking those versions, so maybe we could
>> make it print them out along the way? I'd been thinking of doing exactly
>> this just for documentation purposes, so if there's a concrete need for
>> it, let
Julien Rouhaud writes:
> On Fri, Nov 12, 2021 at 8:51 PM Daniel Gustafsson wrote:
>> It should be a free-form textfield, and only apply to new submissions to
>> avoid
>> a need to backfill. The field should, IMHO, be mandatory. The
>> implementation
>> can be left to discussion on -www iff th
On 11/11/21 15:44, Tom Lane wrote:
> Alvaro Herrera writes:
>> On 2021-Nov-11, Andrew Dunstan wrote:
>>> Perhaps we could add a line to one of the TAP tests that would spit out
>>> the version on the log?
>> Maybe have it spit out the version of *all* the modules we require
>> (which aren't all t
> On Fri, Nov 12, 2021 at 03:36:43PM +0100, Daniel Gustafsson wrote:
> > On 12 Nov 2021, at 15:24, Justin Pryzby wrote:
> >
> > On Fri, Nov 12, 2021 at 01:51:28PM +0100, Daniel Gustafsson wrote:
> >> While reading through and working with the hundreds of patches in the CF
> >> app a
> >> small fe
On 11/12/21, 4:53 AM, "Daniel Gustafsson" wrote:
> While reading through and working with the hundreds of patches in the CF app a
> small feature/process request struck me: it would be really helpful if the
> patch had a brief abstract outlining what it aims to add or fix (or summary,
> descriptio
On Fri, Nov 12, 2021 at 8:42 AM Peter Eisentraut
wrote:
> There are standards for sort order, and the major hiccups we had in the
> past were mostly moving from older versions of those standards to newer
> versions. So at some point this should stabilize.
Only if they don't keep making new versi
> On 12 Nov 2021, at 15:24, Justin Pryzby wrote:
>
> On Fri, Nov 12, 2021 at 01:51:28PM +0100, Daniel Gustafsson wrote:
>> While reading through and working with the hundreds of patches in the CF app
>> a
>> small feature/process request struck me: it would be really helpful if the
>> patch had
Amit Langote writes:
> Whatever mechanism we will use would still need to involve setting a
> global Snapshot variable though, right?
In v14 we'll certainly still be passing the snapshot(s) to SPI, which will
eventually make the snapshot active. With your patch, since we're just
handing the snap
On Fri, Nov 12, 2021 at 01:51:28PM +0100, Daniel Gustafsson wrote:
> While reading through and working with the hundreds of patches in the CF app a
> small feature/process request struck me: it would be really helpful if the
> patch had a brief abstract outlining what it aims to add or fix (or summ
On Fri, Nov 12, 2021 at 10:58 AM Tom Lane wrote:
> I wrote:
> > Anyway, I think that (1) we should write some more test cases around
> > this behavior, (2) you need to establish the snapshot to use in two
> > different ways for the RI_FKey_check and ri_Check_Pk_Match cases,
> > and (3) something's
On 11.11.21 21:04, Andrew Dunstan wrote:
But I'd really like it if we could shift the goalposts a bit and require
0.96. subtests would be really nice to have available. Unfortunately I
don't have any idea what versions of Test::More are actually in use.
My initial patch for TAP tests used subte
On 11.11.21 18:32, Robert Haas wrote:
I agree with Tom that it sounds like a lot of work. And to be honest
it's work that I don't really feel very excited about. It would be
necessary to understand not only the bona fide sorting rules of every
human language out there, which might actually be sor
On 2021-Nov-11, Masahiko Sawada wrote:
> On Thu, Nov 11, 2021 at 12:53 PM Amit Kapila wrote:
> >
> > On Thu, Nov 11, 2021 at 9:11 AM Andres Freund wrote:
> > > This seems like an unnecessary optimization.
> > > ProcArrayInstallRestoredXmin()
> > > only happens in the context of much more expen
On Fri, Nov 12, 2021 at 8:51 PM Daniel Gustafsson wrote:
>
> While reading through and working with the hundreds of patches in the CF app a
> small feature/process request struck me: it would be really helpful if the
> patch had a brief abstract outlining what it aims to add or fix (or summary,
>
While reading through and working with the hundreds of patches in the CF app a
small feature/process request struck me: it would be really helpful if the
patch had a brief abstract outlining what it aims to add or fix (or summary,
description or something else; not sure what to call it). Basically
> On 4 Nov 2021, at 05:24, Bharath Rupireddy
> wrote:
>
> On Wed, Nov 3, 2021 at 6:21 PM Daniel Gustafsson wrote:
>>
>>> On 26 Jul 2021, at 09:33, Bharath Rupireddy
>>> wrote:
>>
>>> PSA v7.
>>
>> This patch no longer applies on top of HEAD, please submit a rebased version.
>
> Here's a r
On Fri, Nov 12, 2021 at 5:15 PM Bharath Rupireddy
wrote:
>
> On Thu, Nov 11, 2021 at 12:14 PM vignesh C wrote:
> > Thanks for the comments, the attached v10 patch has the fixes for the same.
>
> Thanks for the patches. Here are some comments:
>
> 1) In the docs, let's have the similar description
On Thu, Nov 11, 2021 at 12:14 PM vignesh C wrote:
> Thanks for the comments, the attached v10 patch has the fixes for the same.
Thanks for the patches. Here are some comments:
1) In the docs, let's have the similar description of
pg_log_backend_memory_contexts for pg_print_backtrace, just for th
On Fri, Nov 12, 2021 at 6:14 PM Bharath Rupireddy
wrote:
>
> Currently, the server shuts down with a FATAL error (added by commit
> [1]) when the recovery target isn't reached. This can cause a server
> availability problem, especially in case of disaster recovery (geo
> restores) where the primar
On Sat, Oct 23, 2021 at 1:46 AM Jeff Davis wrote:
> What do you want to do after the timeout happens? If you want to issue
> a WARNING instead of failing outright, perhaps that makes sense for
> exploratory PITR cases. That could be a simple boolean GUC without
> needing to introduce the timeout l
Hi,
Currently, the server shuts down with a FATAL error (added by commit
[1]) when the recovery target isn't reached. This can cause a server
availability problem, especially in case of disaster recovery (geo
restores) where the primary was down and the user is doing a PITR on a
server lying in an
On Friday, November 12, 2021 2:24 PM Amit Kapila
wrote:
>
> On Thu, Nov 11, 2021 at 11:15 PM Fabrice Chapuis
> wrote:
> >
> > Hello,
> > Our lab is ready now. Amit, I compile Postgres 10.18 with your patch.Tang,
> > I
> used your script to configure logical replication between 2 databases and
76 matches
Mail list logo
