Re: ltree_gist indexes broken after pg_upgrade from 12 to 13

2022-03-05 Thread Alexander Korotkov
Hi! Sorry for this terrible oversight by me. On Sat, Mar 5, 2022 at 10:13 AM Tomas Vondra wrote: > On 3/4/22 23:09, Nikita Glukhov wrote: > > On 04.03.2022 23:28, Tom Lane wrote: > > > >> Tomas Vondra writes: > >>> On 3/4/22 20:29, Nikita Glukhov wrote: > So, we probably have corrupted ind

Re: Allow async standbys wait for sync replication

2022-03-05 Thread Bharath Rupireddy
On Sun, Mar 6, 2022 at 1:57 AM Andres Freund wrote: > > Hi, > > On 2022-03-05 14:14:54 +0530, Bharath Rupireddy wrote: > > I understand. Even if we use the SyncRepWaitForLSN approach, the async > > walsenders will have to do nothing in WalSndLoop() until the sync > > walsender wakes them up via Sy

Re: timestamp for query in pg_stat_statements

2022-03-05 Thread Julien Rouhaud
On Sat, Mar 05, 2022 at 06:10:44PM -0800, Zhihong Yu wrote: > > Looking at pg_stat_statements, there doesn't seem to be timestamp column > for when the underlying query is performed. > Since the same query can be run multiple times, the absence of timestamp > column makes finding the most recent in

timestamp for query in pg_stat_statements

2022-03-05 Thread Zhihong Yu
Hi, Looking at pg_stat_statements, there doesn't seem to be timestamp column for when the underlying query is performed. Since the same query can be run multiple times, the absence of timestamp column makes finding the most recent invocation of the query difficult. Does it make sense to add such a

Re: JSON path decimal literal syntax

2022-03-05 Thread Nikita Glukhov
On 24.02.2022 21:24, Peter Eisentraut wrote: On 18.02.22 11:17, Peter Eisentraut wrote: I noticed that the JSON path lexer does not support the decimal literal syntax forms .1 1. (that is, there are no digits before or after the decimal point).  This is allowed by the relevant ECMAScript st

Re: range_agg with multirange inputs

2022-03-05 Thread Paul Jungwirth
On 3/1/22 13:33, Chapman Flack wrote: I think the 4 lines should suffice, but it looks like this patch was generated from a rebase of the old one (with three lines) that ended up putting the new 'range_agg' entry ahead of 'max' in func.sgml, which position is now baked into the 4 lines of context

Re: Allow async standbys wait for sync replication

2022-03-05 Thread Andres Freund
Hi, On 2022-03-05 14:14:54 +0530, Bharath Rupireddy wrote: > I understand. Even if we use the SyncRepWaitForLSN approach, the async > walsenders will have to do nothing in WalSndLoop() until the sync > walsender wakes them up via SyncRepWakeQueue. I still think we should flat out reject this appr

Re: Proposal: Support custom authentication methods using hooks

2022-03-05 Thread Jeff Davis
On Wed, 2022-03-02 at 10:54 -0500, Stephen Frost wrote: > It's our decision what we want to support and maintain in the code > base > and what we don't. That might be an argument in favor of custom auth methods, because we could move built-in methods that we don't like into a contrib module that i

Re: [PoC] Let libpq reject unexpected authentication requests

2022-03-05 Thread Tom Lane
Andrew Dunstan writes: > On 3/4/22 20:19, Tom Lane wrote: >> Seems reasonable, but I bet that for very little more code you could >> accept a comma-separated list of allowed methods; libpq already allows >> comma-separated lists for some other connection options. That seems >> like it'd be a usef

Re: [PoC] Let libpq reject unexpected authentication requests

2022-03-05 Thread Andrew Dunstan
On 3/4/22 20:19, Tom Lane wrote: > Jacob Champion writes: >> $subject keeps coming up in threads. I think my first introduction to >> it was after the TLS injection CVE, and then it came up again in the >> pluggable auth thread. It's hard for me to generalize based on "sound >> bites", but among

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-05 Thread Andrew Dunstan
On 3/4/22 17:04, Andres Freund wrote: > Hi, > > On 2022-03-04 16:51:32 -0500, Tom Lane wrote: >> Andres Freund writes: >>> That fixed the immediate problem, but dblink, postgres_fdw tests failed: >>> +ERROR: could not establish connection >>> +DETAIL: connection to server at "localhost" (::1),

Re: Make unlogged table resets detectable

2022-03-05 Thread Michael Paquier
On Fri, Mar 04, 2022 at 10:12:27AM -0600, Justin Pryzby wrote: > Is this patch targetting pg15 ? > There's no discussion since June. > > Latest at 2021-06-08 21:29:25 by Jeff Davis This is too long, so let's discard this patch for now. -- Michael signature.asc Description: PGP signature

Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit

2022-03-05 Thread Etsuro Fujita
On Mon, Feb 28, 2022 at 6:53 PM Etsuro Fujita wrote: > Here is an updated version. I added to the 0003 patch a macro for > defining the milliseconds to wait, as proposed by David upthread. I modified the 0003 patch further: 1) I added to pgfdw_cancel_query_end/pgfdw_exec_cleanup_query_end the PQ

Re: pl/pgsql feature request: shorthand for argument and local variable references

2022-03-05 Thread Michael Paquier
On Sat, Mar 05, 2022 at 04:54:18PM +0800, Julien Rouhaud wrote: > On Thu, Jan 06, 2022 at 05:05:32PM +0800, Julien Rouhaud wrote: >> Anyway, the only committer that showed some interest in the feature is >> Michael, >> and he seemed ok in principle with the "alias-implementation" approach. >> Mich

Re: wal_compression=zstd

2022-03-05 Thread Michael Paquier
On Fri, Mar 04, 2022 at 08:08:03AM -0500, Robert Haas wrote: > On Fri, Mar 4, 2022 at 6:44 AM Justin Pryzby wrote: >> In my 1-off test, it gets 610/633 = 96% of the benefit at 209/273 = 77% of >> the >> cost. Hmm, it may be good to start afresh and compile numbers in a single chart. I did that

Re: pl/pgsql feature request: shorthand for argument and local variable references

2022-03-05 Thread Julien Rouhaud
On Thu, Jan 06, 2022 at 05:05:32PM +0800, Julien Rouhaud wrote: > > Anyway, the only committer that showed some interest in the feature is > Michael, > and he seemed ok in principle with the "alias-implementation" approach. > Michael, did you have a look at this version ([1]), or do you think it s

Re: Allow async standbys wait for sync replication

2022-03-05 Thread Bharath Rupireddy
On Sat, Mar 5, 2022 at 1:26 AM Nathan Bossart wrote: > > On Wed, Mar 02, 2022 at 09:47:09AM +0530, Bharath Rupireddy wrote: > > On Wed, Mar 2, 2022 at 2:57 AM Nathan Bossart > > wrote: > >> I think there are a couple of advantages. For one, spinning is probably > >> not the best from a resource

Re: ICU for global collation

2022-03-05 Thread Julien Rouhaud
Hi, On Wed, Feb 16, 2022 at 03:25:40PM +0100, Peter Eisentraut wrote: > > All that preliminary work has been completed, so here is a new patch. > > There isn't actually much left here now except all the new DDL and > command-line options to set this up and documentation for those. I have > given