Re: generic plans and "initial" pruning

2022-04-01 Thread Amit Langote
On Fri, Apr 1, 2022 at 1:08 PM David Rowley wrote: > On Fri, 1 Apr 2022 at 16:09, Amit Langote wrote: > > definition of PlannedStmt says this: > > > > /* > > * PlannedStmt node > > * > > * The output of the planner > > > > With the ideas that you've outlined below,

Re: Error "initial slot snapshot too large" in create replication slot

2022-04-01 Thread Kyotaro Horiguchi
At Fri, 01 Apr 2022 14:44:30 +0900 (JST), Kyotaro Horiguchi wrote in > At Sun, 13 Feb 2022 17:35:38 +0300, Yura Sokolov > wrote in > > And there are checks for `takenDuringRecovery` in `heapgetpage` and > > `heapam_scan_sample_next_tuple`. Are this checks affected by the change? > > Neither

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

2022-04-01 Thread Thomas Munro
Some thoughts: The v1-0003 patch introduced smgropen_cond() to avoid the problem of IssuePendingWritebacks(), which does desynchronised smgropen() calls and could open files after the barrier but just before they are unlinked. Makes sense, but... 1. For that to actually work, we'd better call

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

2022-04-01 Thread Michael Paquier
On Thu, Mar 31, 2022 at 10:51:59PM -0500, Justin Pryzby wrote: > Is diff -q defined somewhere ? I can't find it in postgres sources nor in > sources for bf client. 322becb has added such a call, at the end of 002_pg_upgrade.pl. vcregress.pl also has one before this commit. -- Michael

<    1   2