Re: Privileges on PUBLICATION

2022-05-11 Thread Peter Eisentraut
On 10.05.22 10:37, Antonin Houska wrote: My understanding is that the rows/columns filtering is a way for the *publisher* to control which data is available to particular replica. From this point of view, the publication privileges would just make the control complete. I think privileges on

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
>> Thank you for the info, but unfortunately it hasn't worked. >> I'm going to try a slightly different steps.. > > And finally I succeeded to clone from git.postgresql.org and to push a > commit. Is it git.postgresql.org, not gitmaster.postgresql.org? Interesting... Best reagards, -- Tatsuo

Re: First draft of the PG 15 release notes

2022-05-11 Thread Amit Langote
On Wed, May 11, 2022 at 11:41 PM Bruce Momjian wrote: > On Wed, May 11, 2022 at 04:02:31PM +0900, Amit Langote wrote: > > On Wed, May 11, 2022 at 12:44 AM Bruce Momjian wrote: > > > I have completed the first draft of the PG 15 release notes > > The commit is intended to only change the behavior

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

2022-05-11 Thread Michael Paquier
On Tue, May 10, 2022 at 10:32:55PM -0700, Noah Misch wrote: > Why did you discontinue testing the longstanding test database name? I am not sure what you mean here. Are you saying that the test should be changed to prefix each database name by "regression", as it was the case in test.sh? Or do

Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-05-11 Thread Michael Paquier
On Wed, May 11, 2022 at 08:32:14PM -0700, Andres Freund wrote: > I'll try to fix it tomorrow... Sorry for the delay. Thanks, Andres. -- Michael signature.asc Description: PGP signature

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

2022-05-11 Thread Thomas Munro
On Thu, May 12, 2022 at 3:13 PM Thomas Munro wrote: > Chipmunk, another little early model Raspberry Pi: > > error running SQL: 'psql::1: ERROR: source database > "conflict_db_template" is being accessed by other users > DETAIL: There is 1 other session using the database.' Oh, for this one I

Re: gitmaster access

2022-05-11 Thread Kyotaro Horiguchi
At Thu, 12 May 2022 11:44:33 +0900 (JST), Kyotaro Horiguchi wrote in > At Thu, 12 May 2022 10:34:49 +0900 (JST), Tatsuo Ishii > wrote in > > Last year we faced a similar problem, namely, a new committer for > > pgpool.git could not access the git repository (Permission denied > >

Re: Skipping schema changes in publication

2022-05-11 Thread vignesh C
On Tue, May 10, 2022 at 9:08 AM vignesh C wrote: > > On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote: > > > > On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote: > > > > > ... > > > > > > Another idea that occurred to me today for tables this is as follows: > > > 1. Allow to mention except

Re: Comments on Custom RMGRs

2022-05-11 Thread Andres Freund
Hi, On 2022-05-11 09:39:48 -0700, Jeff Davis wrote: > On Wed, 2022-05-11 at 15:24 +0100, Simon Riggs wrote: > > [PATCH: rmgr_001.v1.patch] > > > > [PATCH: rmgr_002.v1.patch] > > Thank you. Both of these look like good ideas, and I will commit them > in a few days assuming that nobody else sees

Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-05-11 Thread Andres Freund
Hi, On 2022-05-11 15:48:40 +0900, Michael Paquier wrote: > On Mon, Apr 25, 2022 at 03:18:52PM +0900, Michael Paquier wrote: > > On Wed, Apr 20, 2022 at 01:03:20PM +0200, Erik Rijkers wrote: > >> Yes, that seems to fix it: I applied that latter patch, and ran my program > >> 250x without errors.

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

2022-05-11 Thread Thomas Munro
On Sat, May 7, 2022 at 9:37 PM Thomas Munro wrote: > So far "grison" failed. I think it's probably just that the test > forgot to wait for replay of CREATE EXTENSION before using pg_prewarm > on the standby, hence "ERROR: function pg_prewarm(oid) does not exist > at character 12". I'll wait

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
>> I assume the URL list at: >>https://git.postgresql.org/gitweb/?p=postgresql.git;a=summary >> is for non-committers. > > Yeah, I agree with that. If we advertise the gitmaster address here, > the primary result will be that we get a lot of complaints from random > people complaining that

Re: Support logical replication of DDLs

2022-05-11 Thread Amit Kapila
On Wed, May 11, 2022 at 6:25 PM Masahiko Sawada wrote: > > On Wed, May 11, 2022 at 6:15 PM Amit Kapila wrote: > > > > On Wed, May 11, 2022 at 1:09 PM Masahiko Sawada > > wrote: > > > > > > On Mon, May 9, 2022 at 6:05 PM Alvaro Herrera > > > wrote: > > > > > > > > > > > > The code in

Re: First draft of the PG 15 release notes

2022-05-11 Thread Ian Lawrence Barwick
2022年5月12日(木) 11:46 Bruce Momjian : > > On Thu, May 12, 2022 at 11:40:17AM +0900, Ian Lawrence Barwick wrote: > > Looking at the release notes from the point of view of someone who has maybe > > not been following the long-running debate on removing exclusive backups: > > > > "Important-sounding

Re: First draft of the PG 15 release notes

2022-05-11 Thread Bruce Momjian
On Thu, May 12, 2022 at 11:40:17AM +0900, Ian Lawrence Barwick wrote: > Looking at the release notes from the point of view of someone who has maybe > not been following the long-running debate on removing exclusive backups: > > "Important-sounding backup thing is suddenly gone! What was that >

Re: gitmaster access

2022-05-11 Thread Kyotaro Horiguchi
At Thu, 12 May 2022 10:34:49 +0900 (JST), Tatsuo Ishii wrote in > Last year we faced a similar problem, namely, a new committer for > pgpool.git could not access the git repository (Permission denied > (publickey)). Magnus kindly advised following and it worked. Hope this > helps. > > > 1. Log

Re: First draft of the PG 15 release notes

2022-05-11 Thread Tom Lane
Bruce Momjian writes: > On Thu, May 12, 2022 at 10:37:56AM +0900, Ian Lawrence Barwick wrote: Remove exclusive backup mode (David Steele, Nathan Bossart) >> It'd be useful to mention exclusive backup mode has been deprecated since >> 9.6, >> lest the impression arise that an

Re: gitmaster access

2022-05-11 Thread Tom Lane
Bruce Momjian writes: > On Wed, May 11, 2022 at 08:59:26PM -0400, Bruce Momjian wrote: >> On Thu, May 12, 2022 at 09:04:38AM +0900, Tatsuo Ishii wrote: >>> The last line should be >>> "ssh://g...@gitmaster.postgresql.org/postgresql.git"? > I assume the URL list at: >

Re: First draft of the PG 15 release notes

2022-05-11 Thread Ian Lawrence Barwick
2022年5月12日(木) 11:01 Bruce Momjian : > > On Thu, May 12, 2022 at 10:37:56AM +0900, Ian Lawrence Barwick wrote: > > >> Remove exclusive backup mode (David Steele, Nathan Bossart) > > >> > > >> If the database server stops abruptly while in this mode, the server > > >> could fail to start. > > >>

Re: First draft of the PG 15 release notes (sorting)

2022-05-11 Thread Bruce Momjian
On Thu, May 12, 2022 at 01:59:36PM +1200, Thomas Munro wrote: > On Thu, May 12, 2022 at 12:53 PM Bruce Momjian wrote: > > > > > > Improve performance and reduce memory consumption of in-memory > > sorts (Ronan Dunklau, David Rowley, Thomas Munro) > > > >

Re: First draft of the PG 15 release notes

2022-05-11 Thread Bruce Momjian
On Thu, May 12, 2022 at 10:37:56AM +0900, Ian Lawrence Barwick wrote: > >> Remove exclusive backup mode (David Steele, Nathan Bossart) > >> > >> If the database server stops abruptly while in this mode, the server could > >> fail to start. > >> The non-exclusive backup mode requires a continuous

Re: First draft of the PG 15 release notes (sorting)

2022-05-11 Thread Thomas Munro
On Thu, May 12, 2022 at 12:53 PM Bruce Momjian wrote: > > > Improve performance and reduce memory consumption of in-memory > sorts (Ronan Dunklau, David Rowley, Thomas Munro) > > I'd also add John Naylor here, as he did a lot of work to

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
> On Thu, May 12, 2022 at 10:34:49AM +0900, Tatsuo Ishii wrote: >> Last year we faced a similar problem, namely, a new committer for >> pgpool.git could not access the git repository (Permission denied >> (publickey)). Magnus kindly advised following and it worked. Hope this >> helps. >> >> > 1.

RE: Data is copied twice when specifying both child and parent table in publication

2022-05-11 Thread osumi.takami...@fujitsu.com
On Wednesday, May 11, 2022 11:33 AM I wrote: > On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com > wrote: > > Attach new patches. > > The patch for HEAD: > > 1. Modify the approach. Enhance the API of function > > pg_get_publication_tables to handle one publication or an array of > >

Re: gitmaster access

2022-05-11 Thread Bruce Momjian
On Thu, May 12, 2022 at 10:34:49AM +0900, Tatsuo Ishii wrote: > Last year we faced a similar problem, namely, a new committer for > pgpool.git could not access the git repository (Permission denied > (publickey)). Magnus kindly advised following and it worked. Hope this > helps. > > > 1. Log into

Re: First draft of the PG 15 release notes

2022-05-11 Thread Ian Lawrence Barwick
2022年5月11日(水) 0:44 Bruce Momjian : > > I have completed the first draft of the PG 15 release notes and you can > see the results here: > > https://momjian.us/pgsql_docs/release-15.html > > The feature count is similar to recent major releases: > > release-10 195 >

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
> Thanks for the inspection. I understand what the ssh server is facing. > > I had already filled the filed with an (I beilive correct) openssh > public key, but to make sure, I emptied the field "SSH key", waited > for 20 minutes, then added a fresh pubkey and waited for 20 minutes. > > I tried

Re: gitmaster access

2022-05-11 Thread Kyotaro Horiguchi
At Wed, 11 May 2022 10:40:00 +0100, Dave Page wrote in > OK, so you have write access on the repo on git.postgresql.org, but I can't > find an SSH key for your account on the system. Can you check > https://www.postgresql.org/account/profile/ and make sure you've got the > correct SSH key in

Re: gitmaster access

2022-05-11 Thread Bruce Momjian
On Wed, May 11, 2022 at 08:59:26PM -0400, Bruce Momjian wrote: > On Thu, May 12, 2022 at 09:04:38AM +0900, Tatsuo Ishii wrote: > > Then we need to change this, no? > > > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=summary > > > > URL git://git.postgresql.org/git/postgresql.git > >

Re: gitmaster access

2022-05-11 Thread Bruce Momjian
On Thu, May 12, 2022 at 09:04:38AM +0900, Tatsuo Ishii wrote: > Then we need to change this, no? > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=summary > > URL git://git.postgresql.org/git/postgresql.git > https://git.postgresql.org/git/postgresql.git >

Re: First draft of the PG 15 release notes (sorting)

2022-05-11 Thread Bruce Momjian
On Thu, May 12, 2022 at 10:38:42AM +1200, David Rowley wrote: > On Wed, 11 May 2022 at 14:38, Justin Pryzby wrote: > > I wonder if this is also relevant. > > > > 65014000b35 Replace polyphase merge algorithm with a simple balanced k-way > > merge. > > Thanks for highlighting that. It very much

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
>> Sorry, I meant ssh://g...@gitmaster.postgresql.org/postgresql.git >> works, but ssh://g...@git.postgresql.org/postgresql.git does not work >> for me. >> > > That is expected; no one has write access to that repo (and we only include > SSH keys for users with write access). Then we need to

Re: First draft of the PG 15 release notes (sorting)

2022-05-11 Thread David Rowley
On Wed, 11 May 2022 at 14:38, Justin Pryzby wrote: > I wonder if this is also relevant. > > 65014000b35 Replace polyphase merge algorithm with a simple balanced k-way > merge. Thanks for highlighting that. It very much is relevant. In fact, it seems to account for most of the 25% I mentioned.

Re: make MaxBackends available in _PG_init

2022-05-11 Thread Nathan Bossart
On Wed, May 11, 2022 at 04:18:10PM -0400, Robert Haas wrote: > OK, I have committed 0001 now. Thanks! -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: make MaxBackends available in _PG_init

2022-05-11 Thread Robert Haas
On Wed, May 11, 2022 at 12:12 AM Nathan Bossart wrote: > I swapped 0001 and 0002 in v8. > > Ah, good catch. I adjusted the docs as you suggested. OK, I have committed 0001 now. -- Robert Haas EDB: http://www.enterprisedb.com

It's about time to run pgindent, renumber_oids, etc

2022-05-11 Thread Tom Lane
With beta1 planned for next week, we're running out of time for $SUBJECT. I propose to do that tomorrow, or possibly Friday if anyone needs a little more time to get bugfix patches in. Comments? regards, tom lane

Re: Should use MERGE use BulkInsertState ?

2022-05-11 Thread Justin Pryzby
On Wed, May 11, 2022 at 05:23:27PM +0200, Alvaro Herrera wrote: > As I understand it, the point of using a ring is to throttle performance > for bulk operations such as vacuum. I'm not sure why we would want to > throttle either MERGE or INSERT; it seems to me that we should want them > to go as

Re: Comments on Custom RMGRs

2022-05-11 Thread Jeff Davis
On Wed, 2022-05-11 at 15:24 +0100, Simon Riggs wrote: > [PATCH: rmgr_001.v1.patch] > > [PATCH: rmgr_002.v1.patch] Thank you. Both of these look like good ideas, and I will commit them in a few days assuming that nobody else sees a problem. > It occurs to me that any use of WAL presumes that

Re: support for MERGE

2022-05-11 Thread Justin Pryzby
I suggest to reference the mvcc docs from the merge docs, or to make the merge docs themselves include the referenced information. diff --git a/doc/src/sgml/mvcc.sgml b/doc/src/sgml/mvcc.sgml index 341fea524a1..4446e1c484e 100644 --- a/doc/src/sgml/mvcc.sgml +++ b/doc/src/sgml/mvcc.sgml @@ -425,7

Re: Estimating HugePages Requirements?

2022-05-11 Thread Nathan Bossart
On Wed, May 11, 2022 at 02:34:25PM +0900, Michael Paquier wrote: > Hence, I have applied > the simplest solution to just enforce a log_min_messages=FATAL when > requesting a runtime GUC. Thanks! -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: Should use MERGE use BulkInsertState ?

2022-05-11 Thread Alvaro Herrera
On 2022-May-11, Justin Pryzby wrote: > Should it use it ? > > It occured to me to ask when reading Bruce's release notes, which say: > | [MERGE] is similar to INSERT ... ON CONFLICT but more batch-oriented. > > Currently, INSERT *never* uses bistate - even INSERT SELECT. > > INSERTing 10k

Re: First draft of the PG 15 release notes

2022-05-11 Thread Bruce Momjian
On Wed, May 11, 2022 at 04:12:23PM +0200, Álvaro Herrera wrote: > I think this item is pointless: > > Remove unused function parameter in get_qual_from_partbound() (Hou Zhijie) > > it's just a C-level code, and we don't document such API changes. If we > were to document them all, it'd be a

Re: First draft of the PG 15 release notes

2022-05-11 Thread Bruce Momjian
On Wed, May 11, 2022 at 02:19:20PM +0200, Matthias van de Meent wrote: > On Tue, 10 May 2022 at 17:44, Bruce Momjian wrote: > > > > I have completed the first draft of the PG 15 release notes and you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-15.html > > >

Re: First draft of the PG 15 release notes

2022-05-11 Thread Bruce Momjian
On Wed, May 11, 2022 at 04:02:31PM +0900, Amit Langote wrote: > On Wed, May 11, 2022 at 12:44 AM Bruce Momjian wrote: > > I have completed the first draft of the PG 15 release notes > The commit is intended to only change the behavior of RI triggers, > while leaving user-defined triggers firing

Re: Allowing REINDEX to have an optional name

2022-05-11 Thread Simon Riggs
On Wed, 11 May 2022 at 05:24, Ashutosh Bapat wrote: >> It is designed like this because it is dangerous to REINDEX the system >> catalogs because of potential deadlocks, so we want a way to avoid >> that problem. > > It's more clear if we add SKIP SYSTEM CATALOGS or some such explicit syntax.

Re: First draft of the PG 15 release notes

2022-05-11 Thread Bruce Momjian
On Wed, May 11, 2022 at 02:31:08PM +1200, David Rowley wrote: > On Wed, 11 May 2022 at 14:02, Bruce Momjian wrote: > > > > On Wed, May 11, 2022 at 12:39:41PM +1200, David Rowley wrote: > > > I think the sort improvements done in v15 are worth a mention under > > > General Performance. The

Comments on Custom RMGRs

2022-05-11 Thread Simon Riggs
New rmgr stuff looks interesting. I've had a detailed look through it and tried to think about how it might be used in practice. Spotted a minor comment that needs adjustment for new methods... [PATCH: rmgr_001.v1.patch] I notice rm_startup() and rm_cleanup() presume that this only works in

Re: First draft of the PG 15 release notes

2022-05-11 Thread Alvaro Herrera
I think this item is pointless: Remove unused function parameter in get_qual_from_partbound() (Hou Zhijie) it's just a C-level code, and we don't document such API changes. If we were to document them all, it'd be a very very long document. Here: Improve the algorithm used to compute

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

2022-05-11 Thread Pavel Borisov
v11 patch do not apply due to recent code changes. Rebased. PFA v12. Please feel free to check and discuss it. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com v12-0001-Add-option-for-amcheck-and-pg_amcheck-to-check-u.patch

Re: gitmaster access

2022-05-11 Thread Dave Page
Hi On Wed, 11 May 2022 at 13:56, Tatsuo Ishii wrote: > >> This does not work for me neither. However, in my case following works: > >> > >> ssh://g...@gitmaster.postgresql.org/pgtranslation/messages.git > > > > > > If that works, then colour me confused because: > > > > gemulon:~# host

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
>> This does not work for me neither. However, in my case following works: >> >> ssh://g...@gitmaster.postgresql.org/pgtranslation/messages.git > > > If that works, then colour me confused because: > > gemulon:~# host gitmaster.postgresql.org > gitmaster.postgresql.org is an alias for

Re: Support logical replication of DDLs

2022-05-11 Thread Masahiko Sawada
On Wed, May 11, 2022 at 6:15 PM Amit Kapila wrote: > > On Wed, May 11, 2022 at 1:09 PM Masahiko Sawada wrote: > > > > On Mon, May 9, 2022 at 6:05 PM Alvaro Herrera > > wrote: > > > > > > On 2022-May-08, Dilip Kumar wrote: > > > > > > > > The code in test_ddl_deparse is a pretty lame start, not

Should use MERGE use BulkInsertState ?

2022-05-11 Thread Justin Pryzby
Should it use it ? It occured to me to ask when reading Bruce's release notes, which say: | [MERGE] is similar to INSERT ... ON CONFLICT but more batch-oriented. Currently, INSERT *never* uses bistate - even INSERT SELECT. INSERTing 10k tuples will dirty 10k buffers - not limited to the size of

Re: First draft of the PG 15 release notes

2022-05-11 Thread Matthias van de Meent
On Tue, 10 May 2022 at 17:44, Bruce Momjian wrote: > > I have completed the first draft of the PG 15 release notes and you can > see the results here: > > https://momjian.us/pgsql_docs/release-15.html > > The feature count is similar to recent major releases: > > release-10 195 >

Re: Logical replication timeout problem

2022-05-11 Thread Amit Kapila
On Mon, May 9, 2022 at 2:17 PM Masahiko Sawada wrote: > > The patches look good to me too. > Pushed. -- With Regards, Amit Kapila.

Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit

2022-05-11 Thread Etsuro Fujita
On Fri, May 6, 2022 at 7:08 PM Etsuro Fujita wrote: > > > On Wed, Apr 20, 2022 at 4:55 AM David Zhang wrote: > > >> + * remote server in parallel at (sub)transaction end. > I noticed that the comment failed to mention that the > parallel_commit option is disabled by default. Also, I

Re: postgres_fdw "parallel_commit" docs

2022-05-11 Thread Etsuro Fujita
Hi Justin, On Tue, May 10, 2022 at 12:58 AM Justin Pryzby wrote: > On Mon, May 09, 2022 at 11:37:35AM -0400, Jonathan S. Katz wrote: > > - If multiple foreign servers with this option enabled are involved in > > - a local (sub)transaction, multiple remote (sub)transactions opened >

Re: postgres_fdw "parallel_commit" docs

2022-05-11 Thread Etsuro Fujita
Hi Jonathan, On Tue, May 10, 2022 at 12:37 AM Jonathan S. Katz wrote: > While researching PG15 features, I was trying to read through the > docs[1] for the "parallel_commit" (04e706d4) feature in postgres_fdw to > better understand what it does. I found myself becoming lost with the > references

Re: [RFC] building postgres with meson -v8

2022-05-11 Thread Peter Eisentraut
More patches: I fixed the Perl detection issue in my macOS environment that I had reported a while ago. Then I added in support for all configure options that had not been ported over yet. Some of these are rather trivial. After that, these configure options don't have an equivalent yet:

To add pg_temp schema description to schemas documentation

2022-05-11 Thread Ilya Anfimov
Good day. I've found that the pg_temp schema alias is mentioned in the description of the search_path variable, but is missing from the schemas documentation section. I think it would be good to have that there, as that section is mentioned as an extended reference for schemas.

Re: Multi-Master Logical Replication

2022-05-11 Thread vignesh C
On Thu, Apr 28, 2022 at 5:20 AM Peter Smith wrote: > > MULTI-MASTER LOGICAL REPLICATION > > 1.0 BACKGROUND > > Let’s assume that a user wishes to set up a multi-master environment > so that a set of PostgreSQL instances (nodes) use logical replication > to share tables with every other node in

Re: [RFC] building postgres with meson -v8

2022-05-11 Thread Peter Eisentraut
On 06.05.22 23:27, Andres Freund wrote: Re symlink: Do you have an opion about dropping the symlink vs implementing it (likely via a small helper script?)? I think the postmaster symlink could be dropped. The postmaster man page has been saying that it's deprecated since 2006.

Re: gitmaster access

2022-05-11 Thread Dave Page
On Wed, 11 May 2022 at 09:25, Kyotaro Horiguchi wrote: > At Wed, 11 May 2022 09:08:26 +0100, Dave Page wrote > in > > What is your community user ID? > > My community user name is "horiguti". > OK, so you have write access on the repo on git.postgresql.org, but I can't find an SSH key for your

Re: gitmaster access

2022-05-11 Thread Dave Page
Hi On Wed, 11 May 2022 at 09:34, Tatsuo Ishii wrote: > > Hi > > > > On Wed, 11 May 2022 at 08:21, Kyotaro Horiguchi > > > wrote: > > > >> (Sorry in advance if this is off-topic of -hackers, and please head me > >> to the right place if so.) > >> > >> I'm stuck by connection failure to

Re: Support logical replication of DDLs

2022-05-11 Thread Amit Kapila
On Wed, May 11, 2022 at 1:09 PM Masahiko Sawada wrote: > > On Mon, May 9, 2022 at 6:05 PM Alvaro Herrera wrote: > > > > On 2022-May-08, Dilip Kumar wrote: > > > > > The code in test_ddl_deparse is a pretty lame start, not nearly good > > enough by a thousand miles. My real intention was to have

Re: gitmaster access

2022-05-11 Thread Tatsuo Ishii
> Hi > > On Wed, 11 May 2022 at 08:21, Kyotaro Horiguchi > wrote: > >> (Sorry in advance if this is off-topic of -hackers, and please head me >> to the right place if so.) >> >> I'm stuck by connection failure to gitmaster. >> >> I told that I already have the commit-bit on pgtranslation

Re: gitmaster access

2022-05-11 Thread Kyotaro Horiguchi
At Wed, 11 May 2022 09:08:26 +0100, Dave Page wrote in > What is your community user ID? My community user name is "horiguti". regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: gitmaster access

2022-05-11 Thread Dave Page
Hi On Wed, 11 May 2022 at 08:55, Kyotaro Horiguchi wrote: > At Wed, 11 May 2022 08:46:40 +0100, Dave Page wrote > in > > Hi > > > > On Wed, 11 May 2022 at 08:21, Kyotaro Horiguchi > > > wrote: > > > 2. Clone ssh://g...@gitmaster.postgresql.org/pgtranslation/messages.git > . > > > > > > > The

Re: Allowing REINDEX to have an optional name

2022-05-11 Thread Bernd Helmle
Am Mittwoch, dem 11.05.2022 um 14:42 +0900 schrieb Michael Paquier: > Agreed.  Nobody is going to remember the difference.  REINDEX's > parsing grammar is designed to be extensible because we have the > parenthesized flavor.  Why don't you add an option there to skip the > catalogs, like a

Re: gitmaster access

2022-05-11 Thread Kyotaro Horiguchi
At Wed, 11 May 2022 08:46:40 +0100, Dave Page wrote in > Hi > > On Wed, 11 May 2022 at 08:21, Kyotaro Horiguchi > wrote: > > 2. Clone ssh://g...@gitmaster.postgresql.org/pgtranslation/messages.git. > > > > The correct repo is ssh://g...@git.postgresql.org/pgtranslation/messages.git. Thanks

Re: gitmaster access

2022-05-11 Thread Dave Page
Hi On Wed, 11 May 2022 at 08:21, Kyotaro Horiguchi wrote: > (Sorry in advance if this is off-topic of -hackers, and please head me > to the right place if so.) > > I'm stuck by connection failure to gitmaster. > > I told that I already have the commit-bit on pgtranslation repository > for the

Re: Support logical replication of DDLs

2022-05-11 Thread Masahiko Sawada
On Mon, May 9, 2022 at 6:05 PM Alvaro Herrera wrote: > > On 2022-May-08, Dilip Kumar wrote: > > > On Sat, May 7, 2022 at 9:38 AM Amit Kapila wrote: > > > > I agree that it adds to our maintainability effort, like every time we > > > enhance any DDL or add a new DDL that needs to be replicated,

RE: bogus: logical replication rows/cols combinations

2022-05-11 Thread houzj.f...@fujitsu.com
On Wednesday, May 11, 2022 11:33 AM Amit Kapila wrote: > On Wed, May 11, 2022 at 12:35 AM Tomas Vondra > wrote: > > > > On 5/9/22 05:45, Amit Kapila wrote: > > > On Sun, May 8, 2022 at 11:41 PM Tomas Vondra > > > wrote: > > >> > > >> On 5/7/22 07:36, Amit Kapila wrote: > > >>> On Mon, May 2,

gitmaster access

2022-05-11 Thread Kyotaro Horiguchi
(Sorry in advance if this is off-topic of -hackers, and please head me to the right place if so.) I'm stuck by connection failure to gitmaster. I told that I already have the commit-bit on pgtranslation repository for the community account "horiguti". I did the following steps. 1. Add the

Re: First draft of the PG 15 release notes

2022-05-11 Thread Amit Langote
On Wed, May 11, 2022 at 12:44 AM Bruce Momjian wrote: > I have completed the first draft of the PG 15 release notes Thanks. Regarding: Improve the trigger behavior of updates on partitioned tables that move rows between partitions (Amit Langote) Previously, such updates fired delete

Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-05-11 Thread Michael Paquier
On Mon, Apr 25, 2022 at 03:18:52PM +0900, Michael Paquier wrote: > On Wed, Apr 20, 2022 at 01:03:20PM +0200, Erik Rijkers wrote: >> Yes, that seems to fix it: I applied that latter patch, and ran my program >> 250x without errors. Then I removed it again an it gave the error within >> 15x. > >

Re: Crash in new pgstats code

2022-05-11 Thread Michael Paquier
On Tue, Apr 19, 2022 at 08:31:05PM +1200, Thomas Munro wrote: > On Tue, Apr 19, 2022 at 2:50 AM Andres Freund wrote: > > Kestrel won't go that far back even - I set it up 23 days ago... > > Here's a ~6 month old example from mylodon (I can't see much further > back than that with HTTP

Re: typos

2022-05-11 Thread Michael Paquier
On Tue, May 10, 2022 at 09:03:34PM -0500, Justin Pryzby wrote: > I found a bunch more typos; a couple from codespell, and several which are the > result of looking for previously-reported typos, like: Thanks, applied 0002. Regarding 0001, I don't really know which one of {AND,OR}ed or

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

2022-05-11 Thread Thomas Munro
On Tue, May 10, 2022 at 1:07 AM Robert Haas wrote: > On Sun, May 8, 2022 at 7:30 PM Thomas Munro wrote: > > LOG: still waiting for pid 1651417 to accept ProcSignalBarrier > > STATEMENT: alter database mydb set tablespace ts1; > This is a very good idea. OK, I pushed this, after making the