Re: Backup command and functions can cause assertion failure and segmentation fault

On 2022/07/01 15:09, Masahiko Sawada wrote: The change looks good to me. I've also confirmed the change fixed the issues. Thanks for the review and test! @@ -233,6 +233,12 @@ perform_base_backup(basebackup_options *opt, bbsink *sink) StringInfo labelfile; StringInfo

Eliminating SPI from RI triggers - take 2

Hi, I had proposed $subject for some RI trigger functions in the last dev cycle [1]. Briefly, the proposal was to stop using an SQL query (using the SPI interface) for RI checks that could be done by directly scanning the primary/unique key index of the referenced table, which must always be

Re: making relfilenodes 56 bits

On Thu, Jun 30, 2022 at 10:57 PM Robert Haas wrote: > > On Wed, Jun 29, 2022 at 5:15 AM Dilip Kumar wrote: > > >- It looks to me like you need to give significantly more thought to > > > the proper way of adjusting the relfilenode-related test cases in > > > alter_table.out. > > > > It seems to

Re: Backup command and functions can cause assertion failure and segmentation fault

Hi, On Thu, Jun 30, 2022 at 12:29 PM Fujii Masao wrote: > > Hi, > > I found that the assertion failure and the segmentation fault could > happen by running pg_backup_start(), pg_backup_stop() and BASE_BACKUP > replication command, in v15 or before. > > Here is the procedure to reproduce the

Re: Issue with pg_stat_subscription_stats

On Fri, Jul 1, 2022 at 7:12 AM Masahiko Sawada wrote: > > On Wed, Mar 16, 2022 at 11:34 PM Masahiko Sawada > wrote: > > > > While looking at this issue again, I realized there seems to be two > problems with subscription stats on shmem stats: > > Firstly, we call pgstat_create_subscription()

<    1   2