Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?

2022-09-23 Thread Thomas Munro
On Sat, Sep 24, 2022 at 8:24 AM Nathan Bossart wrote: > +#ifdef WIN32 > +/* > + * XXX: It looks like on Windows, we need an explicit lseek() call > here > + * despite using pwrite() implementation from win32pwrite.c. > Otherwise > + * an error occurs. > +

Re: [PoC] Federated Authn/z with OAUTHBEARER

2022-09-23 Thread Jacob Champion
On Fri, Mar 25, 2022 at 5:00 PM Jacob Champion wrote: > v4 rebases over the latest version of the pluggable auth patchset > (included as 0001-4). Note that there's a recent conflict as > of d4781d887; use an older commit as the base (or wait for the other > thread to be updated). Here's a newly r

Re: Fix typos in code comments

2022-09-23 Thread Justin Pryzby
On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote: > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote: > > Good catch. There is a similar typo in doc, runtime.sgml. > > ```using TLS protocols enabled by by setting the parameter``` > > That one should be backpatched to v15.

Re: First draft of the PG 15 release notes

2022-09-23 Thread Jonathan S. Katz
On 9/23/22 1:33 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 9/23/22 11:25 AM, Tom Lane wrote: I'm planning to do a final(?) pass over the v15 notes today, but I thought it'd be appropriate to push this separately. RE "final pass", there's still an errant "BACKPATCHED"[1] that still ne

Re: pg_stat_have_stats() returns true for dropped indexes (or for index creation transaction rolled back)

2022-09-23 Thread Andres Freund
Hi, On 2022-09-01 08:40:54 +0200, Drouvot, Bertrand wrote: > Thanks for the suggestion, I'm coming up with this proposal in v4 attached: I pushed the bugfix / related test portion to 15, master. Thanks! I left the replication stuff out - it seemed somewhat independent. Probably will just push th

Re: libpq error message refactoring

2022-09-23 Thread Peter Eisentraut
On 23.09.22 04:45, Andres Freund wrote: On 2022-09-22 19:27:27 -0700, Andres Freund wrote: I just noticed it when trying to understand the linker failure - which I still don't... Heh, figured it out. It's inside #ifdef ENABLE_NLS. So it fails on all platforms without NLS enabled. Hah! Here

Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?

2022-09-23 Thread Nathan Bossart
+PGAlignedXLogBlock zbuffer; + +memset(zbuffer.data, 0, XLOG_BLCKSZ); This seems excessive for only writing a single byte. +#ifdef WIN32 +/* + * XXX: It looks like on Windows, we need an explicit lseek() call here + * despite using pwrite() implementation f

Re: Summary function for pg_buffercache

2022-09-23 Thread Melih Mutlu
Hi Andres, Adjusted the patch so that it will work with meson now. Also addressed your other reviews as well. I hope explanations in comments/docs are better now. Best, Melih v11-0001-Added-pg_buffercache_summary-function.patch Description: Binary data

Re: Pluggable toaster

2022-09-23 Thread Nikita Malakhov
Hi hackers! Cfbot is not happy with previous patchset, so I'm attaching new one, rebased onto current master (15b4). Also providing patch with documentation package, and the second one contains large README.toastapi file providing additional in-depth docs for developers. Comments would be greatly

Re: O(n) tasks cause lengthy startups and checkpoints

2022-09-23 Thread Nathan Bossart
On Fri, Sep 02, 2022 at 03:07:44PM -0700, Nathan Bossart wrote: > And another. v11 adds support for building with meson. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com >From 56c9ff2bf1a6524518b62193c0da02372f9674a1 Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Wed, 5 Jan 20

Re: First draft of the PG 15 release notes

2022-09-23 Thread Tom Lane
"Jonathan S. Katz" writes: > On 9/23/22 11:25 AM, Tom Lane wrote: >> I'm planning to do a final(?) pass over the v15 notes today, >> but I thought it'd be appropriate to push this separately. > RE "final pass", there's still an errant "BACKPATCHED"[1] that still > needs addressing. I didn't have

Re: First draft of the PG 15 release notes

2022-09-23 Thread Jonathan S. Katz
On 9/23/22 11:25 AM, Tom Lane wrote: "Jonathan S. Katz" writes: Adjusted to be similar to your suggestion. Updated patch attached. I pushed this with a bit more copy-editing. I'm planning to do a final(?) pass over the v15 notes today, but I thought it'd be appropriate to push this separatel

Re: archive modules

2022-09-23 Thread Nathan Bossart
On Fri, Sep 23, 2022 at 05:58:42AM -0400, Peter Eisentraut wrote: > On 15.09.22 00:27, Nathan Bossart wrote: >> Both archive_command and archive_library are PGC_SIGHUP, so IIUC that >> wouldn't be sufficient. I attached a quick sketch that seems to provide >> the desired behavior. It's nowhere ne

Re: First draft of the PG 15 release notes

2022-09-23 Thread Tom Lane
"Jonathan S. Katz" writes: > Adjusted to be similar to your suggestion. Updated patch attached. I pushed this with a bit more copy-editing. I'm planning to do a final(?) pass over the v15 notes today, but I thought it'd be appropriate to push this separately. regards, to

Re: Temporary file access API

2022-09-23 Thread Antonin Houska
Hi, John Morris wrote: > I’m a latecomer to the discussion, but as a word of introduction, I’m working > with Stephen, and I have started looking over the temp file proposal with the > idea of helping it move along. > > I’ll start by summarizing the temp file proposal and its goals. > > Fr

Re: Refactor backup related code (was: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?)

2022-09-23 Thread Michael Paquier
On Fri, Sep 23, 2022 at 06:02:24AM +0530, Bharath Rupireddy wrote: > PSA v12 patch with the above review comments addressed. I've read this one, and nothing is standing out at quick glance, so that looks rather reasonable to me. I should be able to spend more time on that at the beginning of next

Re: archive modules

2022-09-23 Thread Peter Eisentraut
On 15.09.22 00:27, Nathan Bossart wrote: Both archive_command and archive_library are PGC_SIGHUP, so IIUC that wouldn't be sufficient. I attached a quick sketch that seems to provide the desired behavior. It's nowhere near committable yet, but it demonstrates what I'm thinking. What is the ef

Re: RFC: Logging plan of the running query

2022-09-23 Thread Alena Rybakina
Sorry, I wrote confusingly at that time. No, I suggested adding comment about the explanation of HandleLogQueryPlanInterrupt() only in the explain.h and not removing from the explain.c. I seemed to be necessary separating declaration function for 'explaining feature' of executed query from o

Re: LogwrtResult contended spinlock

2022-09-23 Thread Alvaro Herrera
On 2022-Jul-28, Alvaro Herrera wrote: > v10 is just a trivial rebase. No changes. Moved to next commitfest. I realized that because of commit e369f3708636 this change is no longer as critical as it used to be, so I'm withdrawing this patch from the commitfest. -- Álvaro Herrera Postgr