Re: Error for WITH options on partitioned tables

2022-11-07 Thread Karina Litskevich
Hi David, > I am not very clear about why `build_reloptions` is removed in patch > `v2-0002-better-error-message-for-setting-parameters-for-p.patch`, if > you can help explain would be great. "build_reloptions" parses "reloptions" and takes for it a list of allowed options defined by the 5th

Re: Allow single table VACUUM in transaction block

2022-11-07 Thread Simon Riggs
On Sun, 6 Nov 2022 at 20:40, Peter Geoghegan wrote: > > On Sun, Nov 6, 2022 at 11:14 AM Tom Lane wrote: > > In general, I do not believe in encouraging users to run VACUUM > > manually in the first place. We would be far better served by > > spending our effort to improve autovacuum's

Re: Perform streaming logical transactions by background workers and parallel apply

2022-11-07 Thread Peter Smith
Here are my review comments for v42-0001 == 1. General. Please take the time to process all new code comments using a grammar/spelling checker (e.g. simply cut/paste them into MSWord or Grammarly or any other tool of your choice as a quick double-check) *before* posting the patches; too

Re: Add common function ReplicationOriginName.

2022-11-07 Thread Aleksander Alekseev
Hi Tom, > I looked at this and am inclined to reject it. [...] OK, thanks. Then we are done with this thread. I closed the corresponding CF entry. -- Best regards, Aleksander Alekseev

<    1   2