On 2022-Nov-29, Amit Langote wrote:
> Maybe, we should have the following there so that the PlannedStmt's
> contents don't point into the Query?
>
> newperminfo = copyObject(perminfo);
Hmm, I suppose if we want a separate RTEPermissionInfo node, we should
instead do
On 11/28/22 6:54 PM, Jeff Davis wrote:
>
> =# select * from pg_icu_collation_versions('en_US') order by
> icu_version;
> icu_version | uca_version | collator_version
> -+-+--
> ...
> 67.1| 13.0| 153.14
> 68.2| 13.0|
On Mon, Nov 28, 2022 at 11:49 PM Jeff Davis wrote:
> Not necessarily, #2-4 (at least as implemented in v7) can only load one
> major version at a time, so can't specify minor versions:
> https://www.postgresql.org/message-id/9f8e9b5a3352478d4cf7d6c0a5dd7e82496be4b6.ca...@j-davis.com
>
> With #1,
On Tue, Nov 29, 2022 at 8:42 AM SATYANARAYANA NARLAPURAM <
satyanarlapu...@gmail.com> wrote:
>
>
> On Tue, Nov 29, 2022 at 8:29 AM Bruce Momjian wrote:
>
>> On Tue, Nov 29, 2022 at 08:14:10AM -0800, SATYANARAYANA NARLAPURAM wrote:
>> > 2. Process proc die immediately when a backend is
On Tue, Nov 29, 2022 at 11:41:07AM -0500, Robert Haas wrote:
> My argument is that removing xidStopLimit is totally fine, because it
> only serves to stop the database. What to do about xidWarnLimit is a
> slightly more complex question. Certainly it can't be left untouched,
> because warning that
On Tue, Nov 29, 2022 at 8:29 AM Bruce Momjian wrote:
> On Tue, Nov 29, 2022 at 08:14:10AM -0800, SATYANARAYANA NARLAPURAM wrote:
> > 2. Process proc die immediately when a backend is waiting for sync
> > replication acknowledgement, as it does today, however, upon restart,
> > don't
On Tue, Nov 29, 2022 at 8:03 AM Chris Travers wrote:
> To be clear, I never suggested shutting down the database. What I have
> suggested is that repurposing the current approaching-xid-wraparound warnings
> to start complaining loudly when a threshold is exceeded would be helpful.
> I
On Tue, Nov 29, 2022 at 08:14:10AM -0800, SATYANARAYANA NARLAPURAM wrote:
> 2. Process proc die immediately when a backend is waiting for sync
> replication acknowledgement, as it does today, however, upon restart,
> don't open up for business (don't accept ready-only connections)
>
On Tue, 2022-11-29 at 13:58 +0100, Vik Fearing wrote:
> I disagree. A user does not need to know that a table is partitionned,
> and if the user wants a unique constraint on the table then making them
> type an extra word to get it is just annoying.
Hmm. But if I created a primary key without
On 11/28/22 14:11, Robert Haas wrote:
On Wed, Nov 23, 2022 at 12:09 AM Thomas Munro wrote:
OK. Time for a new list of the various models we've discussed so far:
1. search-by-collversion: We introduce no new "library version"
concept to COLLATION and DATABASE object and little or no new
On Mon, Nov 28, 2022 at 4:53 PM Peter Geoghegan wrote:
> Imagine if we actually had 64-bit XIDs -- let's assume for a moment
> that it's a done deal. This raises a somewhat awkward question: do you
> just let the system get further and further behind on freezing,
> forever? We can all agree that
On Sun, Nov 27, 2022 at 10:33 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Mon, Nov 28, 2022 at 12:57 AM Andrey Borodin
> wrote:
> >
> > Some funny stuff. If a user tries to cancel a non-replicated transaction
> > Azure Postgres will answer: "user requested cancel
On Tue, Nov 29, 2022 at 2:32 AM wrote:
> I propose a slightly different syntax instead:
>
> ALTER DEFAULT PRIVILEGES GRANT CREATED ROLE TO role_specification WITH ...;
>
> This, together with the proposal above regarding the grantor, should be
> consistent.
I think that is more powerful than
On 11/29/22 09:46, Bruce Momjian wrote:
As far as I know, all our freeze values are focused on avoiding XID
wraparound. If XID wraparound is no longer an issue, we might find that
our freeze limits can be much higher than they are now.
I'd be careful in that direction as the values together
On Tue, Nov 29, 2022 at 12:32 AM wrote:
>
> Is there any other argument to be made against ADP?
>
These aren't privileges, they are memberships. The pg_default_acl catalog
is also per-data while these settings should be present in a catalog which,
like pg_authid, is catalog-wide. This latter
Attached is a new version with the tests cleaned up a bit (more comments
mostly).
@Michael, did you have a chance to look at the last version? Because I feel
that the
patch is pretty much ready for a committer to look at, at this point.
v5-0001-Support-load-balancing-in-libpq.patch
Hi,
Thanks for the patch!
On 10/29/22 12:54, Marina Polyakova wrote:
1) The ECPG tests fail because they use the SQL_ASCII encoding [2],
the database template0 uses the ICU locale provider and SQL_ASCII is
not supported by ICU:
$ make -C src/interfaces/ecpg/ installcheck
...
On Tue, Nov 29, 2022 at 02:35:20PM +0100, Chris Travers wrote:
> So I think the problem is that PostgreSQL is becoming more and more scalabile,
> hardware is becoming more capable, and certain use cases are continuing to
> scale up. Over time, we tend to find ourselves approaching the end of the
On Tue, 29 Nov 2022 at 17:51, li jie wrote:
>
> I will continue to give feedback for this patch.
Thanks a lot, that will be very helpful for us.
> 1. LIKE STORAGE
> ```
> CREATE TABLE ctlt (a text, c text);
> ALTER TABLE ctlt ALTER COLUMN c SET STORAGE EXTERNAL;
> CREATE TABLE ctlt_storage
Antonin Houska wrote:
> Peter Eisentraut wrote:
>
> > On 04.11.22 08:28, Antonin Houska wrote:
> > > I thought about the whole concept a bit more and I doubt if the
> > > PUBLICATION
> > > privilege is the best approach. In particular, the user specified in
> > > CREATE
> > > SUBSCRIPTION
Hi,
On 11/28/22 6:58 PM, Robert Haas wrote:
On Tue, Nov 22, 2022 at 3:53 PM Andres Freund wrote:
I think we should consider deprecating the pg_stat_bgwriter columns but
leaving them in place for a few years. New stuff should only be added to
pg_stat_checkpointer, but we don't need to break
There's an old thread that interests me but which ended without any
resolution/solution:
https://www.postgresql.org/messageid/CA%2BHiwqGpoKmDg%2BTJdMfoeu3k4VQnxcfBon4fwBRp8ex_CTCsnA%40mail.gmail.com
Some of our basic requirements are:
1) All data must be labeled at a specific level (using
On Mon, Nov 28, 2022 at 11:06 PM Peter Geoghegan wrote:
> On Mon, Nov 28, 2022 at 1:52 PM Bruce Momjian wrote:
> > I think the problem is that we still have bloat with 64-bit XIDs,
> > specifically pg_xact and pg_multixact files. Yes, that bloat is less
> > serious, but it is still an issue
On Fri, Nov 25, 2022 at 4:13 PM Stavros Koureas
wrote:
>
> Yes, if the property is on the subscription side then it should be applied
> for all the tables that the connected publication is exposing.
> So if the property is enabled you should be sure that this origin column
> exists to all of
Hi Tomas,
Le mar. 29 nov. 2022 à 14:06, Tomas Vondra
a écrit :
>
> On 11/29/22 13:49, Simon Riggs wrote:
> > On Thu, 17 Nov 2022 at 17:29, Simon Riggs
> > wrote:
> >
> >> (yes, the last line shows x10 performance patched, that is not a typo)
> >
> > New version of patch, now just a one-line
On 11/29/22 13:49, Simon Riggs wrote:
> On Thu, 17 Nov 2022 at 17:29, Simon Riggs
> wrote:
>
>> (yes, the last line shows x10 performance patched, that is not a typo)
>
> New version of patch, now just a one-line patch!
>
> Results show it's still a good win for XidInMVCCSnapshot().
>
I'm a
Hi;
I suppose I must not have been clear in what I am suggesting we do and
why. I will try to answer specific points below and then restate what I
think the problem is, and what I think should be done about it.
On Mon, Nov 28, 2022 at 5:53 PM Robert Haas wrote:
> On Sat, Nov 26, 2022 at 4:08
On 11/24/22 19:15, Cary Huang wrote:
On Thu, 24 Nov 2022 08:00:59 -0700 Thomas Kellerer wrote ---
> Pavel Stehule schrieb am 24.11.2022 um 07:03:
> > There are many Oracle users that find global indexes useful despite
> > their disadvantages.
> >
> > I have seen
On Mon, 28 Nov 2022 at 21:10, Robert Haas wrote:
>
> On Mon, Nov 28, 2022 at 3:01 PM Tom Lane wrote:
> > One thing we need to be pretty careful of here is to not break the
> > promise of atomic commit. At topmost commit, all subxacts must
> > appear committed simultaneously. It's not quite
On Mon, Nov 28, 2022 at 11:29 PM Robert Haas wrote:
>
> On Tue, Nov 22, 2022 at 3:53 PM Andres Freund wrote:
> > I think we should consider deprecating the pg_stat_bgwriter columns but
> > leaving them in place for a few years. New stuff should only be added to
> > pg_stat_checkpointer, but we
On Thu, 17 Nov 2022 at 17:29, Simon Riggs wrote:
> (yes, the last line shows x10 performance patched, that is not a typo)
New version of patch, now just a one-line patch!
Results show it's still a good win for XidInMVCCSnapshot().
--
Simon Riggshttp://www.EnterpriseDB.com/
> On 3 Nov 2022, at 21:47, Daniel Gustafsson wrote:
> The patch adds a new GUC, ignore_event_trigger with two option values, 'all'
> and 'none' (the login event patch had 'login' as well).
The attached v2 fixes a small bug which caused testfailures the CFBot.
--
Daniel Gustafsson
On Fri, Nov 18, 2022 at 12:03:53PM +0300, Sergei Kornilov wrote:
> Hello
> Do we need new syntax actually? I think that a global unique index can be
> created automatically instead of raising an error "unique constraint on
> partitioned table must include all partitioning columns"
I may
On Tue, Nov 29, 2022 at 10:18 AM houzj.f...@fujitsu.com
wrote:
>
> Attach the new version patch which addressed all comments.
>
Review comments on v53-0001*
==
1.
Subscription *MySubscription = NULL;
-static bool MySubscriptionValid = false;
+bool MySubscriptionValid =
On Sun, 20 Nov 2022 at 20:00, Simon Riggs wrote:
>
> On Thu, 24 Mar 2022 at 16:21, Robert Haas wrote:
> >
> > On Thu, Mar 24, 2022 at 12:02 PM Simon Riggs
>
> > > What changes will be acceptable for bgwriter, walwriter and logical
> > > worker?
> >
> > Hmm, I think it would be fine to introduce
I will continue to give feedback for this patch.
1. LIKE STORAGE
```
CREATE TABLE ctlt (a text, c text);
ALTER TABLE ctlt ALTER COLUMN c SET STORAGE EXTERNAL;
CREATE TABLE ctlt_storage (LIKE ctlt INCLUDING STORAGE);
```
postgres=# \d+ ctlt_storage
Table
On Mon, 28 Nov 2022 at 23:40, Nathan Bossart wrote:
>
> Okay, here is a new patch set. 0004 adds logic to prevent custodian tasks
> from delaying shutdown.
That all seems good, thanks.
The last important point for me is tests, in src/test/modules
probably. It might be possible to reuse the
Hi!
I'm working on this issue according to the plan Tom proposed above -
>I agree that we can't simply widen varatt_external to use 8 bytes for
>the toast ID in all cases. Also, I now get the point about avoiding
>use of globally assigned OIDs here: if the counter starts from zero
>for each
On Mon, 28 Nov 2022 at 23:16, Thomas Munro wrote:
>
> I found some more comments and some documentation to word-smith very
> lightly, and pushed.
Thanks
> The comments were stray references to the
> trigger file. It's
> a little confusing because the remaining mechanism also uses a file,
> but
On Wed, 23 Nov 2022 at 08:56, David Rowley wrote:
>
> On Wed, 23 Nov 2022 at 21:54, David Rowley wrote:
> > I wonder if you'd be better off with something like:
> >
> > while (*ptr && isxdigit((unsigned char) *ptr))
> > {
> > if (unlikely(tmp &
Dear Andrey and Thom,
Thank you for reviewing and testing the patch. I really apologize for
my late response.
On Tue, Nov 8, 2022 at 8:31 PM Andrey Lepikhov
wrote:
> Looking into find_em_for_rel() changes I see that you replaced
> if (bms_is_subset(em->em_relids, rel->relids)
> with assertion
On Sat, Nov 26, 2022 at 19:50 PM Amit Kapila wrote:
> On Fri, Nov 25, 2022 at 5:30 PM Ashutosh Bapat
> wrote:
> >
> > Hi Hou,
> > Thanks for the patch. With a simple condition, we can eliminate the
> > need to queueing snapshot change in the current transaction and then
> > applying it. Saves
101 - 142 of 142 matches
Mail list logo
