Re: +infinity for dates and timestamps

2022-12-31 Thread Tom Lane
Vik Fearing writes: > It has always annoyed me that we can't write '+infinity' for dates and > timestamps and get the OCD satisfaction of making our queries line up > with '-infinity'. +1, since it works for numerics it should work for these types too. (I didn't read the patch though.)

Re: +infinity for dates and timestamps

2022-12-31 Thread Vik Fearing
On 1/1/23 03:10, Vik Fearing wrote: It has always annoyed me that we can't write '+infinity' for dates and timestamps and get the OCD satisfaction of making our queries line up with '-infinity'. I wrote a fix for that some time ago but apparently never posted it.  I was reminded of it by

Re: Announcing Release 15 of the PostgreSQL Buildfarm client

2022-12-31 Thread Andrew Dunstan
On 2022-12-31 Sa 20:55, Noah Misch wrote: > On Sat, Dec 31, 2022 at 10:02:32AM -0500, Andrew Dunstan wrote: >> * check if a branch is up to date before trying to run it >> This only applies if the |branches_to_build| setting is a keyword >> rather than a list of branches. It reduces

+infinity for dates and timestamps

2022-12-31 Thread Vik Fearing
It has always annoyed me that we can't write '+infinity' for dates and timestamps and get the OCD satisfaction of making our queries line up with '-infinity'. I wrote a fix for that some time ago but apparently never posted it. I was reminded of it by jian he in the Infinite Interval thread,

Re: Infinite Interval

2022-12-31 Thread Vik Fearing
On 12/31/22 06:09, jian he wrote: Since in float8 you can use '+inf', '+infinity', So should we also make interval '+infinity' valid? Yes. Also in timestamp. '+infinity'::timestamp is invalid, should we make it valid. Yes, we should. I wrote a trivial patch for this a while ago but it

Re: Announcing Release 15 of the PostgreSQL Buildfarm client

2022-12-31 Thread Noah Misch
On Sat, Dec 31, 2022 at 10:02:32AM -0500, Andrew Dunstan wrote: > * check if a branch is up to date before trying to run it > This only applies if the |branches_to_build| setting is a keyword > rather than a list of branches. It reduces the number of useless > calls to |git pull| to

Fixing a couple of buglets in how VACUUM sets visibility map bits

2022-12-31 Thread Peter Geoghegan
Attached are two patches, each of which fixes two historical buglets around VACUUM's approach to setting bits in the visibility map. (Whether or not this is actually refactoring work or hardening work is debatable, I suppose.) The first patch makes sure that the snapshotConflictHorizon cutoff

Re: Add SHELL_EXIT_CODE to psql

2022-12-31 Thread Corey Huinker
On Sat, Dec 31, 2022 at 5:28 PM Isaac Morland wrote: > On Sat, 31 Dec 2022 at 16:47, Corey Huinker > wrote: > >> >>> I wonder if there is value in setting up a psql on/off var >>> SHELL_ERROR_OUTPUT construct that when set to "off/false" >>> suppresses standard error via appending "2>

Re: wake up logical workers after ALTER SUBSCRIPTION

2022-12-31 Thread Nathan Bossart
On Sun, Dec 18, 2022 at 03:36:07PM -0800, Nathan Bossart wrote: > This seems to have somehow broken the archiving tests on Windows, so > obviously I owe some better analysis here. I didn't see anything obvious > in the logs, but I will continue to dig. On Windows, WaitForWALToBecomeAvailable()

Re: Add SHELL_EXIT_CODE to psql

2022-12-31 Thread Isaac Morland
On Sat, 31 Dec 2022 at 16:47, Corey Huinker wrote: > >> I wonder if there is value in setting up a psql on/off var >> SHELL_ERROR_OUTPUT construct that when set to "off/false" >> suppresses standard error via appending "2> /dev/null" (or "2> nul" if >> #ifdef WIN32). At the very least, it would

Re: Add SHELL_EXIT_CODE to psql

2022-12-31 Thread Corey Huinker
On Fri, Dec 30, 2022 at 2:17 PM Corey Huinker wrote: > On Wed, Dec 28, 2022 at 5:59 AM Maxim Orlov wrote: > >> Hi! >> >> The patch is implementing what is declared to do. Shell return code is >> now accessible is psql var. >> Overall code is in a good condition. Applies with no errors on

Re: New strategies for freezing, advancing relfrozenxid early

2022-12-31 Thread Peter Geoghegan
On Sat, Dec 31, 2022 at 11:46 AM Jeff Davis wrote: > On Fri, 2022-12-30 at 16:58 -0800, Peter Geoghegan wrote: > > Following the path of freezing a page is *always* valid, by > > definition. Including when there are zero freeze plans to execute, or > > even zero tuples to examine in the first

Re: New strategies for freezing, advancing relfrozenxid early

2022-12-31 Thread Jeff Davis
On Fri, 2022-12-30 at 16:58 -0800, Peter Geoghegan wrote: > Following the path of freezing a page is *always* valid, by > definition. Including when there are zero freeze plans to execute, or > even zero tuples to examine in the first place -- we'll at least be > able to perform nominal freezing,

[PATCH] Add overlaps geometric operators that ignore point overlaps

2022-12-31 Thread Ankit Kumar Pandey
Hi, This is patch for todo item: Add overlaps geometric operators that ignore point overlaps Issue: SELECT circle '((0,0), 1)' && circle '((2,0),1) returns True Expectation: In above case, both figures touch other but do not overlap (i.e. touching != overlap). Hence, it should return

Re: Request for removal of BUG #5705 from todo items as no repro

2022-12-31 Thread Ankit Kumar Pandey
On 31/12/22 23:32, Tom Lane wrote: Ankit Kumar Pandey writes: This is in reference to BUG #5705 and corresponding todo item: Fix /contrib/btree_gist's implementation of inet indexing I am not able to repro this issue. You didn't test it right: the complaint is about the btree_gist

Re: Request for removal of BUG #5705 from todo items as no repro

2022-12-31 Thread Tom Lane
Ankit Kumar Pandey writes: > This is in reference to BUG #5705 and corresponding todo item: Fix > /contrib/btree_gist's implementation of inet indexing > I am not able to repro this issue. You didn't test it right: the complaint is about the btree_gist extension, not the in-core inet opclass,

Re: postgres_fdw: using TABLESAMPLE to collect remote sample

2022-12-31 Thread Tom Lane
Tomas Vondra writes: > On 12/31/22 05:42, Tom Lane wrote: >> ERROR: TABLESAMPLE clause can only be applied to tables and materialized >> views >> I think the patch avoids that, but only accidentally, because >> reltuples will be 0 or -1 for a view. Maybe it'd be a good >> idea to pull back

Announcing Release 15 of the PostgreSQL Buildfarm client

2022-12-31 Thread Andrew Dunstan
Changes * add a new script |manage_alerts.pl| that lets the user enable or disable alerts for an animal This is especially useful in the case of animals that have stopped running for some reason. * check if a branch is up to date before trying to run it This only applies if

Re: postgres_fdw: using TABLESAMPLE to collect remote sample

2022-12-31 Thread Tomas Vondra
On 12/31/22 05:42, Tom Lane wrote: > Tomas Vondra writes: >> After thinking about it a bit more I decided to rip out the 10% sampling >> rate inflation. > > +1. I'm not sure if there's anything more we need to do there, but > that didn't seem like that was it. > > I notice that the

Re: split TOAST support out of postgres.h

2022-12-31 Thread Andrew Dunstan
On 2022-12-30 Fr 11:50, Tom Lane wrote: > Peter Eisentraut writes: >> On 28.12.22 16:07, Tom Lane wrote: >>> I dunno, #3 seems kind of unprincipled. Also, since fmgr.h is included >>> so widely, I doubt it is buying very much in terms of reducing header >>> footprint. How bad is it to do #2?

Request for removal of BUG #5705 from todo items as no repro

2022-12-31 Thread Ankit Kumar Pandey
Hi, This is in reference to BUG #5705 and corresponding todo item: Fix /contrib/btree_gist's implementation of inet indexing Issue: SELECT '1.255.255.200/8'::inet < '1.0.0.0'::inet didn't worked with index. I am not able to repro this issue. Steps: SELECT '1.255.255.200/8'::inet <