Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

On 18.02.23 21:26, Andres Freund wrote: When building with meson, TEMP_CONFIG is supported for TAP tests, but doesn't do anything for regress/isolation. The reason for that is that meson's (and ninja's) architecture is to separate "build setup" from the "build/test/whatever" stage, moving

Re: shoud be get_extension_schema visible?

Hi pá 17. 2. 2023 v 6:45 odesílatel Pavel Stehule napsal: > Hi > > more times I needed to get the extension's assigned namespace. There is > already a cooked function get_extension_schema, but it is static. > > I need to find a function with a known name, but possibly an unknown > schema from

"out of relcache_callback_list slots" after multiple calls to pg_logical_slot_get_binary_changes

Hi hackers, After multiple calls to the function pg_logical_slot_get_binary_changes() in single client backend (the output plugin of the slot is pgoutput), I got the following error: client backend FATAL: out of relcache_callback_list slots client backend CONTEXT: slot "testslot", output

Re: Support logical replication of DDLs

On 2/17/23 4:15 AM, Amit Kapila wrote: On Fri, Feb 17, 2023 at 1:13 AM Jonathan S. Katz wrote: On 2/16/23 2:38 PM, Alvaro Herrera wrote: On 2023-Feb-16, Jonathan S. Katz wrote: On 2/16/23 12:53 PM, Alvaro Herrera wrote: I don't think this is the fault of logical replication. Consider

Re: Ignoring BRIN for HOT updates (was: -udpates seems broken)

On Thu, 16 Jun 2022 at 15:05, Tomas Vondra wrote: > > I've pushed the revert. Let's try again for PG16. As we discussed in person at the developer meeting, here's a patch to try again for PG16. It combines the committed patches with my fix, and adds some additional comments and polish. I am

Re: pg_upgrade and logical replication

On Sat, Feb 18, 2023 at 04:12:52PM +0530, Amit Kapila wrote: > On Sat, Feb 18, 2023 at 11:21 AM Julien Rouhaud wrote: > > > > > Now, I think it would be a bit tricky if the user already has a > > > publication defined with FOR ALL TABLES. In that case, we probably > > > need some way to specify

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

On Fri, Feb 17, 2023 at 5:57 PM Peter Smith wrote: > > FYI, I accidentally left this (v23) patch's TAP test > t/032_subscribe_use_index.pl still lurking even after removing all > other parts of this patch. > > In this scenario, the t/032 test gets stuck (build of latest HEAD) > > IIUC the patch

Re: Weird failure with latches in curculio on v15

Hi, On 2023-02-18 15:51:06 +0530, Robert Haas wrote: > On Thu, Feb 16, 2023 at 10:02 PM Andres Freund wrote: > > But there's nothing inherent in that. We know for certain which files we're > > going to archive. And we don't need to work one-by-one. The archiver could > > just start multiple

Re: occasional valgrind reports for handle_sig_alarm on 32-bit ARM

Hi, On 2023-02-18 13:56:38 +0100, Tomas Vondra wrote: > or (somewhat weird) > > ==23734== Use of uninitialised value of size 4 > ==23734==at 0x88DDC8: handle_sig_alarm (timeout.c:457) > ==23734==by 0x: ??? > ==23734== Uninitialised value was created by a stack

Re: Reducing connection overhead in pg_upgrade compat check phase

On Fri, Feb 17, 2023 at 10:44:49PM +0100, Daniel Gustafsson wrote: > When adding a check to pg_upgrade a while back I noticed in a profile that the > cluster compatibility check phase spend a lot of time in connectToServer. > Some > of this can be attributed to data type checks which each run

Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

Hi, When building with meson, TEMP_CONFIG is supported for TAP tests, but doesn't do anything for regress/isolation. The reason for that is that meson's (and ninja's) architecture is to separate "build setup" from the "build/test/whatever" stage, moving dynamism (and more costly operations) to

Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED

Hi, On 2023-02-18 18:00:00 +0300, Alexander Lakhin wrote: > 18.02.2023 04:06, Andres Freund wrote: > > On 2023-02-18 13:27:04 +1300, Thomas Munro wrote: > > How can a process that we did notify crashing, that has already executed > > SQL statements, end up in MarkPostmasterChildActive()? > >

Re: PATCH: Using BRIN indexes for sorted output

On 2/18/23 19:51, Justin Pryzby wrote: > Are (any of) these patches targetting v16 ? > Probably not. Maybe if there's more feedback / scrutiny, but I'm not sure one commitfest is enough to polish the patch (especially considering I haven't done much on the costing yet). > typos: > ar we - we

Re: PATCH: Using BRIN indexes for sorted output

Are (any of) these patches targetting v16 ? typos: ar we - we are? morestly - mostly interstect - intersect > + * XXX We don't sort the bins, so just do binary sort. For large number of > values > + * this might be an issue, for small number of values a linear search is > fine. "binary sort"

Re: [PATCH] Add pretty-printed XML output option

On 17.02.23 23:24, Nikolay Samokhvalov wrote: My idea was to follow the SQL standard (part 14, SQL/XML); unfortunately, there is no free version, but there are drafts at http://www.wiscorp.com/SQLStandards.html . ::= XMLSERIALIZE [ ] AS [

Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED

Hello, 18.02.2023 04:06, Andres Freund wrote: Hi, On 2023-02-18 13:27:04 +1300, Thomas Munro wrote: I still have no theory for how this condition was reached despite a lot of time thinking about it and searching for more clues. As far as I can tell, the recent improvements to postmaster's

Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED

On Sat, Feb 18, 2023 at 01:27:04PM +1300, Thomas Munro wrote: > (cfbot previously wasn't interested in the past at all; > I'd need to get my hands on the commit IDs for earlier testing but I > can't figure out how to get those out of Cirrus or Github -- anyone > know how?). I wish I knew - my

occasional valgrind reports for handle_sig_alarm on 32-bit ARM

Hi, I've been running a lot of valgrind tests on 32-bit arm recently, and from time to time I get a failure in handle_sig_alarm like this: ==13605== Use of uninitialised value of size 4 ==13605==at 0x88DA98: handle_sig_alarm (timeout.c:457) ==13605==by 0x: ???

Re: pg_upgrade and logical replication

On Sat, Feb 18, 2023 at 11:21 AM Julien Rouhaud wrote: > > On Sat, Feb 18, 2023 at 09:31:30AM +0530, Amit Kapila wrote: > > On Fri, Feb 17, 2023 at 9:05 PM Julien Rouhaud wrote: > > > > > > I'm concerned about people not coming from physical replication. If you > > > just > > > had some

Re: Weird failure with latches in curculio on v15

On Thu, Feb 16, 2023 at 10:02 PM Andres Freund wrote: > But there's nothing inherent in that. We know for certain which files we're > going to archive. And we don't need to work one-by-one. The archiver could > just start multiple subprocesses at the same time. But what if it doesn't want to

Re: Weird failure with latches in curculio on v15

On Thu, Feb 16, 2023 at 10:28 PM Nathan Bossart wrote: > > Hmm. So in this design, the archiver doesn't really do the archiving > > any more, because the interface makes that impossible. It has to use a > > separate background worker process for that, full stop. > > > > I don't think that's a

questions about possible enhancing protocol of communication between psql and pager

Hi I am starting to think about the next generation of pspg ( https://github.com/okbob/pspg). Now, the communication between psql and pspg is very simple. psql reads all data, does formatting to pretty table format, and sends it through pipe to pspg. pspg stores all data and tries to detect

Re: Move defaults toward ICU in 16?

On Fri, Feb 17, 2023 at 10:32 PM Jeff Davis wrote: > Thinking about this more, it's not clear to me if this would be in > scope for pg_upgrade or not. If pg_upgrade is fixing up the new cluster > rather than checking for compatibility, why doesn't it just take over > and do the initdb for the new