On Tue, Feb 21, 2023 at 1:28 PM Hayato Kuroda (Fujitsu)
wrote:
>
> > doc/src/sgml/catalogs.sgml
> >
> > 4.
> > +
> > +
> > + subminsenddelay int4
> > +
> > +
> > + The minimum delay, in milliseconds, by the publisher to send changes
> > +
> > +
> >
>
Given its nature and purpose as a module we don't want to run against an
installed instance, shouldn't src/test/modules/unsafe_tests have
NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
On 2023-Feb-22, Tomas Vondra wrote:
> But instead of I almost immediately ran into a LWLock deadlock :-(
Ouch.
> I've managed to reproduce this on PG13+, but I believe it's there since
> the brinRevmapDesummarizeRange was introduced in PG10. I just haven't
> tried on pre-13 releases.
Hmm, I
On Mon, 20 Feb 2023 at 16:18, Dean Rasheed wrote:
>
> As part of the MERGE RETURNING patch I noticed a suspicious Assert()
> in ExecInitPartitionInfo() that looked like it needed updating for
> MERGE.
>
> After more testing, I can confirm that this is indeed a pre-existing
> bug, that can be
On 21/02/2023 01:35, Stephen Frost wrote:
Greetings,
The name canonicalization support for Kerberos is doing us more harm
than good in the regression tests, so I propose we disable it. Patch
attached.
Thoughts?
Makes sense. A brief comment in 001_auth.pl itself to mention why we
disable
Hi,
While finalizing some fixes in BRIN, I decided to stress-test the
relevant part of the code to check if I missed something. Imagine a
simple script that builds BRIN indexes on random data, does random
changes and cross-checks the results with/without the index.
But instead of I almost
> If in future version the general data type is added, the copy command in
> binary
> format will not work well, right? It is because the inferior version does not
> have
> recv/send functions for added type. It means that there is a possibility that
> replication between different versions may
On 12.02.23 15:48, Mark Dilger wrote:
I should mention, src/sgml/html/libpq-exec.html needs clarification:
paramFormats[]Specifies whether parameters are text (put a zero in the array
entry for the corresponding parameter) or binary (put a one in the array entry
for the corresponding
On 11.02.23 22:54, Mark Dilger wrote:
Thanks Peter. Here are some observations about the documentation in patch
version 15.
In acronyms.sgml, the CEK and CMK entries should link to documentation, perhaps
linkend="glossary-column-encryption-key" and linkend="glossary-column-master-key".
On Wed, Feb 22, 2023 2:20 PM Michael Paquier wrote:
>
> On Wed, Feb 22, 2023 at 12:07:06PM +0900, Kyotaro Horiguchi wrote:
> > At Wed, 22 Feb 2023 12:29:59 +1100, Peter Smith
> wrote in
> >> If you are going to do that, then won't just copying the
> >>
Hi,
Thanks for the review.
On Wed, 22 Feb 2023 at 05:50, Kyotaro Horiguchi wrote:
>
> PgStat_PendingStats should be included in typedefs.list.
Done.
>
> + * Created for accumulating wal_write_time and wal_sync_time as a instr_time
> + * but instr_time can't be used as a type where it ends up
On 2/22/23 03:28, Jonathan S. Katz wrote:
> Hi,
>
> On 2/16/23 10:50 AM, Tomas Vondra wrote:
>> Hi,
>>
>> Here's a rebased patch, without the last bit which is now unnecessary
>> thanks to c981d9145dea.
>
> Thanks for continuing to work on this patch! I tested the latest version
> and have
On Wed, Feb 22, 2023 at 3:29 PM Masahiko Sawada
wrote:
>
> On Wed, Feb 22, 2023 at 4:35 PM John Naylor
> wrote:
> >
> > I don't think any vacuum calls in regression tests would stress any of
this code very much, so it's not worth carrying the old way forward. I was
thinking of only doing this
On Tue, 21 Feb 2023 at 09:34, Alvaro Herrera wrote:
>
> > I think the best fix is to have ExecMergeMatched() pass canSetTag =
> > false to ExecUpdateAct(), so that ExecMergeMatched() takes
> > responsibility for updating estate->es_processed in all cases.
>
> Sounds sensible.
>
I decided it was
> On 18 Feb 2023, at 06:46, Nathan Bossart wrote:
>
> On Fri, Feb 17, 2023 at 10:44:49PM +0100, Daniel Gustafsson wrote:
>> When adding a check to pg_upgrade a while back I noticed in a profile that
>> the
>> cluster compatibility check phase spend a lot of time in connectToServer.
>> Some
>>
On 22.02.23 08:20, Peter Smith wrote:
Here are some review comments for patch v15-0001
FYI, the patch applies clean and tests OK for me.
==
doc/src/sgml/datatype.sgml
1.
XMLSERIALIZE ( { DOCUMENT | CONTENT } value
AS type [ { NO INDENT | INDENT } ] )
~
Another/shorter way to write that
On 14/02/2023 11:10, Aleksander Alekseev wrote:
Hi Andres,
Shouldn't need to extract the column if we just want to know if it's NULL (see
heap_attisnull()). Afaics the value isn't accessed after this.
Many thanks. Fixed.
I'm confused, what exactly is the benefit of this? What extension
On 21/02/2023 21:22, Andres Freund wrote:
On 2023-02-21 18:18:02 +0200, Heikki Linnakangas wrote:
Is it ever possible to call this without a relcache entry? WAL redo
functions do that with ReadBuffer, but they only extend a relation
implicitly, by replay a record for a particular block.
I
On 22.02.23 08:05, Nikolay Samokhvalov wrote:
But is this as expected? Shouldn't it be like this:
text
13
?
Oracle and other parsers I know also do not work well with mixed
contents.[1,2] I believe libxml2's parser does not know where to put the
newline, as mixed values can contain
On 21.02.23 17:32, Nazir Bilal Yavuz wrote:
I like the second approach, with a 'uuid' feature option. As you wrote
earlier, adding an 'auto' choice to a combo option doesn't work fully like a
real feature option.
But we can make it behave exactly like one, by checking the auto_features
option.
On 20.02.23 20:48, Andres Freund wrote:
On 2023-02-20 19:43:56 +0100, Peter Eisentraut wrote:
I don't think any callers try to copy a directory source, so the
shutil.copytree() stuff isn't necessary.
I'd like to use it for installing docs outside of the normal install
target. Of course we
On 14/02/2023 03:42, Kyotaro Horiguchi wrote:
At Mon, 13 Feb 2023 12:18:07 +0900, Michael Paquier wrote
in
On Mon, Feb 13, 2023 at 11:27:58AM +0900, Kyotaro Horiguchi wrote:
I think currently the output by --describe-config can be used only for
consulting while editing a (possiblly broken)
On 09.02.23 10:42, Vik Fearing wrote:
v4 attached. I am putting this back to Needs Review in the commitfest
app, but these changes were editorial so it is probably RfC like Peter
had set it. I will let you be the judge of that.
I have committed this.
I made a few small last-minute tweaks:
Hi,
On Thu, Feb 02, 2023 at 12:56:47PM -0800, Nikolay Samokhvalov wrote:
> On Thu, Feb 2, 2023 at 12:43 PM Peter Geoghegan wrote:
> > I think that that problem should be solved at a higher level, in the
> > program that runs amcheck. Note that pg_amcheck will already do this
> > for B-Tree
On Tue, Feb 21, 2023 at 5:50 PM Nathan Bossart wrote:
> On Tue, Feb 21, 2023 at 09:03:27AM +0900, Michael Paquier wrote:
> > Perhaps beginning a new thread with a patch and a summary would be
> > better at this stage? Another thing I am wondering is if it could be
> > possible to test that
On Wed, Feb 22, 2023 at 4:35 PM John Naylor
wrote:
>
>
> On Wed, Feb 22, 2023 at 1:16 PM Masahiko Sawada wrote:
> >
> > On Mon, Feb 20, 2023 at 2:56 PM Masahiko Sawada
> > wrote:
> > >
> > > Yeah, I did a similar thing in an earlier version of tidstore patch.
>
> Okay, if you had checks
Commit e4602483e95 accidentally introduced a situation where pgindent
disagrees with the git whitespace check. The code is
conn = libpqsrv_connect_params(keywords, values,
/* expand_dbname = */ false,
101 - 127 of 127 matches
Mail list logo
