Re: Direct I/O

2023-04-29 Thread Thomas Munro
On Sun, Apr 30, 2023 at 4:11 PM Noah Misch wrote: > Speaking of the developer-only status, I find the io_direct name more enticing > than force_parallel_mode, which PostgreSQL renamed due to overuse from people > expecting non-developer benefits. Should this have a name starting with > debug_? H

Re: replacing role-level NOINHERIT with a grant-level option

2023-04-29 Thread Noah Misch
On Thu, Aug 25, 2022 at 10:19:39AM -0400, Robert Haas wrote: > I read through this again and found a comment that needed to be > updated, so I did that, bumped catversion, and committed this. [commit e3ce2de] > @@ -4735,8 +4735,8 @@ initialize_acl(void) > > /* >* I

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-04-29 Thread Peter Geoghegan
On Sat, Apr 29, 2023 at 8:54 PM John Naylor wrote: > I've done a more careful read-through, but I'll need a couple more, I imagine. Yeah, it's tough to get this stuff right. > I'll first point out some things I appreciate, and I'm glad are taken care of > as part of this work: > > - Pushing the

Re: Direct I/O

2023-04-29 Thread Noah Misch
On Mon, Apr 17, 2023 at 12:06:23PM -0400, Tom Lane wrote: > Robert Haas writes: > > On Sat, Apr 15, 2023 at 2:19 PM Tom Lane wrote: > >> I get the impression that we are going to need an actual runtime > >> test if we want to defend against this. Not entirely convinced > >> it's worth the troubl

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-04-29 Thread John Naylor
On Thu, Apr 27, 2023 at 12:58 AM Peter Geoghegan wrote: > > [v2] I've done a more careful read-through, but I'll need a couple more, I imagine. I'll first point out some things I appreciate, and I'm glad are taken care of as part of this work: - Pushing the talk of scheduled manual vacuums to t

Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound

2023-04-29 Thread John Naylor
On Sun, Apr 30, 2023 at 4:15 AM Peter Geoghegan wrote: > > On Sat, Apr 29, 2023 at 1:09 AM John Naylor > wrote: > > I made some small changes and wrote a suitably comprehensive commit message. I separated the possible uses for single-user mode into a separate paragraph in the "Note:" , moved the

Re: Add PQsendSyncMessage() to libpq

2023-04-29 Thread Anton Kirilov
Hello, On 28/04/2023 09:08, Denis Laxalde wrote: Michael Paquier a écrit : Speaking of which, what was the performance impact of your application once PQflush() was moved out of the pipeline sync?  Just asking for curiosity.. I have no metrics for that; but maybe Anton has some? I did a quick

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-04-29 Thread Peter Geoghegan
On Sat, Apr 29, 2023 at 1:17 AM John Naylor wrote: > > Although I didn't mention the issue with single user mode in my > > introductory email (the situation there is just appalling IMV), it > > seems like I might not be able to ignore that problem while I'm > > working on this patch. Declaring tha

Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound

2023-04-29 Thread Peter Geoghegan
On Sat, Apr 29, 2023 at 1:09 AM John Naylor wrote: > Looks good to me. I'm strongly in favor of this. It's most unfortunate that it took this long. > I've just made some small edits for v7 and wrote a commit message to explain > how we got here. This can be backpatched all the way, as it's simp

Re: Add PQsendSyncMessage() to libpq

2023-04-29 Thread Anton Kirilov
Hello, On 28/04/2023 13:06, Robert Haas wrote: On Fri, Mar 24, 2023 at 6:39 PM Anton Kirilov wrote: I have attached a patch that introduces PQsendSyncMessage()... I wonder whether this is the naming that we want. The two names are significantly different. Something like PQpipelineSendSync()

[PATCH] Add support function for containment operators

2023-04-29 Thread Kim Johan Andersson
I had noticed that performance wasn't great when using the @> or <@ operators when examining if an element is contained in a range. Based on the discussion in [1] I would like to suggest the following changes: This patch attempts to improve the row estimation, as well as opening the possibilit

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-04-29 Thread John Naylor
On Thu, Apr 27, 2023 at 12:58 AM Peter Geoghegan wrote: > > On Wed, Apr 26, 2023 at 12:16 AM John Naylor > wrote: > > Now is a great time to revise this section, in my view. (I myself am about ready to get back to testing and writing for the task of removing that "obnoxious hint".) > > Although I

Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound

2023-04-29 Thread John Naylor
On Tue, Apr 4, 2023 at 8:08 PM Aleksander Alekseev wrote: > [v6] 0001: Looks good to me. I've just made some small edits for v7 and wrote a commit message to explain how we got here. This can be backpatched all the way, as it's simply a correction. I do want to test on v11 first just for complet