On Wed, May 10, 2023 at 5:34 PM Michael Paquier wrote:
>
> +* NB: LWLockConflictsWithVar (which is called from
> +* LWLockWaitForVar) relies on the spinlock used above in this
> +* function and doesn't use a memory barrier.
>
> This patch adds the following comment in
On Wed, May 17, 2023 at 11:10:21AM +0200, Drouvot, Bertrand wrote:
> Sorry did not pay enough attention to it ;-(
No problem.
> Yeap, done in V10 for sgml and the C part too (for consistency).
The order looks fine seen from here, thanks!
--
Michael
signature.asc
Description: PGP signature
On Mon, May 15, 2023 at 11:23:22PM -0400, Joseph Koshakow wrote:
> Reading through the docs [0], I'm not actually sure if the REVOKE
> in the second example should succeed or not. At first it says:
>
>> A user can only revoke privileges that were granted directly by that
>> user. If, for example,
On Wed, 2023-04-19 at 23:28 +, Arne Roland wrote:
> > Thank you! I just tried our benchmark and got a performance
> > degration > of around 28 %, which is way better than the last
> > patch.
> >
> > The simple query select * from generate_series(0, 1000) shows >
> > roughly 18.9 %
On 5/7/23 3:14 PM, Pavel Luzanov wrote:
On 05.05.2023 19:51, David G. Johnston wrote:
But if it is really a blocker then maybe we should produce 3 separate
newline separated columns, one for the member of role, one for the
list of attributes, and one with the grantor. The column headers can
On 2023-05-17 We 17:55, Andres Freund wrote:
Hi,
On May 17, 2023 2:51:41 PM PDT, Andrew Dunstan wrote:
On 2023-05-16 Tu 17:52, Andres Freund wrote:
I suppose the alternative would be to change the way the buildfarm calls
pg_ctl stop. Do you have a concrete suggestion for that?
The easiest
Thanks for the information.
I checked the assembly code of __sync_lock_test_and_set generated by GCC
for loongarch64. It is exactly the same as this patch.
I guess this patch is not necessary any more.
Regards
On 2023/5/17 20:37, Tom Lane wrote:
YANG Xudong writes:
This patch set tries
On 5/17/23 6:59 PM, Jeff Davis wrote:
On Tue, 2023-05-16 at 20:23 -0700, Jeff Davis wrote:
Other than that, and I took your suggestions almost verbatim. Patch
attached. Thank you!
Attached new patch with a typo fix and a few other edits. I plan to
commit soon.
I did a quicker read through
On 2023-05-17 09:22:19 -0400, Robert Haas wrote:
> Adding pgstat_get_wait_extension adds runtime cost for no corresponding
> benefit. Having a special case in the code to avoid that seems worthwhile.
I don't think that should ever be used in a path where performance is
relevant?
On Thu, May 18, 2023 at 07:48:26AM +0900, Michael Paquier wrote:
> Okay. We are going to need an approach similar to what's done for
> src/backend/nodes where two things are generated in order to be able
> to have some of the wait event classes be treated as exceptions in the
> switch calling
On Tue, 2023-05-16 at 20:23 -0700, Jeff Davis wrote:
> Other than that, and I took your suggestions almost verbatim. Patch
> attached. Thank you!
Attached new patch with a typo fix and a few other edits. I plan to
commit soon.
Regards,
Jeff Davis
From
On Wed, May 17, 2023 at 09:22:19AM -0400, Robert Haas wrote:
> It seems to me that your automatic generation code might need a
> special case for wait event types that contain only a single wait
> event. But that doesn't seem like a bad thing to have. Adding
> pgstat_get_wait_extension adds
On Wed, 17 May 2023 13:46:35 -0400
Melanie Plageman wrote:
> On Wed, May 17, 2023 at 07:10:08PM +0200, Jehan-Guillaume de Rorthais wrote:
> > On Tue, 16 May 2023 16:00:52 -0400
> > Melanie Plageman wrote:
> > > ...
> > > There are some existing indentation issues in these files, but you can
>
On Wed, May 17, 2023 at 5:47 PM Joel Jacobson wrote:
> On Wed, May 17, 2023, at 19:42, Andrew Dunstan wrote:
> > You can use CSV mode pretty reliably for TSV files. The trick is to use a
> > quoting char that shouldn't appear, such as E'\x01' as well as setting
> the
> > delimiter to E'\t'. Yes,
I did a preliminary test run of pgindent today, and was dismayed
to see a bunch of misformatting in backend/jit/llvm/, which
evidently is because the typedefs list available from the
buildfarm no longer includes any LLVM typedefs. We apparently
used to have at least one buildfarm animal that was
Hi,
On May 17, 2023 2:51:41 PM PDT, Andrew Dunstan wrote:
>
>On 2023-05-16 Tu 17:52, Andres Freund wrote:
>>
>>> I suppose the alternative would be to change the way the buildfarm calls
>>> pg_ctl stop. Do you have a concrete suggestion for that?
>> The easiest fix is to redirect stdin to
On 2023-05-16 Tu 17:52, Andres Freund wrote:
I suppose the alternative would be to change the way the buildfarm calls
pg_ctl stop. Do you have a concrete suggestion for that?
The easiest fix is to redirect stdin to /dev/null (or some file, if that's
easier to do portably) - that should fix
On Wed, May 17, 2023, at 19:42, Andrew Dunstan wrote:
> You can use CSV mode pretty reliably for TSV files. The trick is to use a
> quoting char that shouldn't appear, such as E'\x01' as well as setting the
> delimiter to E'\t'. Yes, it's far from obvious.
I've been using that trick myself many
On Wed, May 17, 2023 at 2:13 PM Tom Lane wrote:
> Laurenz Albe writes:
> > You removed the QUERY at the end of the query.
>
> Fixed
Also Fixed Pavel's name.
Also Added Laurenze as a Reviewed By: (not sure, never want to NOT ack
someone)
>
> Also, you'd have to avoid
I wrote:
> Andrew Dunstan writes:
>> I doubt there's something like that.
> I had a read-through of the latest version's man page, and found
> this promising-looking entry:
> -boc, --break-at-old-comma-breakpoints
Sadly, this seems completely not ready for prime time. I experimented
with
Hi,
On 2023-05-17 12:53:15 -0700, Andres Freund wrote:
> I'll try to come up with a benchmark without the issues I pointed out in
> https://postgr.es/m/20230517194331.ficfy5brpfq5lrmz%40awork3.anarazel.de
Here we go:
setup:
create primary
SELECT pg_create_physical_replication_slot('reserve',
Hi,
I was working on setting up a PG16.devel(375407f4) test database with
UTF8 but C locale, and found the following strange behaviour:
plain initdb:
[...]
Using default ICU locale "en_US".
Using language tag "en-US" for ICU locale "en_US".
The database cluster will be initialized with this
Hi,
Thanks for working on the patch!
On 2023-05-15 20:09:00 +0530, Bharath Rupireddy wrote:
> > [1]
> > max_wal_senders = 100
> > before regression(ms)after regression(ms)v2 patch(ms)
> > 13394.4013 14141.2615 13455.2543
> > Compared with
"Jonathan S. Katz" writes:
> The release date for PostgreSQL 16 Beta 1 is scheduled for May 25, 2023.
> Please ensure you have committed any work for Beta 1 released committed
> by May 21, 2023 AoE.
BTW, pursuant to this schedule I intend to run renumber_oids.pl, pgindent,
pgperltidy, etc (cf
On Wed, 2023-05-17 at 12:34 -0700, Andres Freund wrote:
> I understood Jeff's proposal to just have an early exit if there are
> no
> walsenders connected at all.
My suggestion was we early exit unless there is at least one *waiting*
walsender of the appropriate type. In other words, increment
Hi,
On 2023-05-11 09:42:39 +, Zhijie Hou (Fujitsu) wrote:
> I did some simple tests for this to see the performance impact on
> the streaming replication, just share it here for reference.
>
> 1) sync primary-standby setup, load data on primary and count the time spent
> on
> replication.
... BTW, something I'd considered in an earlier attempt at fixing this
was to change clause_is_computable_at's API to pass the clause's
RestrictInfo not just the clause_relids, along the lines of
@@ -541,9 +547,10 @@ extract_actual_join_clauses(List *restrictinfo_list,
*/
bool
Richard Guo writes:
> Here is an updated patch with comments and test case. I also change the
> code to store 'group_clause_relids' directly in RestrictInfo.
Hmm ... I don't like this patch terribly much. It's not obvious why
(or if) it works, and it's squirreling bits of semantic knowledge
Hi,
On 2023-05-10 08:39:08 +0200, Drouvot, Bertrand wrote:
> On 5/9/23 11:00 PM, Andres Freund wrote:
> > Hi,
> >
> > On 2023-05-09 13:38:24 -0700, Jeff Davis wrote:
> > > On Tue, 2023-05-09 at 12:02 -0700, Andres Freund wrote:
> > > > I don't think the approach of not having any sort of
On 5/17/23 1:30 PM, Alexander Korotkov wrote:
Tom,
On Wed, May 17, 2023 at 3:08 PM Tom Lane wrote:
Amit Kapila writes:
Tom/Nathan, do you have any further suggestions here?
My recommendation is to revert this feature. I do not see any
way that we won't regret it as a poor design.
I
On 5/17/23 3:19 PM, Andres Freund wrote:
Hi,
On 2023-05-16 10:30:27 -0400, Jonathan S. Katz wrote:
On 5/6/23 1:30 PM, Melanie Plageman wrote:
I've done that in the attached v5.
[RMT hat]
RMT nudge on this thread, as we're approaching the Beta 1 cutoff. From the
above discussion, it sounds
Hi,
On 2023-05-16 10:30:27 -0400, Jonathan S. Katz wrote:
> On 5/6/23 1:30 PM, Melanie Plageman wrote:
>
> > I've done that in the attached v5.
>
> [RMT hat]
>
> RMT nudge on this thread, as we're approaching the Beta 1 cutoff. From the
> above discussion, it sounds like it's pretty close to
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
Hello Yurii,
I've retested your latest patch and tested
Laurenz Albe writes:
> You removed the QUERY at the end of the query.
> I think we should keep that (as comments, of course). People
> are used to the current output, and it is nice to have a clear
> visual marker at the end of what isn't normally part of "psql"
> output.
I
On Wed, May 17, 2023 at 07:10:08PM +0200, Jehan-Guillaume de Rorthais wrote:
> On Tue, 16 May 2023 16:00:52 -0400
> Melanie Plageman wrote:
> > > From 309ad354b7a9e4dfa01b2985bd883829f5e0eba0 Mon Sep 17 00:00:00 2001
> > > From: Jehan-Guillaume de Rorthais
> > > Date: Tue, 16 May 2023 15:42:14
On Wed, 2023-05-17 at 13:39 -0400, Kirk Wolak wrote:
> Here's the patch.
You removed the QUERY at the end of the query.
I think we should keep that (as comments, of course). People
are used to the current output, and it is nice to have a clear
visual marker at the end of what
On 2023-05-16 Tu 13:15, Joel Jacobson wrote:
On Tue, May 16, 2023, at 13:43, Joel Jacobson wrote:
>If we made midfield quoting a CSV error, those users who are
currently mistaken
>about their TSV/TEXT files being CSV while also having balanced
quotes in their
>data, would encounter an error
On Mon, May 15, 2023 at 9:05 PM Kirk Wolak wrote:
> On Mon, May 15, 2023 at 10:28 AM Tom Lane wrote:
>
>> Alvaro Herrera writes:
>> > It's worth considering what will readline history do with the comment.
>>
>
Hmmm... We could put a SPACE before the comment, that usually stops
readline from
Tom,
On Wed, May 17, 2023 at 3:08 PM Tom Lane wrote:
> Amit Kapila writes:
> > Tom/Nathan, do you have any further suggestions here?
>
> My recommendation is to revert this feature. I do not see any
> way that we won't regret it as a poor design.
I have carefully noted your concerns regarding
On Tue, 16 May 2023 16:00:52 -0400
Melanie Plageman wrote:
> On Tue, May 16, 2023 at 04:00:51PM +0200, Jehan-Guillaume de Rorthais wrote:
>
> > From e5ecd466172b7bae2f1be294c1a5e70ce2b43ed8 Mon Sep 17 00:00:00 2001
> > From: Melanie Plageman
> > Date: Thu, 30 Apr 2020 07:16:28 -0700
> >
I'm sorry I was unable to respond right away.
On 09.05.2023 17:23, torikoshia wrote:
You may already understand it, but these variable names are given in
imitation of FREEZE and BINARY cases:
--- a/src/include/commands/copy.h
+++ b/src/include/commands/copy.h
@@ -42,6 +42,7 @@ typedef
On 5/17/23 12:47 PM, Nathan Bossart wrote:
On Wed, May 17, 2023 at 08:08:36AM -0400, Tom Lane wrote:
Amit Kapila writes:
Tom/Nathan, do you have any further suggestions here?
My recommendation is to revert this feature. I do not see any
way that we won't regret it as a poor design.
I
On Wed, May 17, 2023 at 08:08:36AM -0400, Tom Lane wrote:
> Amit Kapila writes:
>> Tom/Nathan, do you have any further suggestions here?
>
> My recommendation is to revert this feature. I do not see any
> way that we won't regret it as a poor design.
I agree. The problem seems worth solving,
|1. Switch --load-via-partition-root is very useful.
Would it be a big deal to add extra information to the |||dump |custom
format so that this switch can be specified from pg_restore level?
2. Another common usability problem is a quick dump of the selected
parent table.
It is important that
Kirk Wolak writes:
> I made the / QUERY / changes.
> And I found the .po files, and modified those to match.
It's not your job to modify the .po files, at least not unless
you join the translation team --- and even then, it'd not happen
till after the core patch gets committed.
>
Team,
I made the / QUERY / changes.
And I found the .po files, and modified those to match.
make checkworld -- worked
Anyway, I have NO IDEA how I run psql in a different language.
I tried gnome-language-selector, I installed Russian/Czech.
I switched my entire system to Russian.
On 5/17/23 10:59, Tomas Vondra wrote:
> On 5/17/23 08:18, Michael Paquier wrote:
>> On Tue, May 09, 2023 at 02:54:31PM +0200, Tomas Vondra wrote:
>>> Yeah. Thanks for the report, should have been found during review.
>>
>> Tomas, are you planning to do something by the end of this week for
>>
On Tue, May 16, 2023 at 1:14 AM Michael Paquier wrote:
> These are the two things refactored in the patch, explaining the what.
> The reason behind the why is to make the script in charge of
> generating all these structures and functions consistent for all the
> wait event classes, simply.
YANG Xudong writes:
> This patch set tries to add loongarch64 native spin lock to postgresql.
This came up before, and our response was
https://git.postgresql.org/gitweb/?p=postgresql.git=commitdiff=1c72d82c2
In principle, at least, there is no longer any need for
machine-specific s_lock.h
Amit Kapila writes:
> Tom/Nathan, do you have any further suggestions here?
My recommendation is to revert this feature. I do not see any
way that we won't regret it as a poor design.
regards, tom lane
Hi, Amit.
On Wed, May 17, 2023 at 9:47 AM Amit Kapila wrote:
> I see there are mainly three concerns (a) Avoid adding the new option
> USER SET, (b) The behavior of this feature varies from the precedents
> set by a0ffa885e and 13d838815, (c) As per discussion, not following
> 13d838815 could
> On 7 Mar 2023, at 23:05, Daniel Gustafsson wrote:
>
> When skimming through pg_rewind during a small review I noticed the use of
> pipe_read_line for reading arbitrary data from a pipe, the mechanics of which
> seemed odd.
A rebase of this for the CFBot since I realized I had forgotten to add
Hi hackers!
As discussed above, I've created a new thread on the Extension of the TOAST
pointer subject -
https://www.postgresql.org/message-id/flat/CAN-LCVMq2X%3Dfhx7KLxfeDyb3P%2BBXuCkHC0g%3D9GF%2BJD4izfVa0Q%40mail.gmail.com
Please check and comment.
On Thu, Apr 27, 2023 at 1:43 PM Nikita
17.05.2023 04:25, Michael Paquier wrote:
The numbers between f193883fc~1 and HEAD+patch are close to each
other. It does not seem to make the whole difference with 15.3, but
most of it. The difference can also be explained with some noise,
based on the number patterns of the third runs?
I
On 5/17/23 08:18, Michael Paquier wrote:
> On Tue, May 09, 2023 at 02:54:31PM +0200, Tomas Vondra wrote:
>> Yeah. Thanks for the report, should have been found during review.
>
> Tomas, are you planning to do something by the end of this week for
> beta1? Or do you need some help of any kind?
Hi,
This patch set tries to add loongarch64 native spin lock to postgresql.
- [PATCH 1/2] implements a loongarch64 native spin lock.
- [PATCH 2/2] fixes s_lock_test to make it runnable via `make check'.
The patch set is tested on my Loongson 3A5000 machine with Loong Arch
Linux and GCC 13.1.0
On Wed, May 17, 2023 at 08:31:53AM +0200, Drouvot, Bertrand wrote:
> Did it that way in V9 attached and the sorting does look like what
> we expect now.
Yes, the order of the items in the individual tables is fine, but this
is still a bit incorrect for the classes? Note that the tables for
the
On Sun, May 14, 2023 at 2:20 AM Kirk Wolak wrote:
> On Sat, May 13, 2023 at 3:34 PM Jeremy Smith
> wrote:
>
>>
>>
>> On Sat, May 13, 2023, 3:25 AM Kirk Wolak wrote:
>>
>>> Does this imply SQL SYNTAX like:
>>>
>>> SHOW CREATE TABLE
>>> [ INCLUDING { ALL | INDEXES | SEQUENCES | ??? }]
>>>
On Fri, Apr 28, 2023 at 5:01 AM Alexander Korotkov wrote:
>
> On Fri, Apr 28, 2023 at 1:38 AM Tom Lane wrote:
> > Nathan Bossart writes:
> > > On Thu, Apr 27, 2023 at 03:22:04PM -0400, Tom Lane wrote:
> > >> The right way to do this was not to add some
> > >> poorly-explained option to ALTER
Hi,
On 5/16/23 8:16 AM, Michael Paquier wrote:
On Mon, May 15, 2023 at 10:07:04AM +0200, Drouvot, Bertrand wrote:
This is preliminary work to autogenerate some wait events
code and documentation done in [1].
The patch introduces 2 new "wait events" (WAIT_EVENT_EXTENSION
and
On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
wrote:
>
> Den ons 17 maj 2023 kl 03:18 skrev Peter Smith :
> >
> > + errhint("Use %s to disassociate the subscription from the slot after
> > disabling the subscription.",
> >
> > IMO it looked strange having the word "subscription" 2x in the same
On Tue, May 09, 2023 at 02:54:31PM +0200, Tomas Vondra wrote:
> Yeah. Thanks for the report, should have been found during review.
Tomas, are you planning to do something by the end of this week for
beta1? Or do you need some help of any kind?
--
Michael
signature.asc
Description: PGP
On Sun, Apr 30, 2023 at 12:25:20PM -0400, Jonathan S. Katz wrote:
> [RMT hat]
>
> I read through the original thread[1] to understand the use case and also
> the concerns, but I need to study [1] and this thread a bit more before I
> can form an opinion.
>
> The argument that there is "demand
63 matches
Mail list logo
