Re: PG 16 draft release notes ready

On Fri, 19 May 2023 at 22:59, jian he wrote: > > Sorry for changing the subject line. > > these two commits seems not mentioned. > On a similar topic, should every committed item from the commitfest be mentioned, or only ones that are significant enough? I’m wondering because I had a role

Re: PG 16 draft release notes ready

Sorry for changing the subject line. these two commits seems not mentioned. Fix ts_headline() edge cases for empty query and empty search text. https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=029dea882a7aa34f46732473eed7c917505e6481 Simplify the implementations of the to_reg*

Avoiding another needless ERROR during nbtree page deletion

Work from commit 5b861baa (later backpatched as commit 43e409ce) taught nbtree to press on with vacuuming an index when page deletion fails to "re-find" a downlink in the target page's parent (or in some page to the right of the parent) due to index corruption. To recap, avoiding ERRORs during

Re: Wrong results from Parallel Hash Full Join

I noticed that BF animal conchuela has several times fallen over on the test case added by 558c9d75f: diff -U3 /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/expected/join_hash.out /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/results/join_hash.out ---

Re: PG 16 draft release notes ready

The v16 release notes are problematic in a PDF docs build: [WARN] FOUserAgent - Glyph "?" (0x142, lslash) not available in font "Times-Roman". This is evidently from Add functions to add, subtract, and generate timestamptz values in a specified time zone (Przemysław Sztoch, Gurjeet Singh)

Re: benchmark results comparing versions 15.2 and 16

Hi, On 2023-05-19 15:44:09 -0700, MARK CALLAGHAN wrote: > On Tue, May 9, 2023 at 10:36 AM MARK CALLAGHAN wrote: > > > > > > > On Fri, May 5, 2023 at 10:01 PM MARK CALLAGHAN wrote: > > > >> I have two more runs of the benchmark in progress so we will have 3 > >> results for each of the test

Re: Order changes in PG16 since ICU introduction

Jeff Davis writes: > Committed, thank you. This commit has given the PDF docs build some indigestion: Making portrait pages on A4 paper (210mmx297mm) /home/postgres/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf [WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with

Re: benchmark results comparing versions 15.2 and 16

On Tue, May 9, 2023 at 10:36 AM MARK CALLAGHAN wrote: > > > On Fri, May 5, 2023 at 10:01 PM MARK CALLAGHAN wrote: > >> I have two more runs of the benchmark in progress so we will have 3 >> results for each of the test cases to confirm that the small regressions >> are repeatable. >> > I

Re: Adding SHOW CREATE TABLE

On 19/05/2023 19:08, Andrew Dunstan wrote: I think the ONLY place we should have this is in server side functions. More than ten years ago I did some work in this area (see below), but it's one of those things that have been on my ever growing personal TODO list See

Re: Adding SHOW CREATE TABLE

On Fri, 2023-05-19 at 13:08 -0400, Andrew Dunstan wrote: > On 2023-05-18 Th 19:53, Stephen Frost wrote: > > * Kirk Wolak (wol...@gmail.com) wrote: > > > My approach for now is to develop this as the \st command. > > > After reviewing the code/output from the 3 sources (psql, fdw, and > > >

Re: Adding SHOW CREATE TABLE

> > I think the ONLY place we should have this is in server side functions. > More than ten years ago I did some work in this area (see below), but it's > one of those things that have been on my ever growing personal TODO list > > See >

Re: Add operator for dividing interval by an interval

Hi, On 2023-05-18 17:03:24 -0400, Tom Lane wrote: > Andres Freund writes: > > What about an interval / interval -> double operator that errors out > > whenever > > month is non-zero? As far as I can tell that would always be deterministic. > > We have months, days, and microseconds, and

Re: How to ensure that SSPI support (Windows) enabled?

Thanks Stephen, very useful information dm On 5/19/23, 12:02 PM, "Stephen Frost" wrote: Greetings, Please don't top-post. * Dimitry Markman (dmark...@mathworks.com) wrote: > I was asking our 3p library people how to add windows support to gss and they > said

Re: Assert failure of the cross-check for nullingrels

Richard Guo writes: > I keep thinking about my proposal in v2 patch. It seems more natural to > me to fix this issue, because an outer join's quals are always treated > as a whole when we check if identity 3 applies in make_outerjoininfo, as > well as when we adjust the outer join's quals for

Re: Order changes in PG16 since ICU introduction

Jeff Davis wrote: > 2) Automatically change the provider to libc when locale=C. > > Almost works, but it's not clear how we handle the case "provider=icu > lc_collate='fr_FR.utf8' locale=C". > > If we change it to "provider=libc lc_collate=C", we've overridden the > specified

Re: The documentation for READ COMMITTED may be incomplete or wrong

Hi Tom, > Done that way. I chose to replace the tuple_table field, because > it was in a convenient spot and it seemed like the field least > likely to have any outside code referencing it. Many thanks! If it's not too much trouble could you please recommend good entry points to learn more

Re: The documentation for READ COMMITTED may be incomplete or wrong

Amit Langote writes: > On Fri, May 19, 2023 at 8:57 AM Tom Lane wrote: >> What I'm thinking about doing to back-patch this is to replace >> one of the pointer fields in EPQState with a pointer to a >> subsidiary palloc'd structure, where we can put the new fields >> along with the cannibalized

Re: Missing warning on revokes with grant options

Sorry for the multiple consecutive emails. I just came across this comment that explains the current behavior in restrict_and_check_grant /* * Restrict the operation to what we can actually grant or revoke, and * issue a warning if appropriate. (For REVOKE this isn't quite what the * spec says

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

On 2023-May-19, Andrey M. Borodin wrote: > I have a question, but mostly for my own knowledge. Translation > changes seem trivial for all languages, do we typically fix .po files > in such cases? Or do we leave it to translators to revise the stuff? The translations use a completely separate

Re: Adding SHOW CREATE TABLE

On 2023-05-18 Th 19:53, Stephen Frost wrote: Greetings, * Kirk Wolak (wol...@gmail.com) wrote: My approach for now is to develop this as the \st command. After reviewing the code/output from the 3 sources (psql, fdw, and pg_dump). This trivializes the approach, and requires the smallest set

Re: New COPY options: DELIMITER NONE and QUOTE NONE

On 2023-05-19 Fr 05:24, Joel Jacobson wrote: I hacked together a broken patch just to demonstrate the idea on syntax and basic idea. The `COPY ... FROM` examples above works. But it doesn't work at all for `COPY ... TO`, since it output \0 byte as delimiter and quote in the output, which is of

Re: PG 16 draft release notes ready

On Fri, May 19, 2023 at 4:49 AM Bruce Momjian wrote: > I have completed the first draft of the PG 16 release notes. You can > see the output here: > > https://momjian.us/pgsql_docs/release-16.html > > I will adjust it to the feedback I receive; that URL will quickly show > all updates.

Re: Missing warning on revokes with grant options

I've been thinking about this some more and reading the SQL99 spec. In the original thread that added these warnings [0], which was linked earlier in this thread by Nathan, the following assertion was made: > After that, you get to the General Rules, which pretty clearly say that > trying to

Re: Conflict between regression tests namespace & transactions due to recent changes

On 2023-05-19 17:59, Tom Lane wrote: Marina Polyakova writes: On 2023-05-19 09:03, Michael Paquier wrote: FYI, the buildfarm is seeing some spurious failures as well: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=schnauzer=2023-05-1904%3A29%3A42 Yes, it is the same error. Here's

Re: PG 16 draft release notes ready

On Fri, May 19, 2023 at 11:07:29AM -0400, Sehrope Sarkuni wrote: > The intro in "E.1.3. Changes" says "... between PostgreSQL 15 and the previous > major release". > > That should be "... between PostgreSQL __16__ ..." right? Oh, I thought I had changed all those --- fixed now, thanks! --

Re: PG 16 draft release notes ready

On Fri, May 19, 2023 at 07:31:40AM -0700, Nathan Bossart wrote: > On Thu, May 18, 2023 at 04:49:47PM -0400, Bruce Momjian wrote: > > I have completed the first draft of the PG 16 release notes. You can > > see the output here: > > > > https://momjian.us/pgsql_docs/release-16.html > > > > I

Re: The documentation for READ COMMITTED may be incomplete or wrong

Amit Langote writes: > On Fri, May 19, 2023 at 8:57 AM Tom Lane wrote: > +* Initialize per-relation EPQ tuple states. Result relations, if any, > +* get marked as blocked; others as not-fetched. > Would it be helpful to clarify that "blocked" means blocked for a > given EvalPlanQual()

Re: Should CSV parsing be stricter about mid-field quotes?

Joel Jacobson wrote: > I understand its necessity for STDIN, given that the end of input needs to > be explicitly defined. > However, for files, we have a known file size and the end-of-file can be > detected without the need for special markers. > > Also, is the difference in how

Re: How to ensure that SSPI support (Windows) enabled?

Greetings, Please don't top-post. * Dimitry Markman (dmark...@mathworks.com) wrote: > I was asking our 3p library people how to add windows support to gss and they > said that on windows we should use SSPI They're correct. > I’m not really familiar with either gssapi or SSPI Kerberos support

"38.10.10. Shared Memory and LWLocks" may require a clarification

Hi, While re-reading 38.10.10. Shared Memory and LWLocks [1] and the corresponding code in pg_stat_statements.c I noticed that there are several things that can puzzle the reader. The documentation and the example suggest that LWLock* should be stored within a structure in shared memory: ```

Re: How to ensure that SSPI support (Windows) enabled?

Hi Tom, thanks a lot for your super fast answer . I really appreciate that I was asking our 3p library people how to add windows support to gss and they said that on windows we should use SSPI I’m not really familiar with either gssapi or SSPI I see that macOS has builtin support for gssapi,

Re: Memory leak from ExecutorState context?

Tomas Vondra writes: > I didn't push 0001, I don't think generally do separate pgindent patches > like this (I only run pgindent on large patches to ensure it doesn't > cause massive breakage, not separately like this, but YMMV). It's especially pointless when the main pgindent run for v16 is

Re: How to ensure that SSPI support (Windows) enabled?

Dimitry Markman writes: > I’m looking at config_default.pl file and I can see the line > gss => undef,# --with-gssapi= > I was advised to use SSPI API that is built-in (windows) instead of MIT > Kerberos > So what should I set and where to ensure that result PostgreSQL build will >

Re: Memory leak from ExecutorState context?

On 5/19/23 00:27, Melanie Plageman wrote: > On Wed, May 17, 2023 at 6:35 PM Jehan-Guillaume de Rorthais > wrote: >> >> On Wed, 17 May 2023 13:46:35 -0400 >> Melanie Plageman wrote: >> >>> On Wed, May 17, 2023 at 07:10:08PM +0200, Jehan-Guillaume de Rorthais wrote: On Tue, 16 May 2023

How to ensure that SSPI support (Windows) enabled?

Hi I’m looking at config_default.pl file and I can see the line gss => undef,# --with-gssapi= I was advised to use SSPI API that is built-in (windows) instead of MIT Kerberos So what should I set and where to ensure that result PostgreSQL build will support SSPI? Thanks in advance

Re: PG 16 draft release notes ready

The intro in "E.1.3. Changes" says "... between PostgreSQL 15 and the previous major release". That should be "... between PostgreSQL __16__ ..." right? Regards, -- Sehrope Sarkuni Founder & CEO | JackDB, Inc. | https://www.jackdb.com/

Re: WAL Insertion Lock Improvements

On Fri, May 19, 2023 at 12:24 PM Michael Paquier wrote: > > On Thu, May 18, 2023 at 11:18:25AM +0530, Bharath Rupireddy wrote: > > I think what I have so far seems more verbose explaining what a > > barrier does and all that. I honestly think we don't need to be that > > verbose, thanks to

Re: smgrzeroextend clarification

I have committed some of the unrelated formatting changes separately, so what's left now is attached. On 17.05.23 01:38, Andres Freund wrote: - I left this for smgrzeroextend(): FIXME: why both blocknum and nblocks I guess you're suggesting that we would do an lstat() to figure out the size

Re: Conflict between regression tests namespace & transactions due to recent changes

Marina Polyakova writes: > On 2023-05-19 09:03, Michael Paquier wrote: >> FYI, the buildfarm is seeing some spurious failures as well: >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=schnauzer=2023-05-1904%3A29%3A42 > Yes, it is the same error. Here's another one in version 13: >

Re: Naming of gss_accept_deleg

On Fri, May 19, 2023 at 09:42:00AM -0400, Tom Lane wrote: > Abhijit Menon-Sen writes: >> I would also prefer a GUC named gss_accept_delegation, but the current >> name matches the libpq gssdeleg connection parameter and the PGSSDELEG >> environment variable. Maybe there's something to be said for

Re: PostgreSQL 16 Beta 1 release announcement draft

On Fri, May 19, 2023 at 12:17:50AM -0400, Jonathan S. Katz wrote: > Attached is a draft of the release announcement for PostgreSQL 16 Beta 1. > The goal of this announcement is to get people excited about testing the > beta and highlight many of the new features. Thanks! > PostgreSQL 16

Re: PG 16 draft release notes ready

On Thu, May 18, 2023 at 04:49:47PM -0400, Bruce Momjian wrote: > I have completed the first draft of the PG 16 release notes. You can > see the output here: > > https://momjian.us/pgsql_docs/release-16.html > > I will adjust it to the feedback I receive; that URL will quickly show > all

Re: Naming of gss_accept_deleg

On Fri, May 19, 2023 at 09:42:00AM -0400, Tom Lane wrote: > Abhijit Menon-Sen writes: > > I would also prefer a GUC named gss_accept_delegation, but the current > > name matches the libpq gssdeleg connection parameter and the PGSSDELEG > > environment variable. Maybe there's something to be said

Re: Naming of gss_accept_deleg

Abhijit Menon-Sen writes: > I would also prefer a GUC named gss_accept_delegation, but the current > name matches the libpq gssdeleg connection parameter and the PGSSDELEG > environment variable. Maybe there's something to be said for keeping > those three things alike? +1 for spelling it out in

Re: Naming of gss_accept_deleg

At 2023-05-19 09:16:09 -0400, br...@momjian.us wrote: > > On Fri, May 19, 2023 at 09:07:26AM -0400, Stephen Frost wrote: > > > > > Why is the new PG 16 GUC called "gss_accept_deleg" and not > > > "gss_accept_delegation"? The abbreviation here seems atypical. > > > > At the time it felt natural

Re: Naming of gss_accept_deleg

On Fri, May 19, 2023 at 09:07:26AM -0400, Stephen Frost wrote: > Greetings, > > * Bruce Momjian (br...@momjian.us) wrote: > > Why is the new PG 16 GUC called "gss_accept_deleg" and not > > "gss_accept_delegation"? The abbreviation here seems atypical. > > At the time it felt natural to me but I

Re: Naming of gss_accept_deleg

Greetings, * Bruce Momjian (br...@momjian.us) wrote: > Why is the new PG 16 GUC called "gss_accept_deleg" and not > "gss_accept_delegation"? The abbreviation here seems atypical. At the time it felt natural to me but I don't feel strongly about it, happy to change it if folks would prefer it

Re: The documentation for READ COMMITTED may be incomplete or wrong

Thanks for the patch. On Fri, May 19, 2023 at 8:57 AM Tom Lane wrote: > I wrote: > > Debian Code Search doesn't know of any outside code touching > > relsubs_done, so I think we are safe in dropping that code in > > ExecScanReScan. It seems quite pointless anyway considering > > that up to now,

Re: PG 16 draft release notes ready

On Fri, May 19, 2023 at 09:49:18AM +0200, Drouvot, Bertrand wrote: > Thanks! > > " > This adds the function pg_log_standby_snapshot(). TEXT?: > " > > My proposal: > > This adds the function pg_log_standby_snapshot() to log details of the > current snapshot > to WAL. If the primary is idle, the

Naming of gss_accept_deleg

Why is the new PG 16 GUC called "gss_accept_deleg" and not "gss_accept_delegation"? The abbreviation here seems atypical. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: PG 16 draft release notes ready

On Fri, May 19, 2023 at 07:42:12AM +, Hans Buschmann wrote: > I observed a missing end bracket in E 1.3.11: > > > Require Windows 10 or newer versions (Michael Paquier, Juan José Santamaría > Flecha Thanks, fixed. -- Bruce Momjian https://momjian.us EDB

Re: How to connect with PostgreSQL Database with SSL using Certificates and Key from client Eclipse in Java

Thank you for your response. On Fri, 19 May 2023 at 5:11 PM, Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi Sujay, > > > I am trying to connect with PostgreSQL database from client with SSL > enabled on server 10.30.32.186 port 6432 using below java code - > > This mailing list is

Re: How to connect with PostgreSQL Database with SSL using Certificates and Key from client Eclipse in Java

Hi Sujay, > I am trying to connect with PostgreSQL database from client with SSL enabled > on server 10.30.32.186 port 6432 using below java code - This mailing list is dedicated to the PostgreSQL Core development. I don't think you will find many people interested in your question and/or

How to connect with PostgreSQL Database with SSL using Certificates and Key from client Eclipse in Java

I am trying to connect with PostgreSQL database from client with SSL enabled on server 10.30.32.186 port 6432 using below java code - I am using certificates ( [server-cert.pem, server-key.pem, ca.cert] and [postgresql.crt, postgresql.pk8, root.crt] ). Suggest me if there are any specific java

Re: The documentation for READ COMMITTED may be incomplete or wrong

Hi, > The attached v2 mechanizes that using two bool arrays. I tested the patch on several combinations of operating systems (LInux, MacOS) and architectures (x64, RISC-V) available to me at the moment, with both Meson and Autotools. Also I made sure eval-plan-qual.spec fails when the C code is

Re: very long record lines in expanded psql output

On 2022-Jul-25, Andrew Dunstan wrote: > Committed. There were a couple of bits missing, which I filled in, and I > changed the behaviour when the option is given without an argument, so > that instead of resetting it the current value is shown, similarly to > how most pset options work. I was

New COPY options: DELIMITER NONE and QUOTE NONE

The thread "Should CSV parsing be stricter about mid-field quotes?" [1] forked into a new topic, with two new ideas, hence this new thread. 1. COPY ... QUOTE NONE In the [1] thread, Andrew Dunstan suggested a trick on how to deal with unquoted but delimited files, such as TSV-files produced by

Re: PG 16 draft release notes ready

Hi, On 5/18/23 10:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. You can see the output here: https://momjian.us/pgsql_docs/release-16.html I will adjust it to the feedback I receive; that URL will quickly show all updates. Thanks! "

Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN

Hi, On 5/19/23 12:36 AM, Michael Paquier wrote: On Thu, May 18, 2023 at 12:28:20PM -0400, Robert Haas wrote: I mean, I agree that it would probably be hard to measure any real performance difference. But I'm not sure that's a good reason to add cycles to a path where we don't really need to.

Re: ERROR: wrong varnullingrels (b 5 7) (expected (b)) for Var 3/3

On Fri, May 19, 2023 at 1:57 PM Michael Paquier wrote: > Thanks for the test case, issue reproduced here on HEAD and not v15. > This causes an assertion failure here: > #4 0x55a6f8faa776 in ExceptionalCondition > (conditionName=0x55a6f915ac60 "bms_equal(rel->relids, >

PG 16 draft release notes ready

I observed a missing end bracket in E 1.3.11: Require Windows 10 or newer versions (Michael Paquier, Juan José Santamaría Flecha Hans Buschmann

RE: walsender performance regression due to logical decoding on standby changes

On Friday, May 19, 2023 11:08 AM Kyotaro Horiguchi wrote: > At Thu, 18 May 2023 20:11:11 +0530, Bharath Rupireddy > wrote in > > > > + ConditionVariableInit(>physicalWALSndCV); > > > > + ConditionVariableInit(>logicalWALSndCV); > > > > > > It's not obvious to me that

Re: WAL Insertion Lock Improvements

On Thu, May 18, 2023 at 11:18:25AM +0530, Bharath Rupireddy wrote: > I think what I have so far seems more verbose explaining what a > barrier does and all that. I honestly think we don't need to be that > verbose, thanks to README.barrier. Agreed. This file is a mine of information. > I

Re: Conflict between regression tests namespace & transactions due to recent changes

On 2023-05-19 09:03, Michael Paquier wrote: On Wed, May 17, 2023 at 02:39:10PM +0900, Michael Paquier wrote: On Tue, May 16, 2023 at 11:02:45AM +0300, Marina Polyakova wrote: It confuses me a little that different methods are used for the same purpose. But the namespace test checks schemas. So

Re: Should CSV parsing be stricter about mid-field quotes?

On Thu, May 18, 2023, at 18:48, Daniel Verite wrote: > Joel Jacobson wrote: >> OTOH, one would then need to inspect the TSV file doesn't contain \. on an >> empty line... > > Note that this is the case for valid CSV contents, since backslash-dot > on a line by itself is both an end-of-data marker

Re: Conflict between regression tests namespace & transactions due to recent changes

On Wed, May 17, 2023 at 02:39:10PM +0900, Michael Paquier wrote: > On Tue, May 16, 2023 at 11:02:45AM +0300, Marina Polyakova wrote: >> It confuses me a little that different methods are used for the same >> purpose. But the namespace test checks schemas. So see >> diff_abc_to_txn_table.patch