Re: Naming of gss_accept_deleg

2023-05-20 Thread Abhijit Menon-Sen
At 2023-05-20 23:21:57 -0400, t...@sss.pgh.pa.us wrote: > > Nathan Bossart writes: > > On Sat, May 20, 2023 at 09:33:44PM -0400, Bruce Momjian wrote: > >> With less then 48 hours to beta 1 packaging, I have made this change and > >> adjusted internal variable to match. > > > The buildfarm and cfb

Re: createuser --memeber and PG 16

2023-05-20 Thread Peter Eisentraut
On 15.05.23 22:11, Nathan Bossart wrote: On Mon, May 15, 2023 at 04:27:04PM +0900, Michael Paquier wrote: On Fri, May 12, 2023 at 04:35:34PM +0200, Peter Eisentraut wrote: it's not intuitive whether foo becomes a member of bar or bar becomes a member of foo. Maybe something more verbose like -

Re: Adding SHOW CREATE TABLE

2023-05-20 Thread Kirk Wolak
On Sat, May 20, 2023 at 2:33 PM Stephen Frost wrote: > Greetings, > > On Sat, May 20, 2023 at 13:32 David G. Johnston < > david.g.johns...@gmail.com> wrote: > >> On Sat, May 20, 2023 at 10:26 AM Stephen Frost >> wrote: >> >>> > A server function can be conveniently called from any client code. >

Re: Naming of gss_accept_deleg

2023-05-20 Thread Nathan Bossart
On Sat, May 20, 2023 at 11:21:57PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> The buildfarm and cfbot seem unhappy with 9c0a0e2. It looks like there are >> a few remaining uses of gss_accept_deleg to rename. I'm planning to commit >> the attached patch shortly. Done. > I thought the pl

Re: Naming of gss_accept_deleg

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 11:21:57PM -0400, Tom Lane wrote: > Nathan Bossart writes: > > On Sat, May 20, 2023 at 09:33:44PM -0400, Bruce Momjian wrote: > >> With less then 48 hours to beta 1 packaging, I have made this change and > >> adjusted internal variable to match. > > > The buildfarm and cfb

Re: Naming of gss_accept_deleg

2023-05-20 Thread Tom Lane
Nathan Bossart writes: > On Sat, May 20, 2023 at 09:33:44PM -0400, Bruce Momjian wrote: >> With less then 48 hours to beta 1 packaging, I have made this change and >> adjusted internal variable to match. > The buildfarm and cfbot seem unhappy with 9c0a0e2. It looks like there are > a few remaini

Re: Naming of gss_accept_deleg

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 08:17:57PM -0700, Nathan Bossart wrote: > On Sat, May 20, 2023 at 09:33:44PM -0400, Bruce Momjian wrote: > > With less then 48 hours to beta 1 packaging, I have made this change and > > adjusted internal variable to match. > > The buildfarm and cfbot seem unhappy with 9c0a0

Re: Naming of gss_accept_deleg

2023-05-20 Thread Nathan Bossart
On Sat, May 20, 2023 at 09:33:44PM -0400, Bruce Momjian wrote: > With less then 48 hours to beta 1 packaging, I have made this change and > adjusted internal variable to match. The buildfarm and cfbot seem unhappy with 9c0a0e2. It looks like there are a few remaining uses of gss_accept_deleg to r

LLVM 16 (opaque pointers)

2023-05-20 Thread Thomas Munro
Hi, Here is a draft version of the long awaited patch to support LLVM 16. It's mostly mechanical donkeywork, but it took some time: this donkey found it quite hard to understand the mighty getelementptr instruction[1] and the code generation well enough to figure out all the right types, and small

Re: Order changes in PG16 since ICU introduction

2023-05-20 Thread Jeff Davis
On Fri, 2023-05-19 at 21:13 +0200, Daniel Verite wrote: > ISTM that if we want to go that route, we need the make the minimum > changes at the user interface level and not any deeper, so that when > (locale="C" OR locale="POSIX") AND the provider has not been > specified, > then the command (initdb

Re: Naming of gss_accept_deleg

2023-05-20 Thread Bruce Momjian
On Fri, May 19, 2023 at 07:58:34AM -0700, Nathan Bossart wrote: > On Fri, May 19, 2023 at 09:42:00AM -0400, Tom Lane wrote: > > Abhijit Menon-Sen writes: > >> I would also prefer a GUC named gss_accept_delegation, but the current > >> name matches the libpq gssdeleg connection parameter and the PG

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 08:51:21PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have added this release note item: > > > Add functions pg_input_is_valid() and pg_input_error_message() to check > > for type conversion errors (Tom Lane) > > pg_input_error_message got renamed to pg_inp

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 10:37:58AM +0200, Drouvot, Bertrand wrote: > It's the snapshot of running transactions (aka the xl_running_xacts WAL > record) that is used during the > logical slot creation to determine if the logical decoding find a consistent > state to start with. > > On a primary th

Re: PG 16 draft release notes ready

2023-05-20 Thread Tom Lane
Bruce Momjian writes: > I have added this release note item: > Add functions pg_input_is_valid() and pg_input_error_message() to check > for type conversion errors (Tom Lane) pg_input_error_message got renamed to pg_input_error_info later, cf b8da37b3a (which maybe should be included in t

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Fri, May 19, 2023 at 11:08:18PM -0400, Isaac Morland wrote: > On Fri, 19 May 2023 at 22:59, jian he wrote: > > > Sorry for changing the subject line.  > > these two commits seems not mentioned. > > > On a similar topic, should every committed item from the commitfest be > menti

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 10:59:20AM +0800, jian he wrote: > > Sorry for changing the subject line.  > > these two commits seems not mentioned. > Fix ts_headline() edge cases for empty query and empty search text. > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h= > 029dea882a7aa

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 12:59:35AM +0800, jian he wrote: > Add function pg_dissect_walfile_name() to report the segment and timeline > values of WAL file names (Bharath Rupireddy) > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h= > 13e0d7a603852b8b05c03b45228daabffa0cced2

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Sat, May 20, 2023 at 06:07:08PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, May 19, 2023 at 07:05:12PM -0400, Tom Lane wrote: > >> ... "ł" doesn't exist in ISO8859-1. I'd suggest dumbing these > >> down to plain "l". > > > Done. I know we used to be limited to Latin-1 but when

Re: PG 16 draft release notes ready

2023-05-20 Thread Tom Lane
Bruce Momjian writes: > On Fri, May 19, 2023 at 07:05:12PM -0400, Tom Lane wrote: >> ... "ł" doesn't exist in ISO8859-1. I'd suggest dumbing these >> down to plain "l". > Done. I know we used to be limited to Latin-1 but when my build of HTML > worked, I thought that had changed. :-( Yeah, I

Re: PG 16 draft release notes ready

2023-05-20 Thread Bruce Momjian
On Fri, May 19, 2023 at 07:05:12PM -0400, Tom Lane wrote: > The v16 release notes are problematic in a PDF docs build: > > [WARN] FOUserAgent - Glyph "?" (0x142, lslash) not available in font > "Times-Roman". > > This is evidently from > > Add functions to add, subtract, and generate timestampt

Re: benchmark results comparing versions 15.2 and 16

2023-05-20 Thread MARK CALLAGHAN
On Fri, May 19, 2023 at 4:04 PM Andres Freund wrote: > With "yet to see any significant changes" do you mean that the runs are > comparable with earlier runs, showing the same regression? Or that the > regression vanished? Or ...? > I mean that I might be chasing noise and the mean+stddev for th

Re: Adding SHOW CREATE TABLE

2023-05-20 Thread Stephen Frost
Greetings, On Sat, May 20, 2023 at 13:32 David G. Johnston wrote: > On Sat, May 20, 2023 at 10:26 AM Stephen Frost wrote: > >> > A server function can be conveniently called from any client code. >> >> Clearly any client using libpq can conveniently call code which is in >> libpq. >> > > Clearl

Re: Adding SHOW CREATE TABLE

2023-05-20 Thread Tom Lane
"David G. Johnston" writes: > On Sat, May 20, 2023 at 10:26 AM Stephen Frost wrote: >> Clearly any client using libpq can conveniently call code which is in >> libpq. > Clearly there are clients that don't use libpq. JDBC comes to mind. Yeah. I'm also rather concerned about the bloat factor;

Re: Adding SHOW CREATE TABLE

2023-05-20 Thread David G. Johnston
On Sat, May 20, 2023 at 10:26 AM Stephen Frost wrote: > > A server function can be conveniently called from any client code. > > Clearly any client using libpq can conveniently call code which is in > libpq. > > Clearly there are clients that don't use libpq. JDBC comes to mind. David J.

Re: Adding SHOW CREATE TABLE

2023-05-20 Thread Stephen Frost
Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > On Fri, 2023-05-19 at 13:08 -0400, Andrew Dunstan wrote: > > On 2023-05-18 Th 19:53, Stephen Frost wrote: > > > * Kirk Wolak (wol...@gmail.com) wrote: > > > > My approach for now is to develop this as the \st command. > > > > After revi

Re: ICU locale validation / canonicalization

2023-05-20 Thread Jeff Davis
On Tue, 2023-05-02 at 07:29 -0700, Noah Misch wrote: > On Thu, Mar 30, 2023 at 08:59:41AM +0200, Peter Eisentraut wrote: > > On 30.03.23 04:33, Jeff Davis wrote: > > > Attached is a new version of the final patch, which performs > > > canonicalization. I'm not 100% sure that it's wanted, but it > >

Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error

2023-05-20 Thread Alexander Lakhin
Hello Alvaro, 21.02.2023 19:32, Alvaro Herrera wrote: On 2023-Feb-20, Alvaro Herrera wrote: Found one last problem: if you do "-f foobar.sql -M prepared" in that order, then the prepare fails because the statement names would not be assigned when the file is parsed. This coding only supported

Re: Assert failure of the cross-check for nullingrels

2023-05-20 Thread Tom Lane
Richard Guo writes: > I tried with v4 patch and find that, as you predicted, it might reject > all the clones in some cases. Check the query below > ... > So the qual 't3.a = t4.a' is missing in this plan shape. I poked into that more closely and realized that the reason that clause_is_computabl

Re: New COPY options: DELIMITER NONE and QUOTE NONE

2023-05-20 Thread Andrew Dunstan
On 2023-05-20 Sa 02:59, Joel Jacobson wrote: On Fri, May 19, 2023, at 19:03, Andrew Dunstan wrote: > I think you've been a bit too cute with the grammar changes, but as you say this is a POC. Thanks for feedback. The approach I took for the new grammar rules was inspired by previous commits

Re: PG 16 draft release notes ready

2023-05-20 Thread Drouvot, Bertrand
Hi, On 5/19/23 2:29 PM, Bruce Momjian wrote: On Fri, May 19, 2023 at 09:49:18AM +0200, Drouvot, Bertrand wrote: Thanks! " This adds the function pg_log_standby_snapshot(). TEXT?: " My proposal: This adds the function pg_log_standby_snapshot() to log details of the current snapshot to WAL. I

Re: Should CSV parsing be stricter about mid-field quotes?

2023-05-20 Thread Joel Jacobson
On Fri, May 19, 2023, at 18:06, Daniel Verite wrote: > COPY FROM file CSV somewhat differs as your example shows, > but it still mishandle \. when unquoted. For instance, consider this > file to load with COPYt FROM '/tmp/t.csv' WITH CSV > $ cat /tmp/t.csv > line 1 > \. > line 3 > line 4 >

Re: New COPY options: DELIMITER NONE and QUOTE NONE

2023-05-20 Thread Joel Jacobson
On Fri, May 19, 2023, at 19:03, Andrew Dunstan wrote: > I think you've been a bit too cute with the grammar changes, but as you say > this is a POC. Thanks for feedback. The approach I took for the new grammar rules was inspired by previous commits, such as de7531a971b, which introduced support