Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Amit Kapila
On Fri, Aug 11, 2023 at 10:43 AM Julien Rouhaud wrote: > > On Thu, Aug 10, 2023 at 04:30:40PM +0900, Masahiko Sawada wrote: > > On Thu, Aug 10, 2023 at 2:27 PM Amit Kapila wrote: > > > > > > Sawada-San, Julien, and others, do you have any thoughts on the above > > > point? > > > > IIUC during

Re: Inconsistent results with libc sorting on Windows

2023-08-10 Thread Noah Misch
On Wed, Jun 14, 2023 at 12:50:28PM +0200, Juan José Santamaría Flecha wrote: > On Wed, Jun 14, 2023 at 4:13 AM Peter Geoghegan wrote: > > > On Tue, Jun 13, 2023 at 5:59 PM Thomas Munro > > wrote: > > > Trying to follow along here... you're doing the moral equivalent of > > > strxfrm(), so sort

Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Amit Kapila
On Thu, Aug 10, 2023 at 7:07 PM Masahiko Sawada wrote: > > On Thu, Aug 10, 2023 at 12:52 PM Amit Kapila wrote: > > > > > > Are you suggesting doing this before we start the old cluster or after > > we stop the old cluster? I was thinking about the pros and cons of > > doing this check when the

Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Julien Rouhaud
Hi, On Thu, Aug 10, 2023 at 04:30:40PM +0900, Masahiko Sawada wrote: > On Thu, Aug 10, 2023 at 2:27 PM Amit Kapila wrote: > > > > Sawada-San, Julien, and others, do you have any thoughts on the above point? > > IIUC during the old cluster running in the middle of pg_upgrade it > doesn't accept

Re: Report planning memory in EXPLAIN ANALYZE

2023-08-10 Thread Andrey Lepikhov
On 10/8/2023 15:33, Ashutosh Bapat wrote: On Wed, Aug 9, 2023 at 8:56 PM David Rowley wrote: On Thu, 10 Aug 2023 at 03:12, Ashutosh Bapat wrote: I guess it depends on the problem you're trying to solve. I had thought you were trying to do some work to reduce the memory used by the planner,

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

2023-08-10 Thread Noah Misch
On Tue, Aug 08, 2023 at 07:59:55PM -0700, Andres Freund wrote: > On 2023-08-08 22:29:50 -0400, Robert Treat wrote: > 3) using ~350 USD / mo in GCP costs for windows, linux, freebsd (*) > > The other likely option would be to seek out cloud credits > I tried to start that progress within

Re: [PATCH] Add loongarch native checksum implementation.

2023-08-10 Thread Amit Kapila
On Thu, Aug 10, 2023 at 5:07 PM John Naylor wrote: > > On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier wrote: > > > > On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote: > > > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am > > > facing the below error: > > >

Simplify create_merge_append_path a bit for clarity

2023-08-10 Thread Richard Guo
As explained in the comments for generate_orderedappend_paths, we don't currently support parameterized MergeAppend paths, and it doesn't seem like going to change anytime soon. Based on that, we could simplify create_merge_append_path a bit, such as set param_info to NULL directly rather than

Re: 2023-08-10 release announcement draft

2023-08-10 Thread Donghang Lin
Hi, Sorry, join late after the release note is out. > * An out-of-memory error from JIT will now cause a PostgreSQL `FATAL` error instead of a C++ exception. I assume this statement is related to this fix[1]. I think an OOM error from JIT causing a PostgreSQL `FATAL` error is the actual

Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Bruce Momjian
On Thu, Aug 10, 2023 at 10:37:04PM +0900, Masahiko Sawada wrote: > On Thu, Aug 10, 2023 at 12:52 PM Amit Kapila wrote: > > Are you suggesting doing this before we start the old cluster or after > > we stop the old cluster? I was thinking about the pros and cons of > > doing this check when the

Re: Add PG CI to older PG releases

2023-08-10 Thread Andres Freund
Hi, On 2023-08-10 18:09:03 -0400, Tom Lane wrote: > Nazir Bilal Yavuz writes: > > PG CI is added starting from PG 15, adding PG CI to PG 14 and below > > could be beneficial. So, firstly I tried adding it to the > > REL_14_STABLE branch. If that makes sense, I will try to add PG CI to > > other

Re: Add PG CI to older PG releases

2023-08-10 Thread Andres Freund
Hi, On 2023-08-10 19:55:15 +0300, Nazir Bilal Yavuz wrote: > v2-0001-windows-Only-consider-us-to-be-running-as-service.patch is an > older commit (59751ae47fd43add30350a4258773537e98d4063). A couple of > tests were failing without this because the log file was empty and the > tests were comparing

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

2023-08-10 Thread Peter Smith
On Fri, Aug 11, 2023 at 12:54 AM Melih Mutlu wrote: > > Hi Peter and Vignesh, > > Peter Smith , 7 Ağu 2023 Pzt, 09:25 tarihinde şunu > yazdı: >> >> Hi Melih. >> >> Now that the design#1 ERRORs have been fixed, we returned to doing >> performance measuring of the design#1 patch versus HEAD. > > >

Re: obtaining proc oid given a oper id

2023-08-10 Thread CK Tan
Found it. /* * get_opcode * * Returns the regproc id of the routine used to implement an * operator given the operator oid. */ RegProcedure get_opcode(Oid opno) On Thu, Aug 10, 2023 at 1:17 PM CK Tan wrote: > > Hi Hackers, is there a function that would lookup the

Re: Add PG CI to older PG releases

2023-08-10 Thread Tom Lane
Nazir Bilal Yavuz writes: > PG CI is added starting from PG 15, adding PG CI to PG 14 and below > could be beneficial. So, firstly I tried adding it to the > REL_14_STABLE branch. If that makes sense, I will try to add PG CI to > other old PG releases. I'm not actually sure this is worth

obtaining proc oid given a oper id

2023-08-10 Thread CK Tan
Hi Hackers, is there a function that would lookup the proc that implements an operator? Thanks, -cktan

[PATCH] Support static linking against LLVM

2023-08-10 Thread Marcelo Juchem
By default, PostgreSQL doesn't explicitly choose whether to link statically or dynamically against LLVM when LLVM JIT is enabled (e.g.: `./configure --with-llvm`). `llvm-config` will choose to dynamically link by default. In order to statically link, one must pass `--link-static` to

Re: WIP: new system catalog pg_wait_event

2023-08-10 Thread Drouvot, Bertrand
Hi, On 8/9/23 9:56 AM, Michael Paquier wrote: On Tue, Aug 08, 2023 at 10:16:37AM +0200, Drouvot, Bertrand wrote: Please find attached v3 adding the wait event types. +-- There will surely be at least 9 wait event types, 240 wait events and at +-- least 27 related to WAL +select

Re: Add PG CI to older PG releases

2023-08-10 Thread Nazir Bilal Yavuz
Hi, On Thu, 10 Aug 2023 at 18:05, Peter Eisentraut wrote: > I see only one attachment, so it's not clear what these commit hashes > refer to. I split the commit into 3 parts. v2-0001-windows-Only-consider-us-to-be-running-as-service.patch is an older commit

Re: Allow parallel plan for referential integrity checks?

2023-08-10 Thread Juan José Santamaría Flecha
On Tue, Jul 4, 2023 at 9:45 AM Daniel Gustafsson wrote: > > As there is no new patch submitted I will go ahead and do that, please feel > free to resubmit when there is renewed interest in working on this. > > Recently I restored a database from a directory format backup and having this feature

Re: Add PG CI to older PG releases

2023-08-10 Thread Peter Eisentraut
On 10.08.23 16:43, Nazir Bilal Yavuz wrote: 1_ 76e38b37a5f179d4c9d2865ff31b79130407530b is added for debugging Windows. Also a couple of SSL tests were failing without this because the log file is empty. Example failures on 001_ssltests.pl: I see only one attachment, so it's not clear what

Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails

2023-08-10 Thread Jehan-Guillaume de Rorthais
On Thu, 3 Aug 2023 11:02:43 +0200 Alvaro Herrera wrote: > On 2023-Aug-03, tender wang wrote: > > > I think old "sub-FK" should not be dropped, that will be violates foreign > > key constraint. > > Yeah, I've been playing more with the patch and it is definitely not > doing the right things.

RE: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Hayato Kuroda (Fujitsu)
Dear hackers, Based on recent discussions, I updated the patch set. I did not reply one by one because there are many posts, but thank you for giving many suggestion! Followings shows what I changed. 1. This feature is now enabled by default. Instead "--exclude-logical-replication-slots" was

Re: Fix last unitialized memory warning

2023-08-10 Thread Peter Eisentraut
On 09.08.23 17:29, Tristan Partin wrote: On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: On 09.08.23 10:07, Peter Eisentraut wrote: > On 08.08.23 17:14, Tristan Partin wrote: >>> I was able to reproduce the warning now on Fedora.  I agree with the >>> patch >>> >>> -  

Re: LLVM 16 (opaque pointers)

2023-08-10 Thread Ronan Dunklau
Le dimanche 21 mai 2023, 05:01:41 CEST Thomas Munro a écrit : > Hi, > > Here is a draft version of the long awaited patch to support LLVM 16. > It's mostly mechanical donkeywork, but it took some time: this donkey > found it quite hard to understand the mighty getelementptr > instruction[1] and

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

2023-08-10 Thread Melih Mutlu
Hi Peter and Vignesh, Peter Smith , 7 Ağu 2023 Pzt, 09:25 tarihinde şunu yazdı: > Hi Melih. > > Now that the design#1 ERRORs have been fixed, we returned to doing > performance measuring of the design#1 patch versus HEAD. Thanks a lot for taking the time to benchmark the patch. It's really

Re: libpq compression (part 2)

2023-08-10 Thread Jonah H. Harris
Pinging to see if anyone has continued to work on this behind-the-scenes or whether this is the latest patch set there is. -- Jonah H. Harris

Add PG CI to older PG releases

2023-08-10 Thread Nazir Bilal Yavuz
Hi, PG CI is added starting from PG 15, adding PG CI to PG 14 and below could be beneficial. So, firstly I tried adding it to the REL_14_STABLE branch. If that makes sense, I will try to add PG CI to other old PG releases. 'Add PG CI to PG 14' patch is attached. I merged both CI commits and the

Re: proposal: psql: show current user in prompt

2023-08-10 Thread Jelte Fennema
On Thu, 10 Aug 2023 at 14:44, Pavel Stehule wrote: > čt 10. 8. 2023 v 14:05 odesílatel Jelte Fennema napsal: >> That it is not rolled-back >> in a case like this? >> >> BEGIN; >> \set PROMPT '%N' >> ROLLBACK; > > > surely not. > > \set is client side setting, and it is not transactional.

how to ensure parallel restore consistency ?

2023-08-10 Thread 熊艳辉
PG version 15.4 i read code about pg_dump pg_restore, there is an option -j/--jobs related with parallel, i have questions about parallel dump restore 1)In pg_dump when running parallel dump, it can ensure dump data consistency using synchronized snaphot, why should it start a trasaction in

回复:Re: inconsistency between the VM page visibility status and the visibility status of the page

2023-08-10 Thread 熊艳辉
Sure, that's correct. There are indeed some code bugs in my logic, thank you very much for your response. 发自我的企业微信 --回复的邮件信息-- Tomas Vondra

Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Masahiko Sawada
On Thu, Aug 10, 2023 at 12:52 PM Amit Kapila wrote: > > On Thu, Aug 10, 2023 at 6:46 AM Masahiko Sawada wrote: > > > > On Wed, Aug 9, 2023 at 1:15 PM Amit Kapila wrote: > > > > > > On Wed, Aug 9, 2023 at 8:01 AM Masahiko Sawada > > > wrote: > > > > > > I feel it would be a good idea to

Re: Adding a pg_servername() function

2023-08-10 Thread Jimmy Angelakos
Hi all, FWIW, I too believe this is a feature that has been sorely missing for years, leading us to use awful hacks like running "hostname" as PROGRAM and retrieving its output. Ideally that's what this function (or GUC) should return, what the system believes its hostname to be. It doesn't even

Re: [question] multil-column range partition prune

2023-08-10 Thread Christoph Moench-Tegeder
## tender wang (tndrw...@gmail.com): > But I want to know why we don't prune when just have latter partition key > in whereClause. Start with the high level documentation https://www.postgresql.org/docs/current/sql-createtable.html#SQL-CREATETABLE-PARTITION where the 5th paragraph points you to

Re: proposal: psql: show current user in prompt

2023-08-10 Thread Pavel Stehule
čt 10. 8. 2023 v 14:05 odesílatel Jelte Fennema napsal: > On Tue, 8 Aug 2023 at 07:20, Pavel Stehule > wrote: > > The reason why I implemented separate flow is usage from psql and > independence of transaction state. It is used for the \set command, that > is non-transactional, not SQL. If I

Re: proposal: psql: show current user in prompt

2023-08-10 Thread Jelte Fennema
On Tue, 8 Aug 2023 at 07:20, Pavel Stehule wrote: > The reason why I implemented separate flow is usage from psql and > independence of transaction state. It is used for the \set command, that is > non-transactional, not SQL. If I inject this message to some other flow, I > lose this

Re: [PATCH] Add loongarch native checksum implementation.

2023-08-10 Thread John Naylor
On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier wrote: > > On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote: > > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am > > facing the below error: > > Generating configuration headers... > > undefined symbol:

Re: A failure in 031_recovery_conflict.pl on Debian/s390x

2023-08-10 Thread Thomas Munro
On Thu, Aug 10, 2023 at 9:15 PM Christoph Berg wrote: > No XXX lines this time either, but I've seen then im logfiles that > went through successfully. Hmm. Well, I think this looks like a different kind of bug then. That patch of mine is about fixing some unsafe coding on the receiving side of

Re: [PATCH] Add loongarch native checksum implementation.

2023-08-10 Thread Michael Paquier
On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote: > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am > facing the below error: > Generating configuration headers... > undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line > 718 at

Re: Add assertion on held AddinShmemInitLock in GetNamedLWLockTranche()

2023-08-10 Thread Michael Paquier
On Fri, Jul 28, 2023 at 11:07:49AM +0530, Bharath Rupireddy wrote: > Why to block multiple readers (if at all there exists any), with > LWLockHeldByMeInMode(..., LW_EXCLUSIVE)? I think > Assert(LWLockHeldByMe(AddinShmemInitLock)); suffices in > GetNamedLWLockTranche. I am not sure to follow this

Re: [question] multil-column range partition prune

2023-08-10 Thread Matthias van de Meent
On Thu, 10 Aug 2023 at 12:16, tender wang wrote: > > I have an range partition and query below: > create table p_range(a int, b int) partition by range (a,b); create table > p_range1 partition of p_range for values from (1,1) to (3,3); create table > p_range2 partition of p_range for values

Re: [PATCH] Add loongarch native checksum implementation.

2023-08-10 Thread Amit Kapila
On Thu, Aug 10, 2023 at 10:35 AM John Naylor wrote: > > On Tue, Aug 8, 2023 at 2:22 PM YANG Xudong wrote: > > > > On 2023/8/8 14:38, John Naylor wrote: > > > > > v4 0001 is the same as v3, but with a draft commit message. I will > > > squash and commit this week, unless there is additional

[question] multil-column range partition prune

2023-08-10 Thread tender wang
I have an range partition and query below: create table p_range(a int, b int) partition by range (a,b); create table p_range1 partition of p_range for values from (1,1) to (3,3); create table p_range2 partition of p_range for values from (4,4) to (6,6); explain select * from p_range where b =2;

Re: pgsql: Ignore BRIN indexes when checking for HOT udpates

2023-08-10 Thread Alvaro Herrera
On 2023-Aug-09, Tomas Vondra wrote: > On 8/9/23 11:11, Alvaro Herrera wrote: > > I was trying to use RelationGetIndexAttrBitmap for something and > > realized that its header comment does not really explain things very > > well. That was already the case before this commit, but it (this > >

Re: [PoC] Reducing planning time when tables have many partitions

2023-08-10 Thread Yuya Watari
Hello David, I really appreciate your quick reply. On Wed, Aug 9, 2023 at 7:28 PM David Rowley wrote: > If 0004 is adding an em_index to mark the index into > PlannerInfo->eq_members, can't you use that in > setup_eclass_member[_strict]_iterator to loop to verify that the two > methods yield

Re: A failure in 031_recovery_conflict.pl on Debian/s390x

2023-08-10 Thread Christoph Berg
Re: To Thomas Munro > 603 iterations later it hit again, but didn't log anything. (I believe > I did run "make" in the right directory.) This time it took 3086 iterations to hit the problem. Running c27f8621eedf7 + Debian patches + v8 + pgstat-report-conflicts-immediately.patch + the XXX

Re: Fix pg_stat_reset_single_table_counters function

2023-08-10 Thread Masahiko Sawada
On Thu, Aug 10, 2023 at 2:10 PM Masahiro Ikeda wrote: > > On 2023-08-01 15:23, Masahiro Ikeda wrote: > > Hi, > > > > My colleague, Mitsuru Hinata (in CC), found the following issue. > > > > The documentation of pg_stat_reset_single_table_counters() says > >> pg_stat_reset_single_table_counters (

Re: Support to define custom wait events for extensions

2023-08-10 Thread Michael Paquier
On Thu, Aug 10, 2023 at 01:08:39PM +0900, Masahiro Ikeda wrote: > In addition, I change the followings: > * update about custom wait events in sgml. we don't need to use > shmem_startup_hook. > * change the hash names for readability. > (ex. WaitEventExtensionNameHash ->

[question] difference between vm_extend and fsm_extend

2023-08-10 Thread Junwang Zhao
Hey hacks, I'm looking the code of free space map and visibility map, both the module call `ExtendBufferedRelTo` to extend its file when necessary, what confused me is that `vm_extend` has an extra step that send a shared message to force other backends to close other smgr references. My

Re: Report planning memory in EXPLAIN ANALYZE

2023-08-10 Thread Ashutosh Bapat
Hi David, On Wed, Aug 9, 2023 at 8:09 PM Ashutosh Bapat wrote: > > I need to just make sure that the Planning Memory is reported with SUMMARY ON. > The patch reports planning memory in EXPLAIN without ANALYZE when SUMMARY = ON. #explain (summary on) select * from a, b where a.c1 = b.c1 and a.c1

Re: Report planning memory in EXPLAIN ANALYZE

2023-08-10 Thread Ashutosh Bapat
On Wed, Aug 9, 2023 at 8:56 PM David Rowley wrote: > > On Thu, 10 Aug 2023 at 03:12, Ashutosh Bapat > wrote: > > Thinking more about it, I think memory used is the only right metrics. > > It's an optimization in MemoryContext implementation that malloc'ed > > memory is not freed when it is

Re: [BackendXidGetPid] only access allProcs when xid matches

2023-08-10 Thread Junwang Zhao
On Thu, Aug 10, 2023 at 4:11 PM Ashutosh Bapat wrote: > > Please add this to commitfest so that it's not forgotten. > Added [1], thanks [1]: https://commitfest.postgresql.org/44/4495/ > On Wed, Aug 9, 2023 at 8:37 PM Junwang Zhao wrote: > > > > On Wed, Aug 9, 2023 at 10:46 PM Ashutosh Bapat >

Re: Adding a pg_servername() function

2023-08-10 Thread Laetitia Avrot
Dear Christoph, Please find my answers below. Le mer. 9 août 2023 à 22:05, Christoph Moench-Tegeder a écrit : > ## GF (phab...@gmail.com): > > And now that I checked it: I do have systems with gethostname() > returning an FQDN, and other systems return the (short) hostname > only. The return

Re: [BackendXidGetPid] only access allProcs when xid matches

2023-08-10 Thread Ashutosh Bapat
Please add this to commitfest so that it's not forgotten. On Wed, Aug 9, 2023 at 8:37 PM Junwang Zhao wrote: > > On Wed, Aug 9, 2023 at 10:46 PM Ashutosh Bapat > wrote: > > > > On Wed, Aug 9, 2023 at 9:30 AM Junwang Zhao wrote: > > > > > > In function `BackendXidGetPid`, when looping every

Re: Fix last unitialized memory warning

2023-08-10 Thread Richard Guo
On Thu, Aug 10, 2023 at 8:57 AM Julien Rouhaud wrote: > On Wed, Aug 09, 2023 at 10:29:56AM -0500, Tristan Partin wrote: > > On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: > > > > > > This patch has apparently upset one buildfarm member with a very old > > > compiler: > > > >

Re: Extract numeric [field] in JSONB more effectively

2023-08-10 Thread Andy Fan
Hi Chap: Thanks for the review. > The minor spelling point, the word 'field' has been spelled > 'filed' throughout this comment (just as in the email subject): > > + /* > +* Simplify cast(jsonb_object_filed(jsonb, filedName) as > type) > +* to

Re: Adding a pg_servername() function

2023-08-10 Thread Laetitia Avrot
Dear Tom, Thank you for your interest in that patch and for taking the time to point out several things that need to be better. Please find below my answers. Le mer. 9 août 2023 à 16:04, Tom Lane a écrit : > I actually do object to this, because I think the concept of "server > name" is

Re: [PoC] pg_upgrade: allow to upgrade publisher node

2023-08-10 Thread Masahiko Sawada
On Thu, Aug 10, 2023 at 2:27 PM Amit Kapila wrote: > > On Mon, Aug 7, 2023 at 3:46 PM Amit Kapila wrote: > > > > On Mon, Aug 7, 2023 at 1:06 PM Julien Rouhaud wrote: > > > > > > On Mon, Aug 07, 2023 at 12:42:33PM +0530, Amit Kapila wrote: > > > > On Mon, Aug 7, 2023 at 11:29 AM Julien Rouhaud

Re: Support "Right Semi Join" plan shapes

2023-08-10 Thread Richard Guo
On Tue, Apr 18, 2023 at 5:07 PM Richard Guo wrote: > In thread [1] which discussed 'Right Anti Join', Tom once mentioned > 'Right Semi Join'. After a preliminary investigation I think it is > beneficial and can be implemented with very short change. With 'Right > Semi Join', what we want to do

Re: Adding a pg_servername() function

2023-08-10 Thread Laetitia Avrot
Le mer. 9 août 2023 à 17:32, GF a écrit : > > Would it be less problematic if the function were called pg_gethostname()? > @Laetitia: why did you propose that name? maybe to avoid clashes with some > extension out there? > > I used that name to be kind of coherent with the inet_server_addr(),