pg_ctl start may return 0 even if the postmaster has been already started on Windows

2023-09-07 Thread Hayato Kuroda (Fujitsu)
Dear hackers, While investigating the cfbot failure [1], I found a strange behavior of pg_ctl command. How do you think? Is this a bug to be fixed or in the specification? # Problem The "pg_ctl start" command returns 0 (succeeded) even if the cluster has already been started. This occurs on

Re: Transaction timeout

2023-09-07 Thread bt23nguyent
On 2023-09-06 20:32, Andrey M. Borodin wrote: Thanks for looking into this! On 6 Sep 2023, at 13:16, Fujii Masao wrote: While testing v4 patch, I noticed it doesn't handle the COMMIT AND CHAIN case correctly. When COMMIT AND CHAIN is executed, I believe the transaction timeout counter

Re: [PoC] Reducing planning time when tables have many partitions

2023-09-07 Thread Ashutosh Bapat
Hi Yuya, On Fri, Aug 25, 2023 at 1:09 PM Yuya Watari wrote: > > 3. Future works > > 3.1. Redundant memory allocation of Lists > > When we need child EquivalenceMembers in a loop over ec_members, v20 > adds them to the list. However, since we cannot modify the ec_members, > v20 always copies it.

Re: psql help message contains excessive indentations

2023-09-07 Thread Kyotaro Horiguchi
At Thu, 7 Sep 2023 15:02:49 +0900, Yugo NAGATA wrote in > On Thu, 07 Sep 2023 14:29:56 +0900 (JST) > Kyotaro Horiguchi wrote: > > > \q quit psql > > > \watch [[i=]SEC] [c=N] [m=MIN] > > !> execute query every SEC seconds, up to N times > > !>

pg_rewind with cascade standby doesn't work well

2023-09-07 Thread Kuwamura Masaki
Hi there, I tested pg_rewind behavior and found a suspicious one. Consider a scenario like this, Server A: primary Server B :replica of A Server C :replica of B and somehow A down ,so B gets promoted. Server A: down Server B :new primary Server C :replica of B In this case, pg_rewind can be

Re: pg_upgrade and logical replication

2023-09-07 Thread Michael Paquier
On Mon, Sep 04, 2023 at 02:12:58PM +0530, Amit Kapila wrote: > Yeah, I agree that could be hacked quickly but note I haven't reviewed > in detail if there are other design issues in this patch. Note that we > thought first to support the upgrade of the publisher node, otherwise, > immediately

Re: persist logical slots to disk during shutdown checkpoint

2023-09-07 Thread Amit Kapila
On Thu, Sep 7, 2023 at 10:13 AM vignesh C wrote: > > On Wed, 6 Sept 2023 at 12:09, Dilip Kumar wrote: > > > > Other than that the patch LGTM. > > pgindent reported that the new comments added need to be re-adjusted, > here is an updated patch for the same. > Thanks, the patch looks good to me

Re: Improve heapgetpage() performance, overhead from serializable

2023-09-07 Thread John Naylor
On Fri, Sep 1, 2023 at 1:08 PM tender wang wrote: > > This thread [1] also Improving the heapgetpage function, and looks like this thread. > > [1] https://www.postgresql.org/message-id/a9f40066-3d25-a240-4229-ec2fbe94e7a5%40yeah.net Please don't top-post. For the archives: That CF entry has

Re: RFC: Logging plan of the running query

2023-09-07 Thread torikoshia
On 2023-09-06 11:17, James Coleman wrote: > I've never been able to reproduce it (haven't tested the new version, > but v28 at least) on my M1 Mac; where I've reproduced it is on Debian > (first buster and now bullseye). > > I'm attaching several stacktraces in the hope that they provide some >

Re: psql help message contains excessive indentations

2023-09-07 Thread Yugo NAGATA
On Thu, 07 Sep 2023 14:29:56 +0900 (JST) Kyotaro Horiguchi wrote: > This topic is extracted from [1]. > > As mentioned there, in psql, running \? displays the following lines. > > > \gdesc describe result of query, without executing it > > \gexec execute

<    1   2