On Fri, 6 Oct 2023 at 11:38, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Horiguchi-san,
>
> Thank you for making a patch! They can pass ci.
> I'm still not sure what should be, but I can respond a part.
>
> > Another issue is.. that I haven't been able to cause the false
> > positive of pg_ctl start..
On 22.09.23 02:38, Andy Fan wrote:
create table tb(a jsonb);
insert into tb select '{"a": "foo", "b": 1}';
select cast(a->'a' as numeric) from tb;
ERRCODE_INVALID_PARAMETER_VALUE cannot cast jsonb string to type numeric
the call stack is:
0 in errstart of elog.c:351
1 in errstart_
On Fri, Oct 06, 2023 at 02:30:16PM +0900, Michael Paquier wrote:
> Okay, the backtrace is not that useful. I'll see if I can get
> something better, still it seems like this has broken the way the
> syslogger closes these ports.
And here you go:
Program terminated with signal SIGSEGV, Segmentatio
Hi,
On 10/5/23 6:23 PM, Bharath Rupireddy wrote:
On Thu, Oct 5, 2023 at 9:32 PM Drouvot, Bertrand
wrote:
+ CREATE ROLE nologrole with nologin;
+ GRANT CREATE ON DATABASE mydb TO nologrole;
A few nit-picks:
1. s/with/WITH
2. s/nologin/NOLOGIN
done in v8 attached.
3. + is specified a
The "Description" and "Notes" parts of the following logical
replication PUB/SUB reference pages (almost always) link to each other
whenever a sibling command gets mentioned.
CREATE PUBLICATION
ALTER PUBLICATION
DROP PUBLICATION
CREATE SUBSCRIPTION
ALTER SUBSCRIPTION
DROP SUBSCRIPTION
~
AFAICT
On 06.10.23 04:00, Michael Paquier wrote:
That's not really something for this patch, but I got to ask. What's
the final plan for the documentation when it comes to releases? A
second tarball separated from the git-only tarball that includes all
that and the HTML docs, generated with a new "doc
On Fri, Oct 06, 2023 at 09:09:10AM +0900, Michael Paquier wrote:
> I am not completely sure what you mean here. We've never supported
> load_session_libraries for background workers, and I'm not quite sure
> that there is a case for it. FWIW, my idea around that would be to
> have two separate se
On Wed, Oct 04, 2023 at 03:49:03PM +0100, Vik Fearing wrote:
> Okay. Here is a v3 using that approach.
You have not posted any numbers to show if there's a difference in
performance, so I have run a simple test:
PREPARE test AS SELECT TIMESTAMP '1978-07-07 19:38' AT LOCAL;
DO $$ BEGIN
FOR i IN
On Thu, Oct 05, 2023 at 03:08:37PM +0300, Heikki Linnakangas wrote:
> This seems pretty uncontroversial, and I heard no objections, so I went
> ahead and committed that.
It looks like e29c4643951 is causing issues here. While doing
benchmarking on a cluster compiled with -O2, I got a crash:
LOG:
Hi Ajin. Thanks for addressing my previous review comments from v19.
I checked all the changes. Below are a few follow-up remarks.
On Thu, Oct 5, 2023 at 7:54 PM Ajin Cherian wrote:
>
> On Wed, Sep 27, 2023 at 2:37 PM Peter Smith wrote:
> >
> > Here are some more review comments for the patch v
On Thu, Oct 5, 2023 at 2:35 AM James Coleman wrote:
>
> I talked to Andres and Peter again today, and out of that conversation
> I have some observations and ideas for future improvements.
>
> 1. The most trivial case where this is useful is INSERT: we have a
> target page, and it may have dead tu
kuroda.keis...@nttcom.co.jp writes:
> On 2023-06-14 15:31, vignesh C wrote:
>> I have attempted to convert pg_get_indexdef() to use
>> systable_beginscan() based on transaction-snapshot rather than using
>> SearchSysCache().
Has anybody thought about the fact that ALTER TABLE ALTER TYPE
(specifica
Hi hackers,
With '0001-pg_get_indexdef-modification-to-access-catalog-based.patch'
patch,
I confirmed that definition information
can be collected even if the index is droped during pg_dump.
The regression test (make check-world) has passed.
I also tested the view definition for a similar prob
On 2023-10-05 10:28, Michael Paquier wrote:
On Wed, Oct 04, 2023 at 05:19:40PM +0900, Michael Paquier wrote:
I am lacking a bit of time now, but I have applied the bits for
test_shm_mq and worker_spi. Note that I have not added tests for
test_shm_mq as it may be possible that the two events (fo
On Thu, Oct 05, 2023 at 05:46:46PM +0200, Peter Eisentraut wrote:
> Ok, I think I found a better way to address this. It requires keeping a
> subset of the old distprep target in src/backend/Makefile for use by nls.mk.
> I have checked that the above sequence now works, and that the generated
> .p
Thank you, Peter, Andres and Tom for your comments and thoughts.
Hi Peter,
> For example, for NAMEDATALEN, SIZEOF_POINTER, ALIGNOF_POINTER,
> FLOAT8PASSBYVAL, these are known at build time, so we could have
> genbki.pl substitute them at build time.
I have modified the patch to use genbki to gen
On Thu, Oct 05, 2023 at 11:45:18AM -0500, Justin Pryzby wrote:
> This table is what it sounds like: a partition into which CSV logs are
> COPY'ed. It would've been created around 8am. There's no special
> params set for the table nor for autovacuum.
This may be an important bit of information.
On Thu, Oct 05, 2023 at 05:51:31PM +0530, Bharath Rupireddy wrote:
> I think changing BGWORKER_BYPASS_ALLOWCONN to 0x0001 and having bits32
> for InitPostgres inputs load_session_libraries and
> override_allow_connections can be 0001 in this patch series so that it
> can go first, no? This avoids t
Correct a typo in my last message:
Instead of:
“ I added an additional condition to make sure that the tailPage proceeds the
headPage
as well. “
It should be:
“ I added an additional condition to make sure that the tailPage precedes the
headPage
as well. ”
Regards,
Sami
> On Oct 5, 2023, a
> I think the smallest fix here would be to change CheckPointPredicate()
> so that if tailPage > headPage, pass headPage to SimpleLruTruncate()
> instead of tailPage. Or perhaps it should go into the "The SLRU is no
> longer needed" codepath in that case. If tailPage > headPage, the SLRU
> isn't ne
On Thu, Oct 5, 2023 at 1:09 PM Jeff Davis wrote:
>
> >
> > I think this would be mighty confusing to users since it's not clear
> > that
> > adding a password will potentially invalidate a current password
> > (which
> > might be actively in use), but only if there are already 2 in the
> > stack.
On Thu, Oct 5, 2023 at 12:04 PM Nathan Bossart wrote:
>
> On Wed, Oct 04, 2023 at 10:41:15PM -0700, Gurjeet Singh wrote:
> > The patches posted in this thread so far attempt to add the ability to
> > allow the user to have an arbitrary number of passwords. I believe
> > that allowing arbitrary num
I found another bit of fun we'll need to deal with: on my F38
platform, pgcrypto/3des fails as attached. Some googling finds
this relevant info:
https://github.com/pyca/cryptography/issues/6875
That is, FIPS deprecation of 3DES is happening even as we speak.
So apparently we'll have little choic
On Thu, 2023-10-05 at 14:04 -0500, Nathan Bossart wrote:
> IMHO neither of these problems seems insurmountable. Besides
> advising
> against using hints as names, we could also automatically generate
> safe
> names, or even disallow user-provided names entirely.
I'd like to see what this looks
Peter Eisentraut writes:
> Continuing this, we have fixed many issues since. Here is a patch set
> to fix all remaining issues.
On the way to testing this, I discovered that we have a usability
regression with recent OpenSSL releases. The Fedora 35 installation
I used to use for testing FIPS-m
On Thu, 2023-10-05 at 14:58 +, Jon Erdman wrote:
> > > > For the proposal (this one is a bit Apple specific): because my team
> > > > offers managed postgres to our Apple-internal customers, many of whom
> > > > are not database experts, or at least not postgres experts, we'd like to
> > > > be
On Thu, Oct 05, 2023 at 03:49:37PM -0400, Tom Lane wrote:
> Nico Williams writes:
> > Text+encoding can be just like bytea with a one- or two-byte prefix
> > indicating what codeset+encoding it's in. That'd be how to encode
> > such text values on the wire, though on disk the column's type should
Nico Williams writes:
> Text+encoding can be just like bytea with a one- or two-byte prefix
> indicating what codeset+encoding it's in. That'd be how to encode
> such text values on the wire, though on disk the column's type should
> indicate the codeset+encoding, so no need to add a prefix to th
Rajesh Mittal writes:
> Is there a way, where an authorized user (Creates Table / Inserts Data) in
> a DB, which the SuperUser cannot access the same.
> I understand SuperUser can revoke the access of the user, but he should not
> be able to see the table structure and data inserted in those table
Hello,
Is there a way, where an authorized user (Creates Table / Inserts Data) in
a DB, which the SuperUser cannot access the same.
I understand SuperUser can revoke the access of the user, but he should not
be able to see the table structure and data inserted in those tables.
Best,
Rajesh
On Thu, 2023-10-05 at 09:10 -0400, Isaac Morland wrote:
> In the case you describe, the users don’t have text at all; they have
> bytes, and a vague belief about what encoding the bytes might be in
> and therefore what characters they are intended to represent. The
> correct way to store that in th
On Thu, Oct 05, 2023 at 07:31:54AM -0400, Robert Haas wrote:
> [...] On the other hand, to do that in PostgreSQL, we'd need to
> propagate the character set/encoding information into all of the
> places that currently get the typmod and collation, and that is not a
> small number of places. It's a
On Wed, Oct 04, 2023 at 10:41:15PM -0700, Gurjeet Singh wrote:
> The patches posted in this thread so far attempt to add the ability to
> allow the user to have an arbitrary number of passwords. I believe
> that allowing arbitrary number of passwords is not only unnecessary,
> but the need to name
On Thu, Oct 05, 2023 at 07:16:31PM +0200, Matthias van de Meent wrote:
> On Thu, 5 Oct 2023 at 18:48, Justin Pryzby wrote:
> >
> > On an instance running pg16.0:
> >
> > log_time | 2023-10-05 10:03:00.014-05
> > backend_type | autovacuum worker
> > left | page verification
On Thu, Oct 05, 2023 at 05:51:31PM +0530, Bharath Rupireddy wrote:
> I think changing BGWORKER_BYPASS_ALLOWCONN to 0x0001 and having bits32
> for InitPostgres inputs load_session_libraries and
> override_allow_connections can be 0001 in this patch series so that it
> can go first, no? This avoids t
Hi,
On 2023-10-02 10:42:37 -0400, Robert Haas wrote:
> I was trying to think of a test case where XLogInsertRecord would be
> exercised as heavily as possible, so I really wanted to generate a lot
> of WAL while doing as little real work as possible. The best idea that
> I had was to run pg_create
Andres Freund writes:
> I think you can just pass c_args directly to executable() here, I think adding
> c_args to default_bin_args would be a bad idea.
Hm. IIUC that would result in an error if someone did try to
put some c_args into default_bin_args, and I didn't think it would
be appropriate
Hi,
On 2023-10-05 13:17:25 -0400, Tom Lane wrote:
> I wrote:
> > So I experimented with fixing things so that the versions of these
> > functions exported by libpq have physically different names from those
> > that you'd get from linking to libpgcommon.a or libpgcommon_srv.a.
> > Then, there's ce
On Thu, 2023-10-05 at 07:31 -0400, Robert Haas wrote:
> It's a lot of infrastructure for the project to carry
> around for a feature that's probably only going to continue to become
> less relevant.
Agreed, at least until we understand the set of users per-column
encoding is important to. I acknow
I wrote:
> So I experimented with fixing things so that the versions of these
> functions exported by libpq have physically different names from those
> that you'd get from linking to libpgcommon.a or libpgcommon_srv.a.
> Then, there's certainty about which one a given usage will link to,
> based o
On Thu, 5 Oct 2023 at 18:48, Justin Pryzby wrote:
>
> On an instance running pg16.0:
>
> log_time | 2023-10-05 10:03:00.014-05
> backend_type | autovacuum worker
> left | page verification failed, calculated checksum 5074 but
> expected 5050
> context | while scan
On an instance running pg16.0:
log_time | 2023-10-05 10:03:00.014-05
backend_type | autovacuum worker
left | page verification failed, calculated checksum 5074 but
expected 5050
context | while scanning block 119 of relation
"public.postgres_log_2023_10_05_0900"
On Thu, Oct 5, 2023 at 9:32 PM Drouvot, Bertrand
wrote:
>
> + CREATE ROLE nologrole with nologin;
> + GRANT CREATE ON DATABASE mydb TO nologrole;
A few nit-picks:
1. s/with/WITH
2. s/nologin/NOLOGIN
3. + is specified as flags it is possible to
bypass the login check to connect to databases.
Hi,
On 10/5/23 2:21 PM, Bharath Rupireddy wrote:
On Thu, Oct 5, 2023 at 12:22 PM Drouvot, Bertrand
wrote:
A comment on v6-0002:
1.
+ CREATE ROLE nologrole with nologin;
+ ALTER ROLE nologrole with superuser;
+]);
We don't need superuser privileges here, do we? Or do we need it for
the work
On Thu, Oct 5, 2023 at 11:11 PM Jon Erdman wrote:
>
> As a second more general question: could my original idea (i.e. sans
> event trigger) be implemented in an extension somehow, or is that not
> technically possible (I suspect not)?
It should be easy to do using the ProcessUtility_hook hook, de
On 19.09.23 15:11, Peter Eisentraut wrote:
Here is an updated version of this patch set. I resolved some conflicts
and addressed this comment of yours. I also dropped the one patch with
some catalog header edits that people didn't seem to particularly like.
The patches that are now 0001 thro
On 26.09.23 06:49, Michael Paquier wrote:
On Wed, Aug 23, 2023 at 12:46:45PM +0200, Peter Eisentraut wrote:
Apparently, the headerscheck and cpluspluscheck targets still didn't work
right in the Cirrus jobs. Here is an updated patch to address that. This
is also rebased over some recent change
On 10/5/23 8:53 AM, Tom Lane wrote:
> Laurenz Albe writes:
>> On Thu, 2023-10-05 at 02:22 +, Jon Erdman wrote:
>>> For the proposal (this one is a bit Apple specific): because my team
>>> offers managed postgres to our Apple-internal customers, many of whom
>>> are not database experts, or a
Hi team,
We have observed that for logically same over clause two different window
aggregate nodes are created in plan.
The below query contains two window functions. Both Over clause contain the
same partition & order clause in it. But in one over clause ordering option is
mentioned as
> On 5 Oct 2023, at 15:44, Peter Eisentraut
> wrote:
>
> On 04.10.22 17:45, Peter Eisentraut wrote:
>> While working on the column encryption patch, I wanted to check that what is
>> implemented also works in OpenSSL FIPS mode. I tried running the normal
>> test suites after switching the Ope
On Wednesday, October 4, 2023, Jon Erdman wrote:
>
> So I'd like to get a general idea how likely this would be to getting
> accepted if it did it, and did it right?
>
Run a cron job checking for them. Allow for overrides by adding a comment
to any unclogged tables you’ve identified as being ac
Laurenz Albe writes:
> On Thu, 2023-10-05 at 02:22 +, Jon Erdman wrote:
>> For the proposal (this one is a bit Apple specific): because my team
>> offers managed postgres to our Apple-internal customers, many of whom
>> are not database experts, or at least not postgres experts, we'd like to
On 04.10.22 17:45, Peter Eisentraut wrote:
While working on the column encryption patch, I wanted to check that
what is implemented also works in OpenSSL FIPS mode. I tried running
the normal test suites after switching the OpenSSL installation to FIPS
mode, but that failed all over the place.
Dear Hackers,
I figured out this email was sent at release time. The worst time to ask
for thoughts on a subject IMHO. Anyway, I hope this email will pop the
topic over the stack!
Thank you!
Le ven. 8 sept. 2023 à 16:41, Jean-Christophe Arnu a
écrit :
> Dear hackers,
>
> I recently found a weir
On Thu, Oct 5, 2023 at 1:48 AM Amit Kapila wrote:
>
> Then, we should also try to create slots before invoking pg_resetwal.
> The idea is that we can write a new binary mode function that will do
> exactly what pg_resetwal does to compute the next segment and use that
> location as a new location
On Thu, 5 Oct 2023 at 07:32, Robert Haas wrote:
> But I do think that sometimes users are reluctant to perform encoding
> conversions on the data that they have. Sometimes they're not
> completely certain what encoding their data is in, and sometimes
> they're worried that the encoding conversio
On Thu, Oct 5, 2023 at 6:25 AM Nazir Bilal Yavuz wrote:
> What do you think about the second patch, counting extend calls'
> timings in blk_write_time? In my opinion if something increments
> {shared|local}_blks_written, then it needs to be counted in
> blk_write_time too. I am not sure why it is
On Thu, 5 Oct 2023 at 14:13, Dave Cramer wrote:
>
> Greetings,
>
> Before 16 if I created an array type in schema1 it would be named
> schema1._array_type
> if I created the same type in schema 2 it would have been named
>
> schema2.__array_type
>
> Can someone point me to where the code was chan
On Thu, Oct 5, 2023 at 12:22 PM Drouvot, Bertrand
wrote:
>
> >
> > @@ -719,6 +719,7 @@ InitPostgres(const char *in_dbname, Oid dboid,
> >const char *username, Oid useroid,
> >bool load_session_libraries,
> >bool override_allow
On Thu, Oct 5, 2023 at 1:52 AM Jon Erdman wrote:
>
> So I have some good news! At long last I've found a company/manager that
> wants to actually factually pay me to do some work on PG!!
Congratulations!
> For the proposal (this one is a bit Apple specific): because my team
> offers managed post
Greetings,
Before 16 if I created an array type in schema1 it would be named
schema1._array_type
if I created the same type in schema 2 it would have been named
schema2.__array_type
Can someone point me to where the code was changed ?
Thanks,
Dave Cramer
On 29/08/2023 09:58, Heikki Linnakangas wrote:
On 29/08/2023 09:21, Heikki Linnakangas wrote:
Thinking about this some more, the ListenSockets array is a bit silly
anyway. We fill the array starting from index 0, always append to the
end, and never remove entries from it. It would seem more
stra
On Thu, Oct 5, 2023 at 4:24 PM Amit Kapila wrote:
>
> > > Today, I discussed this problem with Andres at PGConf NYC and he
> > > suggested as following. To verify, if there is any pending unexpected
> > > WAL after shutdown, we can have an API like
> > > pg_logical_replication_slot_advance() which
On Wed, Oct 4, 2023 at 9:02 PM Isaac Morland wrote:
>> > What about characters not in UTF-8?
>>
>> Honestly I'm not clear on this topic. Are the "private use" areas in
>> unicode enough to cover use cases for characters not recognized by
>> unicode? Which encodings in postgres can represent charac
On Thu, Oct 5, 2023 at 2:29 PM Dilip Kumar wrote:
>
> On Thu, Oct 5, 2023 at 1:48 AM Amit Kapila
wrote:
> >
> > On Tue, Oct 3, 2023 at 9:58 AM Bharath Rupireddy
> > wrote:
> > >
> > > On Fri, Sep 29, 2023 at 5:27 PM Hayato Kuroda (Fujitsu)
> > > wrote:
> > > >
> > > > Yeah, the approach enforce
Hi,
On Tue, 3 Oct 2023 at 19:44, Robert Haas wrote:
>
> Given that, I'm inclined to agree that this is a bug. But we might
> need to go through and make sure all of the code that deals with these
> counters is on the same page about what the values represent. Maybe
> there is code lurking somewhe
Dear Amit, Andres,
Thank you for giving the decision! Basically I will follow your idea and make
a patch accordingly.
> Today, I discussed this problem with Andres at PGConf NYC and he
> suggested as following. To verify, if there is any pending unexpected
> WAL after shutdown, we can have an API
Hi Jon,
> Had my performance review today, and Apple wants me to get a patch
> accepted this quarter, with the promise of more to come after that.
> Luckily, this first patch can be anything (doesn't have to be of use to
> Apple, more to prove that I can get a patch accepted), so I'm open to
> sug
On Thu, 2023-10-05 at 02:22 +, Jon Erdman wrote:
> For the proposal (this one is a bit Apple specific): because my team
> offers managed postgres to our Apple-internal customers, many of whom
> are not database experts, or at least not postgres experts, we'd like to
> be able to toggle the
On 4/10/2023 14:34, Alexander Korotkov wrote:
> Relid replacement machinery is the most contradictory code here. We used
> a utilitarian approach and implemented a simplistic variant.
> > 2) It would be nice to skip the insertion of IS NOT NULL checks when
> > they are not necessary. [1] po
On 2023-Aug-08, Alvaro Herrera wrote:
> One idea that Tom floated was to allow the JsonLexContext to be
> optionally stack-allocated. That reduces palloc() traffic; but some
> callers do need it to be palloc'ed. Here's a patch that does it that
> way, and adds a freeing routine that knows what t
On Thu, Oct 5, 2023 at 1:48 AM Amit Kapila wrote:
>
> On Tue, Oct 3, 2023 at 9:58 AM Bharath Rupireddy
> wrote:
> >
> > On Fri, Sep 29, 2023 at 5:27 PM Hayato Kuroda (Fujitsu)
> > wrote:
> > >
> > > Yeah, the approach enforces developers to check the decodability.
> > > But the benefit seems sma
Oops,
Looking at my old message from 2015 on this subject, it was Magnus who
pish-poshed it, and Page who liked it. Don't want to throw shaded at the
wrong person ;)
--
Jon Erdman (aka StuckMojo)
PostgreSQL Zealot
On 10/5/23 12:14 AM, Jon Erdman wrote:
>
> Well,
>
> Given my earlier mes
Well,
Given my earlier message about Apple wanting to pay me for writing
patches now, maybe I can revisit this idea.
For background: I brought up the idea of an FDW that could read custom
dump files and expose them as tables so that you could grab just a
single record (or of course more) from
Hiya Hackers!
So I have some good news! At long last I've found a company/manager that
wants to actually factually pay me to do some work on PG!!
Had my performance review today, and Apple wants me to get a patch
accepted this quarter, with the promise of more to come after that.
Luckily, th
On Thu, 5 Oct 2023 at 18:23, Michael Paquier wrote:
>
> On Wed, Oct 04, 2023 at 07:47:11PM +1300, David Rowley wrote:
> > The original patch had a new function in stringinfo.c which allowed a
> > StringInfoData to be initialised from an existing string with some
> > given length. Tom wasn't a fan
On Thu, 5 Oct 2023 at 14:11, Andy Fan wrote:
> Patch LGTM.
Thanks. Pushed.
David
On 02.10.23 09:38, Michael Paquier wrote:
Attached is a v2 with these adjustments, for now.
General comments:
- I think we can't just delete install-windows.sgml. Some of that
content needs to be moved over to installation.sgml. As a simple
example, install-windows.sgml shows which MSVC ve
Hi Chap
On 04.10.23 23:05, Chapman Flack wrote:
I hope I'm not butting in, but I too would be leery of any default
behavior that's going to say thing1 and thing2 are the same thing
but ignoring (name part of thing here). If that's the comparison
I mean to make, and it's as easy as CANONICAL WITH
On Wed, 4 Oct 2023 at 21:08, Orlov Aleksej wrote:
> I've finished testing the patch.
> I confirm that the patch solves the problem and works just as fast.
Thanks for checking that.
I've pushed the patch now.
David
On 4/10/2023 14:34, Alexander Korotkov wrote:
Hi!
On Wed, Oct 4, 2023 at 9:56 AM Andrei Lepikhov
mailto:a.lepik...@postgrespro.ru>> wrote:
> On 4/10/2023 07:12, Alexander Korotkov wrote:
> > On Tue, Sep 12, 2023 at 4:58 PM Andrey Lepikhov
> > mailto:a.lepik...@postgrespro.ru>> wrote:
> >>
81 matches
Mail list logo
