Re: pg_resetwal: Corrections around -c option

2023-10-10 Thread Peter Eisentraut
On 09.10.23 17:48, Alvaro Herrera wrote: Hmm, not sure about this. SLRU_PAGES_PER_SEGMENT is 32, and COMMIT_TS_XACTS_PER_PAGE is 819, so this formula gives decimal 26208 = 0x6660. But more generally, I'm not sure about the algorithm. Really, the safe value also depends on how large the latest

Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag

2023-10-10 Thread Drouvot, Bertrand
On 10/10/23 9:21 AM, Michael Paquier wrote: On Tue, Oct 10, 2023 at 09:18:04AM +0200, Drouvot, Bertrand wrote: Please forget about it ;-) That's called an ENOCOFFEE :D Exactly, good one! ;-) Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Se

Re: Synchronizing slots from primary to standby

2023-10-10 Thread Peter Smith
On Mon, Oct 9, 2023 at 9:34 PM shveta malik wrote: > > On Wed, Oct 4, 2023 at 8:53 AM Peter Smith wrote: > > > > Here are some review comments for v20-0002. > > > > Thanks Peter for the feedback. Comments from 31 till end are addressed > in v22. First 30 comments will be addressed in the next ver

Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag

2023-10-10 Thread Michael Paquier
On Tue, Oct 10, 2023 at 09:18:04AM +0200, Drouvot, Bertrand wrote: > Please forget about it ;-) That's called an ENOCOFFEE :D -- Michael signature.asc Description: PGP signature

Re: False "pg_serial": apparent wraparound” in logs

2023-10-10 Thread Michael Paquier
On Thu, Oct 05, 2023 at 11:28:02PM +, Imseih (AWS), Sami wrote: > I spent sometime studying this and it appears to be a good approach. > > Passing the cutoff page as headPage (SLRU not needed code path ) instead of > the tailPage to > SimpleLruTruncate is already being done when the tailXid

Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag

2023-10-10 Thread Drouvot, Bertrand
On 10/10/23 9:12 AM, Drouvot, Bertrand wrote: Hi, Any reason why INIT_PG_BYPASS_ROLE_LOGIN is not 0x0003? Please forget about it ;-) Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag

2023-10-10 Thread Drouvot, Bertrand
Hi, On 10/10/23 7:58 AM, Michael Paquier wrote: On Tue, Oct 10, 2023 at 06:57:05AM +0200, Drouvot, Bertrand wrote: Please find attached v9 (v8 rebase due to f483b2090). I was looking at v8 just before you sent this v9, and still got annoyed by the extra boolean argument added to InitPostgres(

<    1   2