Re: Emitting JSON to file using COPY TO

2024-01-31 Thread vignesh C
On Sat, 27 Jan 2024 at 11:25, Junwang Zhao wrote: > > Hi hackers, > > Kou-san(CCed) has been working on *Make COPY format extendable[1]*, so > I think making *copy to json* based on that work might be the right direction. > > I write an extension for that purpose, and here is the patch set

Re: CI and test improvements

2024-01-31 Thread vignesh C
On Thu, 18 Jan 2024 at 06:46, Michael Paquier wrote: > > On Wed, Jan 17, 2024 at 05:34:00PM +0530, vignesh C wrote: > > Are we planning to do anything more in this thread, the thread has > > been idle for more than 7 months. If nothing more is planned for this, > > I'm planning to close this

Re: Improve WALRead() to suck data directly from WAL buffers when possible

2024-01-31 Thread Alvaro Herrera
Looking at 0003, where an XXX comment is added about taking a spinlock to read LogwrtResult, I suspect the answer is probably not, because it is likely to slow down the other uses of LogwrtResult. But I wonder if a better path forward would be to base further work on my older uncommitted patch to

Re: Transaction timeout

2024-01-31 Thread Japin Li
On Tue, 30 Jan 2024 at 14:22, Andrey M. Borodin wrote: >> On 26 Jan 2024, at 19:58, Japin Li wrote: >> >> Thanks for updating the patch. Here are some comments for v24. >> >> + >> +Terminate any session that spans longer than the specified amount of >> +time in

Re: Improve WALRead() to suck data directly from WAL buffers when possible

2024-01-31 Thread Bharath Rupireddy
On Tue, Jan 30, 2024 at 11:01 PM Alvaro Herrera wrote: > > Hmm, this looks quite nice and simple. Thanks for looking at it. > My only comment is that a > sequence like this > >/* Read from WAL buffers, if available. */ >rbytes = XLogReadFromBuffers(_message.data[output_message.len], >

Re: Extending SMgrRelation lifetimes

2024-01-31 Thread Thomas Munro
On Wed, Nov 29, 2023 at 1:42 PM Heikki Linnakangas wrote: > I spent some more time digging into this, experimenting with different > approaches. Came up with pretty significant changes; see below: Hi Heikki, I think this approach is good. As I wrote in the first email, I had briefly considered

Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix

2024-01-31 Thread Alvaro Herrera
How about rewording it more extensively? It doesn't read great IMO. I would use something like # In the upgraded instance, the running status and failover option of the # subscription with the failover option should have been preserved; the other # should not. # So regress_sub1 should still have

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

2024-01-31 Thread Nazir Bilal Yavuz
Hi, On Wed, 31 Jan 2024 at 01:18, Andrew Dunstan wrote: > > Pushed to all live branches. Thanks for the patch. Thanks for the push! -- Regards, Nazir Bilal Yavuz Microsoft

Re: Synchronizing slots from primary to standby

2024-01-31 Thread Masahiko Sawada
On Tue, Jan 30, 2024 at 9:53 PM shveta malik wrote: > > On Tue, Jan 30, 2024 at 4:06 PM shveta malik wrote: > > > > PFA v73-0001 which addresses the above comments. Other patches will be > > rebased and posted after pushing this one. > > Since v73-0001 is pushed, PFA rest of the patches.

Re: Improve eviction algorithm in ReorderBuffer

2024-01-31 Thread vignesh C
On Tue, 30 Jan 2024 at 13:37, Masahiko Sawada wrote: > > On Fri, Jan 26, 2024 at 5:36 PM Masahiko Sawada wrote: > > > > On Wed, Dec 20, 2023 at 12:11 PM Amit Kapila > > wrote: > > > > > > On Wed, Dec 20, 2023 at 6:49 AM Masahiko Sawada > > > wrote: > > > > > > > > On Tue, Dec 19, 2023 at

Re: Reducing output size of nodeToString

2024-01-31 Thread Peter Eisentraut
On 30.01.24 12:26, Matthias van de Meent wrote: Most of the other defaults I'm doubtful about. First, we are colliding here between the goals of minimizing the storage size and making the debug output more readable. I've never really wanted to make the output "more readable". The current one

Re: make dist using git archive

2024-01-31 Thread Peter Eisentraut
On 26.01.24 22:18, Eli Schwartz wrote: Hello, meson developer here. Hello, and thanks for popping in! 3. Meson does not support tar.bz2 archives. Simple enough to add, but I'm a bit surprised as usually people seem to want either gzip for portability or xz for efficient compression. We

<    1   2