Re: Support "Right Semi Join" plan shapes

On Mon, Jun 24, 2024 at 5:59 PM Richard Guo wrote: > I noticed that this patch changes the plan of a query in join.sql from > a semi join to right semi join, compromising the original purpose of > this query, which was to test the fix for neqjoinsel's behavior for > semijoins (see commit 7ca25b7d)

Re: Showing applied extended statistics in explain Part 2

Hi Tomas, The attached patch does not correspond to the above comment. > But it does solve some of the issues mentioned in previous threads. > Oops, I made a mistake sending a patch on my previous email. Attached patch is the right patch. Regards, Tatsuro Yamada 0001-Add-Showing-applied-extend

Re: Support LIKE with nondeterministic collations

Here is an updated patch for this. I have added some more documentation based on the discussions, including some examples taken directly from the emails here. One thing I have been struggling with a bit is the correct use of LIKE_FALSE versus LIKE_ABORT in the MatchText() code. I have made s

Re: walsender.c comment with no context is hard to understand

On Fri, Jun 28, 2024 at 5:15 AM Peter Smith wrote: > > On Thu, Jun 27, 2024 at 3:44 PM Michael Paquier wrote: > > > > On Wed, Jun 26, 2024 at 02:30:26PM +0530, vignesh C wrote: > > > On Mon, 3 Jun 2024 at 11:21, Peter Smith wrote: > > >> Perhaps the comment should say something like it used to:

Re: remaining sql/json patches

Hi Alexander, On Wed, Jun 26, 2024 at 8:00 PM Alexander Lakhin wrote: > > Hello, > > I'm not sure I've chosen the most appropriate thread for reporting the > issue, but maybe you would like to look at code comments related to > SQL/JSON constructors: > > * Transform JSON_ARRAY() constructor. >

Re: pgsql: Add more SQL/JSON constructor functions

On Thu, Jun 27, 2024 at 7:48 PM Amit Langote wrote: > > > > I've attempted that in the attached 0001, which removes > > JsonExpr.coercion_expr and a bunch of code around it. > > > > 0002 is now the original patch minus the changes to make > > JSON_EXISTS(), JSON_QUERY(), and JSON_VALUE() behave as

Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions

Hi David, On Tue, Jun 25, 2024 at 3:47 PM David G. Johnston wrote: > > Hey! > > Lots of SQL/JSON threads going about. This one is less about technical > correctness and more about usability of the documentation. Though in writing > this I am finding some things that aren't quite clear. I'm go

Re: SQL/JSON query functions context_item doc entry and type requirement

On Thursday, June 20, 2024, David G. Johnston wrote: > >> > >> > > As for table 9.16.3 - it is unwieldy already. Lets try and make the >> core syntax shorter, not longer. We already have precedence in the >> subsequent json_table section - give each major clause item a name then >> below the ta

Re: SQL/JSON query functions context_item doc entry and type requirement

On Thu, Jun 27, 2024 at 9:01 PM Amit Langote wrote: > On Sat, Jun 22, 2024 at 6:39 PM jian he wrote: > > On Fri, Jun 21, 2024 at 8:18 PM Amit Langote > > wrote: > > > > > > >> JSON_VALUE on error, on empty semantics should be the same as > > > >> json_query. > > > >> like: > > > >> [ { ERROR |

Re: race condition in pg_class

Noah Misch writes: > Pushed. Buildfarm member prion is failing the new inplace-inval.spec, almost > surely because prion uses -DCATCACHE_FORCE_RELEASE and inplace-inval.spec is > testing an extant failure to inval a cache entry. Naturally, inexorable inval > masks the extant bug. Ideally, I'd j

Re: race condition in pg_class

On Fri, Jun 21, 2024 at 02:28:42PM -0700, Noah Misch wrote: > On Thu, Jun 13, 2024 at 05:35:49PM -0700, Noah Misch wrote: > > I think the attached covers all comments to date. I gave everything v3, but > > most patches have just a no-conflict rebase vs. v2. The exceptions are > > inplace031-inj-w

Re: speed up a logical replica setup

On Wed, Jun 26, 2024 at 11:35 AM Hayato Kuroda (Fujitsu) wrote: > > Thanks for giving comment! 0001 was modified per suggestions. > > > Yeah, it is a good idea to add a new option for two_phase but that > > should be done in the next version. For now, I suggest updating the > > docs and probably r

Re: stale comments about fastgetattr and heap_getattr

On Fri, Jun 28, 2024 at 11:06:05AM +0700, Stepan Neretin wrote: > Hi! Looks good to me. Please, register it in CF. > Best regards, Stepan Neretin. No need for that. I've looked at the patch, and you are right so I have applied it now on HEAD. -- Michael signature.asc Description: PGP signature

Parallel heap vacuum

Hi all, The parallel vacuum we have today supports only for index vacuuming. Therefore, while multiple workers can work on different indexes in parallel, the heap table is always processed by the single process. I'd like to propose $subject, which enables us to have multiple workers running on the

Re: stale comments about fastgetattr and heap_getattr

Hi! Looks good to me. Please, register it in CF. Best regards, Stepan Neretin. On Fri, Jun 28, 2024 at 10:05 AM Junwang Zhao wrote: > fastgetattr and heap_getattr are converted to inline functions > in e27f4ee0a701, while some comments still referring them as macros. > > -- > Regards > Junwang Z

Re: Injection point locking

On Wed, Jun 26, 2024 at 10:56:12AM +0900, Michael Paquier wrote: > That's true, we could delay the release of the lock to happen just > before a callback is run. I am not sure what else we can do for the postmaster case for now, so I've moved ahead with the concern regarding the existing locking r

RE: Improve EXPLAIN output for multicolumn B-Tree Index

On Thu, 27 Jun 2024 at 22:02, Peter Geoghegan wrote: > Unfortunately, my patch will make the situation more complicated > for your patch. I would like to resolve the tension between the > two patches, but I'm not sure how to do that. OK. I would like to understand more about your proposed patch.

stale comments about fastgetattr and heap_getattr

fastgetattr and heap_getattr are converted to inline functions in e27f4ee0a701, while some comments still referring them as macros. -- Regards Junwang Zhao 0001-stale-comments-about-fastgetattr-and-heap_getattr.patch Description: Binary data

Re: Doc: fix track_io_timing description to mention pg_stat_io

> > On Thu, Jun 27, 2024 at 5:06 AM wrote: > > > > > > Hi, > > > > > pg_stat_io has I/O statistics that are collected when track_io_timing is > > > enabled, but it is not mentioned in the description of track_io_timing. > > > I think it's better to add a description of pg_stat_io for easy referenc

Re: ON ERROR in json_query and the like

On Wed, Jun 26, 2024 at 9:10 PM Amit Langote wrote: > On Sat, Jun 22, 2024 at 5:43 PM Amit Langote wrote: > > On Fri, Jun 21, 2024 at 8:00 PM Markus Winand > > wrote: > > > So updating the three options: > > > > 1. Disallow anything but jsonb for context_item (the patch I posted > > > > yester

Re: Virtual generated columns

On Thu, May 23, 2024 at 1:23 AM Peter Eisentraut wrote: > > On 29.04.24 10:23, Peter Eisentraut wrote: > > Here is a patch set to implement virtual generated columns. > > > The main feature patch (0005 here) generally works but has a number of > > open corner cases that need to be thought about an

Re: walsender.c comment with no context is hard to understand

On Thu, Jun 27, 2024 at 3:44 PM Michael Paquier wrote: > > On Wed, Jun 26, 2024 at 02:30:26PM +0530, vignesh C wrote: > > On Mon, 3 Jun 2024 at 11:21, Peter Smith wrote: > >> Perhaps the comment should say something like it used to: > >> /* Fail if there is not enough WAL available. This can happ

Re: Improve EXPLAIN output for multicolumn B-Tree Index

On Thu, Jun 27, 2024 at 4:46 PM Jelte Fennema-Nio wrote: > On Thu, 27 Jun 2024 at 22:02, Peter Geoghegan wrote: > > It's also possible that we should just do something simple, like your > > patch, even though technically it won't really be accurate in cases > > where skip scan is used to good eff

Re: Proposal: Document ABI Compatibility

On Jun 27, 2024, at 17:48, Jeremy Schneider wrote: > Minor nit - misspelled “considerd" Thank you, Jeremy. V3 attached. Best, David v3-0001-Add-API-an-ABI-guidance-to-the-C-language-docs.patch Description: Binary data

Inline non-SQL SRFs using SupportRequestSimplify

Hi Hackers, Here is a proof-of-concept patch to inline set-returning functions (SRFs) besides those written in SQL. We already try to inline SQL-language functions,[1] but that means you must have a static SQL query. There is no way to get an inline-able query by dynamically building the sql in

Re: Proposal: Document ABI Compatibility

On 6/26/24 12:23 PM, David E. Wheeler wrote: > On Jun 26, 2024, at 15:20, David E. Wheeler wrote: > >> CF: https://commitfest.postgresql.org/48/5080/ >> PR: https://github.com/theory/postgres/pull/6 > > Aaaand v2 without the unnecessary formatting of unrelated documentation 🤦🏻‍♂️. Minor nit - m

Re: Improve EXPLAIN output for multicolumn B-Tree Index

On Thu, 27 Jun 2024 at 22:02, Peter Geoghegan wrote: > It's also possible that we should just do something simple, like your > patch, even though technically it won't really be accurate in cases > where skip scan is used to good effect. Maybe showing the "default > working assumption" about how th

Re: POC, WIP: OR-clause support for indexes

Tobe honest,I've alreadystartedwritingcodetodothis,butI'm facedwitha misunderstandingof howto correctlycreatea conditionfor"OR"expressionsthatare notsubjectto transformation. For example,the expressions b=1in the query below: alena@postgres=# explain select * from x where ( (a =5 or a=4) and a

Re: Improve EXPLAIN output for multicolumn B-Tree Index

On Fri, Jun 21, 2024 at 3:12 AM wrote: > Regarding the multicolumn B-Tree Index, I'm considering > if we can enhance the EXPLAIN output. There have been requests > for this from our customer. I agree that this is a real problem -- I'm not surprised to hear that your customer asked about it. In t

Re: Is missing LOGIN Event on Trigger Firing Matrix ?

On Thu, Jun 27, 2024 at 12:39 PM Andrew Dunstan wrote: > On 2024-06-27 Th 2:40 PM, Marcos Pegoraro wrote: > > create event trigger ... on login is now available but it is not shown on > DOCs or is it in another page ? > > https://www.postgresql.org/docs/devel/event-trigger-matrix.html > doesn't h

Re: POC, WIP: OR-clause support for indexes

On 26.06.2024 23:19, Robert Haas wrote: I think maybe replying to multiple emails with a single email is something you'd be better off doing less often. Ok, I won't do this in the future. After thinkingit over,I realizedthatit turnedout to be somekindof messinthe end. On Tue, Jun 25, 2024 at 7:

Re: Is missing LOGIN Event on Trigger Firing Matrix ?

On 2024-06-27 Th 2:40 PM, Marcos Pegoraro wrote: create event trigger ... on login is now available but it is not shown on DOCs or is it in another page ? https://www.postgresql.org/docs/devel/event-trigger-matrix.html doesn't have it, should be there ? It's not triggered by a statement. Bu

Re: Apparent bug in WAL summarizer process (hung state)

> Yeah, this is a bug. It seems that the WAL summarizer process, when > restarted, wants to restart from wherever it was previously > summarizing WAL, which is correct if that WAL is still around, but if > summarize_wal has been turned off in the meanwhile, it might not be > correct. Here's a patch

Is missing LOGIN Event on Trigger Firing Matrix ?

create event trigger ... on login is now available but it is not shown on DOCs or is it in another page ? https://www.postgresql.org/docs/devel/event-trigger-matrix.html doesn't have it, should be there ? regards Marcos

Re: Visibility bug with prepared transaction with subtransactions on standby

On 20/06/2024 17:10, Heikki Linnakangas wrote: On 20/06/2024 16:41, Heikki Linnakangas wrote: Attached is a patch to fix this, with a test case. The patch did not compile, thanks to a last-minute change in a field name. Here's a fixed version. All I heard is crickets, so committed and backpo

Re: Custom type's modifiers

Marthin Laubscher writes: > I confess to some uncertainty whether the PostgreSQL specific x::y notation > and the standards based CAST(x AS y) would both be addressed by creating a > cast. Those notations are precisely equivalent, modulo concerns about operator precedence (ie, if x isn't a sing

Re: Custom type's modifiers

On 2024/06/27, 18:13, "David G. Johnston" wrote: > A cast between two types is going to accept a concrete instance of the input > type, in memory, as its argument and then produces a concrete instance of the > output type, in memory, as output.  If the input d

Re: JIT causes core dump during error recovery

Ranier Vilela writes: > Em qui., 27 de jun. de 2024 às 13:18, Tom Lane escreveu: >> In any case, I found that adding some copying logic to CopyErrorData() >> is enough to solve this problem, since the SPI infrastructure applies >> that before executing xact cleanup. > In this case, I think that

Re: Backporting BackgroundPsql

On 26/06/2024 14:54, Robert Haas wrote: On Wed, Jun 26, 2024 at 3:34 AM Heikki Linnakangas wrote: I haven't looked closely at the new PgFFI stuff but +1 on that in general, and it makes sense to backport that once it lands on master. In the meanwhile, I think we should backport BackgroundPsql a

Re: JIT causes core dump during error recovery

Em qui., 27 de jun. de 2024 às 13:18, Tom Lane escreveu: > I wrote: > > So delaying removal of the jit-created code segment until transaction > > cleanup wouldn't be enough to prevent this crash, if I'm reading > > things right. The extra-pstrdup solution may be the only viable one. > > > I coul

Re: Custom type's modifiers

Marthin Laubscher writes: > I don't see another function getting passed the value so I'd assume that > (unless I return a MyType value from one of my own functions which would > follow its internal logic to determine which type modifiers to use) the only > way a MyType can get an initial value

Re: JIT causes core dump during error recovery

I wrote: > So delaying removal of the jit-created code segment until transaction > cleanup wouldn't be enough to prevent this crash, if I'm reading > things right. The extra-pstrdup solution may be the only viable one. > I could use confirmation from someone who knows the JIT code about > when ji

Re: Custom type's modifiers

On Thu, Jun 27, 2024 at 8:49 AM Marthin Laubscher wrote: > > I suppose when a cast is involved it goes via the external format as well, > right? > A cast between two types is going to accept a concrete instance of the input type, in memory, as its argument and then produces a concrete instance o

Re: Custom type's modifiers

On 2024/06/27, 17:06, "Tom Lane" mailto:t...@sss.pgh.pa.us>> wrote: > You can't. Whatever info is needed by operations on the type had better be > embedded in the value. OK, thanks, that's clear and easy enough. I'll ensure the the third parameter to the input function is embedded in my opaque v

Re: ClientRead on ROLLABACK

Oh, I see. So the ROLLBACK command was executed! So I suppose the client was waiting just for the ACK and the connection has been left open. > I think this is a super common confusion among users. Maybe we should > consider making it clearer that no query is currently being executed. > Something

Re: ClientRead on ROLLABACK

On Thu, 27 Jun 2024 at 17:21, Tom Lane wrote: > (We used to show "" in the query column in this state, but that > was deemed less helpful than the current behavior.) I think this is a super common confusion among users. Maybe we should consider making it clearer that no query is currently being e

Re: ClientRead on ROLLABACK

Simone Giusso writes: > I have a question regarding postgresql waiting for the client. I queried > the pg_stat_activity because I noticed a connection that had not been > released for days!!! I saw that the wait_event was ClientRead and the query > was ROLLBACK. What the server is waiting for from

Re: Custom type's modifiers

Marthin Laubscher writes: > But now I need to (re)define MyType to support type modifiers (e.g. > MyType(1,14,18)) and I got that done using CREATE TYPE’s TYPMOD_IN and > TYPMOD_OUT parameters resulting in the correct packed value getting stored in > pg_attribute when I define a column of that

Re: Patch bug: Fix jsonpath .* on Arrays

On Jun 27, 2024, at 04:17, Michael Paquier wrote: > The tests of jsonb_jsonpath.sql include a lot of patterns for @? and > jsonb_path_query with the lax and strict modes, so shouldn't these > additions be grouped closer to the existing tests rather than added at > the end of the file? I think y

Custom type's modifiers

Hi, I’m defining a custom type “MyType” with additional functions and an custom aggregate in a C-coded extension. From a PostgreSQL perspective it is a base type that piggybacks on the bytea type, i.e. LIKE = BYTEA. But now I need to (re)define MyType to support type modifiers (e.g. MyType(1,

Re: SQL/JSON query functions context_item doc entry and type requirement

Hi, On Sat, Jun 22, 2024 at 6:39 PM jian he wrote: > On Fri, Jun 21, 2024 at 8:18 PM Amit Langote wrote: > > > > >> JSON_VALUE on error, on empty semantics should be the same as json_query. > > >> like: > > >> [ { ERROR | NULL | EMPTY { [ ARRAY ] | OBJECT } | DEFAULT expression } > > >> ON EMPTY

Re: Doc: fix track_io_timing description to mention pg_stat_io

Hi, On Thu, 27 Jun 2024 at 14:30, Melanie Plageman wrote: > > On Thu, Jun 27, 2024 at 5:06 AM wrote: > > > > Hi, > > > > pg_stat_io has I/O statistics that are collected when track_io_timing is > > enabled, but it is not mentioned in the description of track_io_timing. > > I think it's better to

Re: Should we document how column DEFAULT expressions work?

On 27.06.24 02:34, David Rowley wrote: For the special timestamp stuff, that place is probably the special timestamp table in [1]. It looks like the large caution you added in 540849814 might not be enough or perhaps wasn't done soon enough to catch the people who read that part of the manual be

Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)

Em qui., 27 de jun. de 2024 às 08:48, Ranier Vilela escreveu: > Em qui., 27 de jun. de 2024 às 01:01, Yugo NAGATA > escreveu: > >> On Mon, 24 Jun 2024 08:25:36 -0300 >> Ranier Vilela wrote: >> >> > Em dom., 23 de jun. de 2024 às 23:56, Richard Guo < >> guofengli...@gmail.com> >> > escreveu: >>

Re: pgsql: Add more SQL/JSON constructor functions

On Thu, Jun 27, 2024 at 6:57 PM Amit Langote wrote: > On Wed, Jun 26, 2024 at 11:46 PM jian he wrote: > > On Wed, Jun 26, 2024 at 8:39 PM Amit Langote > > wrote: > > > > > > > > > > > The RETURNING variant giving an error is what the standard asks us to > > > > do apparently. I read Tom's last

Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)

Em qui., 27 de jun. de 2024 às 01:01, Yugo NAGATA escreveu: > On Mon, 24 Jun 2024 08:25:36 -0300 > Ranier Vilela wrote: > > > Em dom., 23 de jun. de 2024 às 23:56, Richard Guo < > guofengli...@gmail.com> > > escreveu: > > > > > On Mon, Jun 24, 2024 at 7:51 AM Ranier Vilela > wrote: > > > > In s

Re: Doc: fix track_io_timing description to mention pg_stat_io

On Thu, Jun 27, 2024 at 5:06 AM wrote: > > Hi, > > pg_stat_io has I/O statistics that are collected when track_io_timing is > enabled, but it is not mentioned in the description of track_io_timing. > I think it's better to add a description of pg_stat_io for easy reference. > What do you think? S

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

Hi, > > I prepared the patch for clog.c. The rest of the warnings don't strike > > me as something we should immediately act on unless we have a bug > > report. Or perhaps there is a particular warning that worries you? > > Is "int" acceptable or unacceptable in the following grep match? > > src/b

Re: Support a wildcard in backtrace_functions

On Wed, 15 May 2024 at 20:31, Robert Haas wrote: > That's fine, except that I think that what the previous discussion > revealed is that we don't have consensus on how backtrace behavior > ought to be controlled: backtrace_on_internal_error was one proposal, > and this was a competing proposal, an

Re: doc: modify the comment in function libpqrcv_check_conninfo()

Thanks for your suggestion. I used ChatGPT to choose the wording, but it's still difficult for me. The new patch includes your suggestion. On 2024-06-27 17:18, Jelte Fennema-Nio wrote: On Thu, 27 Jun 2024 at 09:09, ikedarintarof wrote: Thank you for your comment! I've added the must_use_pa

Re: pgsql: Add more SQL/JSON constructor functions

Hi, On Wed, Jun 26, 2024 at 11:46 PM jian he wrote: > On Wed, Jun 26, 2024 at 8:39 PM Amit Langote wrote: > > > > > > > > The RETURNING variant giving an error is what the standard asks us to > > > do apparently. I read Tom's last message on this thread as agreeing > > > to that, even though he

Re: Doc: fix track_io_timing description to mention pg_stat_io

Hi, pg_stat_io has I/O statistics that are collected when track_io_timing is enabled, but it is not mentioned in the description of track_io_timing. I think it's better to add a description of pg_stat_io for easy reference. What do you think? Its always good to add new things. Thanks for your posi

[PATCH] Fix docs to use canonical links

Hello hackers, During work in the separate thread [1], I discovered more cases where the link in docs wasn't the canonical link [2]. [1]  https://postgr.es/m/cakfquwyex9pj9g0zhjewsmsbnquygh+fycw-66ezjfvg4ko...@mail.gmail.com [2] https://en.wikipedia.org/wiki/Canonical_link_element The. below scr

Re: Pgoutput not capturing the generated columns

Hi, here are some patch v11-0001 comments. (BTW, I had difficulty reviewing this because something seemed strange with the changes this patch made to the test_decoding tests). == General 1. Patch name Patch name does not need to quote 'logical replication' ~ 2. test_decoding tests Multip

Re: Doc: fix track_io_timing description to mention pg_stat_io

On Thu, Jun 27, 2024 at 2:06 PM wrote: > Hi, > > pg_stat_io has I/O statistics that are collected when track_io_timing is > enabled, but it is not mentioned in the description of track_io_timing. > I think it's better to add a description of pg_stat_io for easy reference. > What do you think? > I

Doc: fix track_io_timing description to mention pg_stat_io

Hi, pg_stat_io has I/O statistics that are collected when track_io_timing is enabled, but it is not mentioned in the description of track_io_timing. I think it's better to add a description of pg_stat_io for easy reference. What do you think? Regards, -- Hajime Matsunaga NTT DATA Group Corporatio

Re: Vacuum statistics

Hello! On Thu, 27/06/2024 at 10:39 +0900, Masahiko Sawada: > On Fri, May 31, 2024 at 4:19 AM Andrei Zubkov > wrote: > > As the vacuum process is a backend it has a workload > > instrumentation. > > We have all the basic counters available such as a number of blocks > > read, hit and written, time

Re: [PATCH] Add ACL (Access Control List) acronym

On Wed, Jun 26, 2024, at 18:54, David G. Johnston wrote: > On Wed, Jun 26, 2024 at 8:47 AM Nathan Bossart > wrote: >> On Wed, Jun 26, 2024 at 07:58:55AM -0700, David G. Johnston wrote: >> > On Wed, Jun 26, 2024 at 7:52 AM Joel Jacobson wrote: >> >> Want me to fix that or will the committer handl

Re: Adminpack removal

On Thu, 27 Jun 2024, 07:34 Philippe BEAUDOIN, wrote: > > Hi, > > I have just tested PG17 beta1 with the E-Maj solution I maintain. The > only issue I found is the removal of the adminpack contrib. > > In the emaj extension, which is the heart of the solution, and which is > written in plpgsql, the

Re: doc: modify the comment in function libpqrcv_check_conninfo()

On Thu, 27 Jun 2024 at 09:09, ikedarintarof wrote: > > Thank you for your comment! > > I've added the must_use_password argument. A new patch is attached. s/whther/whether nit: "it will do nothing" sounds a bit strange to me (but I'm not native english). Something like this reads more natural to

Re: Patch bug: Fix jsonpath .* on Arrays

On Thu, Jun 27, 2024 at 11:53:14AM +0700, Stepan Neretin wrote: > HI! Now it looks good for me. The tests of jsonb_jsonpath.sql include a lot of patterns for @? and jsonb_path_query with the lax and strict modes, so shouldn't these additions be grouped closer to the existing tests rather than adde

Re: libpq: Fix lots of discrepancies in PQtrace

On Thu, 27 Jun 2024 at 07:39, Michael Paquier wrote: > Looking at the whole, the rest of the patch set qualifies as a new > feature, even if they're aimed at closing existing gaps. Alright, seems reasonable. To be clear, I don't care at all about this being backported personally. > Particularly,

ClientRead on ROLLABACK

I have a question regarding postgresql waiting for the client. I queried the pg_stat_activity because I noticed a connection that had not been released for days!!! I saw that the wait_event was ClientRead and the query was ROLLBACK. What the server is waiting for from the client? It is a simple ROL

Re: doc: modify the comment in function libpqrcv_check_conninfo()

Thank you for your comment! I've added the must_use_password argument. A new patch is attached. On 2024-06-26 23:36, Jelte Fennema-Nio wrote: On Wed, 26 Jun 2024 at 14:53, ikedarintarof wrote: The function 'libpqrcv_check_conninfo()' returns 'void', but the comment above says that the funct