On 03.08.24 16:07, Heikki Linnakangas wrote:
On 03/08/2024 14:04, Peter Eisentraut wrote:
I noticed (during [0]) to some uses of the function atol() seem
inappropriate. Either they assume that sizeof(long)==8 and so might
truncate data if not, or they are gratuitous because the surrounding
co
On Sat, Aug 10, 2024 at 3:48 PM Thomas Munro wrote:
> * we could use LC_C_LOCALE to get a "C" locale slightly more
> efficiently on those
Oops, lost some words, I meant "on those systems that have them (macOS
and NetBSD AFAIK)"
On Sat, Aug 10, 2024 at 1:29 PM Thomas Munro wrote:
> Here is a new attempt at this can of portability worms.
Slightly better version:
* it's OK to keep relying on the global locale in the backend; for
now, we know that LC_NUMERIC is set in main(), and in the
multi-threaded future calling setloc
I've posted a new attempt at ripping those ECPG setlocales() out on
the other thread that had the earlier version and discussion:
https://www.postgresql.org/message-id/CA%2BhUKG%2BYv%2Bps%3DnS2T8SS1UDU%3DiySHSr4sGHYiYGkPTpZx6Ooww%40mail.gmail.com
On Tue, Nov 21, 2023 at 5:40 AM Tom Lane wrote:
> Thomas Munro writes:
> > If we are sure that we'll *never* want locale-aware printf-family
> > functions (ie we *always* want "C" locale), then in the thought
> > experiment above where I suggested we supply replacement _l()
> > functions, we coul
v8-0001-vaccum_delay-with-absolute-time-nanosleep.patch
Description: Binary data
>
> Yeah, I had the same thought in [1], so +1.
>
> [1]:
> https://www.postgresql.org/message-id/ZpDhS4nFX66ItAze%40ip-10-97-1-34.eu-west-3.compute.internal
>
The intention ( see start of the thread ) was to ma
Regarding 0004:
I don't want to add 4 bytes to struct pg_conn for tracing support. I'm
tempted to make the new struct member a plain 'char' to reduce overhead
for a feature that almost nobody is going to use. According to pahole
we have a 3 bytes hole in that position of the struct, so if we mak
Hi Hackers,
Often in a debugger I've wanted to way to print Datums, in particular non-trivial ones like range
types. This came up a lot when I was working on multiranges, and I've wished for it lately while
working on UPDATE/DELETE FOR PORTION OF. But all the obvious approaches are inlined func
I wrote:
> Nathan Bossart writes:
>> Another option might be to introduce a new GUC flag or source for anything
>> we want to bypass the check (perhaps with the stipulation that it must also
>> be marked PGC_INTERNAL).
> A new GUC flag seems like a promising approach, and better than
> giving a b
Pushed 0002 and 0003. On the latter: I decided against using int32 to
print the request identifiers; by splitting into two int16's, we see
that the numbers match the values in the PG_PROTOCOL() declarations:
2024-08-09 17:37:38.364622 F 8 SSLRequest 1234 5679
and
2024-08-09
On Wed, Aug 7, 2024 at 7:07 PM Thomas Munro wrote:
> On Wed, Aug 7, 2024 at 10:23 AM Tom Lane wrote:
> > Jeff Davis writes:
> > > But there are a couple problems:
> >
> > > 1. I don't think it's supported on Windows.
> >
> > Can't help with that, but surely Windows has some thread-safe way.
>
>
On 08/08/2024 13:47, Thomas Munro wrote:
On Windows, if a child process exits with ERROR_WAIT_NO_CHILDREN, it's
now logged with that exit code, instead of 0. Also, if a bgworker
exits with ERROR_WAIT_NO_CHILDREN, it's now treated as crashed and is
restarted. Previously it was
On Fri, Aug 9, 2024 at 3:30 PM Amit Kapila wrote:
>
> On Thu, Aug 8, 2024 at 9:43 PM Masahiko Sawada wrote:
> >
> > On Wed, Aug 7, 2024 at 3:17 PM Amit Kapila wrote:
> > >
> > > On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada
> > > wrote:
> >
> > >
> > > >
> > > > > BTW, commit 5bec1d6bc5e also
Hi,
On Fri, 2024-08-09 at 15:16 -0500, Tristan Partin wrote:
> Hey Jeff,
>
> See this thread[0] for some work that I had previously done. Feel
> free
> to take it over, or we could collaborate.
>
> [0]:
> https://www.postgresql.org/message-id/cwmw5ozbwj10.1yflqwsue5...@neon.tech
Sounds good, s
Nathan Bossart writes:
> On Fri, Aug 09, 2024 at 04:04:15PM -0400, Tom Lane wrote:
>> Yeah, I had been thinking along the same lines. Here's a draft
>> patch. (Still needs some attention to nearby comments, and I can't
>> avoid the impression that the miscinit.c code in this area could
>> use re
On Fri, Aug 09, 2024 at 04:04:15PM -0400, Tom Lane wrote:
> Nathan Bossart writes:
>> From a couple of quick tests, it looks like setting
>> "current_role_is_superuser" directly works.
>
> Yeah, I had been thinking along the same lines. Here's a draft
> patch. (Still needs some attention to nea
On Tue Aug 6, 2024 at 5:00 PM CDT, Jeff Davis wrote:
After some previous work here:
https://postgr.es/m/89475ee5487d795124f4e25118ea8f1853edb8cb.ca...@j-davis.com
we are less dependent on setlocale(), but it's still not completely
gone.
setlocale() counts as thread-unsafe, so it would be nice
>
> I'll admit I hadn't really considered pipelining, but I'm tempted to say
> that it's probably not worth the complexity. Not only do most of the tasks
> have only one step, but even tasks like the data types check are unlikely
> to require more than a few queries for upgrades from supported ver
Nathan Bossart writes:
> On Fri, Aug 09, 2024 at 02:43:59PM -0400, Tom Lane wrote:
>> The simplest fix would be to hack this test to allow the action anyway
>> when context == PGC_INTERNAL, excusing that as "assume the caller
>> knows what it's doing". That feels pretty grotty though. Perhaps
>>
Hi,
On Fri, Aug 09, 2024 at 02:03:55PM -0500, Nathan Bossart wrote:
> On Thu, Aug 08, 2024 at 03:01:20PM -0500, Nathan Bossart wrote:
> > Thanks. This one looks pretty good to me, and so I plan to commit it in
> > the near future unless anyone voices concerns about the approach.
>
> As I am prep
On Fri, Aug 09, 2024 at 02:43:59PM -0400, Tom Lane wrote:
> The simplest fix would be to hack this test to allow the action anyway
> when context == PGC_INTERNAL, excusing that as "assume the caller
> knows what it's doing". That feels pretty grotty though. Perhaps
> a cleaner way would be to mov
On Thu, Aug 08, 2024 at 03:01:20PM -0500, Nathan Bossart wrote:
> Thanks. This one looks pretty good to me, and so I plan to commit it in
> the near future unless anyone voices concerns about the approach.
As I am preparing this for commit, I'm wondering whether it makes sense to
name the new fun
I came across this misbehavior:
regression=# create or replace function foo() returns text as
$$select current_setting('role')$$ language sql
parallel safe set role = postgres;
CREATE FUNCTION
regression=# select foo();
foo
--
postgres
(1 row)
regression=# set debug_parallel_query
Hi,
On Fri, Aug 9, 2024 at 4:29 PM Dmitry Dolgov <9erthali...@gmail.com> wrote:
> Seems like the retry loop from 019_replslot_limit might help.
>
Thanks for the tip. Attached v2 adds the retry loop in the test which would
hopefully fix the cfbot.
Kind Regards,
Stefan
From 203747394503b479338980
On Fri, 2024-08-09 at 13:41 +0200, Andreas Karlsson wrote:
> I am leaning towards that we should write our own pure ascii
> functions
> for this.
That makes sense for a lot of call sites, but it could cause breakage
if we aren't careful.
> Since we do not support any non-ascii compatible encodi
On Thu, Aug 08, 2024 at 03:13:50PM -0400, Robert Haas wrote:
> LGTM.
Committed, thanks.
--
nathan
On Fri, Aug 9, 2024 at 1:03 PM Tomas Vondra wrote:
>
> On 8/9/24 17:48, Melanie Plageman wrote:
> > On Fri, Aug 9, 2024 at 9:15 AM Melanie Plageman
> > wrote:
> >>
> >> On Fri, Aug 9, 2024 at 9:09 AM Tomas Vondra wrote:
> >>>
> >>> I suggest we do the simplest and most obvious algorithm possible
On 8/9/24 15:09, Melanie Plageman wrote:
>
> ...
>
> Okay, so as I think about evaluating a few new algorithms, I realize
> that we do need some sort of criteria. I started listing out what I
> feel is "reasonable" accuracy and plotting it to see if the
> relationship is linear/exponential/etc. I
On 8/9/24 17:48, Melanie Plageman wrote:
> On Fri, Aug 9, 2024 at 9:15 AM Melanie Plageman
> wrote:
>>
>> On Fri, Aug 9, 2024 at 9:09 AM Tomas Vondra wrote:
>>>
>>> I suggest we do the simplest and most obvious algorithm possible, at
>>> least for now. Focusing on this part seems like a distracti
On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote:
Hi,
commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce
Author: Heikki Linnakangas
Date: 2024-07-27 13:53:11 +0300
Fallback to clang in PATH with meson
Some distributions put clang into a different path than the llvm
binary p
Hey all,
A lot of calendaring software includes the ability to subscribe to
a calendar. For instance, in my personal life, I subscribe to a US
Holidays calendar[0]. I wanted to see if anyone else thought it might be
a good idea to host an ICS file on postgresql.org that people could
subscribe
On Thu, 8 Aug 2024 at 23:29, Tomas Vondra wrote:
> On 8/8/24 14:18, Abdoulaye Ba wrote:
> > Hello PostgreSQL Hackers,
> >
> > I am submitting a patch to add hooks for the functions
> > pg_total_relation_size and pg_indexes_size. These hooks allow for custom
> > behaviour to be injected into these
Hello everyone,
The ALT Linux Team has recently initiated a focused testing effort on
PostgreSQL, with an emphasis on its security aspects.
As part of this effort, we conducted static analysis using Svace, which raised
some questions regarding the use of the Assert() function.
We were unable t
Hi,
commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce
Author: Heikki Linnakangas
Date: 2024-07-27 13:53:11 +0300
Fallback to clang in PATH with meson
Some distributions put clang into a different path than the llvm
binary path.
For example, this is the case on NixOS / nixpkgs,
On 8/8/24 2:18 PM, Abdoulaye Ba wrote:
I am submitting a patch to add hooks for the functions
pg_total_relation_size and pg_indexes_size. These hooks allow for custom
behaviour to be injected into these functions, which can be useful for
extensions and other custom PostgreSQL modifications.
W
On Fri, Aug 9, 2024 at 9:15 AM Melanie Plageman
wrote:
>
> On Fri, Aug 9, 2024 at 9:09 AM Tomas Vondra wrote:
> >
> > I suggest we do the simplest and most obvious algorithm possible, at
> > least for now. Focusing on this part seems like a distraction from the
> > freezing thing you actually wan
On Thu, Aug 08, 2024 at 06:18:38PM -0400, Corey Huinker wrote:
> I think the underlying mechanism is basically solid, but I have one
> question: isn't this the ideal case for using libpq pipelining? That would
> allow subsequent tasks to launch while the main loop slowly gets around to
> clearing o
> On Fri, Aug 02, 2024 at 08:47:02AM GMT, Stefan Fercot wrote:
>
> Not sure why CFbot CI fails on macOS/Windows while it works with the Github
> CI on my fork (
> https://cirrus-ci.com/github/pgstef/postgres/partial-walseg-recovery).
I guess it's because the test has to wait a bit after the node h
On Fri, 9 Aug 2024 at 15:16, Peter Eisentraut wrote:
> -*.sgml whitespace=space-before-tab,trailing-space,tab-in-indent
> -*.x[ms]l whitespace=space-before-tab,trailing-space,tab-in-indent
> +*.py
> whitespace=space-before-tab,trailing-space,tab-in-indent,tabwidth=4
> +*.s
On Fri, 9 Aug 2024 at 12:40, Peter Smith wrote:
>
> Hi Vignesh, here are my review comments for the sequences docs patch
> v20240808-0004.
>
> ==
> doc/src/sgml/logical-replication.sgml
>
> The new section content looked good.
>
> Just some nitpicks including:
> - renamed the section "Replicat
On Fri, 9 Aug 2024 at 05:51, Peter Smith wrote:
>
> Hi Vignesh, I reviewed the latest v20240808-0003 patch.
>
> Attached are my minor change suggestions.
Thanks, these changes are merged in the v20240809 version posted at [1].
[1] -
https://www.postgresql.org/message-id/CALDaNm0LJCtGoBCO6DFY-RDj
On Fri, 9 Aug 2024 at 12:13, shveta malik wrote:
>
> On Wed, Aug 7, 2024 at 2:00 PM vignesh C wrote:
> >
> > On Wed, 7 Aug 2024 at 08:09, Amit Kapila wrote:
> > >
> > > On Tue, Aug 6, 2024 at 5:13 PM vignesh C wrote:
> > > >
> > > > On Mon, 5 Aug 2024 at 18:05, shveta malik
> > > > wrote:
> >
On 07.08.24 22:42, Jelte Fennema-Nio wrote:
I also added a .gitattributes rule for .py files, and changed the
default tab_width to unset. Because I realized the resulting
.editorconfig was using tab_width 8 for python files when editing
src/tools/generate_editorconfig.py
This looks kind of weir
On Fri, Aug 9, 2024 at 9:09 AM Tomas Vondra wrote:
>
>
>
> On 8/9/24 03:02, Melanie Plageman wrote:
> > On Thu, Aug 8, 2024 at 2:34 PM Tomas Vondra wrote:
> >> each seconds. And we want to allow merging stuff nicely. The smallest
> >> merges we could do is 1s -> 2s -> 4s -> 8s -> ... but let's sa
On Thu, Aug 8, 2024 at 9:02 PM Melanie Plageman
wrote:
>
> On Thu, Aug 8, 2024 at 2:34 PM Tomas Vondra wrote:
> >
> > Maybe it'd be good to approach this from the opposite direction, say
> > what "accuracy guarantees" we want to provide, and then design the
> > structure / algorithm to ensure tha
On 8/9/24 03:02, Melanie Plageman wrote:
> On Thu, Aug 8, 2024 at 2:34 PM Tomas Vondra wrote:
>>
>> On 8/7/24 21:39, Melanie Plageman wrote:
>>> On Wed, Aug 7, 2024 at 1:06 PM Robert Haas wrote:
As I mentioned to you off-list, I feel like this needs some sort of
recency bias. Ce
On 8/9/24 03:29, Melanie Plageman wrote:
> On Thu, Aug 8, 2024 at 3:00 PM Robert Haas wrote:
>>
>> On Thu, Aug 8, 2024 at 2:34 PM Tomas Vondra wrote:
>>> A-D is already enough to cover 30h, with A-E it'd be ~300h. Do we need
>>> (or want) to keep a longer history?
>>
>> I think there is a differe
Em qui., 8 de ago. de 2024 às 21:57, jian he
escreveu:
>
> please check attached.
>
I still think this way would be better
+ Sawada, John Naylor). [
+ ee1b30f12,
+ 30e144287,
+ 667e65aac,
+ 6dbb49026]
instead of this
+ Sawada, John Naylor).
+[ee1b30f12]
Hi,
On Thu, Aug 08, 2024 at 03:53:29PM +0800, cca5507 wrote:
> Hi,
>
>
> Thanks for pointing it out!
>
>
> Here are the new version patches with a test case.
Thanks!
I think the approach that the patch implements makes sense and that we should
track the transactions that have been commmitted
Hello, everyone.
There are some comments on this patch related to issue [0].
In short: any DirtySnapshot index scan may fail to find an existing tuple
in the case of a concurrent update.
- FindConflictTuple may return false negative result in the case of
concurrent update because ExecCheckIndexCo
On 8/8/24 12:45 AM, Jeff Davis wrote:
My point was just that there are a lot of those call sites (especially
for isspace()) in various parsers. It feels like a lot of code churn to
change all of them, when a lot of them seem to be intended for ascii
anyway.
And where do we get the locale_t struc
On Thu, 8 Aug 2024 at 16:24, Shlok Kyal wrote:
>
> On Wed, 31 Jul 2024 at 11:17, Shlok Kyal wrote:
> >
> > On Wed, 31 Jul 2024 at 09:36, Amit Kapila wrote:
> > >
> > > On Wed, Jul 31, 2024 at 3:27 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Wed, Jul 24, 2024 at 9:53 PM Amit Kapila
> >
On Fri, Aug 9, 2024 at 5:20 PM Kirill Reshke wrote:
>
> On Thu, 1 Aug 2024 at 17:32, Junwang Zhao wrote:
> >
> > Hi Steven,
> >
> > On Wed, Jul 31, 2024 at 11:16 AM Steven Niu wrote:
> > >
> > > Hello, hackers,
> > >
> > > I think there may be some duplicated codes.
> > > Function smgrDoPendingD
Hi,
adding Jeff to CC as he changed the way ICU configure detection was done
in fcb21b3.
On Fri, Aug 09, 2024 at 11:59:12AM +0300, Heikki Linnakangas wrote:
> On 09/08/2024 11:16, Michael Banck wrote:
> > Hi,
> >
> > Holger Jacobs complained in pgsql-admin that in v17, if you have the ICU
> > de
Hi Jacob,
On Tue, Jul 23, 2024 at 7:54 PM Jacob Champion
wrote:
>
> On Tue, Jul 23, 2024 at 3:32 AM Nazir Bilal Yavuz wrote:
> > Upthread Jacob said he could work on a patch about introducing the
> > PG_TEST_EXTRA configure option to make builds. Would you still be
> > interested in working on t
On Thu, 1 Aug 2024 at 17:32, Junwang Zhao wrote:
>
> Hi Steven,
>
> On Wed, Jul 31, 2024 at 11:16 AM Steven Niu wrote:
> >
> > Hello, hackers,
> >
> > I think there may be some duplicated codes.
> > Function smgrDoPendingDeletes() calls both smgrdounlinkall() and
> > smgrclose().
> > But both fu
Dear Amit, Shveta, Hou,
Thanks for giving many comments! I've updated the patch.
> @@ -4409,6 +4409,14 @@ start_apply(XLogRecPtr origin_startpos)
> }
> PG_CATCH();
> {
> + /*
> + * Reset the origin data to prevent the advancement of origin progress
> + * if the transaction failed to apply.
On 09/08/2024 11:16, Michael Banck wrote:
Hi,
Holger Jacobs complained in pgsql-admin that in v17, if you have the ICU
development libraries installed but not pkg-config, you get a somewhat
unhelpful error message about ICU not being present:
|checking for pkg-config... no
|checking whether to
On Wed, Aug 7, 2024 at 9:32 PM Fujii Masao wrote:
> However, when using PostgreSQL 9.4 or earlier as a remote server,
> INSERT ON CONFLICT on a foreign table fails because this feature
> is only supported in v9.5 and later. Should we add a note to
> the documentation to clarify this limitation?
+
On Wed, May 22, 2024 at 10:13 AM Jeff Davis wrote:
> On Mon, 2024-05-06 at 23:10 +0100, SAIKIRAN AVULA wrote:
> > Additionally, the commit afb9249d06f47d7a6d4a89fea0c3625fe43c5a5d,
> > which introduced late locking for foreign tables, mentions that the
> > benefits of late locking against a remot
Meh, forgot the attachment. Also, this should be backpatched to v17 if
accepted.
Michael
>From b696949180437a3c7307ac0509cba54828b44259 Mon Sep 17 00:00:00 2001
From: Michael Banck
Date: Fri, 9 Aug 2024 10:13:27 +0200
Subject: [PATCH] Improve configure error for ICU libraries if pkg-config is
a
Hi,
Holger Jacobs complained in pgsql-admin that in v17, if you have the ICU
development libraries installed but not pkg-config, you get a somewhat
unhelpful error message about ICU not being present:
|checking for pkg-config... no
|checking whether to build with ICU support... yes
|checking for
> On 9 Aug 2024, at 09:21, Peter Eisentraut wrote:
> In dbcommands.c function createdb(), there are several sets of very similar
> local variable names, such as "downer" and "dbowner", which is very confusing
> and error-prone. The first set are the DefElem nodes from the parser, the
> second
In dbcommands.c function createdb(), there are several sets of very
similar local variable names, such as "downer" and "dbowner", which is
very confusing and error-prone. The first set are the DefElem nodes
from the parser, the second set are the local variables with the values
extracted from
This breaks from the CVE-2014-0062 (commit 5f17304) principle of not repeating
name lookups. The attached demo uses this defect to make one partition have
two parents.
Thank you very much for information (especially for the demo)!
I'm not sure that we can get the identifier of the newly create
Hi Vignesh, here are my review comments for the sequences docs patch
v20240808-0004.
==
doc/src/sgml/logical-replication.sgml
The new section content looked good.
Just some nitpicks including:
- renamed the section "Replicating Sequences"
- added missing mention about how to publish sequence
On Wednesday, August 7, 2024 1:24 PM Amit Kapila
wrote:
>
> On Tue, Aug 6, 2024 at 1:45 PM Zhijie Hou (Fujitsu)
> > Thanks for the idea! I thought about few styles based on the suggested
> format,
> > what do you think about the following ?
> >
> > ---
> > Version 1
> > ---
> > LOG: CONFLICT: in
67 matches
Mail list logo
