On 13/08/2024 08:45, Thomas Munro wrote:
Hi,
Over on the discussion thread about remaining setlocale() work[1], I
wrote out some long boring theories about $SUBJECT. Here are some
draft patches to try those theories out, and make a commitfest entry.
nl_langinfo_l() is a trivial drop-in replacem
Hi,
On Tue, Aug 13, 2024 at 12:23:04PM +0800, cca5507 wrote:
> Hi,
>
> I refactor the code and fix the git apply warning according to [1].
>
>
> Here are the new version patches.
Thanks!
1 ===
+ /* True if the xlog marks the transaction as containing catalog changes
*/
+ bool
On Tue, Aug 13, 2024 at 10:43 AM Thomas Munro wrote:
> I'll try this in a bit unless someone else has better ideas or plans
> for this part... sorry for the drip-feeding.
And done, see commitfest entry #5170.
Hi hackers.
While reviewing another thread I had cause to be looking more
carefully at the SEQUENCE documentation.
I found it curious that, unlike other clauses, the syntax of the CYCLE
clause was not displayed on a line by itself.
I have changed that, and at the same time I have moved the CYCLE
Hi,
Over on the discussion thread about remaining setlocale() work[1], I
wrote out some long boring theories about $SUBJECT. Here are some
draft patches to try those theories out, and make a commitfest entry.
nl_langinfo_l() is a trivial drop-in replacement, and
pg_localeconv_r() has 4 different
Hi,
On Mon, Aug 12, 2024 at 05:04:02PM -0500, Nathan Bossart wrote:
> On Tue, Aug 13, 2024 at 12:04:28AM +0300, Heikki Linnakangas wrote:
> >> In the case of the patch being proposed by Bertrand, the number of
> >> interrupts > will be much more frequent as parallel workers would send a
> >> messa
Hi hackers,
We encountered an issue lately, that if the database grants too many roles
`datacl` is toasted, following which, the drop database command will fail
with error "wrong tuple length".
To reproduce the issue, please follow below steps:
CREATE DATABASE test;
-- create helper function
CR
On Monday, August 12, 2024 7:41 PM Amit Kapila wrote:
>
> On Fri, Aug 9, 2024 at 12:29 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Here is the V12 patch that improved the log format as discussed.
> >
>
> Review comments:
Thanks for the comments.
> ===
> 1. The patch doesn't display t
On 06.08.24 16:00, Robert Haas wrote:
On Tue, Aug 6, 2024 at 4:04 AM Peter Eisentraut wrote:
constexpr is a keyword in C23. Rename a conflicting identifier for
future-proofing.
Obviously, C23 is way in the future, but this is a hard error that
prevents any further exploration. (To be clear:
Hi,
I refactor the code and fix the git apply warning according to [1].
Here are the new version patches.
--
Regards,
ChangAo Chen
[1] https://www.postgresql.org/message-id/Zrmh7X8jYCbFYXjH%40ip-10-97-1-34.eu-west-3.compute.internal
v3-0002-Add-test-case-snapshot_build-for-test_decoding.pa
On Mon, Aug 12, 2024 at 3:37 PM shveta malik wrote:
>
> On Fri, Aug 9, 2024 at 2:39 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> >
> > > + /*
> > > + * Register a callback to reset the origin state before aborting the
> > > + * transaction in ShutdownPostgres(). This is to prevent the advancement
>
On Mon, Aug 12, 2024 at 11:07 PM vignesh C wrote:
>
> On Mon, 12 Aug 2024 at 10:40, Peter Smith wrote:
> >
> > Hi Vignesh,
> >
> > I found that when 2 subscriptions are both subscribing to a
> > publication publishing sequences, an ERROR occurs on refresh.
> >
> > ==
> >
> > Publisher:
> > --
On Mon, Aug 5, 2024 at 10:05 AM shveta malik wrote:
>
> On Mon, Aug 5, 2024 at 9:19 AM Amit Kapila wrote:
> >
> > On Fri, Aug 2, 2024 at 6:28 PM Nisha Moond wrote:
> > >
> > > Performance tests done on the v8-0001 and v8-0002 patches, available at
> > > [1].
> > >
> >
> > Thanks for doing the d
Hi Vignesh, Here are my review comments for latest v20240812* patchset:
patch v20240812-0001. No comments.
patch v20240812-0002. Fixed docs.LGTM
patch v20240812-0003. This is new refactoring. See below.
patch v20240812-0004. (was 0003). See below.
patch v20240812-0005. (was 0004). No comments.
//
Fujii Masao writes:
> Yes, so I think that adding a note about the required remote server version
> to the cross-version compatibility section would be more intuitive.
> This section already discusses the necessary server versions and limitations.
> Patch attached.
This discussion tickles a conce
On Mon, Aug 12, 2024 at 3:43 PM Arseny Sher wrote:
>
> Sorry for the poor formatting of the message above, this should be better:
>
> Hey. Currently synchronous_commit is disabled for logical apply worker
> on the ground that reported flush_lsn includes only locally flushed data
> so slot (publish
On 2024/08/09 17:49, Etsuro Fujita wrote:
I just thought consolidating the information to one place would make
the documentation more readable.
Yes, so I think that adding a note about the required remote server version
to the cross-version compatibility section would be more intuitive.
This
On 2024-Aug-06, Kyotaro Horiguchi wrote:
> After a recent commit f80b09bac8, make update-po fails with "missing
> required files". The commit moved some files to fe_utils but this
> change was not reflected in pg_basebackup's nls.mk. The attached patch
> fixes this issue.
Thanks, pushed!
--
Álv
On 2024-Aug-10, Jelte Fennema-Nio wrote:
> On Sat, 10 Aug 2024 at 01:08, Alvaro Herrera wrote:
> > I propose something like the attached, but it's as yet untested. What
> > do you think?
>
> Looks good, but I haven't tested it yet either.
I tested the SASL exchange and it looks OK. Didn't te
On Mon, 12 Aug 2024 at 16:17, Joel Jacobson wrote:
>
> On Mon, Aug 12, 2024, at 17:14, Joel Jacobson wrote:
> > The case found with the smallest rscale adjustment was this one:
> > -[ RECORD 1 ]--+
> > var1 | 0.9873307197037692
> > var2
On 2024-Aug-06, Michael Paquier wrote:
> On Tue, Aug 06, 2024 at 10:21:23AM +0900, Kyotaro Horiguchi wrote:
> > After a recent commit f80b09bac8, make update-po fails with "missing
> > required files". The commit moved some files to fe_utils but this
> > change was not reflected in pg_basebackup's
On Mon, Aug 12, 2024 at 4:53 PM Thomas Munro wrote:
> ... though if we wanted to replace all use of localeconv and struct
> lconv with nl_langinfo_l() calls,
Gah. I realised while trying the above that you can't really replace
localeconv() with nl_langinfo_l() as the GNU documentation recommends
Skimming the last few messages of that thread [0], it looks like Bertrand
is exploring ways to avoid so many interrupts. I guess the unavoidable
question is whether this work is still worthwhile given that improvement.
The way the instrumentation in [0] dealt with interrupts was too complex,
On Tue, Aug 13, 2024 at 12:04:28AM +0300, Heikki Linnakangas wrote:
>> In the case of the patch being proposed by Bertrand, the number of
>> interrupts > will be much more frequent as parallel workers would send a
>> message
> to the leader
>> to update the vacuum delay counters every vacuum_delay_
On Mon, Aug 12, 2024, at 3:43 PM, Doruk Yilmaz wrote:
> Hello all,
Hi!
> While working on our internal tools that utilise replication, we
> realised that a new parameter was added to the internal C function
> corresponding to pg_replication_origin_session_setup.
> However this parameter wasn't in
On Tue, Jul 9, 2024 at 3:01 PM Nathan Bossart wrote:
>
> On Mon, Jun 24, 2024 at 11:30:00AM +0530, Bharath Rupireddy wrote:
> > 6) Vacuum command can't be run on the standby in recovery. So, to help
> > invalidate replication slots on the standby, I have for now let the
> > checkpointer also do th
On Mon, 12 Aug 2024 at 23:15, Paul Jungwirth
wrote:
> On 8/12/24 04:32, Aleksander Alekseev wrote:
> >> (gdb) call format_datum(range_out, $1)
> >> $2 = 0x59162692d938 "[1,4)"
> >>
> >> I assume a patch like this doesn't need documentation. Does it need a
> >> test? Anything else?
> >
> > I think
On Sun, 11 Aug 2024 at 23:54, Tom Lane wrote:
> I think this might be the same issue recently discussed here:
>
> https://www.postgresql.org/message-id/flat/1df84daa-7d0d-e8cc-4762-85523e45e5e7%40mailbox.org
Yeah that's definitely the same issue.
> That discussion was leaning towards the idea th
On Sat, Aug 10, 2024 at 6:58 PM Alexander Korotkov wrote:
> On Tue, Aug 6, 2024 at 8:36 AM Michael Paquier wrote:
> > On Tue, Aug 06, 2024 at 05:17:10AM +0300, Alexander Korotkov wrote:
> > > The 0001 patch is intended to improve this situation. Actually, it's
> > > not right to just put Recover
On 8/12/24 04:32, Aleksander Alekseev wrote:
[...] This function takes a Datum and the appropriate out function, and returns
a char *. So you
can do this:
(gdb) call format_datum(range_out, $1)
$2 = 0x59162692d938 "[1,4)"
I assume a patch like this doesn't need documentation. Does it need a te
I'm trying to understand what the point of this patch is, so I went to
read this thread from the beginning:
In the proposal by Bertrand [1] to implement vacuum cost delay tracking
in pg_stat_progress_vacuum, it was discovered that the vacuum cost delay
ends early on the leader process of a para
As cfbot points out [0], this is missing a Windows/frontend implementation.
[0] https://cirrus-ci.com/task/6393555868975104
Looks like the pgsleep implementation is missing the
#ifndef WIN32
I followed what is done in pg_usleep.
v11 should now build on Windows, hopefully.
Strangely, v10 buil
On Tue, Aug 13, 2024 at 2:35 AM Tom Lane wrote:
> I can confirm that the attached program works on cfarm111 (AIX 7.1)
> and cfarm119 (AIX 7.3), though "man realpath" denies it on both
> systems.
Another example of this phenomenon: they have nl_langinfo_l(), a POSIX
2008 feature we want in a nearb
On Mon, Aug 12, 2024 at 03:56:18PM +, Bertrand Drouvot wrote:
> Thanks, v10 LGTM.
As cfbot points out [0], this is missing a Windows/frontend implementation.
[0] https://cirrus-ci.com/task/6393555868975104
--
nathan
On Mon, 2024-08-12 at 09:00 +0200, Peter Eisentraut wrote:
> > I assume it would now be okay to take out "locale &&" here?
>
> Correct, that check is no longer necessary.
Thank you, fixed.
Regards,
Jeff Davis
Hello all,
While working on our internal tools that utilise replication, we
realised that a new parameter was added to the internal C function
corresponding to pg_replication_origin_session_setup.
However this parameter wasn't included in the user-facing API [1].
In 'src/backend/replication/logica
Andrew Dunstan writes:
> On 2024-08-11 Su 8:32 PM, Tom Lane wrote:
>> I think we need more data. We know that the
>> wait_for_catchup query is never getting to true:
>>
>> SELECT '$target_lsn' <= ${mode}_lsn AND state = 'streaming'
>>
>> but we don't know if the LSN condition or the state condi
On Thu, Aug 8, 2024 at 10:27 PM Xiaoran Wang wrote:
> > Add function 'pq_leave_shm_mq' to allow the process to go
> > back to the previous pq environment.
>
> >.In the code as it currently exists, a parallel worker never has a
> >.connected client, and it talks to a shm_mq instead.
On 8/12/24 17:57, Ilia Evdokimov wrote:
> On 12.8.24 14:53, Tomas Vondra wrote:
>
>> I agree, and I'm grateful someone picked up the original patch. I'll try
>> to help to keep it moving forward. If the thread gets stuck, feel free
>> to ping me to take a look.
> Good. Thank you!
>>> I started rev
On 12.8.24 14:53, Tomas Vondra wrote:
I agree, and I'm grateful someone picked up the original patch. I'll try
to help to keep it moving forward. If the thread gets stuck, feel free
to ping me to take a look.
Good. Thank you!
I started reviewing it and want to suggest some changes to better co
Hi,
On Mon, Aug 12, 2024 at 10:19:56AM -0500, Sami Imseih wrote:
> v10 attached in the previous message addresses
> Bertrands last comment and replaces “This” with “this"
>
Thanks, v10 LGTM.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Servic
On Mon, Aug 12, 2024 at 04:13:02PM +0300, Aleksander Alekseev wrote:
> Patch v5 LGTM.
Committed.
--
nathan
My email client attached the last response for
some reason :(
v10 attached in the previous message addresses
Bertrands last comment and replaces “This” with “this"
Regards,
Sami
On Mon, Aug 12, 2024, at 17:14, Joel Jacobson wrote:
> The case found with the smallest rscale adjustment was this one:
> -[ RECORD 1 ]--+
> var1 | 0.9873307197037692
> var2 | 0.426697279270850
> rscale_adjustment | -15
>
On Mon, Aug 12, 2024, at 12:47, Joel Jacobson wrote:
>> 2). Attempt to fix the formulae incorporating maxdigits mentioned
>> above. This part really made my brain hurt, and I'm still not quite
>> sure that I've got it right. In particular, it needs double-checking
>> to ensure that it's not losing
>
> + * Unlike pg_usleep, This function continues
>
> s/This/this/?
>
> Apart from the above, LGTM.
>
v10-0001-vaccum_delay-with-absolute-time-nanosleep.patch
Description: Binary data
Thanks for this catch. Uploaded v10.
Regards,
Sami
I wrote:
> Peter Eisentraut writes:
>> Tom had tested this on and found that it does actually work on AIX 7.1
>> and 7.3 but the documentation is wrong.
> I too have a distinct recollection of having tested this (using the
> gcc compile farm machines), but I cannot find anything saying so in
> t
Hi all,
Attaching a patch to add remaining cached and loaded stats as mentioned
in commit f68cd847fa40ead44a786b9c34aff9ccc048004b message. Existing TAP
tests were updated to handle new stats. This patch has been tested on
HEAD using "make check-world" after enabling injection points via
"--e
Em seg., 12 de ago. de 2024 às 06:21, jian he
escreveu:
>
> as your wish.
>
Looks good.
regards
Marcos
Peter Eisentraut writes:
> On 12.08.24 08:47, Thomas Munro wrote:
>> I checked this in the AIX 7.3 manual and the POSIX 2008 way does not
>> appear to be mentioned there:
>> https://www.ibm.com/docs/en/aix/7.3?topic=r-realpath-subroutine
> Tom had tested this on and found that it does actually wo
On 2024-08-11 Su 8:32 PM, Tom Lane wrote:
Andrew Dunstan writes:
We'll see. I have switched crake from --run-parallel mode to --run-all
mode i.e. the runs are serialized. Maybe that will be enough to stop the
errors. I'm still annoyed that this test is susceptible to load, if that
is indeed wh
On 8/7/24 23:39, Nathan Bossart wrote:
I've attached a new patch to show roughly what I think this new GUC should
look like. I'm hoping this sparks more discussion, if nothing else.
Thank you. FWIW, I would prefer a sub-linear growth, so maybe something
like this:
vacthresh = Min(vac_ba
On Mon, 12 Aug 2024 at 20:34, John Naylor wrote:
> I just remembered an article I read a while back by a compiler
> engineer who said that compilers have heuristics that treat NULL
> pointers as "unlikely" since the most common reason to test that is so
> we can actually dereference it and do some
Hi,
> WFM. Here is what I have staged for commit.
Patch v5 LGTM.
--
Best regards,
Aleksander Alekseev
On Mon, 12 Aug 2024 at 09:59, Peter Smith wrote:
>
> Hi Vignesh,
>
> I noticed it is not currently possible (there is no syntax way to do
> it) to ALTER an existing publication so that it will publish
> SEQUENCES.
>
> Isn't that a limitation? Why?
>
> For example,. Why should users be prevented fr
On Mon, 12 Aug 2024 at 10:40, Peter Smith wrote:
>
> Hi Vignesh,
>
> I found that when 2 subscriptions are both subscribing to a
> publication publishing sequences, an ERROR occurs on refresh.
>
> ==
>
> Publisher:
> --
>
> test_pub=# create publication pub1 for all sequences;
>
> Subs
On Thu, Jun 20, 2024 at 2:09 AM Alvaro Herrera wrote:
> I hope we can get this new executor code in 18.
Thanks for doing the benchmark, Alvaro, and sorry for the late reply.
Yes, I'm hoping to get *some* version of this into v18. I've been
thinking how to move this forward and I'm starting to t
On 10.08.24 16:12, Tom Lane wrote:
Stepan writes:
Hi, hackers! If you look at the code in the src/backend/executor/spi.c file,
you will see the SPI_connect function familiar to many there, which
internally simply calls SPI_connect_ext. The return type is int, at the end
it says return SPI_OK_CO
Hi,
> I was playing with a static analyzer security scanner and it flagged a
> time-of-check-time-of-use violation in libpq. I was going to propose a
> fix for this on -hackers, since you probably can't do anything
> interesting with this, but then I figured I'd better check here first.
>
> libpq
On Mon, Jun 24, 2024 at 4:01 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> Hi,
>
> On Mon, Jun 17, 2024 at 5:55 PM Bharath Rupireddy
> wrote:
> >
> > Here are my thoughts on when to do the XID age invalidation. In all
> > the patches sent so far, the XID age invalidation
(I know Daniel mentioned he'd get to these, but the ScanDirection one
was my fault and I needed to clear that off my mind. I did a few
others while on this topic.)
On Fri, 5 Jul 2024 at 05:00, Alexander Lakhin wrote:
> Please look at another bunch of inconsistencies/orphaned entities I found
> in
On 8/12/24 13:44, Alena Rybakina wrote:
> Hi! I think your work is important)
>
I agree, and I'm grateful someone picked up the original patch. I'll try
to help to keep it moving forward. If the thread gets stuck, feel free
to ping me to take a look.
> I started reviewing it and want to suggest
+ * See if we have a matching backend. Reading the pss_pid and
+ * pss_cancel_key fields is racy, a backend might die and remove itself
+ * from the array at any time. The probability of the cancellation key
+ * matching wrong process is miniscule, however, so we can live with that
Hi! I think your work is important)
I started reviewing it and want to suggest some changes to better code:
I think we should consider the case where the expression is not neither
an OpExpr and VarOpVar expression.
Have you tested this code with any benchmarks?
--
Regards,
Alena Rybakina
Pos
On Mon, 12 Aug 2024 at 22:32, David Rowley wrote:
>
> On Mon, 12 Aug 2024 at 22:03, jian he wrote:
> > I think first ri_RowIdAttNo applies to MERGE also. so the comments may
> > not be correct?
>
> Yeah, ri_RowIdAttNo is used for MERGE. We should fix that comment.
>
> > Other files comments are f
On Fri, Aug 9, 2024 at 12:29 PM Zhijie Hou (Fujitsu)
wrote:
>
> Here is the V12 patch that improved the log format as discussed.
>
Review comments:
===
1. The patch doesn't display the remote tuple for delete_differ case.
However, it shows the remote tuple correctly for update_differ.
Hi,
Thanks for the comments!
- I think it's fine to skip during fast forward as we are not generating logical
- changes. It's done that way in master, in your proposal and in my "if"
proposals.
- Note that my proposals related to the if conditions are for heap2_decode and
- heap_decode (not xac
Hi Paul,
> [...] This function takes a Datum and the appropriate out function, and
> returns a char *. So you
> can do this:
>
> (gdb) call format_datum(range_out, $1)
> $2 = 0x59162692d938 "[1,4)"
>
> I assume a patch like this doesn't need documentation. Does it need a test?
> Anything else?
Hello, Hou zj!
> In my test, if the tuple is updated and new tuple is in the same page,
> heapam_index_fetch_tuple should find the new tuple using HOT chain. So,
it's a
> bit unclear to me how the updated tuple is missing. Maybe I missed some
other
> conditions for this issue.
Yeah, I think the p
Another issue mentioned in [1] involves cases where the clause is in the
form (A op A). In my view, this isn't related to the current patch, as
it can be addressed by rewriting the clause, similar to transforming A =
A into A IS NOT NULL. This adjustment would result in more accurate
estimation
Hi Alexander,
> As part of this effort, we conducted static analysis using Svace, which
> raised some questions regarding the use of the Assert() function.
> We were unable to find clear answers in the documentation or previous
> discussions and would greatly appreciate your insights,
> as these
On Sun, Aug 11, 2024, at 22:04, Joel Jacobson wrote:
>> Attachments:
>> * v4-0001-Extend-mul_var_short-to-5-and-6-digit-inputs.patch
>> * v4-0002-Optimise-numeric-multiplication-using-base-NBASE-.patch
>
> I've reviewed and tested both patches and think they are ready to be
> committed.
In additi
On Fri, Jul 5, 2024 at 10:59 PM Tom Lane wrote:
>
> The cfbot noticed that this patchset had a conflict with d35cd0619,
> so here's a rebase. It's just a rebase of v1, no other changes.
Hi Tom,
I started looking at the earlier cleanup patches.
0001 seems straightforward. Note: It doesn't apply
Hi hackers,
I'd like to submit a patch that improves the estimated rows for queries
containing (Var op Var) clauses by applying extended MCV statistics.
*New functions:*
* mcv_clauselist_selectivity_var_op_var() - calculates the selectivity
for (Var op Var) clauses.
* is_opclause_var_op_
Hi,
On Mon, Aug 12, 2024 at 04:34:25PM +0800, cca5507 wrote:
> Hi,
>
>
> 4, 5 ===
>
>
> > if (SnapBuildCurrentState(builder) < SNAPBUILD_BUILDING_SNAPSHOT ||
> > (SnapBuildCurrentState(builder) ==
> SNAPBUILD_BUILDING_SNAPSHOT && info != XLOG_HEAP_INPLACE) ||
> > ctx->fast_forward)
>
On Sat, Aug 10, 2024 at 11:41 PM Joseph Koshakow wrote:
>
>
>
> On Thu, Aug 8, 2024 at 9:01 PM jian he wrote:
> >
> > Should the error about integers be out of range?
> >
> > SELECT make_date(-2147483648, 1, 1);
> > "-2147483648" is not an allowed integer.
> >
> > \df make_date
> >
On Mon, 12 Aug 2024 at 22:03, jian he wrote:
> AttrNumberri_RowIdAttNo;
>
> /* arrays of stored generated columns expr states, for INSERT and UPDATE
> */
> ExprState **ri_GeneratedExprsI;
> ExprState **ri_GeneratedExprsU;
> }
> for the struct ResultRelInfo, i've checked the ab
Sorry for the poor formatting of the message above, this should be better:
Hey. Currently synchronous_commit is disabled for logical apply worker
on the ground that reported flush_lsn includes only locally flushed data
so slot (publisher) preserves everything higher than this, and so in
case of s
Kirill,
Good catch!
I will split the patch into two to cover both cases.
Thanks,
Steven
Junwang Zhao 于2024年8月9日周五 18:19写道：
> On Fri, Aug 9, 2024 at 5:20 PM Kirill Reshke
> wrote:
> >
> > On Thu, 1 Aug 2024 at 17:32, Junwang Zhao wrote:
> > >
> > > Hi Steven,
> > >
> > > On Wed, Jul 31, 2024
On Mon, Aug 12, 2024 at 3:36 PM shveta malik wrote:
>
> On Fri, Aug 9, 2024 at 2:39 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Amit, Shveta, Hou,
> >
> > Thanks for giving many comments! I've updated the patch.
> >
> > > @@ -4409,6 +4409,14 @@ start_apply(XLogRecPtr origin_startpos)
> > >
On Fri, Aug 9, 2024 at 2:39 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit, Shveta, Hou,
>
> Thanks for giving many comments! I've updated the patch.
>
> > @@ -4409,6 +4409,14 @@ start_apply(XLogRecPtr origin_startpos)
> > }
> > PG_CATCH();
> > {
> > + /*
> > + * Reset the origin data to pr
hi.
{
/*
* For UPDATE/DELETE result relations, the attribute number of the row
* identity junk attribute in the source plan's output tuples
*/
AttrNumberri_RowIdAttNo;
/* Projection to generate new tuple in an INSERT/UPDATE */
ProjectionInfo *ri_projectNew;
Hey. Currently synchronous_commit is by default disabled for logical
apply worker on the
ground that reported flush_lsn includes only locally flushed data so slot
(publisher) preserves everything higher than this, and so in case of
subscriber
restart no data is lost. However, imagine that subsc
On Fri, Aug 9, 2024 at 8:43 PM Marcos Pegoraro wrote:
>
> I still think this way would be better
> + Sawada, John Naylor). [
> + ee1b30f12,
> + 30e144287,
> + 667e65aac,
> + 6dbb49026]
> instead of this
> + Sawada, John Naylor).
> +[ee1b30f12],
> +
David Rowley , 12 Ağu 2024 Pzt, 06:44 tarihinde şunu
yazdı:
> I made a few adjustments and pushed the patch. Let's see if anyone
> complains.
>
Thanks David.
On Wed, Aug 7, 2024 at 11:28 PM Robert Haas wrote:
>
> On Wed, Aug 7, 2024 at 1:05 PM Amul Sul wrote:
> > The main issue I have is computing the total_size of valid files that
> > will be checksummed and that exist in both the manifests and the
> > backup, in the case of a tar backup. This cannot
On Mon, Aug 12, 2024 at 8:50 AM Richard Guo wrote:
>
> On Sat, Aug 10, 2024 at 6:22 AM Alexey Dvoichenkov
> wrote:
> > I haven't read the entire thread so I might be missing something, but
> > one interesting consequence of this patch is that it kind of breaks
> > the initial pruning of generic p
Hello,
I believe the topic on the link below
https://www.postgresql.org/message-id/flat/98760523-a0d2-8705-38e3-c4602ecf2448%402ndquadrant.com
should be re-discussed, as more than 6 years passed from the last message.
Let me summarize the topic first and ask the real question: Can declared
cursors
Hi,
4, 5 ===
> if (SnapBuildCurrentState(builder) < SNAPBUILD_BUILDING_SNAPSHOT ||
> (SnapBuildCurrentState(builder) ==
SNAPBUILD_BUILDING_SNAPSHOT && info != XLOG_HEAP_INPLACE) ||
> ctx->fast_forward)
> return;
I think during fast forward, we also need handle the xlog that mark
On Sun, Jun 30, 2024 at 10:24 PM Tom Lane wrote:
> In general, we have a policy of using likely/unlikely very sparingly,
> and only in demonstrably hot code paths. This hook call certainly
> doesn't qualify as hot.
I just remembered an article I read a while back by a compiler
engineer who said
On 09.08.24 06:55, Tom Lane wrote:
Noah Misch writes:
On Thu, Aug 08, 2024 at 08:46:35AM +0200, Peter Eisentraut wrote:
I propose to fix that by making a copy of the scan keys passed by the caller
and make the modifications there.
No objection, but this would obsolete at least some of these
On 12.08.24 08:47, Thomas Munro wrote:
On Mon, Aug 12, 2024 at 6:18 PM Peter Eisentraut wrote:
On 05.08.24 09:41, Heikki Linnakangas wrote:
On 05/08/2024 09:12, Peter Eisentraut wrote:
The now preferred way to call realpath() is by passing NULL as the
second argument and get a malloc'ed resul
On 11.08.24 18:33, Tom Lane wrote:
Jeff Davis writes:
We can address those as part of a separate thread. I'll count this as
committed.
Coverity has a nit about this:
*** CID 1616189: Null pointer dereferences (REVERSE_INULL)
/srv/coverity/git/pgsql-git/postgresql/src/backend/utils/adt/like
93 matches
Mail list logo
