Re: Improve node type forward reference

2024-10-16 Thread Peter Eisentraut
On 15.10.24 16:43, Nathan Bossart wrote: On Tue, Oct 15, 2024 at 09:02:48AM +0200, Peter Eisentraut wrote: On 14.10.24 23:28, Nathan Bossart wrote: On Mon, Oct 14, 2024 at 09:47:59AM +0200, Peter Eisentraut wrote: But we can do this better by using an incomplete struct, like struct

Re: [PoC] Federated Authn/z with OAUTHBEARER

2024-10-16 Thread Peter Eisentraut
On 15.10.24 20:10, Jacob Champion wrote: On Tue, Oct 15, 2024 at 11:00 AM Alexander Lakhin wrote: I've discovered that starting from 0785d1b8b, make check -C src/bin/pg_combinebackup fails under Valgrind, with the following diagnostics: Yep, sorry for that (and thanks for the report!). It's c

Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions

2024-10-16 Thread jian he
On Thu, Oct 17, 2024 at 7:59 AM Bruce Momjian wrote: > > > Where are we on this? I still see this behavior. > > --- > > but I found following two examples returning different results, > > i think they should return the same

Re: Doc: shared_memory_size_in_huge_pages with the "SHOW" command.

2024-10-16 Thread Seino Yuki
Thank you, everyone. the point being to encourage its use before the server is running as we don't want to allocate anything when tuning it. I was mistaken and now understand that it needs to be run before the server is running. Another idea is to use the same wording as for num_os_semaphores

Re: Should we document how column DEFAULT expressions work?

2024-10-16 Thread Tom Lane
Andrei Lepikhov writes: > Pardon the noise, but can you consider the idea of replacing the phrase > 'data insertion time' with something like 'immediately before the > insertion operation starts'? Sometimes people (especially younglings) > ask which time it is precisely: will it differ for each

Re: BF mamba failure

2024-10-16 Thread Michael Paquier
On Wed, Oct 16, 2024 at 10:11:08AM +, Bertrand Drouvot wrote: > Indeed, in pgstat_release_entry_ref(), we're doing: > > if (pg_atomic_fetch_sub_u32(&entry_ref->shared_entry->refcount, 1) == 1) > . > . > shent = dshash_find(pgStatLocal.shared_hash, > &entry_ref->sh

Re: Should we document how column DEFAULT expressions work?

2024-10-16 Thread Andrei Lepikhov
On 10/17/24 06:19, Bruce Momjian wrote: On Fri, Jul 5, 2024 at 05:11:22PM -0400, Bruce Momjian wrote: On Fri, Jul 5, 2024 at 05:03:35PM -0400, Tom Lane wrote: Bruce Momjian writes: Well, 'now()' certainly _looks_ like a function call, though it isn't. The fact that 'now()'::timestamptz and

Re: Set query_id for query contained in utility statement

2024-10-16 Thread jian he
hi. Anthonin please check attached v9-0001, v9-0002, v9-003. v9-0001-Better-error-reporting-from-extension-scripts-Was.patch same as v4-0001-Improve-parser-s-reporting-of-statement-start-loc.patch in [1] v9-0002-Add-tests-covering-pgss-nested-queries.patch same as v8-0001-Add-tests-covering-pgss-

Re: Considering fractional paths in Append node

2024-10-16 Thread Andrei Lepikhov
On 10/17/24 07:05, Andy Fan wrote: Nikita Malakhov writes: Helll Nikita, Hi hackers! Sorry, I've forgot to attach the patch itself. Please check it out. Could you check if [1] is related to this subject? I think the hard part would be which tuple_fraction to use during adding add_paths_to_

Re: wrong comment in libpq.h

2024-10-16 Thread Bruce Momjian
On Fri, May 10, 2024 at 11:14:51AM -0700, David Zhang wrote: > > > It looks like this wording "prototypes for functions in" is used many > > times in src/include/, in many cases equally inaccurately, so I would > > suggest creating a more comprehensive patch for this. > > I noticed this "prototyp

Re: POC, WIP: OR-clause support for indexes

2024-10-16 Thread Andrei Lepikhov
On 10/17/24 03:39, Alexander Korotkov wrote: On Wed, Oct 16, 2024 at 7:22 AM Andrei Lepikhov wrote: On 10/12/24 21:25, Alexander Korotkov wrote: I forgot to specify (COSTS OFF) for EXPLAINs in regression tests. Fixed in v42. I've passed through the patch set. Let me put aside the v42-0003

Re: ltree docs imprecise about sorting order

2024-10-16 Thread David G. Johnston
On Wednesday, October 16, 2024, Bruce Momjian wrote: > On Thu, May 23, 2024 at 04:17:50PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/ltree.html > > Description: > > > > The ltree docs

Re: Fixing Hash Join bug I caused with adf97c156

2024-10-16 Thread David Rowley
On Wed, 16 Oct 2024 at 15:21, David Rowley wrote: > Here's a patch including a test this time. I've pushed this patch. Thanks for looking. David

Re: ltree docs imprecise about sorting order

2024-10-16 Thread Bruce Momjian
On Thu, May 23, 2024 at 04:17:50PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/ltree.html > Description: > > The ltree docs available at > https://www.postgresql.org/docs/current/ltree.html s

Re: Should we document how column DEFAULT expressions work?

2024-10-16 Thread Bruce Momjian
On Wed, Oct 16, 2024 at 04:45:39PM -0700, David G. Johnston wrote: > On Wednesday, October 16, 2024, Bruce Momjian wrote: > I do not, but maybe I’m being overly pedantic.  All string literals are parsed > during the create table command.  It’s only the situations where that parsing > is non-determ

Re: MergeAppend could consider sorting cheapest child path

2024-10-16 Thread Andy Fan
Bruce Momjian writes: > Is this still being considered? I'd +1 on this feature. I guess this would be more useful on parallel case, where the Sort can be pushed down to parallel worker, and in the distributed database case, where the Sort can be pushed down to multiple nodes, at the result, the

Re: Set AUTOCOMMIT to on in script output by pg_dump

2024-10-16 Thread Shinya Kato
On 2024-10-10 14:56, Shinya Kato wrote: A new patch is attached. I am not a native English, so corrections to the texts are welcome. I created a commit fest entry. https://commitfest.postgresql.org/50/5306/ -- Regards, Shinya Kato NTT DATA GROUP CORPORATION

Re: Should we document how column DEFAULT expressions work?

2024-10-16 Thread Tom Lane
Bruce Momjian writes: > Does anyone like this patch? I changed now()::timestamptz to > now::timestamptz. No, because you clearly didn't bother to test it: regression=# select now::timestamptz; ERROR: column "now" does not exist LINE 1: select now::timestamptz; ^ Also "a string

Re: Considering fractional paths in Append node

2024-10-16 Thread Andy Fan
Nikita Malakhov writes: Helll Nikita, > Hi hackers! > > Sorry, I've forgot to attach the patch itself. Please check it out. Could you check if [1] is related to this subject? I think the hard part would be which tuple_fraction to use during adding add_paths_to_append_rel since root->tuple_fract

Re: MergeAppend could consider sorting cheapest child path

2024-10-16 Thread Bruce Momjian
Is this still being considered? --- On Tue, Jun 18, 2024 at 07:45:09PM +0300, Alexander Pyhalov wrote: > Hi. > > Now when planner finds suitable pathkeys in generate_orderedappend_paths(), > it uses them, even if explicit

Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions

2024-10-16 Thread Bruce Momjian
Where are we on this? I still see this behavior. --- On Fri, Jun 21, 2024 at 04:53:55PM +0800, jian he wrote: > On Fri, Jun 21, 2024 at 11:11 AM David G. Johnston > wrote: > > > > On Thu, Jun 20, 2024 at 7:30 PM jian he

Re: [BUG FIX] Fix validation of COPY options FORCE_NOT_NULL/FORCE_NULL

2024-10-16 Thread Michael Paquier
On Wed, Oct 16, 2024 at 02:50:53PM +0900, Michael Paquier wrote: > You are right. f6d4c9cf162b got that wrong. Will fix and backpatch > with the extra tests. And done down to 17 for 0002, down to 16 for 0001, with tweaks in 0001 to limit the use of COPY TO in the queries where we want to force e

Should we document how column DEFAULT expressions work?

2024-10-16 Thread David G. Johnston
On Wednesday, October 16, 2024, Bruce Momjian wrote: > On Fri, Jul 5, 2024 at 05:11:22PM -0400, Bruce Momjian wrote: > > On Fri, Jul 5, 2024 at 05:03:35PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Well, 'now()' certainly _looks_ like a function call, though it > isn't. > > > >

Re: Limiting overshoot in nbtree's parallel SAOP index scans

2024-10-16 Thread Matthias van de Meent
On Thu, 17 Oct 2024 at 00:33, Peter Geoghegan wrote: > > On Wed, Oct 16, 2024 at 5:48 PM Matthias van de Meent > wrote: > > In v17 and the master branch you'll note 16 buffer hits for the test > > query. However, when we use more expensive btree compare operations > > (e.g. by adding pg_usleep(1)

Re: pgindent exit status if a file encounters an error

2024-10-16 Thread Bruce Momjian
Uh, where are we on this? --- On Fri, Jun 28, 2024 at 06:05:35PM +0530, Ashutosh Bapat wrote: > > > On Wed, Jun 26, 2024 at 8:54 PM Tom Lane wrote: > > Ashutosh Bapat writes: > > The usage help mentions exit co

Re: Statistics Import and Export

2024-10-16 Thread Corey Huinker
> > Code fix with comment on why nobody expects a relpages -1. Test case to > demonstrate that relpages -1 can happen, and updated doc to reflect the new > lower bound. > Additional fixes, now in a patch-set: 1. Allow relpages to be set to -1 (partitioned tables with partitions have this value af

Re: Should we document how column DEFAULT expressions work?

2024-10-16 Thread Bruce Momjian
On Fri, Jul 5, 2024 at 05:11:22PM -0400, Bruce Momjian wrote: > On Fri, Jul 5, 2024 at 05:03:35PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Well, 'now()' certainly _looks_ like a function call, though it isn't. > > > The fact that 'now()'::timestamptz and 'now'::timestamptz generat

Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

2024-10-16 Thread Bruce Momjian
On Tue, Jul 16, 2024 at 08:23:11AM -0400, Andrew Dunstan wrote: > > On 2024-07-16 Tu 7:46 AM, Yasir wrote: > > Hi Hackers,  > > Recently, I compiled PG17 on the windows. Till PG16 "ActiveState Perl", as > instructed in the documentation, was being used successfully on the > Windows

Re: Limiting overshoot in nbtree's parallel SAOP index scans

2024-10-16 Thread Peter Geoghegan
On Wed, Oct 16, 2024 at 5:48 PM Matthias van de Meent wrote: > In v17 and the master branch you'll note 16 buffer hits for the test > query. However, when we use more expensive btree compare operations > (e.g. by adding pg_usleep(1) to both btint8cmp and btint4cmp), the > buffer access count start

Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch)

2024-10-16 Thread Shayon Mukherjee
> On Oct 16, 2024, at 2:15 PM, Shayon Mukherjee wrote: > > >> On Oct 16, 2024, at 12:19 PM, Shayon Mukherjee wrote: >> >> - ALTER INDEX ... ENABLE/DISABLE performs an in-place update of the pg_index >> catalog to protect against indcheckxmin [2] (older unrelated thread). > > Performing th

Re: Limiting overshoot in nbtree's parallel SAOP index scans

2024-10-16 Thread Matthias van de Meent
On Wed, 16 Oct 2024 at 20:52, Peter Geoghegan wrote: > > On Fri, Oct 11, 2024 at 10:27 AM Matthias van de Meent > wrote: > > With the introduction of the new SAOP handling in PG17, however, the > > shared state has become a bit more muddied. Because the default has > > changed from "stop scanning

Re: Popcount optimization using AVX512

2024-10-16 Thread Nathan Bossart
On Tue, Oct 08, 2024 at 09:36:03PM -0500, Nathan Bossart wrote: > On Wed, Jul 31, 2024 at 04:43:02PM -0500, Nathan Bossart wrote: >> On Wed, Jul 31, 2024 at 01:52:54PM -0700, Andres Freund wrote: >>> I think we'd be better off enabling architectural features on a per-function >>> basis, roughly lik

Re: POC, WIP: OR-clause support for indexes

2024-10-16 Thread Alexander Korotkov
On Wed, Oct 16, 2024 at 7:22 AM Andrei Lepikhov wrote: > On 10/12/24 21:25, Alexander Korotkov wrote: > > I forgot to specify (COSTS OFF) for EXPLAINs in regression tests. Fixed in > > v42. > I've passed through the patch set. > > Let me put aside the v42-0003 patch—it looks debatable, and I ne

Soft errors and ThrowErrorData() comment updates

2024-10-16 Thread Jeff Davis
The comments around ThrowErrorData() and how it might apply to soft errors is slightly confusing. Attached a patch which hopefully clarifies things. >From a distance, ThrowErrorData() is somewhat like ReThrowError(), but it's actually quite different. The former is expecting a free-standing ErrorD

Re: Using per-transaction memory contexts for storing decoded tuples

2024-10-16 Thread Masahiko Sawada
On Wed, Oct 16, 2024 at 10:32 AM Masahiko Sawada wrote: > > On Tue, Oct 15, 2024 at 9:01 PM Amit Kapila wrote: > > > > On Tue, Oct 15, 2024 at 11:15 PM Masahiko Sawada > > wrote: > > > > > > On Sun, Oct 13, 2024 at 11:00 PM Amit Kapila > > > wrote: > > > > > > > > On Fri, Oct 11, 2024 at 3:40

Re: New "raw" COPY format

2024-10-16 Thread Joel Jacobson
On Wed, Oct 16, 2024, at 20:30, Joel Jacobson wrote: > A final thought is to maybe consider just skipping > the automagical newline detection for RAW? > > Instead of the automagical detection, > the default newline delimiter could be the OS default, > similar to how COPY TO works. > > That way, it

Re: Limiting overshoot in nbtree's parallel SAOP index scans

2024-10-16 Thread Peter Geoghegan
On Fri, Oct 11, 2024 at 10:27 AM Matthias van de Meent wrote: > With the introduction of the new SAOP handling in PG17, however, the > shared state has become a bit more muddied. Because the default has > changed from "stop scanning at the end of a SAOP value's range" to > "continue scanning, unle

Re: Considering fractional paths in Append node

2024-10-16 Thread Nikita Malakhov
Hi hackers! Sorry, I've forgot to attach the patch itself. Please check it out. -- Regards, Nikita Malakhov Postgres Professional The Russian Postgres Company https://postgrespro.ru/ 0001_append_limit_v1.patch Description: Binary data

Re: New "raw" COPY format

2024-10-16 Thread Joel Jacobson
On Wed, Oct 16, 2024, at 18:34, Daniel Verite wrote: > Joel Jacobson wrote: > >> However, I thinking rejecting such column data seems like the >> better alternative, to ensure data exported with COPY TO >> can always be imported back using COPY FROM, >> for the same format. > > On the other hand,

Considering fractional paths in Append node

2024-10-16 Thread Nikita Malakhov
Hi hackers! A colleague of mine, Andrei Lepikhov, has found interesting behavior in path cost calculation for Append node - when evaluating the cheapest path it does not take into account fractional path costs. We've prepared a patch that forces add_paths_to_append_rel function to consider non-pa

Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR)

2024-10-16 Thread Tom Lane
jian he writes: > just found out the"elog(INFO, "should not reached here");" part never reached. You didn't check any of the cases we were discussing I guess? (That is, places in gram.y that throw an error without a parser_errposition call.) Note that even if we fix all of those and keep them fi

Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch)

2024-10-16 Thread Shayon Mukherjee
On Oct 16, 2024, at 12:19 PM, Shayon Mukherjee wrote:- ALTER INDEX ... ENABLE/DISABLE performs an in-place update of the pg_index   catalog to protect against indcheckxmin [2] (older unrelated thread).Performing the in place update of the pg_index row from ATExecEnableDisableIndex using systable_i

Re: Pgoutput not capturing the generated columns

2024-10-16 Thread Shubham Khanna
On Thu, Oct 10, 2024 at 10:53 AM Peter Smith wrote: > > Here are some comments for TAP test patch v37-0003. > > I’m not in favour of the removal of such a large number of > 'combination' and other 'misc' tests. In the commit message, please > delete me as a "co-author" of this patch. > > == >

Re: Avoiding superfluous buffer locking during nbtree backwards scans

2024-10-16 Thread Peter Geoghegan
On Fri, Oct 11, 2024 at 7:29 PM Peter Geoghegan wrote: > Attached is v5 Now I'm attaching a v6, which further polishes things. Current plan is to commit something very close to this in the next day or two. v6 is mostly just further comment polishing. But it also merges together the two existing

Re: Pgoutput not capturing the generated columns

2024-10-16 Thread Shubham Khanna
On Wed, Oct 9, 2024 at 11:52 AM vignesh C wrote: > > On Tue, 8 Oct 2024 at 11:37, Shubham Khanna > wrote: > > > > On Fri, Oct 4, 2024 at 9:36 AM Peter Smith wrote: > > > > > > Hi Shubham, here are my review comments for v36-0001. > > > > > > == > > > 1. General - merge patches > > > > > >

Re: Pgoutput not capturing the generated columns

2024-10-16 Thread Shubham Khanna
On Wed, Oct 9, 2024 at 11:13 AM Peter Smith wrote: > > Hi, here are my review comments for patch v37-0001. > > == > Commit message > > 1. > Example usage of subscription option: > CREATE PUBLICATION FOR TABLE tab_gencol WITH (publish_generated_columns > = true); > > ~ > > This is wrong -- it's

Re: Pgoutput not capturing the generated columns

2024-10-16 Thread Shubham Khanna
On Wed, Oct 9, 2024 at 11:00 AM vignesh C wrote: > > On Tue, 8 Oct 2024 at 11:37, Shubham Khanna > wrote: > > > > On Fri, Oct 4, 2024 at 9:36 AM Peter Smith wrote: > > > > > > Hi Shubham, here are my review comments for v36-0001. > > > > > > == > > > 1. General - merge patches > > > > > >

Re: Fix for consume_xids advancing XIDs incorrectly

2024-10-16 Thread Masahiko Sawada
On Tue, Oct 15, 2024 at 10:06 PM Yushi Ogiwara wrote: > > Hi, > > Thank you for your comment. > > Regarding the first patch, I believe it works correctly when > consume_xids(1) is called. This is because the lastxid variable in the > consume_xids_common function is initialized as lastxid = > Read

Re: ECPG cleanup and fix for clang compile-time problem

2024-10-16 Thread Tom Lane
I wrote: > Attached are rebased and renumbered 0006-0008, mostly to keep the > cfbot happy. For some reason I thought the stuff I pushed later on Monday didn't interact with these patches, but the cfbot disabused me of that folly. Here's a rebased v7 --- no substantive change.

Re: New "raw" COPY format

2024-10-16 Thread Joel Jacobson
On Wed, Oct 16, 2024, at 18:04, Jacob Champion wrote: > A hypothetical type whose text representation can contain '\r' but not > '\n' still can't be unambiguously round-tripped under this scheme: > COPY FROM will see the "mixed" line endings and complain, even though > there's no ambiguity. Yeah,

Re: Using per-transaction memory contexts for storing decoded tuples

2024-10-16 Thread Masahiko Sawada
On Tue, Oct 15, 2024 at 9:01 PM Amit Kapila wrote: > > On Tue, Oct 15, 2024 at 11:15 PM Masahiko Sawada > wrote: > > > > On Sun, Oct 13, 2024 at 11:00 PM Amit Kapila > > wrote: > > > > > > On Fri, Oct 11, 2024 at 3:40 AM Masahiko Sawada > > > wrote: > > > > > > > > Please find the attached p

Re: optimize hashjoin

2024-10-16 Thread Bruce Momjian
On Fri, Aug 23, 2024 at 08:17:26AM -0400, Robert Haas wrote: > On Fri, Aug 23, 2024 at 7:02 AM bucoo wrote: > > Howerver, the non-parallel hashjoin indeed showed about a 10% performance > > improvement. > >-> Hash Join (cost=508496.00..2302429.31 rows=47989008 width=0) > > (actual time=107

Failing assertion in predicate.c

2024-10-16 Thread Yurii Rashkovskii
Hi pg-hackers, I am encountering an assertion failure in predicate.c when running a high volume of short serializable transactions. The error occurs during stress testing with many concurrent connections. I have replicated this issue on two separate macOS M1 systems, but I have not been able to r

Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description

2024-10-16 Thread Bruce Momjian
On Mon, Sep 9, 2024 at 01:15:32PM +1000, Peter Smith wrote: > On Mon, Sep 9, 2024 at 12:20 PM David G. Johnston > wrote: > > > > > > > > On Sun, Sep 8, 2024, 18:55 Peter Smith wrote: > >> > >> Saying "The time..." is fine, but the suggestions given seem backwards to > >> me: > >> - The time thi

Re: allowing extensions to control planner behavior

2024-10-16 Thread Robert Haas
On Mon, Oct 14, 2024 at 6:02 AM Jakub Wartak wrote: >> I wonder if we could think about reversing the order of operations >> here and making it so that we do the distinct-ification during parse >> analysis or maybe early in planning, so that the name you see EXPLAIN >> print out is the real name o

Re: Misleading error "permission denied for table"

2024-10-16 Thread Tom Lane
Nathan Bossart writes: > On Wed, Oct 16, 2024 at 07:36:29PM +0530, Ashutosh Bapat wrote: >> Shouldn't we report "permission defined for column atest5.three? > We do have "permission denied for column" messages in aclchk.c (e.g., > aclcheck_error_col()), but I don't see them actually used anywhere

Re: New "raw" COPY format

2024-10-16 Thread Daniel Verite
Joel Jacobson wrote: > However, I thinking rejecting such column data seems like the > better alternative, to ensure data exported with COPY TO > can always be imported back using COPY FROM, > for the same format. On the other hand, that might prevent cases where we want to export, for i

Re: ECPG cleanup and fix for clang compile-time problem

2024-10-16 Thread Tom Lane
Alexander Lakhin writes: > Maybe you would like to fix in passing several (not new) defects, I've > found while playing with ecpg under Valgrind: Done. After evaluation I concluded that none of these were worth the trouble to back-patch, but by all means let's fix such things in HEAD.

Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch)

2024-10-16 Thread Shayon Mukherjee
On Oct 15, 2024, at 7:25 PM, David Rowley wrote:On Wed, 16 Oct 2024 at 03:40, Robert Haas wrote:On Sat, Oct 12, 2024 at 5:56 AM Shayon Mukherjee wrote:Thank you for sharing this Robert. I like the idea behind "allowing extensions to control planner behavior” overall and I think it does help towa

Re: Misleading error "permission denied for table"

2024-10-16 Thread Nathan Bossart
On Wed, Oct 16, 2024 at 07:36:29PM +0530, Ashutosh Bapat wrote: > In privileges.sql there are tests for column level privileges e.g. > > INSERT INTO atest5(two) VALUES (6) ON CONFLICT (two) DO UPDATE set > three = 10 RETURNING atest5.three; > ERROR: permission denied for table atest5 > > In the

Re: New "raw" COPY format

2024-10-16 Thread Jacob Champion
On Tue, Oct 15, 2024 at 1:38 PM Joel Jacobson wrote: > > However, I thinking rejecting such column data seems like the > better alternative, to ensure data exported with COPY TO > can always be imported back using COPY FROM, > for the same format. If text column data contains newlines, > users pro

Re: Large expressions in indexes can't be stored (non-TOASTable)

2024-10-16 Thread Nathan Bossart
On Wed, Oct 16, 2024 at 10:24:32AM +0900, Michael Paquier wrote: > On Tue, Oct 15, 2024 at 08:20:17PM -0500, Nathan Bossart wrote: >> I assume all of this will get compiled out in non-USE_ASSERT_CHECKING >> builds as-is, but I see no problem with surrounding it with an #ifdef to be >> sure. > > Ye

Re: Add support to TLS 1.3 cipher suites and curves lists

2024-10-16 Thread Jacob Champion
On Tue, Oct 15, 2024 at 3:42 AM Daniel Gustafsson wrote: > Thanks! I think the v8 posted todays is about ready to go in and unless there > are objections I'll go ahead with it shortly. This new paragraph is missing a close-paren: > + > + Additionally, LibreSSL is supported >

Re: sunsetting md5 password support

2024-10-16 Thread Nathan Bossart
On Fri, Oct 11, 2024 at 04:36:27PM -0500, Nathan Bossart wrote: > Here is a first attempt at a patch for marking MD5 passwords as deprecated. > It's quite bare-bones at the moment, so I anticipate future revisions will > add more content. Besides sprinkling several deprecation notices > throughout

Re: BitmapHeapScan streaming read user and prelim refactoring

2024-10-16 Thread Tomas Vondra
Hi, I took a quick look on the first couple parts of this series, up to 0007. I only have a couple minor review comments: 1) 0001 I find it a bit weird that we use ntuples to determine if it's exact or lossy. Not an issue caused by this patch, of course, but maybe we could improve that somehow?

Re: Doc: shared_memory_size_in_huge_pages with the "SHOW" command.

2024-10-16 Thread Nathan Bossart
On Wed, Oct 16, 2024 at 03:31:05PM +0900, Fujii Masao wrote: > Another idea is to use the same wording as for num_os_semaphores in > runtime.sgml, like this: > > This parameter can be viewed > before starting the server with a postgres command > like: WFM -- nathan

Re: System views for versions reporting

2024-10-16 Thread Tom Lane
Joe Conway writes: > On 10/16/24 08:47, Peter Eisentraut wrote: >> That way, you can get this information without having to start a server >> instance. (Maybe you can't start a server instance because it just >> crashed because of some library version issue ...) > While it is also useful to be a

Misleading error "permission denied for table"

2024-10-16 Thread Ashutosh Bapat
Hi hackers, In privileges.sql there are tests for column level privileges e.g. INSERT INTO atest5(two) VALUES (6) ON CONFLICT (two) DO UPDATE set three = 10 RETURNING atest5.three; ERROR: permission denied for table atest5 In the above case the current user regress_priv_user4, doesn't have privi

Re: Doc: typo in config.sgml

2024-10-16 Thread Bruce Momjian
On Wed, Oct 16, 2024 at 09:58:23AM +0200, Peter Eisentraut wrote: > On 15.10.24 23:51, Bruce Momjian wrote: > > > I don't see why we need to enforce this at this level. Whatever > > > downstream > > > toolchain has requirements about which characters are allowed will > > > complain > > > if it e

Re: Doc: typo in config.sgml

2024-10-16 Thread Bruce Momjian
On Wed, Oct 16, 2024 at 10:00:15AM +0200, Peter Eisentraut wrote: > On 15.10.24 23:51, Bruce Momjian wrote: > > On Tue, Oct 15, 2024 at 05:27:49PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Well, we can only use Latin-1, so the idea is that we will be explicit > > > > about specify

Re: System views for versions reporting

2024-10-16 Thread Joe Conway
On 10/16/24 08:47, Peter Eisentraut wrote: On 06.10.24 17:36, Dmitry Dolgov wrote: Based on the feedback in [1], here is my attempt at implementing system views for versions reporting. It adds pg_system_versions for showing things like core version, compiler, LLVM, etc, and pg_system_libraries f

Re: Proposal to Enable/Disable Index using ALTER INDEX

2024-10-16 Thread Robert Haas
On Wed, Oct 16, 2024 at 8:33 AM Peter Eisentraut wrote: > > Yeah, I'd be inclined to implement this by having create_index_paths > > just not make any paths for rejected indexes. Or you could back up > > another step and keep plancat.c from building IndexOptInfos for them. > > The latter might ha

Re: System views for versions reporting

2024-10-16 Thread Peter Eisentraut
On 06.10.24 17:36, Dmitry Dolgov wrote: Based on the feedback in [1], here is my attempt at implementing system views for versions reporting. It adds pg_system_versions for showing things like core version, compiler, LLVM, etc, and pg_system_libraries for showing linked shared objects. Is a sys

Re: Proposal to Enable/Disable Index using ALTER INDEX

2024-10-16 Thread Peter Eisentraut
On 24.09.24 20:21, Tom Lane wrote: Peter Eisentraut writes: On 23.09.24 22:51, Shayon Mukherjee wrote: I am happy to draft a patch for this as well. I think I have a working idea so far of where the necessary checks might go. However if you don’t mind, can you elaborate further on how the effe

Re: Vacuum statistics

2024-10-16 Thread Andrei Zubkov
Hi Ilia, On Wed, 2024-10-16 at 13:31 +0300, Ilia Evdokimov wrote: > BTW, I recommend renaming the view pg_stat_vacuum_database to > pg_stat_vacuum_databaseS  for consistency with pg_stat_vacuum_tables > and pg_stat_vacuum_indexes Such renaming doesn't seems correct to me because pg_stat_vacuum_da

Re: replace strtok()

2024-10-16 Thread Ranier Vilela
Em qua., 16 de out. de 2024 às 04:45, Peter Eisentraut escreveu: > On 15.10.24 14:07, Ranier Vilela wrote: > > I also wonder, if other places touched by 5d2e1cc11 need corrections > > too. > > I played with > > PG_COLOR=always PG_COLORS="error=01;31" .../initdb > > > > and it

Re: Add “FOR UPDATE NOWAIT” lock details to the log.

2024-10-16 Thread Fujii Masao
On 2024/09/13 20:49, Seino Yuki wrote: Hello, I would like to add the information of the PID that caused the failure when acquiring a lock with "FOR UPDATE NOWAIT". When "FOR UPDATE" is executed and interrupted by lock_timeout, xid and PID are output in the logs, Could you explain how to r

Re: Vacuum statistics

2024-10-16 Thread Alena Rybakina
Hi! On 16.10.2024 13:31, Ilia Evdokimov wrote: On 08.10.2024 19:18, Alena Rybakina wrote: Made a rebase on a fresh master branch. -- Regards, Alena Rybakina Postgres Professional Thank you for rebasing. I have noticed that when I create a table or an index on this table, there is no infor

Re: Vacuum statistics

2024-10-16 Thread Ilia Evdokimov
On 08.10.2024 19:18, Alena Rybakina wrote: Made a rebase on a fresh master branch. -- Regards, Alena Rybakina Postgres Professional Thank you for rebasing. I have noticed that when I create a table or an index on this table, there is no information about the table or index in pg_stat_vacuum

Re: BF mamba failure

2024-10-16 Thread Bertrand Drouvot
Hi, On Wed, Oct 16, 2024 at 09:43:48AM +0900, Michael Paquier wrote: > On Fri, Oct 11, 2024 at 08:18:58AM +, Bertrand Drouvot wrote: > > On Fri, Oct 11, 2024 at 11:07:29AM +0300, Kouber Saparev wrote: > >> Unfortunately not, we are running 15.4 and planning to upgrade very soon. > >> Is the pa

Re: ECPG Refactor: move sqlca variable in ecpg_log()

2024-10-16 Thread Fujii Masao
On 2024/10/16 15:04, Yuto Sasaki (Fujitsu) wrote: >Hmm, I'm not sure we want that, because if we do this, then >ECPGget_sqlca() gets run with the debug_mutex held.  In the original >coding, it's run without the mutex. Thank you for pointing that out. I agree with your observation. But ther

Re: Enable data checksums by default

2024-10-16 Thread Daniel Gustafsson
> On 16 Oct 2024, at 09:49, Peter Eisentraut wrote: > Ah yes, and the upgrade tests on the buildfarm don't like this. What shall > we do about this? Maybe adjust the buildfarm scripts to use > --no-data-checksums? I can't see many other options, and it represents a reasonable use-case, so +1

Re: Doc: typo in config.sgml

2024-10-16 Thread Peter Eisentraut
On 15.10.24 23:51, Bruce Momjian wrote: On Tue, Oct 15, 2024 at 05:27:49PM -0400, Tom Lane wrote: Bruce Momjian writes: Well, we can only use Latin-1, so the idea is that we will be explicit about specifying Latin-1 only as HTML entities, rather than letting non-Latin-1 creep in as UTF8. We c

Re: Doc: typo in config.sgml

2024-10-16 Thread Peter Eisentraut
On 15.10.24 23:51, Bruce Momjian wrote: I don't see why we need to enforce this at this level. Whatever downstream toolchain has requirements about which characters are allowed will complain if it encounters a character it doesn't like. Uh, the PDF build does not complain if you pass it a non-

Re: Enable data checksums by default

2024-10-16 Thread Peter Eisentraut
On 16.10.24 08:54, Peter Eisentraut wrote: On 14.10.24 11:28, Peter Eisentraut wrote: On 03.10.24 23:13, Nathan Bossart wrote: On Tue, Oct 01, 2024 at 11:15:02AM -0400, Peter Eisentraut wrote: I have committed 0001 (the new option) and 0004 (the docs tweak).  I think there is consensus for the

Re: replace strtok()

2024-10-16 Thread Peter Eisentraut
On 15.10.24 14:07, Ranier Vilela wrote: I also wonder, if other places touched by 5d2e1cc11 need corrections too. I played with PG_COLOR=always PG_COLORS="error=01;31" .../initdb and it looks like this free() call in pg_logging_init():        char       *colors = st

Re: New function normal_rand_array function to contrib/tablefunc.

2024-10-16 Thread Andy Fan
Hello Dean, Thanks for the detailed feedback! Here is the rebased version. > 1). In the tests: > > +select setseed(0.8); > +select rand_array(10, 0, 3, 50::int, 80::int); .. > this should really have a comment block to distinguish these new tests > from the preceeding normal_rand() tests. > 3

Re: replace strtok()

2024-10-16 Thread Peter Eisentraut
On 15.10.24 14:00, Alexander Lakhin wrote: I also wonder, if other places touched by 5d2e1cc11 need corrections too. I played with PG_COLOR=always PG_COLORS="error=01;31" .../initdb and it looks like this free() call in pg_logging_init():        char       *colors = strdup(pg_colors_env);

Re: Set query_id for query contained in utility statement

2024-10-16 Thread Anthonin Bonnefoy
On Tue, Oct 15, 2024 at 3:23 PM jian he wrote: > explain(verbose) SELECT 1, 2, 3\; explain SELECT 1, 2, 3, 4; > will transformed to > explain(verbose) SELECT 1, 2, 3; explain SELECT 1, 2, 3, 4; > > it seems to me your patch care about following position. > explain(verbose

Re: Remove deprecated -H option from oid2name

2024-10-16 Thread Daniel Gustafsson
> On 15 Oct 2024, at 22:48, Peter Eisentraut wrote: > > On 09.10.24 20:30, Daniel Gustafsson wrote: >>> On 9 Oct 2024, at 19:15, Nathan Bossart wrote: >>> Another problem is that "deprecated" may or may not imply that the feature >>> will be removed in the future. IMHO we should be clear about