Re: Adding error messages to a few slash commands

2025-04-12 Thread Pavel Luzanov
On 13.04.2025 08:29, Tom Lane wrote: Abhishek Chanda writes: Currently, some slash commands in psql return an error saying "Did not find any named " while some return an empty table. This patch changes a few of the slash commands to return a similar error message. +1 for this patch.

Re: AIO v2.5

2025-04-12 Thread Alexander Lakhin
Hello Andres, 07.04.2025 22:10, Alexander Lakhin wrote: I ran it for a while in a VM, it hasn't triggered yet. Neither on xfs nor on tmpfs. Before sharing the script I tested it on two my machines, but I had anticipated that the error can be hard to reproduce. Will try to reduce the reproducer

Re: Adding error messages to a few slash commands

2025-04-12 Thread Tom Lane
Abhishek Chanda writes: > Currently, some slash commands in psql return an error saying "Did not > find any named " while some return an empty table. This patch > changes a few of the slash commands to return a similar error message. Personally, if I were trying to make these things cons

Re: Adding error messages to a few slash commands

2025-04-12 Thread Abhishek Chanda
Sorry, I forgot to attach example usage. Here is how these currently behave: postgres=> \dT foo List of data types Schema | Name | Description +--+- (0 rows) postgres => \du foo List of roles Role name | Attributes ---+ postgres => \df foo

Adding error messages to a few slash commands

2025-04-12 Thread Abhishek Chanda
Hello hackers, Currently, some slash commands in psql return an error saying "Did not find any named " while some return an empty table. This patch changes a few of the slash commands to return a similar error message. I did not change all of the slash commands in this initial patch to wa

Re: Buildfarm: Enabling injection points on basilisk/dogfish (Alpine / musl)

2025-04-12 Thread Noah Misch
On Sat, Apr 12, 2025 at 07:51:06PM +0200, Wolfgang Walther wrote: > With injection points enabled, I get the following errors in test_aio: > > > [15:14:45.408](0.000s) not ok 187 - worker: first hard IO error is reported: > expected stderr > [15:14:45.409](0.000s) > [15:14:45.409](0.000s) #   Fai

Re: Non-text mode for pg_dumpall

2025-04-12 Thread Ranier Vilela
Hi Andrew. I just saw the fix commit. My fault. I'm sorry. best regards, Ranier Vilela

Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls

2025-04-12 Thread Mahendra Singh Thalor
On Sat, 12 Apr 2025 at 23:56, Andrew Dunstan wrote: > > > On 2025-04-11 Fr 1:36 PM, Mahendra Singh Thalor wrote: > > Hi, > > In the current master code, 3 places we are using appendStringInfoChar > > call with explicit type conversion into char. This is not needed as > > all other places, we are u

Re: Can we use Statistics Import and Export feature to perforamance testing?

2025-04-12 Thread Corey Huinker
> > You might be getting confused because the code does look at the > pg_class fields, but that's only to estimate the tuple density. When > pg_class has those estimates, they're used to calculate the estimated > density by doing reltuples / relpages, but that average rows per page > > Thanks for t

Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls

2025-04-12 Thread Andrew Dunstan
On 2025-04-11 Fr 1:36 PM, Mahendra Singh Thalor wrote: Hi, In the current master code, 3 places we are using appendStringInfoChar call with explicit type conversion into char. This is not needed as all other places, we are using direct character to append. --- a/src/backend/tcop/postgres.c +++

Buildfarm: Enabling injection points on basilisk/dogfish (Alpine / musl)

2025-04-12 Thread Wolfgang Walther
I recently enabled more features on my two buildfarm animals basilisk and dogfish, which are running on Alpine with musl-libc in a docker container. --with-libnuma and --with-liburing seemed to work fine and have been enabled for the last few runs, but --enable-injection-points does not [1].

RE: AIX support

2025-04-12 Thread Srirama Kucherlapati
Working on the patch. I will update you. -Sriram.

Automatically sizing the IO worker pool

2025-04-12 Thread Thomas Munro
It's hard to know how to set io_workers=3. If it's too small, io_method=worker's small submission queue overflows and it silently falls back to synchronous IO. If it's too high, it generates a lot of pointless wakeups and scheduling overhead, which might be considered an independent problem or no

RE: AIX support

2025-04-12 Thread Srirama Kucherlapati
Here are some stats wrt to loop and native memset after enabling optimization with the same test tool(tested for long and long align using MemSetAligned). Corresponding glibc is linked on PPcle and AIX libc is linked on AIX. https://postgrespro.com/list/thread-id/1673194

Re: [18] Unintentional behavior change in commit e9931bfb75

2025-04-12 Thread Noah Misch
On Mon, Dec 02, 2024 at 10:24:07PM -0800, Jeff Davis wrote: > On Mon, 2024-12-02 at 17:25 -0500, Tom Lane wrote: > > > Should I put the special case back? > > > > I think so. > > Done. I put the special case back in (commit e3fa2b037c) because the > earlier commit wasn't intended to be a behavio

Re: Can we use Statistics Import and Export feature to perforamance testing?

2025-04-12 Thread David Rowley
On Sat, 12 Apr 2025 at 20:29, Corey Huinker wrote: >> >> at the *actual size* of the relation and takes that into account when >> scaling the statistics (see table_block_relation_estimate_size() in >> tableam.c). If the table sizes don't match between the two servers >> then there's no guarantees

Re: someone else to do the list of acknowledgments

2025-04-12 Thread Corey Huinker
> > The whole thing might take about 20 to 30 hours wall-clock time. > After this dev cycle, things with a defined end to them hold a greater attraction than they did previously. > So, there is some time to think about this. Please discuss here if > you're interested or have questions. > I am

Re: Can we use Statistics Import and Export feature to perforamance testing?

2025-04-12 Thread Corey Huinker
> > * Question > > By using Statistics Import and Export feature, is it possible to achieve > the above request by following procedure? > > > > (1) Export the statistics from production environment by using pg_dump > --statistics-only. > > (2) On the staging environment, set the autovacuum related

Re: Can we use Statistics Import and Export feature to perforamance testing?

2025-04-12 Thread Corey Huinker
> > at the *actual size* of the relation and takes that into account when > scaling the statistics (see table_block_relation_estimate_size() in > tableam.c). If the table sizes don't match between the two servers > then there's no guarantees the planner will produce the same plan. > Sorry that I d

Re: ci: Allow running mingw tests by default via environment variable

2025-04-12 Thread Thomas Munro
On Tue, Apr 8, 2025 at 1:43 AM Andres Freund wrote: > On 2025-04-07 16:03:48 +0300, Nazir Bilal Yavuz wrote: > > On Wed, 5 Mar 2025 at 18:51, Andres Freund wrote: > > > I'm inclined to think we should apply to this to all branches with CI > > > support, > > > not just master. It's kind of annoyi