Re: [PATCH] PGSERVICEFILE as part of a normal connection string

2025-05-27 Thread Michael Paquier
On Sun, Apr 13, 2025 at 07:06:06PM +0900, Ryo Kanbayashi wrote: > I rebased our patch according to 2c7bd2ba507e. > https://commitfest.postgresql.org/patch/5387/ Thanks for the new version. -# for the connection options and their environment variables. +# for the connection options, servicefile o

Re: Replication slot is not able to sync up

2025-05-27 Thread Masahiko Sawada
On Tue, May 27, 2025 at 9:15 PM Zhijie Hou (Fujitsu) wrote: > > On Wed, May 28, 2025 at 2:09 AM Masahiko Sawada wrote: > > > > On Fri, May 23, 2025 at 10:07 PM Amit Kapila > > wrote: > > > > > > In the case presented here, the logical slot is expected to keep > > > forwarding, and in the consecut

foreign key on virtual generated column

2025-05-27 Thread jian he
hi. attached patch is implement a TODO (foreign key on virtual generated column) left on [1] for foreign key on virtual generated column, we only support ON UPDATE NO ACTION ON UPDATE RESTRICT ON DELETE CASCADE ON DELETE NO ACTION ON DELETE RESTRICT demo: CREATE TABLE gtest23a

RE: Replication slot is not able to sync up

2025-05-27 Thread Zhijie Hou (Fujitsu)
On Wed, May 28, 2025 at 2:09 AM Masahiko Sawada wrote: > > On Fri, May 23, 2025 at 10:07 PM Amit Kapila > wrote: > > > > In the case presented here, the logical slot is expected to keep > > forwarding, and in the consecutive sync cycle, the sync should be > > successful. Users using logical decod

Re: Speed up JSON escape processing with SIMD plus other optimisations

2025-05-27 Thread John Naylor
On Wed, May 28, 2025 at 10:18 AM David Rowley wrote: > I think we'll end up needing some SWAR code. There are plenty of > places where 16 bytes is too much to do at once. e.g. looking for the > delimiter character in a COPY FROM, 16 is likely too many when you're > important a bunch of smallish i

Re: queryId constant squashing does not support prepared statements

2025-05-27 Thread Michael Paquier
On Tue, May 27, 2025 at 05:05:39PM -0500, Sami Imseih wrote: > * 0001: > > This is a normalization issue discovered when adding new > tests for squashing. This is also an issue that exists in > v17 and likely earlier versions and should probably be > backpatched. > > The crux of the problem is if

Re: Speed up JSON escape processing with SIMD plus other optimisations

2025-05-27 Thread David Rowley
On Wed, 28 May 2025 at 11:24, John Naylor wrote: > https://lemire.me/blog/2025/04/13/detect-control-characters-quotes-and-backslashes-efficiently-using-swar/ > > I don't find this use of SWAR that bad for readability, and there's > only one obtuse clever part that merits a comment. Plus, it seems

Re: Large expressions in indexes can't be stored (non-TOASTable)

2025-05-27 Thread Michael Paquier
On Tue, May 27, 2025 at 03:02:52PM -0500, Nathan Bossart wrote: > Here is what I have staged for commit for the others. I'm hoping to push > these in the next couple of days. Thanks for the refreshed versions. Looks sensible to me overall. +static inline void +AssertHasSnapshotForToast(Relation

Re: Standardize the definition of the subtype field of AlterDomainStmt

2025-05-27 Thread wenhui qiu
HI Thank you for your update ,I marked the path as "Ready for Committer" Thank On Wed, May 28, 2025 at 10:27 AM Quan Zongliang wrote: > > > On 2025/5/27 11:54, Michael Paquier wrote: > > On Tue, May 27, 2025 at 11:06:46AM +0800, Quan Zongliang wrote: > >> I noticed that the subtype of AlterDo

Re: Standardize the definition of the subtype field of AlterDomainStmt

2025-05-27 Thread Quan Zongliang
On 2025/5/27 11:54, Michael Paquier wrote: On Tue, May 27, 2025 at 11:06:46AM +0800, Quan Zongliang wrote: I noticed that the subtype of AlterDomainStmt is directly using constants in the code. It is not conducive to the maintenance and reading of the code. Based on the definition of AlterTabl

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-27 Thread Fujii Masao
On 2025/05/26 16:55, ikedamsh wrote: 2025/05/21 12:54 Fujii Masao : On Mon, May 19, 2025 at 5:18 PM Masahiro Ikeda wrote: > > Thanks for your work and feedback! > > I've updated the patches and added regular regression tests for > both pg_prewarm and amcheck.

Re: Pathify RHS unique-ification for semijoin planning

2025-05-27 Thread Richard Guo
On Thu, May 22, 2025 at 4:05 PM Richard Guo wrote: > Therefore, I'm thinking that maybe we could create a new RelOptInfo > for the RHS rel to represent its unique-ified version, and then > generate all worthwhile paths for it, similar to how it's done in > create_distinct_paths(). Since this is l

Re: Fix slot synchronization with two_phase decoding enabled

2025-05-27 Thread Masahiko Sawada
On Sun, May 25, 2025 at 11:34 PM Nisha Moond wrote: > > to > On Fri, May 23, 2025 at 10:06 PM Masahiko Sawada > wrote: > > > > > > Here are review comments for v14 patch: > > > > Thank you for the review. > > > I think we need to include a basic test case where we simply create a > > subscripti

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Julien Rouhaud
On Wed, 28 May 2025, 07:21 Tom Lane, wrote: > Shaik Mohammad Mujeeb writes: > > So, I feel that if we can reliably detect when the backend is a > non-PostgreSQL server, it might be better to adjust the warning > accordingly, rather than relying on a client-server version comparison in > such cas

Re: queryId constant squashing does not support prepared statements

2025-05-27 Thread Sami Imseih
> I've spent a bit of time looking at this, and I want to > propose the following patchset. Sorry about this, but I missed to add a comment in one of the test cases for 0004 that describes the behavior of parameters and constants that live outside of the squashed list. The following 2 cases will

Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X

2025-05-27 Thread John Naylor
On Tue, May 27, 2025 at 3:24 AM Eduard Stefes wrote: > So I worked on the algorithm to also work on buffers between 16-64 > bytes. Then I ran the performance measurement on two > dataset[^raw_data_1] [^raw_data_2]. And created two diagrams > [^attachment]. > > my findings so far: > > - the optimiz

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Tom Lane
Shaik Mohammad Mujeeb writes: > So, I feel that if we can reliably detect when the backend is a > non-PostgreSQL server, it might be better to adjust the warning accordingly, > rather than relying on a client-server version comparison in such cases. The entire point of having a wire protocol is

Re: Speed up JSON escape processing with SIMD plus other optimisations

2025-05-27 Thread John Naylor
On Thu, May 23, 2024 at 8:24 AM David Rowley wrote: > Other things I considered were if doing 16 bytes at a time is too much > as it puts quite a bit of work into byte-at-a-time processing if just > 1 special char exists in a 16-byte chunk. I considered doing SWAR [1] > processing to do the job of

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Shaik Mohammad Mujeeb
Also, let’s say hypothetically that PgBouncer had a version like 17.2 - matching the psql (client) major version. In that case, the warning wouldn’t be shown at all, which might not be accurate either. So, I feel that if we can reliably detect when the backend is a non-PostgreSQL server, it m

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Shaik Mohammad Mujeeb
> Anyway, I'm minus quite a lot on silencing this warning, because > it is telling you about real problems you are likely to hit. +1 I just wanted to clarify that the concern here isn’t about the warning itself being shown, but rather about the reason it conveys, which can be a bit misleading.

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Tom Lane
"David G. Johnston" writes: > On Tue, May 27, 2025 at 3:08 PM Tom Lane wrote: >> Yeah. I'd say the fundamental problem is that pgbouncer is abusing >> the server_version parameter, which will break plenty of things >> besides psql --- pg_dump for instance > They proxy over the real server infor

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread David G. Johnston
On Tue, May 27, 2025 at 3:08 PM Tom Lane wrote: > "David G. Johnston" writes: > > psql has zero awareness of pgbouncer or any other non-PostgreSQL server > you > > might be able to point it to and establish a successful connection. The > > lack of a warning previously is probably more incorrect

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Tom Lane
"David G. Johnston" writes: > psql has zero awareness of pgbouncer or any other non-PostgreSQL server you > might be able to point it to and establish a successful connection. The > lack of a warning previously is probably more incorrect than its presence > now. Yeah. I'd say the fundamental pr

Re: queryId constant squashing does not support prepared statements

2025-05-27 Thread Sami Imseih
> > therefore, a user supplied query like this: > > ``` > > select where $5 in ($1, $2, $3) and $6 = $4 and 1 = 2 > > ``` > > > > will be normalized to: > > ``` > > select where $1 in ($2 /*...*/) and $3 = $4 and $5 = $6 > > ``` > > Hmm, interesting. > > I think this renumbering should not be a pro

Re: PG 18 release notes draft committed

2025-05-27 Thread Bruce Momjian
On Tue, May 27, 2025 at 09:26:41AM -0500, Nathan Bossart wrote: > For the "Deprecate MD5 password authentication" item, IMHO we should > emphasize that support for MD5 passwords will be removed in a future major > release, as we did for the 18beta1 announcement. Here's an attempt: > > Depre

Re: Non-reproducible AIO failure

2025-05-27 Thread Tom Lane
Andres Freund writes: > I'll see if being graphically logged in somehow indeed increased the repro > rate, and if so I'll expand the debugging somewhat, or if this was just an > absurd coincidence. Hmm. Now that you mention it, the one repro on the M1 came just as I was about to give up and manu

Re: Fixing memory leaks in postgres_fdw

2025-05-27 Thread Tom Lane
Matheus Alcantara writes: > I think that we can delay the allocation a bit more. The > dblink_security_check just use the rconn to pfree in case of a failure, > so I think that we can remove this parameter and move the rconn > allocation to the next if (connname) block. See attached as an example.

Re: PG 18 release notes draft committed

2025-05-27 Thread Bruce Momjian
On Tue, May 27, 2025 at 08:13:24AM +1000, Peter Smith wrote: > Hi, > > There seems to be some unexpected ">" here: > > "E.1.3.7.3. Logical Replication Applications>" Yes, a mistake, fixed. -- Bruce Momjian https://momjian.us EDB https://enterpr

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Euler Taveira
On Tue, May 27, 2025, at 3:41 PM, Shaik Mohammad Mujeeb wrote: > In my case, *pset.sversion* ends up being *12001* (due to PgBouncer v1.20.1), > and since that’s less than *90200*, the warning gets triggered, which feels > misleading. But I was wondering - does it really make sense to compare >

Re: PG 18 release notes draft committed

2025-05-27 Thread Bruce Momjian
On Mon, May 26, 2025 at 10:20:08AM -0400, Joe Conway wrote: > On 5/23/25 09:47, Bruce Momjian wrote: > > On Fri, May 23, 2025 at 09:54:54AM +0200, Álvaro Herrera wrote: > > > I also think that showing an XML-ish format of a commit message is > > > unhelpful, not to mention hard to read. Showing a

Re: Fixing memory leaks in postgres_fdw

2025-05-27 Thread Matheus Alcantara
Hi, On 26/05/25 16:36, Tom Lane wrote: > Here's a v4 that is actually more or less feature-complete: > it removes no-longer-needed complexity such as PG_TRY blocks. > I've checked that Valgrind shows no leaks in the postgres_fdw > and dblink tests after applying this on top of my other > patch ser

Re: Large expressions in indexes can't be stored (non-TOASTable)

2025-05-27 Thread Nathan Bossart
On Thu, May 08, 2025 at 08:55:08AM +0900, Michael Paquier wrote: > On Wed, May 07, 2025 at 02:55:49PM -0500, Nathan Bossart wrote: >> Committed with that change. That takes care of a good chunk of these TOAST >> snapshot problems. I think there are about 4 others left, unless something >> has cha

Re: Tightening DecodeNumberField's parsing rules

2025-05-27 Thread Robert Haas
On Tue, May 27, 2025 at 2:38 PM Tom Lane wrote: > So what I propose we do about this is to apply the attached to HEAD > and leave the back branches alone. +1. In most cases, we pride ourselves on carefully validating the input we receive and people on this list have been known to disparage other

Re: Understanding when VM record needs snapshot conflict horizon

2025-05-27 Thread Melanie Plageman
On Sun, May 25, 2025 at 6:45 AM Dilip Kumar wrote: > > IMHO, if we include snapshot conflict horizon in cases where it is not > necessary, don't you think it will impact performance on standby? > because now it has to loop through the procarray on standby to check > whether there is any conflict b

Re: Non-reproducible AIO failure

2025-05-27 Thread Robert Haas
On Sun, May 25, 2025 at 8:25 PM Tom Lane wrote: > The fact that I can trace through this Assert failure but not the > AIO one strongly suggests some system-level problem in the latter. > There is something rotten in the state of Denmark. I have been quite frustrated with lldb on macOS for a while

Re: Non-reproducible AIO failure

2025-05-27 Thread Andres Freund
Hi, On 2025-05-27 14:43:14 -0400, Tom Lane wrote: > Andres Freund writes: > > I just meant that it seems that I can't reproduce it for some as of yet > > unknown reason. I've now been through 3k+ runs of 027_stream_regress, > > without > > a single failure, so there has to be *something* differe

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

2025-05-27 Thread Masahiko Sawada
On Fri, May 23, 2025 at 1:53 PM Melanie Plageman wrote: > > On Fri, May 23, 2025 at 12:41 PM Masahiko Sawada > wrote: > > > > I'll remove that part and push early next week, barring any objections. > > Great, thanks so much! Pushed the fix and closed the open item. Thank you for reviewing the p

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread David G. Johnston
On Tue, May 27, 2025 at 11:41 AM Shaik Mohammad Mujeeb < mujeeb...@zohocorp.com> wrote: > After the commit cf0cab868a, introduced in PG15, I noticed that when > connecting to the 'pgbouncer' database via Pgbouncer, the following warning > is shown: > > psql (17.2, server 1.20.1/bouncer) > WARNING:

Re: Non-reproducible AIO failure

2025-05-27 Thread Tom Lane
Andres Freund writes: > I just meant that it seems that I can't reproduce it for some as of yet > unknown reason. I've now been through 3k+ runs of 027_stream_regress, without > a single failure, so there has to be *something* different about my > environment than yours. > Darwin m4-dev 24.1.0 Da

Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Shaik Mohammad Mujeeb
Hi Hackers, I was hoping to get some clarification regarding a behaviour I observed while connecting to the special 'pgbouncer' database used for administering or monitoring Pgbouncer. After the commit cf0cab868a, introduced in PG15, I noticed that when connecting to the 'pgbouncer' databa

Tightening DecodeNumberField's parsing rules

2025-05-27 Thread Tom Lane
Evgeniy Gorbanev reported to the security list that he'd found a case where timestamp_in triggered an undefined-behavior sanitizer warning, due to trying to store a float value larger than INT_MAX into an integer variable. We concluded that there's no real security issue there, it's just that the

Re: Doc: section "8.21. Pseudo-Types" needs a bit of clarification?

2025-05-27 Thread David G. Johnston
On Tue, May 27, 2025 at 11:15 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > While reading our documentation about pseudo-types [1] I noticed that it > says: > > """ > anyelement - Indicates that a function accepts any data type > anyarray - Indicates that a function accepts any array

Re: Non-reproducible AIO failure

2025-05-27 Thread Andres Freund
Hi, On 2025-05-27 10:12:28 -0400, Tom Lane wrote: > Andres Freund writes: > > This is on a m4 mac mini. I'm wondering if there's some hardware specific > > memory ordering issue or disk speed based timing issue that I'm just not > > hitting. > > I dunno, I've seen it on three different physical

Doc: section "8.21. Pseudo-Types" needs a bit of clarification?

2025-05-27 Thread Aleksander Alekseev
Hi, While reading our documentation about pseudo-types [1] I noticed that it says: """ anyelement - Indicates that a function accepts any data type anyarray - Indicates that a function accepts any array data type """ This may give an impression that anyelement and anyarray can be used as an argu

Re: Replication slot is not able to sync up

2025-05-27 Thread Masahiko Sawada
On Fri, May 23, 2025 at 10:07 PM Amit Kapila wrote: > > In the case presented here, the logical slot is expected to keep > forwarding, and in the consecutive sync cycle, the sync should be > successful. Users using logical decoding APIs should also be aware > that if due for some reason, the logic

Re: Automatically sizing the IO worker pool

2025-05-27 Thread Dmitry Dolgov
On Mon, May 26, 2025, 8:01 AM Thomas Munro wrote: > But ... I'm not even sure if we can say that our > I/O arrivals have a Poisson distribution, since they are not all > independent. > Yeah, a good point, one have to be careful with assumptions about distribution -- from what I've read many proc

Re: queryId constant squashing does not support prepared statements

2025-05-27 Thread Álvaro Herrera
On 2025-May-24, Sami Imseih wrote: > therefore, a user supplied query like this: > ``` > select where $5 in ($1, $2, $3) and $6 = $4 and 1 = 2 > ``` > > will be normalized to: > ``` > select where $1 in ($2 /*...*/) and $3 = $4 and $5 = $6 > ``` Hmm, interesting. I think this renumbering should

Re: Make wal_receiver_timeout configurable per subscription

2025-05-27 Thread Fujii Masao
On 2025/05/22 21:21, Amit Kapila wrote: On Wed, May 21, 2025 at 6:04 PM Fujii Masao wrote: On 2025/05/20 18:13, vignesh C wrote: If we set the wal_receiver_timeout configuration using ALTER ROLE for the subscription owner's role, the apply worker will start with that value. However, any cha

Re: POC: make mxidoff 64 bits

2025-05-27 Thread Maxim Orlov
On Tue, 29 Apr 2025 at 15:01, Ashutosh Bapat wrote: > > I notice that transam/README does not mention multixact except one place > in section "Transaction Emulation during Recovery". I expected it to > document how pg_multixact/members and pg_multixact/offset are used and what > is their layout.

Re: Cygwin support

2025-05-27 Thread Ken Marshall
On Tue, May 27, 2025 at 10:53:55AM -0400, Andrew Dunstan wrote: > > On 2025-04-28 Mo 4:53 PM, Mark Woodward wrote: > > What are the economics of this? I used PostgreSQL and Cygwin 25 years > > ago and am amazed it is still a thing. > > How much effort is it to support PostgreSQL on Cygwin? > > How

Re: Non-reproducible AIO failure

2025-05-27 Thread Alexander Lakhin
Hello hackers, 27.05.2025 16:35, Andres Freund пишет: On 2025-05-25 20:05:49 -0400, Tom Lane wrote: Thomas Munro writes: Could you guys please share your exact repro steps? I've just been running 027_stream_regress.pl over and over. It's not a recommendable answer though because the failure p

Re: Cygwin support

2025-05-27 Thread Andrew Dunstan
On 2025-04-28 Mo 4:53 PM, Mark Woodward wrote: What are the economics of this? I used PostgreSQL and Cygwin 25 years ago and am amazed it is still a thing. How much effort is it to support PostgreSQL on Cygwin? How many actual users are using PostgreSQL on cygwin in production? (I should hope

Re: PG 18 release notes draft committed

2025-05-27 Thread Nathan Bossart
For the "Deprecate MD5 password authentication" item, IMHO we should emphasize that support for MD5 passwords will be removed in a future major release, as we did for the 18beta1 announcement. Here's an attempt: Deprecate MD5 password authentication (Nathan Bossart) Support for M

Re: All supported PostgreSQL 17 extensions list

2025-05-27 Thread Laurenz Albe
On Tue, 2025-05-27 at 18:01 +0500, Zaid Shabbir wrote: > I’m looking for a complete list of PostgreSQL 17 extensions — both open-source > and proprietary. I found a link, but it doesn’t seem to include all available > extensions. > > Is there an official or community-maintained source where I can

Re: Non-reproducible AIO failure

2025-05-27 Thread Alexander Lakhin
Hello Tomas, 27.05.2025 16:26, Tomas Vondra wrote: I'm interested in how you run these tests in parallel. Can you share the patch/script? Yeah, sure. I'm running the test as follows: rm -rf src/test/recovery_*; for i in `seq 40`; do cp -r src/test/recovery/ src/test/recovery_$i/; sed -i .bak

Re: Non-reproducible AIO failure

2025-05-27 Thread Tom Lane
Andres Freund writes: > This is on a m4 mac mini. I'm wondering if there's some hardware specific > memory ordering issue or disk speed based timing issue that I'm just not > hitting. I dunno, I've seen it on three different physical machines now (one M1, two M4 Pros). But it is darn hard to re

Re: Non-reproducible AIO failure

2025-05-27 Thread Tom Lane
Thomas Munro writes: > Could you please share your configure options? The failures on indri and sifaka were during ordinary buildfarm runs, you can check the animals' details on the website. (Note those are same host machine, the difference is that indri uses some MacPorts packages while sifaka i

Re: All supported PostgreSQL 17 extensions list

2025-05-27 Thread Chapman Flack
On 05/27/25 09:29, Laurenz Albe wrote: > There is no "supported". Each extension has to support itself. > An exception are the "contrib" extensions shipped with PostgreSQL: > they are supported by the PGDG. > > There is also no complete list of extensions that I am aware of. There is some info i

Re: All supported PostgreSQL 17 extensions list

2025-05-27 Thread Florents Tselai
> On 27 May 2025, at 4:29 PM, Laurenz Albe wrote: > > On Tue, 2025-05-27 at 18:01 +0500, Zaid Shabbir wrote: >> I’m looking for a complete list of PostgreSQL 17 extensions — both >> open-source >> and proprietary. I found a link, but it doesn’t seem to include all >> available extensions. >>

Re: Conflict detection for update_deleted in logical replication

2025-05-27 Thread Amit Kapila
On Tue, May 27, 2025 at 3:59 PM shveta malik wrote: > > On Mon, May 26, 2025 at 12:46 PM Zhijie Hou (Fujitsu) > wrote: > > > > Attaching the V32 patch set which addressed comments in [1]~[5]. > > Thanks for the patch, I am still reviewing the patches, please find > few trivial comments for patch0

Re: Non-reproducible AIO failure

2025-05-27 Thread Tomas Vondra
On 5/24/25 23:00, Alexander Lakhin wrote: > ... > > I'm yet to see the Assert triggered on the buildfarm, but this one looks > interesting too. > > (I can share the complete patch + script for such testing, if it can be > helpful.) > I'm interested in how you run these tests in parallel. Can

Re: Non-reproducible AIO failure

2025-05-27 Thread Andres Freund
Hi, On 2025-05-25 20:05:49 -0400, Tom Lane wrote: > Thomas Munro writes: > > Could you guys please share your exact repro steps? > > I've just been running 027_stream_regress.pl over and over. > It's not a recommendable answer though because the failure > probability is tiny, under 1%. It sound

Re: Non-reproducible AIO failure

2025-05-27 Thread Thomas Munro
On Mon, May 26, 2025 at 12:05 PM Tom Lane wrote: > Thomas Munro writes: > > Could you guys please share your exact repro steps? > > I've just been running 027_stream_regress.pl over and over. > It's not a recommendable answer though because the failure > probability is tiny, under 1%. It sounded

All supported PostgreSQL 17 extensions list

2025-05-27 Thread Zaid Shabbir
Hello Hackers, I’m looking for a complete list of PostgreSQL 17 extensions — both open-source and proprietary. I found a link , but it doesn’t seem to include all available extensions. Is there an official or community-maintai

Re: Init connection time grows quadratically

2025-05-27 Thread Matthias van de Meent
On Tue, 27 May 2025 at 12:45, Потапов Александр wrote: > > Hello! > > I ran some experiments with pgbench to measure the initialization time and > found that the time increases quadratically with the number of clients. It > was surprising to me and I would like to understand a reason of such beh

Support specifying compression level in wal_compression

2025-05-27 Thread Nikolay Samokhvalov
I thought it makes sense to extend wal_compression to support compression levels. The patch replaces the simple enum-based setting with string-based 'method[:level]' syntax, similar to the --compress option in pg_dump. What's inside: - Unified GUC design: wal_compression = 'method[:level]' - Supp

Re: Init connection time grows quadratically

2025-05-27 Thread Потапов Александр
Sorry, I forgot to add the table and graph for point #8 The graph is attached.  This is the table: -- | Number of clients  |  Average init time, ms | -- |            1024             |        ~435 +-20

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-05-27 Thread Amit Kapila
On Tue, May 27, 2025 at 2:48 PM Alexander Korotkov wrote: > > On Tue, May 27, 2025 at 12:12 PM Alexander Korotkov > wrote: > > > > On Tue, May 27, 2025 at 7:08 AM Amit Kapila wrote: > > > On Mon, May 26, 2025 at 10:36 PM Alexander Korotkov > > > wrote: > > > > > > > > On Mon, May 26, 2025 at 2:

Re: ZStandard (with dictionaries) compression support for TOAST compression

2025-05-27 Thread Nikhil Kumar Veldanda
On Wed, May 7, 2025 at 5:38 PM Michael Paquier wrote: > Yes, I was wondering if this is not the most natural approach in terms > of structure once if we plug an extra byte into the varlena header if > all the bits of va_extinfo for the compression information are used. > Having all the bits may no

Init connection time grows quadratically

2025-05-27 Thread Потапов Александр
Hello!   I ran some experiments with pgbench to measure the initialization time and found that the time increases quadratically with the number of clients. It was surprising to me and I would like to understand a reason of such behavior.   Some details on how it was done:   1) I used the branch

Re: Conflict detection for update_deleted in logical replication

2025-05-27 Thread shveta malik
On Mon, May 26, 2025 at 12:46 PM Zhijie Hou (Fujitsu) wrote: > > Attaching the V32 patch set which addressed comments in [1]~[5]. Thanks for the patch, I am still reviewing the patches, please find few trivial comments for patch001: 1) + FullTransactionId last_phase_at; /* publisher transaction

Suggestion : support for environment variable in initdb to set the superuser password

2025-05-27 Thread Reda Agaoua
Hi, The initdb command currently supports prompting for the superuser password using --pwprompt or reading it from a file using --pwfile. I’m wondering if it might also make sense to allow specifying the password via an environment variable. I do believe it can be useful in a variety of settings,

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-05-27 Thread Alexander Korotkov
On Tue, May 27, 2025 at 12:12 PM Alexander Korotkov wrote: > > On Tue, May 27, 2025 at 7:08 AM Amit Kapila wrote: > > On Mon, May 26, 2025 at 10:36 PM Alexander Korotkov > > wrote: > > > > > > On Mon, May 26, 2025 at 2:43 PM Amit Kapila > > > wrote: > > > > > > > > On Mon, May 26, 2025 at 3:52

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-05-27 Thread Alexander Korotkov
On Tue, May 27, 2025 at 7:08 AM Amit Kapila wrote: > On Mon, May 26, 2025 at 10:36 PM Alexander Korotkov > wrote: > > > > On Mon, May 26, 2025 at 2:43 PM Amit Kapila wrote: > > > > > > On Mon, May 26, 2025 at 3:52 PM Vitaly Davydov > > > wrote: > > > > > OTOH, if we don't want to adjust physic

Re: Prevent internal error at concurrent CREATE OR REPLACE FUNCTION

2025-05-27 Thread Yugo Nagata
On Tue, 27 May 2025 08:33:42 +0200 Jim Jones wrote: > Hi Yugo > > On 26.05.25 18:39, Yugo Nagata wrote: > > I can see the error when two concurrent transactions issue > > "alter function f() immutable". > > > I might have missed something in my last tests... I could now reproduce > the behavio

RE: Review/Pull Request: Adding new CRC32C implementation for IBM S390X

2025-05-27 Thread Eduard Stefes
Hi, So I worked on the algorithm to also work on buffers between 16-64 bytes. Then I ran the performance measurement on two dataset[^raw_data_1] [^raw_data_2]. And created two diagrams [^attachment]. my findings so far: - the optimized crc32cvx is faster - the sb8 performance is heavily dependi

Re: Add pg_get_injection_points() for information of injection points

2025-05-27 Thread Michael Paquier
On Sun, May 25, 2025 at 03:59:51AM +, Rustam ALLAKOV wrote: > to match how `unicode_version` function is documented > > Returns a string representing the version of Unicode used by ICU, if > > the server was built with ICU support; otherwise returns Makes sense, with the difference that the fu

Re: Conflict detection for update_deleted in logical replication

2025-05-27 Thread Amit Kapila
On Mon, May 26, 2025 at 12:46 PM Zhijie Hou (Fujitsu) wrote: > > On Sun, May 25, 2025 at 4:36 PM Dilip Kumar wrote: > > > > > I am thinking can't we make it more deterministic such that when we > > get the status first time if we find some transactions that are in > > commit phase then we should j