Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid

Hi Fujii-san, Thanks for working on this. On Sat, Aug 2, 2025 at 5:48 PM Fujii Masao wrote: > > Hi, > > It looks like pg_dump --filter can mistakenly treat invalid object types > in the filter file as valid ones. For example, the invalid type "table-data" > (probably a typo for "table_data") is

Re: Why our Valgrind reports suck

I wrote: > Richard Guo writes: >> This is very useful work; I hope we can get it in soon. > Thanks for looking at it! Pushed, after squashing related commits, changing the pq_mq_handle bit as you suggested, and fixing one more leak report that I don't think was there in May. There's still work

Re: Assertion failure in pgbench

On Fri, Aug 1, 2025 at 8:55 PM Fujii Masao wrote: > Unless there are any objections, I plan to commit this and > back-patch to v15. I've pushed the patch. Thanks! Regards, -- Fujii Masao

Re: Trivial patch to fix a typo

Hi Michael, Thank you so much for your help. I am new to PG development, I'll keep learning. :) Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Michael Paquier 于2025年8月2日周六 18:55写道： > On Fri, Aug 01, 2025 at 03:16:18PM +0800, Chao Li wrote: > > Ah ..

V18 release Notes typo

The V18 Release notes contain this: Allow inactive replication slots to be automatically invalided using server variable idle_replication_slot_timeout (Nisha Moond, Bharath Rupire

Re: [PATCH] Proposal to Enable/Disable Index using ALTER INDEX

Hello, > On Jul 23, 2025, at 9:43 PM, Michael Paquier wrote: > > On Tue, Jul 22, 2025 at 01:15:16PM -0500, Sami Imseih wrote: >> The GUC serves multiple purposes. For example,I can create an index as >> invisible >> and use it in a controlled way, which is helpful for experimenting >> with a ne

Re: [PATCH] Proposal to Enable/Disable Index using ALTER INDEX

> On Jul 15, 2025, at 1:58 PM, Robert Treat wrote: > > On Tue, Jul 15, 2025 at 8:19 AM Shayon Mukherjee wrote: >> On Jun 23, 2025, at 10:14 AM, Robert Treat wrote: >> Glad to hear you are still interested, slightly disheartened by the >> general lack of concern around operational safety in t

Re: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote: > These were introduced (commit efdc7d74753) at the same time as we were > moving to using the standard inttypes.h format macros (commit a0ed19e0a9e). > It doesn't seem useful to keep a new already-deprecated interface like this > wi

Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid

On Sat, Aug 2, 2025 at 3:18 PM Fujii Masao wrote: > Hi, > > It looks like pg_dump --filter can mistakenly treat invalid object types > in the filter file as valid ones. For example, the invalid type > "table-data" > (probably a typo for "table_data") is incorrectly recognized as "table", > and pg

Re: pg_dump --with-* options

On Sat, 2025-08-02 at 22:58 +0900, Fujii Masao wrote: > I'm OK with this approach. Thanks for the patch! It looks good to me. Thank you for the review. > -   bool    statistics_only = false; > +   static int  statistics_only = 0; Agreed. That can just be done for 19 though.

Re: pg_dump --with-* options

On Fri, 2025-08-01 at 17:46 -0500, Nathan Bossart wrote: > On Fri, Aug 01, 2025 at 12:42:16PM -0700, Jeff Davis wrote: > > -  --with-statistics > > +  --statistics > > > -  --with-statistics > > +  --statistics > > > -  --with-statistics > > +  --statistics > > nitpick: -

Re: pg_dump --with-* options

On Sat, Aug 2, 2025 at 4:42 AM Jeff Davis wrote: > Patch attached. > > * removes --with-data and --with-schema (redundant) > * renames --with-statistics to just --statistics > > I kept --statistics and --no-statistics for both pg_dump and > pg_restore, because: (a) I think it's good to have co

Re: Dropping publication breaks logical replication

On Fri, 1 Aug 2025 at 10:54, Ashutosh Bapat wrote: > > Hi Vignesh, Amit, > We encountered a situation where a customer dropped a publication > accidentally and that broke logical replication in an irrecoverable > manner. This is PG 15.3 but the team confirmed that the behaviour is > reproducible w

Re: Trivial patch to fix a typo

On Fri, Aug 01, 2025 at 03:16:18PM +0800, Chao Li wrote: > Ah ... Good to learn. Attached v2 updated the out file as well, now the > test passed: > > $ make check > ... > # All 229 tests passed. That's much better ;) Applied now down to v18. -- Michael signature.asc Description: PGP signature

Re: Document transition table triggers are not allowed on views/foreign tables

On Mon, Jul 28, 2025 at 2:14 PM Ashutosh Bapat wrote: > On Sat, Jul 26, 2025 at 4:59 PM Etsuro Fujita wrote: > > I updated the patch as above. I will push this version. > > LGTM. Pushed and back-patched. Thanks! Best regards, Etsuro Fujita

Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid

Hi, It looks like pg_dump --filter can mistakenly treat invalid object types in the filter file as valid ones. For example, the invalid type "table-data" (probably a typo for "table_data") is incorrectly recognized as "table", and pg_dump runs without error when it should fail. --

Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

These were introduced (commit efdc7d74753) at the same time as we were moving to using the standard inttypes.h format macros (commit a0ed19e0a9e). It doesn't seem useful to keep a new already-deprecated interface like this with only a few users, so remove the new symbols again and have the cal

Re: Improving tracking/processing of buildfarm test failures

Hello hackers, Please take a look at the July report on buildfarm failures: # SELECT br, COUNT(*) FROM failures WHERE dt >= '2025-07-01' AND  dt < '2025-08-01' GROUP BY br; REL_13_STABLE: 4 REL_14_STABLE: 2 REL_15_STABLE: 4 REL_16_STABLE: 3 REL_17_STABLE: 4 REL_18_STABLE: 9 master: 42 -- Total: 6