Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

On Tue, Aug 5, 2025 at 11:57 AM Peter Smith wrote: > > On Tue, Aug 5, 2025 at 2:28 PM vignesh C wrote: > > > > On Tue, 5 Aug 2025 at 05:35, Peter Smith wrote: > > > > > > Here is a v1 patch, where: > > > > > > - now user gets ERROR if the 'publish_generated_columns' parameter is > > > specified

Re: Dropping publication breaks logical replication

On Tue, Aug 5, 2025 at 9:50 AM Amit Kapila wrote: > > On Fri, Aug 1, 2025 at 5:06 PM Ashutosh Bapat > wrote: > > > > On Fri, Aug 1, 2025 at 4:03 PM Amit Kapila wrote: > > > > > > Now, seeing this report, it seems the customer(s) are probably okay to > > > skip a missing publication and let repli

Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

On Tue, Aug 5, 2025 at 2:28 PM vignesh C wrote: > > On Tue, 5 Aug 2025 at 05:35, Peter Smith wrote: > > > > Here is a v1 patch, where: > > > > - now user gets ERROR if the 'publish_generated_columns' parameter is > > specified without a value > > - regression tests are updated > > Few comments: >

Re: Raw parse tree is not dumped to log

CommitFests patch created: https://commitfest.postgresql.org/patch/5946/ > 2025年8月4日 16:17，Chao Li 写道： > > I just noticed that my IDE auto formatted guc_tables.c, which generated a lot > of unnecessary diffs. Recreated the patch, and attach the v2 version. > > Chao Li (Evan) >

Re: GB18030-2022 Support in PostgreSQL

> 2025年8月4日 21:51，Tom Lane wrote： > > > So on the whole I'd lean a bit towards just redefining GB18030 as > meaning the new standard. The fact that we don't support it as a > server-side encoding perhaps makes that idea more tenable than it > would be if the encoding governed the interpretati

Re: Improve pg_sync_replication_slots() to wait for primary to advance

On Tue, Aug 5, 2025 at 9:28 AM shveta malik wrote: > > On Mon, Aug 4, 2025 at 3:41 PM Amit Kapila wrote: > > > > On Mon, Aug 4, 2025 at 12:19 PM shveta malik wrote: > > If we want to avoid continuously syncing newly added slots in later > cycles and instead focus only on the ones that failed to

Re: PoC: adding CustomJoin, separate from CustomScan

On Fri, Jul 25, 2025 at 9:23 AM Tomas Vondra wrote: > I don't think CustomScans help with parser/grammar at all. It's just a > planner/executor node, it has no way to interact with parser. Maybe some > sort of "custom operator" would work, not sure. Not sure what exactly > you need in the planner.

Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

On Tue, 5 Aug 2025 at 05:35, Peter Smith wrote: > > Here is a v1 patch, where: > > - now user gets ERROR if the 'publish_generated_columns' parameter is > specified without a value > - regression tests are updated Few comments: 1) Generally in other case we throw the following error "option requi

Re: Dropping publication breaks logical replication

On Fri, Aug 1, 2025 at 5:06 PM Ashutosh Bapat wrote: > > On Fri, Aug 1, 2025 at 4:03 PM Amit Kapila wrote: > > > > Now, seeing this report, it seems the customer(s) are probably okay to > > skip a missing publication and let replication continue. So, we should > > consider backpatching this chang

Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions

> > > In the end, it seems we need to make all these functions in the below > query error safe. > select castsource::regtype, casttarget::regtype, castfunc, > castcontext,castmethod, pp.prosrc, pp.proname from pg_cast pc join pg_proc > pp on > pp.oid = pc.castfunc and pc.castfunc > 0 > order by cas

Re: Improve pg_sync_replication_slots() to wait for primary to advance

On Mon, Aug 4, 2025 at 3:41 PM Amit Kapila wrote: > > On Mon, Aug 4, 2025 at 12:19 PM shveta malik wrote: > > > > On Mon, Aug 4, 2025 at 11:31 AM Amit Kapila wrote: > > > > > > On Fri, Aug 1, 2025 at 2:50 PM shveta malik > > > wrote: > > > > > > > > 5) > > > > I tried a test where there were 4

Re: Improve LWLock tranche name visibility across backends

> > > With a local hash table, I don't think it's necessary to introduce new > > > code for managing > > > a DSA based list of tranche names as is done in v3. We can go back to > > > storing the shared > > > trance names in dshash. > > > > > > What do you think? > > > > My first thought is that a p

RE: Conflict detection for update_deleted in logical replication

On Monday, August 4, 2025 2:16 PM shveta malik wrote: > > On Fri, Aug 1, 2025 at 9:16 PM Zhijie Hou (Fujitsu) > wrote: > > > > > > Thanks for confirming. Here is V56 patch set which addressed all the > > comments including the comments from Amit[1] and Shveta[2]. > > > > I have merged V55-0002 i

psql: Count all table footer lines in pager setup

Here's a patch to fix the pager setup when printing tables with large footers, e.g., long view definitions. For testing create a view with many columns (50 in this example): select 'create view longview as select ' || string_agg('1 f' || s, ', ') from generate_series(1, 50) s

Re: CREATE OR REPLACE MATERIALIZED VIEW

Sorry for the late reply but I haven't had the time to dig into this. Here's v7 fixing the points below. On 2025-04-05 22:37 +0200, Tom Lane wrote: > * I think the proposal to deprecate IF NOT EXISTS is a nonstarter. > Yeah, I don't like it much, but the standard of proof to remove > features is a

Re: Doc: Add note for running ANALYZE after ALTER TABLE ... SET EXPRESSION

On Mon, 4 Aug 2025 20:01:34 +0900 Fujii Masao wrote: > On Mon, Aug 4, 2025 at 3:14 PM Yugo Nagata wrote: > > > > Hi, > > > > The documentation recommends running ANALYZE after the "ALTER TABLE ... SET > > DATA TYPE" > > command since the statistics will become wrong after that. > > > > That sam

Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid

On Mon, Aug 4, 2025 at 11:18 PM Fujii Masao wrote: > > On Sun, Aug 3, 2025 at 3:03 PM Xuneng Zhou wrote: > > After testing, the patch LGTM. I noticed two very small possible nits: > > Thanks for the review! > > > > 1) Comment wording > > > > The loop now calls isspace((unsigned char)*ptr), so a t

Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

Here is a v1 patch, where: - now user gets ERROR if the 'publish_generated_columns' parameter is specified without a value - regression tests are updated (docs are unchanged) == Kind Regards, Peter Smith. Fujitsu Australia v1-0001-CREATE-PUBLICATION-gencols-param-with-no-value.patch Descri

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

On Mon, Aug 4, 2025 at 3:38 AM shveta malik wrote: > > On Sat, Aug 2, 2025 at 4:53 AM Masahiko Sawada wrote: > > > > On Thu, Jul 31, 2025 at 5:00 AM Hayato Kuroda (Fujitsu) > > wrote: > > > > > > Dear Sawada-san, > > > > > > > I thought we could fix this issue by checking the number of in-use >

Re: Adding REPACK [concurrently]

Hello Álvaro, Should we skip non-ready indexes in build_new_indexes? Also, in the current implementation, concurrent mode is marked as non-MVCC safe. From my point of view, this is a significant limitation for practical use. Should we consider an option to exchange non-MVCC issues to short exclus

libpq-oauth: a mid-beta naming check

On Wed, Apr 30, 2025 at 10:59 AM Jacob Champion wrote: > > I still see the choice of naming (with its forced-ABI break > every major version) as needing more scrutiny, and probably worth a > Revisit entry. It is now time to revisit. = The Status Quo = The libpq-oauth module is loaded on-demand,

Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring

On Mon, Aug 4, 2025 at 1:16 AM Naga Appani wrote: > > Hi Ashutosh, Michael, > > Thanks for the detailed reviews. I have incorporated the feedback; > please find attached v2 and my responses inline below. > > On Fri, Jul 25, 2025 at 5:57 AM Ashutosh Bapat > wrote: > > > In [1], we decided to docum

Re: More protocol.h replacements this time into walsender.c

On Mon, Aug 04, 2025 at 02:11:26PM -0700, Jacob Champion wrote: > On Mon, Aug 4, 2025 at 12:56 PM Nathan Bossart > wrote: >> The replication protocol uses many of the >> existing PqMsg macros already, so it would be a little strange if only a >> subset of the replication protocol messages used th

Re: More protocol.h replacements this time into walsender.c

On Mon, Aug 4, 2025 at 12:56 PM Nathan Bossart wrote: > > The replication protocol uses many of the > existing PqMsg macros already, so it would be a little strange if only a > subset of the replication protocol messages used the special prefix. May I ask why? These messages are legitimately diff

Re: Improve LWLock tranche name visibility across backends

> On Mon, Aug 04, 2025 at 11:32:19AM -0500, Sami Imseih wrote: > > With a local hash table, I don't think it's necessary to introduce new > > code for managing > > a DSA based list of tranche names as is done in v3. We can go back to > > storing the shared > > trance names in dshash. > > > > What d

Re: Enable data checksums by default

On Fri, Aug 1, 2025 at 6:37 AM Ants Aasma wrote: > Even if we made the checksum algorithm itself faster, the main issue > is actually memory bandwidth. Intel server CPUs have about half the > bandwidth of AMD ones. A checksum has to pull in the whole page in a > few hundred cycles. Without checks

Re: More protocol.h replacements this time into walsender.c

On Mon, Aug 04, 2025 at 02:31:05PM +0200, Álvaro Herrera wrote: > +/* Replication Protocol, sent by the primary */ > + > +#define PqReplMsg_WALData'w' > +#define PqReplMsg_PrimaryKeepAlive 'k' > +#define PqReplMsg_PrimaryStatusUpdate's' > + > +/* Replic

Re: V18 release Notes typo

On 2025-08-02 Sa 4:57 PM, Andrew Dunstan wrote: The V18 Release notes contain this: Allow inactive replication slots to be automatically invalided using server variable idle_replication_slot_timeout

Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)

On Fri, Aug 1, 2025 at 4:03 AM Michael Paquier wrote: > - Addition of separate patch to rename varatt_external to > varatt_external_oid and VARTAG_ONDISK to VARTAG_ONDISK_OID, in 0003. > Since you're already renaming things... ISTM "ondisk" has the potential for confusion, assuming that at some

Re: Missing import in 035_standby_logical_decoding.pl

On Mon, Aug 4, 2025 at 3:49 AM Bertrand Drouvot wrote: > > On Fri, Aug 01, 2025 at 03:04:20PM -0400, Melanie Plageman wrote: > > > but it does not import usleep as other tests do (like this) > > use Time::HiRes qw(usleep); > > > > I think it simply hasn't been called because postgres exits and > >

Re: Improve LWLock tranche name visibility across backends

On Mon, Aug 04, 2025 at 11:32:19AM -0500, Sami Imseih wrote: > With a local hash table, I don't think it's necessary to introduce new > code for managing > a DSA based list of tranche names as is done in v3. We can go back to > storing the shared > trance names in dshash. > > What do you think? M

Re: Missing import in 035_standby_logical_decoding.pl

On Mon, Aug 4, 2025 at 3:52 AM Bertrand Drouvot wrote: > > On Sat, Aug 02, 2025 at 08:09:14AM +0900, Michael Paquier wrote: > > > Not the author of these two ones, but am I the only one who does not > > see the point of these two tests? These check that something does not > > happen, > > > > Woul

Re: GB18030-2022 Support in PostgreSQL

On Mon, Aug 04, 2025 at 04:08:24PM +0800, JiaoShuntian wrote: > Hi hackers, > > I noticed that PostgreSQL currently supports GB18030 encoding based on the > older GB18030-2000 standard (as seen in commits like extend GB18030 > conversion). However, China has since updated its mandatory character

Re: Improve LWLock tranche name visibility across backends

> > > I think we could add a local backend copy that stays up to date with the > > > DSA. One idea would be to use an atomic counter to track the number of > > > entries in the DSA and compare it with a local backend counter whenever > > > the > > > tranche name lookup occurs. If the atomic counte

Re: Typo in create_index regression test

On Mon, 4 Aug 2025 at 15:18, Tender Wang wrote: > > Dean Rasheed 于2025年8月4日周一 22:10写道： >> >> While looking at create_index.sql, I noticed the following: >> >> which isn't testing what it claims to test because there's a typo in >> the table name. Patch attached. > > Good catch. > LGTM. Pushed. T

Re: Improve LWLock tranche name visibility across backends

> > I think we could add a local backend copy that stays up to date with the > > DSA. One idea would be to use an atomic counter to track the number of > > entries in the DSA and compare it with a local backend counter whenever the > > tranche name lookup occurs. If the atomic counter is higher (si

Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events

On Mon, Aug 4, 2025 at 7:53 AM Thomas Munro wrote: > [FYI, I'm looking into this and planning to post a review in 1-2 days...] Thanks so much! --Jacob

Re: set role issue

Thank you for clarifying this point. And yes of course grantor, sorry for the confusion. Regards, Fabrice On Mon, Aug 4, 2025 at 4:30 PM Tom Lane wrote: > Fabrice Chapuis writes: > > I do the following command when connecting locally with user postgres > > SET ROLE asuperrole; -- asuperrol

Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid

On Sun, Aug 3, 2025 at 3:03 PM Xuneng Zhou wrote: > After testing, the patch LGTM. I noticed two very small possible nits: Thanks for the review! > 1) Comment wording > > The loop now calls isspace((unsigned char)*ptr), so a token ends at > any whitespace, not just at ASCII space (0x20). Could

Re: Improving and extending int128.h to more of numeric.c

On Fri, 18 Jul 2025 at 07:42, John Naylor wrote: > > While testing something else on s390x, I noticed that __int128 support > is broken on that platform at least for some versions of clang [1], > and I see improvement there with this patch: > > Query 1: > HEAD: 3015ms > Patch: 2206ms > > Query 2:

Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events

On Tue, Jul 29, 2025 at 8:52 AM Jacob Champion wrote: > On Thu, Jun 26, 2025 at 4:33 PM Jacob Champion > wrote: > > My plan, if this code seems reasonable, is to backport 0001-0003, but > > keep the larger 0004 on HEAD only until it has proven to be stable. > > It's a big new suite and I want to

Re: set role issue

Fabrice Chapuis writes: > I do the following command when connecting locally with user postgres > SET ROLE asuperrole; -- asuperrole has superuser privilege > GRANT SELECT ON pg_statistic TO test_role; > why the grantee is postgres? You mean "grantor", no? When a superuser does grant/revoke on

Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions

On Mon, Aug 4, 2025 at 1:09 PM Corey Huinker wrote: >> >> so we need to handle numeric source types with fractional points with >> special care. >> currently, this applies only to numeric, float4, and float8. >> (hope this is all the corner case we need to catch...) > > > I'm fairly certain that t

Adding per backend commit and rollback counters

Hi hackers, PFA a patch for $SUBJECT. Currently we can find xact_commit and xact_rollback in pg_stat_database but we don't have this information per backend. This patch adds 2 functions: pg_stat_get_backend_xact_commit() and pg_stat_get_backend_xact_rollback() to report the number of transaction

Re: Typo in create_index regression test

Dean Rasheed 于2025年8月4日周一 22:10写道： > While looking at create_index.sql, I noticed the following: > > -- > -- Check handling of indexes on system columns > -- > CREATE TABLE syscol_table (a INT); > > -- System columns cannot be indexed > CREATE INDEX ON syscolcol_table (ctid); > > which isn't test

Typo in create_index regression test

While looking at create_index.sql, I noticed the following: -- -- Check handling of indexes on system columns -- CREATE TABLE syscol_table (a INT); -- System columns cannot be indexed CREATE INDEX ON syscolcol_table (ctid); which isn't testing what it claims to test because there's a typo in the

Re: Dropping publication breaks logical replication

On Mon, Aug 4, 2025 at 4:08 PM vignesh C wrote: > > On Mon, 4 Aug 2025 at 09:47, Ashutosh Bapat > wrote: > > > > Hi Vignesh, > > Thanks for the patches. > > > > On Sat, Aug 2, 2025 at 7:10 PM vignesh C wrote: > > > > > > > > > > The backport seems to be straight forward. Please let me know if yo

Re: GB18030-2022 Support in PostgreSQL

Andrew Dunstan writes: > On 2025-08-04 Mo 6:35 AM, John Naylor wrote: >> There is a risk of breaking applications, although only a few dozen >> mappings changed. If it were added as a separate encoding, users could >> opt in. > That makes sense ... naming the new encoding so as to avoid confusion

Re: split func.sgml to separated individual sgml files

On 2025-07-29 Tu 11:40 AM, Tom Lane wrote: Andrew Dunstan writes: OK. I'm inclined to do this after the CF finishes, to avoid collisions with other patches. I assume it's going to make the CFbot fairly unhappy. +1 for proceeding that way. (I did not look at whether the proposed changes are

Re: implement CAST(expr AS type FORMAT 'template')

On 04/08/2025 07:55, David G. Johnston wrote: On Sunday, August 3, 2025, Corey Huinker wrote: On Sun, Aug 3, 2025 at 11:36 PM David G. Johnston wrote: I was under the impression that for format to be allowed in the expression one of the two data types involved has to

Re: GB18030-2022 Support in PostgreSQL

On 2025-08-04 Mo 6:35 AM, John Naylor wrote: On Mon, Aug 4, 2025 at 3:08 PM JiaoShuntian wrote: I noticed that PostgreSQL currently supports GB18030 encoding based on the older GB18030-2000 standard (as seen in commits like extend GB18030 conversion). However, China has since updated its ma

Re: Dropping publication breaks logical replication

On Mon, 4 Aug 2025 at 16:08, vignesh C wrote: > > On Mon, 4 Aug 2025 at 09:47, Ashutosh Bapat > wrote: > > > > Hi Vignesh, > > Thanks for the patches. > > > > On Sat, Aug 2, 2025 at 7:10 PM vignesh C wrote: > > > > > > > > > > The backport seems to be straight forward. Please let me know if you

Re: More protocol.h replacements this time into walsender.c

On 2025-Jul-28, Dave Cramer wrote: > I chose PqReplMsg patch attached I think you sent a patch that applied on top of your previous patch instead of a patch on top of master. Here it is as a standalone patch. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ >Fro

Re: More protocol.h replacements this time into walsender.c

On 2025-Jul-25, Nathan Bossart wrote: > On Fri, Jul 25, 2025 at 06:28:28AM -0400, Dave Cramer wrote: > > On Fri, 25 Jul 2025 at 06:23, Álvaro Herrera wrote: > >> Yeah, we could rename it, as in the attached. It doesn't harm anything. > > > > Consistency is good. If your patch were applied, then

Re: A little cosmetic to convert_VALUES_to_ANY()

On Sun, 27 Jul 2025 at 19:53, Tender Wang wrote: > While debugging the pull-up sublink codes, I noticed the > convert_VALUES_to_ANY(). > The function is to convert "where colX in VALUES(xxx)" into SAOP. It firstly > scans the values_list to > make sure no volatile function is in this list, then

Re: Doc: Add note for running ANALYZE after ALTER TABLE ... SET EXPRESSION

On Mon, Aug 4, 2025 at 3:14 PM Yugo Nagata wrote: > > Hi, > > The documentation recommends running ANALYZE after the "ALTER TABLE ... SET > DATA TYPE" > command since the statistics will become wrong after that. > > That same thing can be applied to "ALTER TABLE ... SET EXPRESSION" commands, > bu

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

On Sat, Aug 2, 2025 at 4:53 AM Masahiko Sawada wrote: > > On Thu, Jul 31, 2025 at 5:00 AM Hayato Kuroda (Fujitsu) > wrote: > > > > Dear Sawada-san, > > > > > I thought we could fix this issue by checking the number of in-use > > > logical slots while holding ReplicationSlotControlLock and > > > L

Re: Dropping publication breaks logical replication

On Mon, 4 Aug 2025 at 09:47, Ashutosh Bapat wrote: > > Hi Vignesh, > Thanks for the patches. > > On Sat, Aug 2, 2025 at 7:10 PM vignesh C wrote: > > > > > > > The backport seems to be straight forward. Please let me know if you > > > need my help in doing so, if we decide to backport the fix. > >

Re: GB18030-2022 Support in PostgreSQL

On Mon, Aug 4, 2025 at 3:08 PM JiaoShuntian wrote: > I noticed that PostgreSQL currently supports GB18030 encoding based on the > older GB18030-2000 standard (as seen in commits like extend GB18030 > conversion). However, China has since updated its mandatory character set > standard to GB18030

Re: Improve pg_sync_replication_slots() to wait for primary to advance

On Mon, Aug 4, 2025 at 12:19 PM shveta malik wrote: > > On Mon, Aug 4, 2025 at 11:31 AM Amit Kapila wrote: > > > > On Fri, Aug 1, 2025 at 2:50 PM shveta malik wrote: > > > > > > 5) > > > I tried a test where there were 4 slots on the publisher, where one > > > was getting used while the others w

Re: Assertion failure in pgbench

> On Fri, Aug 1, 2025 at 8:55 PM Fujii Masao wrote: >> Unless there are any objections, I plan to commit this and >> back-patch to v15. > > I've pushed the patch. Thanks! Thanks. Great! -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp

Re: BF mamba failure

We just had the same sudden replica shutdown, this time with version 17.3. 2025-08-02 22:10:02.229 UTC,,,473966,,67b3d76c.73b6e,14,,2025-02-18 00:42:20 UTC,8111/0,0,FATAL,XX000,"trying to drop stats entry already dropped: kind=relation dboid=16420 objoid=4169049057 refcount=1","WAL redo at 633

Re: Conflict detection for update_deleted in logical replication

On Mon, Aug 4, 2025 at 11:46 AM shveta malik wrote: > > 7) > Shall we rename 'max_conflict_retention_duration' to > 'max_conflict_info_retention_duration' as the latter one is more > clear? > Before bikeshedding on the name of this option, I would like us to once again consider whether we should

Re: GB18030-2022 Support in PostgreSQL

Hi 😂，Not long ago, many people were rushing to remove this character set because of a security vulnerability. I was honestly quite shocked when I saw it. Thanks On Mon, Aug 4, 2025 at 4:08 PM JiaoShuntian wrote: > Hi hackers, > > I noticed that PostgreSQL currently supports GB18030 encodin

Re: GB18030-2022 Support in PostgreSQL

> I would like to ask: > > Are there any plans to upgrade PostgreSQL’s GB18030 support to the 2022 > version?Would the community be open to contributions in this area? I think we only need to update the perl script and map file to complete this task. JiaoShuntian HighGo Inc.

set role issue

Hi, I do the following command when connecting locally with user postgres SET ROLE asuperrole; -- asuperrole has superuser privilege GRANT SELECT ON pg_statistic TO test_role; SELECT grantee, grantor, table_catalog, table_schema, table_name, privilege_type FROM information_schema.r

Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

On Mon, Aug 4, 2025 at 11:54 AM Peter Smith wrote: > > Recently, I learned it is possible to say: > > CREATE PUBLICATION pub ... WITH (publish_generated_columns); > > This is equivalent to: > CREATE PUBLICATION pub ... WITH (publish_generated_columns = stored); > > ~~~ > > Example: > > postgres=#

Re: Add backup_type to pg_stat_progress_basebackup

On Fri, 1 Aug 2025 16:12:15 -0700 Masahiko Sawada wrote: > The patch seems reasonably simple and looks good to me. I've updated > the comment in bbsink_progress_new() and attached the modified version > patch (with the commit message). Please review it. /* -* Report that a base b

Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

On Mon, Aug 4, 2025 at 4:37 PM David G. Johnston wrote: > > On Sunday, August 3, 2025, Peter Smith wrote: >> >> Recently, I learned it is possible to say: >> >> CREATE PUBLICATION pub ... WITH (publish_generated_columns); >> >> This is equivalent to: >> CREATE PUBLICATION pub ... WITH (publish_ge

Re: Raw parse tree is not dumped to log

I just noticed that my IDE auto formatted guc_tables.c, which generated a lot of unnecessary diffs. Recreated the patch, and attach the v2 version. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Chao Li 于2025年8月4日周一 15:57写道： > Oh, I forget to attache

Re: Add backup_type to pg_stat_progress_basebackup

On Sat, Aug 2, 2025 at 8:12 AM Masahiko Sawada wrote: > > On Tue, Jul 22, 2025 at 2:42 AM Shinya Kato wrote: > > > > On Tue, Jul 22, 2025 at 6:06 PM Yugo Nagata wrote: > > > > > > On Tue, 22 Jul 2025 17:48:35 +0900 > > > Shinya Kato wrote: > > > > > > > Hi hackers, > > > > > > > > Starting with

GB18030-2022 Support in PostgreSQL

Hi hackers, I noticed that PostgreSQL currently supports GB18030 encoding based on the older GB18030-2000 standard (as seen in commits like extend GB18030 conversion). However, China has since updated its mandatory character set standard to GB18030-2022, which includes additional characters and

Re: Raw parse tree is not dumped to log

Oh, I forget to attached the patch file, here comes it. Chao Li (Evan) -- HighGo Software Inc. https://www.highgo.com/ Chao Li 于2025年8月4日周一 15:53写道： > I was reviewing some patches today, and during debugging the patches, I > wanted to view raw parse tree, so I had t

Re: Improve LWLock tranche name visibility across backends

Hi, On Fri, Aug 01, 2025 at 01:15:24PM -0500, Sami Imseih wrote: > I think we could add a local backend copy that stays up to date with the > DSA. One idea would be to use an atomic counter to track the number of > entries in the DSA and compare it with a local backend counter whenever the > tranc

Re: Raw parse tree is not dumped to log

I was reviewing some patches today, and during debugging the patches, I wanted to view raw parse tree, so I had to apply my local patch of dumping raw parse for every review, which was so inconvenient. You may argue that raw parse tree might not be useful for every reviews. I am still ramping up P

Re: Missing import in 035_standby_logical_decoding.pl

Hi, On Sat, Aug 02, 2025 at 08:09:14AM +0900, Michael Paquier wrote: > On Fri, Aug 01, 2025 at 03:22:06PM -0700, Masahiko Sawada wrote: > > On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman > > wrote: > >> Another issue I see is that there are two incorrect tests for a log message > >> > >> # messa

Re: Missing import in 035_standby_logical_decoding.pl

Hi, On Fri, Aug 01, 2025 at 04:57:50PM -0400, Melanie Plageman wrote: > On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman > wrote: > > > > 035_standby_logical_decoding.pl has this code > > Another issue I see is that there are two incorrect tests for a log message > > # message should not be issu

Re: Missing import in 035_standby_logical_decoding.pl

Hi, On Fri, Aug 01, 2025 at 03:04:20PM -0400, Melanie Plageman wrote: > Hi, > > 035_standby_logical_decoding.pl has this code > > # wait for postgres to terminate > foreach my $i (0 .. 10 * $PostgreSQL::Test::Utils::timeout_default) > { > last if !-f $node_standby->data_dir . '/postmaster.pi

Re: Skipping schema changes in publication

On Mon, Aug 4, 2025 at 2:07 AM Shlok Kyal wrote: > ... > > 10b. > > How does "ALTER PUBLICATION tap_pub_col SET > > (publish_generated_columns)" even work? I thought the > > "pubish_generated_columns" is an enum but you did not specify any enum > > value here (???) > > > > ~~~ > Yes, it works. It

Re: Improve prep_buildtree

On 31.07.25 09:24, Nazir Bilal Yavuz wrote: On Wed, 30 Jul 2025 at 21:56, Peter Eisentraut wrote: On 30.07.25 12:58, Nazir Bilal Yavuz wrote: That makes sense. I noticed one difference, patched prep_buildtree does not create a symbolic link for the top Makefile in the builddir. Ok, here is