On 05.09.25 13:32, Dmitry Mityugov wrote:
Dmitry Mityugov писал(а) 2025-09-05 11:11:
Dmitry Mityugov писал(а) 2025-09-05 00:32:
It seems that when I add --with-llvm flag to ./configure on any 32-
bit platform that I have (Debian 12, Debian 13, Arch Linux), many
tests invoked by `make check` fa
On 12.09.25 09:47, Holger Hoffstätte wrote:
As a small style request, I would flip the conditional around so
that the new code appears first. I see that we don't do this very
consistently in the existing code, but maybe we can start a new
trend. ;-)
I knew this would come up since I pondered t
On Mon, 15 Sept 2025 at 17:32, Chao Li wrote:
> UPDATE, DELETE, SELECT FOR UPDATE, and SELECT FOR SHARE commands behave the
> same as SELECT in terms of searching for target rows: they will only find
> target rows that were committed as of the command start time.
>
> It says that UPDATE will onl
On Sunday, September 14, 2025, Chao Li wrote:
>
>
> It says that UPDATE will only find target rows that were committed as of
> the command start time. I think the statement implies that an “update”
> statement will never update a “future” tuple.
>
It will indeed see a future physical tuple so lon
Hi Ashutosh,
Thank you for continuing to review the patch. Attached is v9,
incorporating the feedback. Please see my responses inline below.
On Fri, Sep 12, 2025 at 5:34 AM Ashutosh Bapat
wrote:
> + Returns statistics about current multixact usage:
> + num_mxids is the total number of multixact
On 11.09.25 20:03, Pierrick wrote:
On 11/09/2025 16:11, Peter Eisentraut wrote:
Here is a patch for that. Please test it against your setup.
Thanks a lot. Here is a test, and IMHO, it looks good.
committed
Hi David and Sophie,
> If you need guidance about how this should be behaving, try with "SET
> enable_tidscan = 0;" and see what that does.
>
> David
>
> [1]
> https://www.postgresql.org/docs/current/transaction-iso.html#XACT-READ-COMMITTED
Thanks for pointing out “SET enable_tidsan=0”, with
On Mon, Sep 15, 2025 at 6:01 AM Peter Smith wrote:
>
> Hi Shubham,
>
> IIUC the v6 will be rewritten to remove the new option, in favour of
> just redefining the --publication option behaviour.
>
> So, much of the current v6 will become obsolete. The below comment is
> just for one piece of code t
One concern:
if (should_stop_conflict_info_retention(rdt_data))
+ {
+ /*
+ * Stop retention if not yet. Otherwise, reset to the initial phase to
+ * retry all phases. This is required to recalculate the current wait
+ * time and resume retention if the time falls within
+ * max_retention_duratio
On Fri, Sep 12, 2025 at 3:39 PM Zhijie Hou (Fujitsu)
wrote:
>
> Here is the V74 patch which addressed all comments.
>
+ ereport(LOG,
+ errmsg("logical replication worker for subscription \"%s\" will
resume retaining the information for detecting conflicts",
+MySubscription->name),
+ MySubscri
On Sun, Sep 14, 2025 at 5:47 PM Peter Geoghegan wrote:
> Thanks for the review.
Attached is v2, which is just v1 with some extra polish, and a real
commit message.
I plan on committing this in the next couple of days.
Thanks
--
Peter Geoghegan
v2-0001-Teach-nbtree-to-avoid-evaluating-row-com
hi.
demo:
CREATE TABLE coll_t (c) AS VALUES ('bar'::text);
CREATE POLICY coll_p ON coll_t USING (c < ('foo'::text COLLATE "C"));
+-- coll_t1 row security is not enabled, but we still copy it's policies
+CREATE TABLE coll_t1(LIKE coll_t INCLUDING POLICIES);
+\d coll_t1
+ Table "regress_rls
> index expression/predicate and check constraint expression can not contain
> subquery, that's why using pull_varattnos to test whole-row containment works
> fine. but pull_varattnos can not cope with subquery, see pull_varattnos
> comments.
>
> row security policy can have subquery, for exampl
On Sun, Sep 14, 2025 at 6:49 PM, Chao Li wrote:
> This is a wrong example and (0,3) should NOT be updated. According to the
> definition of “read committed”:
> https://www.postgresql.org/docs/current/transaction-iso.html#XACT-READ-COMMITTED
> “A query sees only data committed before the query be
On Mon, 15 Sept 2025 at 13:49, Chao Li wrote:
> This is a wrong example and (0,3) should NOT be updated. According to the
> definition of “read committed”:
>
> 13.2. Transaction Isolation
> postgresql.org
>
> “A query sees only data committed before the query began”.
I'm afraid your understandin
On Mon, Sep 15, 2025 at 3:19 AM David Rowley wrote:
>
> On Wed, 10 Sept 2025 at 21:18, Ashutosh Bapat
> wrote:
> > > > If there's LIMIT without ORDER BY, we could order the list of subpaths
> > > > by the number of rows in descending order or cost per row in ascending
> > > > order. That way ther
On Fri, Sep 12, 2025 at 11:18 PM Masahiko Sawada wrote:
>
> On Thu, Sep 11, 2025 at 9:08 PM Amit Kapila wrote:
> >
>
> > For the shutdown sequence, can't we think of resetting effective_wal
> > after a restart?
>
> Does it mean that effective_wal_level keeps 'logical' until the next
> server star
On Fri, Sep 12, 2025 at 4:19 PM jian he wrote:
>
> hi.
>
> in [1],
> RememberAllDependentForRebuilding
> /*
> * A policy can depend on a column because the column is
> * specified in the policy's USING or WITH CHECK qual
> * expres
On Sun, Sep 14, 2025 at 11:23 PM Jeff Davis wrote:
>
> On Sun, 2025-09-14 at 13:39 +0530, Dilip Kumar wrote:
> > I tried to improve it in v2
>
> Thank you. Looks good to me.
Thanks
> >
> > IMHO during crash recovery LocalMinRecoveryPoint and
> > ControlFile->minRecoveryPoint can not initialized
> On Sep 12, 2025, at 20:39, Maksim.Melnikov wrote:
>
> Hello hackers,
> I've noticed some places where elements of ProcGlobal->allProcs are addressed
> directly via arr index.
> But in proc.h macros GetPGProcByNumber exist, that was added to get proc
> objects by index,
> so I suggest minor
On Sat, Sep 13, 2025 at 1:58 AM Timur Magomedov
wrote:
>
> Hello Peter!
> Thanks for updates. Here is a small fix for clang "variable set but not
> used" warnings.
>
Thanks for your fixes. I will include these whenever I post the next version.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Re: Tomas Vondra
> Thanks! Pushed, with both adjustments (link to kernel thread, adding the
> commit hash).
The PG18 Debian package is still carrying the contrib complement of
this patch (see attachment).
Should that be addressed before 18.0?
Christoph
Work around a Linux bug in move_pages
In 3
> On Sep 14, 2025, at 06:12, Sophie Alpert wrote:
>
>
> And indeed, like I mentioned in my previous message, my isolation test
> `permutation tid1 tidsucceed2 c1 c2 read` from eval-plan-qual.spec in my
> patch will fail if Recheck were to return false in this case. Though somewhat
> contriv
> On Sep 14, 2025, at 14:37, jian he wrote:
>
> hi.
>
> in src/backend/commands/policy.c, i found that
> #include "access/htup.h"
> #include "access/htup_details.h"
> #include "catalog/catalog.h"
> #include "nodes/pg_list.h"
> #include "parser/parse_node.h"
> #include "utils/array.h"
>
> is n
I wrote:
> Robert Haas writes:
>> But, I also can't commit either v4-0003 or v5-0003 or any variant
>> thereof until we agree on what to do about 0001, and you're the
>> holdout there.
> Yeah, I owe you a review, hope to get to it over the weekend.
I'm running out of weekend, but I found time to
On Wed, 10 Sept 2025 at 19:41, Andrei Lepikhov wrote:
>
> On 10/9/2025 00:57, David Rowley wrote:
> > ... However, it's not all that clear to me how often someone would
> > have a LIMIT without an ORDER BY, as effectively there's nothing there
> > to determine which rows your query returns, and th
On Wed, 10 Sept 2025 at 21:18, Ashutosh Bapat
wrote:
> > > If there's LIMIT without ORDER BY, we could order the list of subpaths
> > > by the number of rows in descending order or cost per row in ascending
> > > order. That way there are more chances of scanning fewer partitions
> > > quicker.
>
On Fri, Aug 15, 2025 at 2:38 AM Chao Li wrote:
> I tested the patch. Basically all of my test cases passed.
Thanks for the review.
> + if (subkey->sk_attno > firstchangingattnum)
> /* >, not >= */
> + break;
>
> Can we enhance
On 9/12/25 11:46 AM, Jonathan S. Katz wrote:
As per above, I'll need remaining feedback no later than 2025-09-14 0:00
UTC - after this, it's frozen for the translation process to begin.
Thank everyone for your feedback. I've attached the copy of the release
announcement that will be translate
[ blast-from-the-past department ]
I wrote:
> Peter Eisentraut writes:
>> I suggest that if there are no other concerns, we proceed with the patch
>> set as is for now.
> After thinking about it for awhile, I guess I'm okay with only
> bothering to provide expected-files for FIPS failures under
> My current philosophy with this stuff is to favor simplicity,
> maintainability, portability, etc. over extracting the absolute maximum
> amount of performance gain, so I think we should proceed with the simd.h
> approach. But I'm curious how others feel about this.
> +1. The maintainability as
On 9/12/25 3:24 PM, Álvaro Herrera wrote:
Hello,
Thanks for putting this together! It's quite the monster. I read
through and found the following points worth mentioning:
Thank you!
I think almost all of the non-stock section titles Are Lacking Case
Title.
Putting this is as an example o
On Sun, 2025-09-14 at 13:39 +0530, Dilip Kumar wrote:
> I tried to improve it in v2
Thank you. Looks good to me.
>
> IMHO during crash recovery LocalMinRecoveryPoint and
> ControlFile->minRecoveryPoint can not initialized until we replay all
> WAL so those should never get accessed. However if
On Sun, 2025-09-14 at 09:41 -0400, Jonathan S. Katz wrote:
> I went with breaking this up into two sentences:
>
> This release adds the
> [`PG_UNICODE_FAST`](
> https://www.postgresql.org/docs/18/collation.html#COLLATION-MANAGING-
> STANDARD),
> which provides full Unicode semantics for case tra
Hello Hackers,
Looks like there may not be enough interest to port any functionality into
core. So, just noting that I have withdrawn the patch from CommitFest[1]. Thank
you for the good discussions and leanings.
[1] https://commitfest.postgresql.org/patch/5274/
Shayon
> On Aug 11, 2025, at
I wrote:
> Florian Weimer writes:
>> There's a story making the rounds that the removal of the
>> /usr/share/zoneinfo/US/Pacific etc. in Debian broke installations.
>> These identifiers should not be used, but they may get picked by
>> initdb if they are shorter than the alternatives.
> Ugh. (Fo
On 9/12/25 1:11 PM, Jeff Davis wrote:
On Tue, 2025-09-09 at 23:13 -0400, Jonathan S. Katz wrote:
Hi,
Attached is a draft of the PostgreSQL 18 GA press release. A few
comments before the ask for reviewing:
"This release adds the [`PG_UNICODE_FAST`], which accelerates lookups
using the `upper`
Florian Weimer writes:
> There's a story making the rounds that the removal of the
> /usr/share/zoneinfo/US/Pacific etc. in Debian broke installations.
> These identifiers should not be used, but they may get picked by
> initdb if they are shorter than the alternatives.
Ugh. (Fortunately, I don'
Hi Alexander,
On Sun, Sep 14, 2025 at 3:31 AM Alexander Korotkov wrote:
>
> Hi, Xuneng!
>
> On Wed, Aug 27, 2025 at 6:54 PM Xuneng Zhou wrote:
> > I did a rebase for the patch to v8 and incorporated a few changes:
> >
> > 1) Updated documentation, added new tests, and applied minor code
> > adju
On 13/09/2025 10:10 PM, Peter Geoghegan wrote:
On Wed, Sep 3, 2025 at 2:25 AM Konstantin Knizhnik wrote:
Do you suggest to replace `PageGetTempPage` with using local buffers?
Or may be change `PageGetTempPage*` to accept parameter with provided
local buffer?
I think that _bt_split could easily
В письме от пятница, 12 сентября 2025 г. 16:46:19 MSK пользователь Timur
Magomedov написал:
> Hello Nikolay!
>
> Found a typo in reloptions.h, treaed -> treated.
Oups. Fixed that in the attached version.
> Can ternary enum be added in a separate header file, say,
> src/include/ternary.h instead
There's a story making the rounds that the removal of the
/usr/share/zoneinfo/US/Pacific etc. in Debian broke installations.
These identifiers should not be used, but they may get picked by
initdb if they are shorter than the alternatives. The length-based
tie breaking was introduced in commit e38
42 matches
Mail list logo
