Hi folks,
apologies for not replying earlier. Thanks torikoshia for having
reviewed the related patch I sent that includes instrumentation.
It makes total sense to focus on this one first.
Been thinking about the current strategy of having to iterate through
the execution tree to add the custom E
On 9/19/25 12:50 PM, Nathan Bossart wrote:
On Fri, Sep 19, 2025 at 09:25:52AM -0500, Nathan Bossart wrote:
I'm hoping to commit this around 20:00 UTC today, and I will be happy to
address any feedback that folks have in the meantime.
Here's a v4. The content is the same except for a typo fix,
On Fri, 19 Sep 2025 19:21:29 +0900
Fujii Masao wrote:
> On Fri, Sep 19, 2025 at 11:43 AM Fujii Masao wrote:
> >
> > On Thu, Sep 18, 2025 at 4:20 PM Yugo Nagata wrote:
> > >
> > > On Thu, 18 Sep 2025 14:37:29 +0900
> > > Fujii Masao wrote:
> > >
> > > > On Thu, Sep 18, 2025 at 10:22 AM Yugo Nag
On Sat, Sep 20, 2025 at 2:04 AM Rafael Thofehrn Castro
wrote:
> apologies for not replying earlier. Thanks torikoshia for having
> reviewed the related patch I sent that includes instrumentation.
> It makes total sense to focus on this one first.
Thank you as well for agreeing on the direction fo
Proposal
New builtin case-insensitive collation PG_UNICODE_CI, where the
ordering semantics are just:
strcmp(CASEFOLD(arg1), CASEFOLD(arg2))
and the character semantics are the same as PG_UNICODE_FAST.
This does not perform the Unicode Collation algorithm (UCA), and it is
On Fri, Sep 19, 2025 at 08:52:24PM -0500, Sami Imseih wrote:
> Thank you! I update the CF entry [0] as committed.
>
> [0] https://commitfest.postgresql.org/patch/6033/
Oops, missed this part. Thanks.
--
Michael
signature.asc
Description: PGP signature
> On Thu, Sep 18, 2025 at 11:52:05AM -0500, Sami Imseih wrote:
> > v2 looks good to me. Not sure if there are edge cases in which
> > the assert will succeed even with padding (I can't think of any way
> > that will be possible), so for now what you have seems good enough.
>
> Okay, I've applied t
=?utf-8?Q?=C3=81lvaro?= Herrera writes:
> Oh, and replication/conflict.h including all of execnodes.h is kind of
> ridiculous.
Sooner or later we need to work out a subsystem hierarchy that
can define which headers should be allowed to include which
other ones. I have no clear ideas about what t
On Thu, 2025-09-11 at 20:51 +0300, Alexander Borisov wrote:
>
> > Hey.
> >
> > I've looked into these patches.
>
> Hi Victor,
>
> Thank you for reviewing the patch and testing it!
Heikki, do you have thoughts on this thread?
Regards,
Jeff Davis
Tender Wang writes:
> While working on another issue, I stepped into match_orclause_to_indexcol().
> I found below codes:
> /* Only the operator returning a boolean suit the transformation. */
> if (get_op_rettype(opno) != BOOLOID)
> break;
I don't understand what purpose this check serves
On 9/19/25 4:14 PM, Tom Lane wrote:
"Jonathan S. Katz" writes:
On a quick read, I believe this is easily settable in the cgit.css file
by setting "tab-size" to "4". I did a quick test hacking this inline,
and it worked.
Cool, thanks for looking into it.
Tested inline, but untested as a whol
On 19.09.25 10:22, Álvaro Herrera wrote:
There are two things we could do. One is to simply restrict `git blame`
to authenticated users; this shouldn't be_too_ bad. But if we don't
want that, we could put the bot checker javascript tricks in front of
`blame`. In fact maybe we could have the be
Hi Tender,
> Although this would not improve performance, it can save some CPU time.
> Any thoughts?
The patch looks correct to me. The correctness can also be rechecked like this:
```
--- a/src/backend/optimizer/path/indxpath.c
+++ b/src/backend/optimizer/path/indxpath.c
@@ -3372,6 +3372,9 @@
On 9/19/25 7:42 AM, David Rowley wrote:
On Fri, 19 Sept 2025 at 23:05, Peter Eisentraut wrote:
On 19.09.25 10:22, Álvaro Herrera wrote:
There are two things we could do. One is to simply restrict `git blame`
to authenticated users; this shouldn't be_too_ bad. But if we don't
want that, we c
Committed.
--
nathan
>
Hi Japin!
> I'm curious about the assert here. Why is it that children must be
> CustomScan?
> It seems that there is a JOIN node, and we do not support customizing
> the JOIN
> operation, right?
You are right, looks like we don't have VCI joins and this was the
cause of the problem. Thanks!
-
Hi,
Currently waitonlock_error_callback() allocates memory in ErrorContext
and doesn't explicitly free it. Valgrind is not happy about it and
generates multiple reports like this:
```
2,048 bytes in 2 blocks are definitely lost in loss record 1,097 of 1,165
at 0x999539: palloc (mcxt.c:1389)
On Fri, Sep 19, 2025 at 01:04:26PM -0400, Jonathan S. Katz wrote:
> On 9/19/25 12:50 PM, Nathan Bossart wrote:
>> + An asynchronous I/O subsystem (AIO) that can improve performance of
>> + sequential scans, bitmap heap scans, vacuums, and other operations.
>>
>> I wondered whether we sho
On 18.09.25 17:15, Jacob Champion wrote:
On Thu, Sep 18, 2025 at 3:03 AM Peter Eisentraut wrote:
Here is some relevant documentation that suggests that this is the
correct approach:
https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-headers/crt/_mingw.h.in#L476
This also says that t
On Thu, Sep 18, 2025 at 9:12 PM Jonathan S. Katz wrote:
> While prepping the website for the PG18 GA, I stumbled on the inability
> to access parts of commits through the gitweb links, specifically
> hitting 429 status code errors (this seems to be intermittent). After
> some briefing on why it's
> On 18 Sep 2025, at 21:19, Daniel Gustafsson wrote:
> .. else I'll take care of it tomorrow.
FWIW since there were new reviews and comments I wanted to allow some more time
for additional comments, so will do this over the weekend insteead.
--
Daniel Gustafsson
On 9/19/25 4:09 PM, Nathan Bossart wrote:
Committed.
Thanks!
Jonathan
OpenPGP_signature.asc
Description: OpenPGP digital signature
"Jonathan S. Katz" writes:
> On a quick read, I believe this is easily settable in the cgit.css file
> by setting "tab-size" to "4". I did a quick test hacking this inline,
> and it worked.
Cool, thanks for looking into it.
regards, tom lane
On 2025-03-26 07:21:43 -0400, Andres Freund wrote:
> On 2025-01-14 15:13:21 +0200, Heikki Linnakangas wrote:
> > Committed with those fixes. Thanks for the review!
>
> The test doesn't seem entirely stable. E.g.
> https://cirrus-ci.com/task/6166374147424256
> failed spuriously:
>
> [08:52:06.822]
I happened to realize that brin_tuple.h (a somewhat nasty header which
was only supposed to be used by BRIN itself and stuff like amcheck)
recently somehow snuck into tuplesort.h with some nefarious
consequences: that one has polluted execnodes.h, which means that header
now depends on struct defin
Peter Geoghegan writes:
> cgit messes up indentation by showing 8 space tabs (not 4 space tabs)
> -- that's certainly not ideal.
To me that seems like a complete blocker for this proposal,
if we can't find a fix.
regards, tom lane
> The "everything" also includes the query_text.
>
> This makes me wonder then if all it takes is just adding this to PortalDrop
> (proposed earlier in the thread by Frédéric):
One thing I did not like about that approach is that we will need to
save the current debug_query_string inside PortalDr
On Sep 19 2025, at 2:36 am, Michael Paquier wrote:
> On Thu, Sep 18, 2025 at 02:50:45PM -0400, Greg Burd wrote:
>> Thanks for all the feedback and time spent reviewing this patch. I
>> switched out the encode/decode functions to use the nodeToString() and
>> stringToNode() functions and change
On Fri, Sep 12, 2025 at 1:56 AM Ashutosh Bapat
wrote:
>
> On Fri, Sep 12, 2025 at 9:38 AM Amit Kapila wrote:
> >
> >
> > One thing related to this which needs a discussion is after this
> > change, it is possible that part of the transaction contains
> > additional logical_wal_info. I couldn't th
Hi,
> With that, I think the only change since the last drop is the removal of
> Hacking Discord, which my scanner read as a name alias/qualifier like Jane
> Doe (BIg Megacorp), so I think we're done.
FWIW the following entries look the same to me:
+Andrew
+Felix
+Nikita
It's like
On Fri, Sep 19, 2025 at 5:36 PM Matheus Alcantara
wrote:
>
> On Fri Sep 19, 2025 at 9:34 AM -03, Arseniy Mukhin wrote:
> > Hi,
> >
> Thanks for taking a look at this!
>
> > I like this approach. We got rid of dependency on clog and don't limit
> > vacuum. Several points about the fix:
> >
> > Is i
On Fri, Sep 19, 2025 at 11:43 AM Fujii Masao wrote:
>
> On Thu, Sep 18, 2025 at 4:20 PM Yugo Nagata wrote:
> >
> > On Thu, 18 Sep 2025 14:37:29 +0900
> > Fujii Masao wrote:
> >
> > > On Thu, Sep 18, 2025 at 10:22 AM Yugo Nagata wrote:
> > > > That makes sense. How about rewriting this like:
> >
On Fri, 19 Sept 2025 at 15:59, Aleksander Alekseev
wrote:
>
> Hi Zhao,
>
> Thanks for sharing.
>
> > I hacked some of the code into my extension to skip these unnecessary
> > operations,
> > and the performance will improve by 2%~5%. Then I think that if there is a
> > way
> > to remove the node
On 2025-Sep-19, David Rowley wrote:
> On Fri, 19 Sept 2025 at 21:36, Álvaro Herrera wrote:
> >
> > So, there's already an implementation of an index-organized table in
> > OrioleDB, as I understand, so maybe we can ask Alexander K. about this.
> > I suspect it's fine to say that if you have a tab
On Fri, Sep 19, 2025 at 7:45 AM Ashutosh Bapat
wrote:
>
> On Fri, Sep 12, 2025 at 2:26 PM Ashutosh Bapat
> wrote:
> >
> > On Fri, Sep 12, 2025 at 9:38 AM Amit Kapila wrote:
> > >
> > >
> > > One thing related to this which needs a discussion is after this
> > > change, it is possible that part o
On Fri, Sep 19, 2025 at 09:25:52AM -0500, Nathan Bossart wrote:
> I'm hoping to commit this around 20:00 UTC today, and I will be happy to
> address any feedback that folks have in the meantime.
Here's a v4. The content is the same except for a typo fix, some
formatting adjustments that don't cha
On 9/19/25 10:47 AM, Álvaro Herrera wrote:
On 2025-Sep-19, Peter Eisentraut wrote:
On 19.09.25 03:12, Jonathan S. Katz wrote:
* Moves any web links to git.postgresql.org repos to use the cgit
interface instead of gitweb (e.g. [1])
* Update the commit search[2] to use cgit instead of gitweb
I
hi. about v59.
check_partitions_not_overlap_list
overlap = list_intersection(sps1->bound->listdatums,
sps2->bound->listdatums);
if (list_length(overlap) > 0)
{
Const *val = (Const *) lfirst(list_head(
On Fri, Sep 19, 2025 at 11:48 AM shveta malik wrote:
>
> On Thu, Sep 18, 2025 at 3:54 PM Ashutosh Bapat
> wrote:
> >
> >
> > >
> > > Few comments:
> > >
> > > 1)
> > > postgres=# select slot_name,
> > > total_bytes,plugin_filtered_bytes,plugin_sent_bytes from
> > > pg_stat_replication_slots orde
On Fri Sep 19, 2025 at 9:34 AM -03, Arseniy Mukhin wrote:
> Hi,
>
Thanks for taking a look at this!
> I like this approach. We got rid of dependency on clog and don't limit
> vacuum. Several points about the fix:
>
> Is it correct to remember and reuse slru slots here? IIUC we can't do
> it if we
Hi Peter!
> What exactly did Valgrind report? For example, you said the
> VciScanState points beyond allocated memory. Do you have any more
> clues, like where that happened? Did you discover where that (smaller
> than it should be) memory was allocated in the first place?
Doing some experiments
On Fri, Sep 19, 2025 at 07:41:14AM +0800, Chao Li wrote:
> Good catch. LGTM.
Committed.
--
nathan
On Fri, Sep 19, 2025 at 3:04 PM shveta malik wrote:
>
> On Thu, Sep 18, 2025 at 5:20 PM Ashutosh Sharma wrote:
> >
> > Hi Ajin,
> >
> > On Thu, Sep 18, 2025 at 4:16 PM Ajin Cherian wrote:
> > >
> > > On Fri, Sep 12, 2025 at 1:56 PM shveta malik
> > > wrote:
> > > >
> > > > The approach seems v
Hi Zhao,
Thanks for sharing.
> I hacked some of the code into my extension to skip these unnecessary
> operations,
> and the performance will improve by 2%~5%. Then I think that if there is a way
> to remove the nodes corresponding to these redundant operations in the
> targetlist
> when initia
Hi,
On 2025-09-20 00:51:55 +1200, Thomas Munro wrote:
> On Fri, Sep 19, 2025 at 8:13 PM Nazir Bilal Yavuz wrote::
> > pg_locale_libc.c: In function ‘wc_isdigit_libc_mb’:
> > ../../../../src/include/port/win32_port.h:438:20: error: implicit
> > declaration of function ‘_iswctype_l’; did you mean ‘
On Fri, Sep 19, 2025 at 8:58 AM Aleksander Alekseev <
[email protected]> wrote:
> Hi,
>
> > With that, I think the only change since the last drop is the removal of
> Hacking Discord, which my scanner read as a name alias/qualifier like Jane
> Doe (BIg Megacorp), so I think we're done.
>
>
On Thu, Sep 18, 2025 at 4:16 PM Ajin Cherian wrote:
>
> On Fri, Sep 12, 2025 at 1:56 PM shveta malik wrote:
> >
> > The approach seems valid and should work, but introducing a new file
> > like promote.inprogress for this purpose might be excessive. We can
> > first try analyzing existing informa
On Fri, Sep 19, 2025 at 8:13 PM Nazir Bilal Yavuz wrote::
> pg_locale_libc.c: In function ‘wc_isdigit_libc_mb’:
> ../../../../src/include/port/win32_port.h:438:20: error: implicit
> declaration of function ‘_iswctype_l’; did you mean ‘_isctype_l’?
> [-Wimplicit-function-declaration]
> 438 | #defin
On 19.09.25 14:52, Corey Huinker wrote:
I was thinking we should wait for more timezones to have a chance to
dig into
the list before committing. If you want to pick it up since you
have a long
history of doing the list, feel free, else I can take care of it.
Fire Emerald
>
>
> I was thinking we should wait for more timezones to have a chance to dig
> into
> the list before committing. If you want to pick it up since you have a
> long
> history of doing the list, feel free, else I can take care of it.
>
Fire Emerald replied to Álvaro and myself off-list, saying th
On 2025-Sep-19, Antonin Houska wrote:
> Admittedly I haven't thought about clause like ORDER BY yet, but I wonder if
> it'd really be useful. My understanding is that the purpose of clustering is
> to make index scan more efficient:
Not necessarily. For some queries in some workloads, having tup
On Wed, Sep 17, 2025 at 12:06 AM Robert Haas
wrote:
Thanks for the comments!
On Tue, Sep 16, 2025 at 9:30 AM torikoshia
wrote:
> I'm not sure if this is the best approach, but I changed them to log
> nothing in these cases.
> In addition to the reason you mentioned, I found that when
> pg_lo
Hi,
On Fri, Sep 19, 2025 at 12:35 AM Matheus Alcantara
wrote:
>
> On Mon Sep 15, 2025 at 2:40 PM -03, Masahiko Sawada wrote:
> > While the WAL-based approach discussed on another thread is promising,
> > I think it would not be acceptable for back branches as it requires
> > quite a lot of refact
David Rowley wrote:
> On Fri, 19 Sept 2025 at 23:58, Antonin Houska wrote:
> > Admittedly I haven't thought about clause like ORDER BY yet, but I wonder if
> > it'd really be useful. My understanding is that the purpose of clustering is
> > to make index scan more efficient: with a clustered tab
On Fri, 19 Sept 2025 at 23:58, Antonin Houska wrote:
> Admittedly I haven't thought about clause like ORDER BY yet, but I wonder if
> it'd really be useful. My understanding is that the purpose of clustering is
> to make index scan more efficient: with a clustered table, the heap tuples
> pertaini
On Fri, 19 Sept 2025 at 23:14, David Rowley wrote:
>
> On Fri, 19 Sept 2025 at 22:48, Tender Wang wrote:
> > "catched" should be "caught".
>
> Thanks. I'll handle this.
I ended up doing a bit more rewording in this area. I wasn't quite
sure if I understood the "to be effective" terminology. I su
On Wed, Sep 10, 2025 at 2:12 AM Zsolt Parragi wrote:
> > I think this is focusing on authentication again. I mean that you need
> > to authorize the _client_ -- libpq itself. What does the consent
> > screen say for a user logging in, in your proposed architecture?
>
> I tried to implement my idea
На пт, 12.09.2025 г. в 3:37 Michael Paquier написа:
> Okay, the bit about the cascading standby is a useful piece of
> information. Do you have some data about the relation reported in the
> error message this is choking on based on its OID? Is this actively
> used in read-only workloads, with
Álvaro Herrera wrote:
> On 2025-Sep-19, David Rowley wrote:
>
> > I was just thinking about how much of a heap-ism cluster using an
> > index is. If we were to ever have an index organised table AM, what
> > would it mean to REPACK tab USING INDEX idx? Would that "secondary"
> > index then go aw
On Fri, 19 Sept 2025 at 21:36, Álvaro Herrera wrote:
>
> On 2025-Sep-19, David Rowley wrote:
>
> > I was just thinking about how much of a heap-ism cluster using an
> > index is. If we were to ever have an index organised table AM, what
> > would it mean to REPACK tab USING INDEX idx? Would that "
On Fri, 19 Sep 2025 11:43:28 +0900
Fujii Masao wrote:
> On Thu, Sep 18, 2025 at 4:20 PM Yugo Nagata wrote:
> >
> > On Thu, 18 Sep 2025 14:37:29 +0900
> > Fujii Masao wrote:
> >
> > > On Thu, Sep 18, 2025 at 10:22 AM Yugo Nagata wrote:
> > > > That makes sense. How about rewriting this like:
>
On Sat, Sep 6, 2025 at 10:33 AM Dilip Kumar wrote:
>
> On Wed, Aug 13, 2025 at 4:17 PM Zhijie Hou (Fujitsu)
> wrote:
>
> >
> > Here is the initial POC patch for this idea.
> >
> > The basic implementation is outlined below. Please note that there are
> > several
> > TODO items remaining, which w
On 2025-Sep-17, David G. Johnston wrote:
> That changes logical aspects of a table and so would be done as part of
> alter table, IMO. “AT tbl Rearrange columns (names list) “
Yes.
> Concretely, maybe we should remove vacuum full from the vacuum command
> page, and just call it out as compatibil
David Rowley 于2025年9月19日周五 19:38写道：
> On Fri, 19 Sept 2025 at 23:14, David Rowley wrote:
> >
> > On Fri, 19 Sept 2025 at 22:48, Tender Wang wrote:
> > > "catched" should be "caught".
> >
> > Thanks. I'll handle this.
>
> I ended up doing a bit more rewording in this area. I wasn't quite
> sure
Hi,
While working on another issue, I stepped into match_orclause_to_indexcol().
I found below codes:
/* Only the operator returning a boolean suit the transformation. */
if (get_op_rettype(opno) != BOOLOID)
break;
In get_op_rettype, it calls SearchSysCache1() to get oprresult
of Form_pg_o
On Fri, 19 Sept 2025 at 23:05, Peter Eisentraut wrote:
>
> On 19.09.25 10:22, Álvaro Herrera wrote:
> > There are two things we could do. One is to simply restrict `git blame`
> > to authenticated users; this shouldn't be_too_ bad. But if we don't
> > want that, we could put the bot checker java
On Fri, 19 Sept 2025 at 22:48, Tender Wang wrote:
> /*
> * Try to convert a list of OR-clauses to a single SAOP expression. Each
> * OR entry must be in the form: (indexkey operator constant) or (constant
> * operator indexkey). Operators of all the entries must match. To be
> * effective, give
On Thu, Sep 18, 2025 at 3:54 PM Ashutosh Bapat
wrote:
>
>
> >
> > Few comments:
> >
> > 1)
> > postgres=# select slot_name,
> > total_bytes,plugin_filtered_bytes,plugin_sent_bytes from
> > pg_stat_replication_slots order by slot_name;
> > slot_name | total_bytes | plugin_filtered_bytes | plugin_
> On 19 Sep 2025, at 13:05, Peter Eisentraut wrote:
>
> On 19.09.25 10:22, Álvaro Herrera wrote:
>> There are two things we could do. One is to simply restrict `git blame`
>> to authenticated users; this shouldn't be_too_ bad. But if we don't
>> want that, we could put the bot checker javascrip
On 19.09.25 03:12, Jonathan S. Katz wrote:
* Moves any web links to git.postgresql.org repos to use the cgit
interface instead of gitweb (e.g. [1])
* Update the commit search[2] to use cgit instead of gitweb
If we're doing that -- which seems reasonable -- then perhaps also
update the forward
Following up to correct my previous email: the query plan did not really
change - we see Bitmap Heap Scans even before the upgrade. Therefore,
the query plan doesn't seem to have changed after the upgrade.
However after the upgrade it seems that those queries are doing more
disk IO (increased
On Wed, Sep 10, 2025 at 4:32 PM Alastair Turner wrote:
>
>> Here we will have to create a built-in type of type table which is I
>> think typcategory => 'C' and if we create this type it should be
>> supplied with the "typrelid" that means there should be a backing
>> catalog table. At least thats
Hi,
On Fri, 19 Sept 2025 at 04:15, Oreo Yang wrote:
>
> Hi all,
>
> When i execute meson setup, an error occurred "meson.build:1610:4: ERROR:
> Expected 1 arguments, got 2."
> I saw [1] discussing about the meson minimun version which is 0.57.2.
> So I have attached a patch try to fix that.
>
>
Here's a few more forward struct declarations turned into typedefs, for
cleanliness sake.
struct VacuumCutoffs could use a typedef, by the way ...
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La espina, desde que nace, ya pincha" (Proverbio africano)
>From 7e
Hi,
While debugging the optimizer codes, I found a typo
in match_orclause_to_indexcol():
/*
* Try to convert a list of OR-clauses to a single SAOP expression. Each
* OR entry must be in the form: (indexkey operator constant) or (constant
* operator indexkey). Operators of all the entries must ma
Hi,
On 18/09/2025 18:06, Sami Imseih wrote:
The "everything" also includes the query_text.
This makes me wonder then if all it takes is just adding this to
PortalDrop (proposed earlier in the thread by Frédéric):
if (portal->queryDesc)
debug_query_string = portal->queryDesc->sourceText;
Hi John,
Thanks for the feedback. This is v5 of the patchset, updated following your
comments:
- Moved the function pointer definitions out of common headers and
into src/port, consistent with existing practice.
Thanks again for the guidance.
Best regards,
Kim Andrew
On Wed, Sep 10, 2025 at 3:18 AM Dilip Kumar wrote:
>
> On Wed, Sep 10, 2025 at 1:59 AM Melanie Plageman
> wrote:
>
> > Though, it seems like LocalMinRecoveryPoint must be getting
> > incorrectly set elsewhere, otherwise this would have guarded us from
> > examining the control file:
> >
> >
On 2025-Sep-19, David Rowley wrote:
> I was just thinking about how much of a heap-ism cluster using an
> index is. If we were to ever have an index organised table AM, what
> would it mean to REPACK tab USING INDEX idx? Would that "secondary"
> index then go away and the table would become that i
Great to see some consensus on the warning message at least.
I get that this is a niche issue and that it may not be a priority to make
a medium-sized change as changing from a warning to an error would be.
Regarding demand: Keep in mind that basically nobody will create an account
and join a mail
On Thu, 11 Sept 2025 at 19:27, Álvaro Herrera wrote:
>
> On 2025-Sep-11, Kirill Reshke wrote:
>
> > I think we can remove "support" for ALTER DATABASE RESET TABLESPACE.
>
> What about ALTER USER RESET TABLESPACE?
>
> --
> Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com
> and the only chance
> you'll have to reject the theft is to notice that the client name
> looks different from usual. (If I catch you on the first login, you
> might not even know what "usual" is.)
Isn't this also true with custom scopes? Similarly the only thing
protecting users if they notice
On Thu, Sep 18, 2025 at 5:20 PM Ashutosh Sharma wrote:
>
> Hi Ajin,
>
> On Thu, Sep 18, 2025 at 4:16 PM Ajin Cherian wrote:
> >
> > On Fri, Sep 12, 2025 at 1:56 PM shveta malik wrote:
> > >
> > > The approach seems valid and should work, but introducing a new file
> > > like promote.inprogress f
On Tue, Sep 9, 2025 at 9:27 AM Nazir Bilal Yavuz wrote:
>
Thanks for the review!
> From 053dd9d15416d76ce4b95044d848f51ba13a2d20 Mon Sep 17 00:00:00 2001
> From: Melanie Plageman
> Date: Tue, 2 Sep 2025 11:00:44 -0400
> Subject: [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
>
Hi, Alexey!
Thank you for spotting this problem, and thank you for working on it.
On Sun, Aug 31, 2025 at 2:47 AM Alexey Makhmutov
wrote:
> This is a continuation of the thread
>
https://www.postgresql.org/message-id/flat/076eb7bd-52e6-4a51-ba00-c744d027b15c%40postgrespro.ru
,
> with focus only
On 16/09/2025 21:13, Sami Imseih wrote:
They can be committed together if there is agreement that tests are worth it.
One argument for keeping the tests would be that they nicely bring
together the side-effect (logging) and these use-cases, whereas in the
code they're pretty distant, making t
> On Mon, Sep 15, 2025 at 05:33:45PM -0500, Sami Imseih wrote:
> > I think it's better to use ->pending here, since this is referenced
> > as an example and most real-world cases will likely want to use
> > ->pending for performance reasons.
>
> Yes, it should use the pending entry. b757abefc041 d
Hi all,
I'm recently working on debugging an extension that utilizes user-defined
operator
classes, and I find it hard to understand some of the details.
I'll use extension cube as an example to briefly describe my problem, execute
following sql,
```
CREATE EXTENSION cube;
CREATE TABLE test(a
Hi Maxim
Thank you for your feedback.I remember this path the primary
challenges are in the upgrade section, where we're still debating how to
address a few edge cases. Right now, this thread is missing input from core
code contributors.
Thanks
On Fri, Sep 19, 2025 at 12:37 AM Maxim Orlov
On 2025-Sep-19, David Rowley wrote:
> You didn't mention the cause of the specific issues, but it has been
> mentioned on www lists before, so I don't think it's a secret with the
> bot traffic. Have you considered if switching these links to cgit
> wouldn't just cause the traffic to migrate to c
Hi,
I am working on upgrading Debian bookworm CI images to Debian trixie.
CompilerWarnings CI task's mingw_cross_warning_script failed with [1]:
```
make -s -j${BUILD_JOBS} clean
time make -s -j${BUILD_JOBS} world-bin
In file included from ../../../../src/include/port.h:16,
from ../../../../src/i
Hi Maxime,
> > Can you think of any test cases we can add to the code base?
>
> The only idea I have would be adding a new index module in src/test/modules
> that has this particular property and have a test that will hit
> get_actual_variable_range().
> For example, it could be a new access met
Em qua., 17 de set. de 2025 às 10:17, David G. Johnston <
[email protected]> escreveu:
> That changes logical aspects of a table and so would be done as part of
> alter table, IMO. “AT tbl Rearrange columns (names list) “
>
If this command recreates entirely that table, it is not only a
Dear John,
> The first issue can be mitigated by 'max_slot_wal_keep_size'. However
> in the second case there are no good mechanisms to prioritize write
> availability of the database and avoid wraparound. The new GUC
> 'idle_replication_slot_timeout' partially addresses the concern if you
> have
> On Sep 19, 2025, at 14:45, Florents Tselai wrote:
>>
>> I reviewed and tested this patch. Overall looks good to me. Actually, I
>> think this patched fixed a bug of current implementation of base64 encoding
>> by moving the logic of handling newline into “if (pos<0)”.
>
> IIUC what you mea
> On 19 Sep 2025, at 08:56, Chao Li wrote:
>> On Sep 19, 2025, at 14:45, Florents Tselai wrote:
>>> This is a normal usage that injects sub-strings based on condition.
>>> However, PG doesn’t like that, see here:
>>> https://www.postgresql.org/docs/devel/nls-programmer.html#NLS-GUIDELINES
>>
> On 19 Sep 2025, at 08:45, Florents Tselai wrote:
>> On 19 Sep 2025, at 6:50 AM, Chao Li wrote:
>> It’s not common to use two white-spaces after “.”, usually we need only one.
>
> I agree with this
This might date me (and others) but double-space after period was the norm for
monospaced types
On 9/18/25 18:06, Sami Imseih wrote:
I also realized that the initial tests we've been working with included:
```
+log_statement = all
+log_min_duration_statement = 0
```
Yes, you added these two in your v8, together with a useless
log_line_prefix.
which caused additional noise and did
98 matches
Mail list logo
