Hi Nathan,
Thanks for your comment.
> On Sep 26, 2025, at 22:30, Nathan Bossart wrote:
>
> I have mixed feelings about this patch. I have no concrete objections to
> the technical content, but some questions come to mind. For example, why
> are we only fixing Datum parameters? Are we going t
On Fri, Sep 26, 2025 at 11:00 PM Tom Lane wrote:
> Yeah. In particular, probably 99% of such Datum arrays also have an
> associated array of bool isnull flags. IMO it makes exactly zero
> sense to const-ify the Datums without similar protection for their
> isnull flags.
>
>
Based on Tom's comme
On Fri, 5 Sept 2025 at 11:57, Shlok Kyal wrote:
>
> On Mon, 25 Aug 2025 at 13:38, Shlok Kyal wrote:
> >
> > On Thu, 21 Aug 2025 at 05:33, Peter Smith wrote:
> > >
> > > Hi Shlok,
> > >
> > > I reviewed your latest v20-0003 patch and have no more comments at
> > > this time; I only found one triv
On 27/09/2025 18:03, Tom Lane wrote:
So according to the standard, this:
select a+b, count(*) from ... group by all;
would be invalid because a+b couldn't be written directly in
GROUP BY?
Correct.
I can't see us rejecting that though, since we do
allow a+b in GROUP BY.
No, no
Here's a v6 that's rebased up to HEAD and contains fixes for the
semantic issues we discussed. It still lacks documentation, but
otherwise I think it's about ready to go.
regards, tom lane
From 5503815351b2e45661262fddaab1271a435dd730 Mon Sep 17 00:00:00 2001
From: Tom La
On Sat, Sep 27, 2025 at 9:24 PM Dilip Kumar wrote:
>
> On Sat, Sep 27, 2025 at 8:53 PM Amit Kapila wrote:
> >
> > I am not able to understand what exact problem you are seeing here. I
> > was thinking that during the CREATE SUBSCRIPTION command, a new table
> > with user provided name will be cre
Hi,
I think I encountered the bug that relates to the patch from this
thread so I decided to write a report here.
version(): PostgreSQL 19devel on x86_64-linux, compiled by gcc-13.3.0,
64-bit. (master)
While writing a TAP test I noticed that background_psql hangs on a
simple query without any re
> What I'm afraid of is that this would be similar to the proposals in
> the original patch (not really clean at it used a direct point to the
> debug query string) or v13 (pstrdup of the debug string), which are
> both localized changes, and these seem unsafe to do because we'd
> expect the saved
This is a spur of the moment patch really,
but while going through the process of translating some json data from
Greek to English I found myself wishing for $subject.
Inspired by the Unix tr utility.
Here's a working v1
If others find it useful as well,
I'd go ahead with a json implementation
An
Hi,
On Wed, Sep 03, 2025 at 07:33:37AM +, Bertrand Drouvot wrote:
> Hi,
>
> On Wed, Sep 03, 2025 at 02:47:51PM +0900, Michael Paquier wrote:
> > On Tue, Sep 02, 2025 at 12:42:54PM -0400, Andres Freund wrote:
> > > I think that's the wrong direction to go. Diffing stats is far from cheap
> >
Andrew Dunstan writes:
> On 2025-09-26 Fr 8:06 PM, Jacob Champion wrote:
>> Unfortunately it only gives about a 4x speedup on my machine, and I
>> was hoping for much more. (We should really expect this entire thing
>> to run in a fraction of a second.)
>>
>> Let me know if you think the tradeoff
Peter Eisentraut writes:
> The language used in the standard at the moment is the select list
> elements that "do not directly contain an ", where
> "directly contain" is a term of art that means "contains without an
> intervening instance of , , or
> that is not an ". So
> it means not to
On Sat, Sep 27, 2025 at 8:53 PM Amit Kapila wrote:
>
> I am not able to understand what exact problem you are seeing here. I
> was thinking that during the CREATE SUBSCRIPTION command, a new table
> with user provided name will be created similar to how we create a
> slot. The difference would be
On Fri, Sep 26, 2025 at 4:42 PM Dilip Kumar wrote:
>
> On Thu, Sep 25, 2025 at 4:19 PM Dilip Kumar wrote:
> >
> > On Thu, Sep 25, 2025 at 11:53 AM Dilip Kumar wrote:
> > >
> > > > [1]
> > > > /*
> > > > * For logical decode we need combo CIDs to properly decode the
> > > > * catalog
> > > > */
>
On Sat, Sep 27, 2025 at 5:54 PM jian he wrote:
>
> While at it, maybe we can also polish the comment below in ATRewriteCatalogs.
> /*
> * After the ALTER TYPE or SET EXPRESSION pass, do cleanup work
> * (this is not done in ATExecAlterColumnType since it shoul
On 2025-09-26 Fr 8:06 PM, Jacob Champion wrote:
On Fri, Sep 26, 2025 at 9:26 AM Jacob Champion
wrote:
If it's truly just a few lines, then I've misunderstood what you're
suggesting (patches welcome). It's not the separator splitting that
I'm worried about, but the restructuring of the test.
On Tue, Sep 23, 2025 at 6:04 PM Andres Freund wrote:
>
> Hi,
>
> On 2025-09-23 17:45:19 +0530, Ashutosh Bapat wrote:
> > On Tue, Sep 23, 2025 at 11:30 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Aug 27, 2025 at 9:36 PM Ashutosh Bapat
> > > wrote:
> > > >
> > > > Ok. I am interested in kno
On Sep 24 2025, at 7:28 pm, Michael Paquier wrote:
> On Wed, Sep 24, 2025 at 07:39:59AM -0400, Greg Burd wrote:
>> Thanks Michael, Tom, for the help getting this into shape and in the tree.
>
> By the way, Greg, do you think that we should aim for a state where we
> are closer to completion?
H
On 26.09.25 22:18, Tom Lane wrote:
Got it, mostly. There is an edge case, though: what if there are no
candidate grouping items? I see these test cases in David's patch:
+-- oops all aggregates
+EXPLAIN (COSTS OFF) SELECT COUNT(a), SUM(b) FROM t1 GROUP BY ALL;
+ QUERY PLAN
+--
On 26.09.25 18:23, Tom Lane wrote:
No, I think the correct behavior would have to be to descend into
SubLinks to see if they contain any aggregates belonging to the
outer query level.
However (looks around) we do already have that code.
See contain_aggs_of_level. (contain_agg_clause is essentia
On Fri, Sep 26, 2025 at 8:48 AM Robert Haas wrote:
> Interesting. Are you on Linux?
Yeah, this is aarch64 Ubuntu on an M3 Pro.
--Jacob
Hello,
While messing around with NLS under Make for commit [1], I noticed in the Ninja
manual [2] that apparently calling the i18n.gettext() function generates a few
"hidden" targets -- most notably, things like -update-po and
-pot targets. These would presumably be used to build the POT and
u
On Wed, 17 Sept 2025 at 15:52, David Rowley wrote:
> Updated patch attached. Thanks for the review.
Now pushed and awaiting buildfarm feedback.
Thanks for reviewing.
David
hi.
bug demo:
drop table if exists gtest25;
CREATE TABLE gtest25 (a0 int, a int, b int GENERATED ALWAYS AS (a * 2
+ a0) STORED);
alter table gtest25 add constraint cc check (b > 0);
alter table gtest25 alter column b set data type int8, ALTER COLUMN b
SET EXPRESSION AS (a * 3 + a0);
ERROR: cach
Thanks for v3. The only remaining comment I have is:
This comment seems unnecessary, since refcount is not checked inside
pgstat_free_entry, but earlier.
+ /*
+* Entry has been dropped with refcount at 0, hence decrement the
+* entry counter.
+*/
I would just say th
Hello,
> /*
> - * Check whether the passed slot name is valid and report errors at elevel.
> + * Check whether the passed slot name is valid and report errors.
> + *
> + * When called from a GUC check hook, elevel must be 0. In that case,
> + * errors are reported as additional details or hints
Hi Rahila,
On Thu, Sep 25, 2025 at 12:02 PM Rahila Syed wrote:
> Hi,
>
> Please find attached a POC patch that introduces changes to the WAL sender
> and
> receiver, allowing WAL records to be sent to standbys before they are
> flushed
> to disk on the primary during physical replication. This i
27 matches
Mail list logo
