Re: regarding statistics retaining with 18 Upgrade

2025-11-15 Thread Rambabu V
Thanks all for the proactive response and clarification. people will be confused by seeing the release notes, it should be a little bit clear or need to update. i have one more question : with every version of package installation , PG 17 version is getting by default installed, is it a hard dep

Re: regarding statistics retaining with 18 Upgrade

2025-11-15 Thread Dilip Kumar
On Sun, Nov 16, 2025 at 5:22 AM Robert Treat wrote: > > On Sat, Nov 15, 2025 at 9:32 AM Bruce Momjian wrote: > > On Sat, Nov 15, 2025 at 06:02:53PM +0800, Rambabu V wrote: > > > Hi Team, > > > > > > seems stats are not retained after upgrade. Below are the artifacts , is > > > it > > > expected?

Re: regarding statistics retaining with 18 Upgrade

2025-11-15 Thread Robert Treat
On Sat, Nov 15, 2025 at 9:32 AM Bruce Momjian wrote: > On Sat, Nov 15, 2025 at 06:02:53PM +0800, Rambabu V wrote: > > Hi Team, > > > > seems stats are not retained after upgrade. Below are the artifacts , is it > > expected? as per the release notes statistics should be retained. > > Uh, it is the

Re: Improve error reporting in 027_stream_regress test

2025-11-15 Thread Tom Lane
I wrote: > Michael Paquier writes: >> We are getting PQPING_NO_RESPONSE meaning a lack of report activity >> from the postmaster. An increase in timeout may help, but the host >> seems like it's facing a high workload so it's not really possible to >> come with a perfect number, just an estimatio

Re: Optimize LISTEN/NOTIFY

2025-11-15 Thread Joel Jacobson
On Fri, Nov 14, 2025, at 17:01, Joel Jacobson wrote: > On Thu, Nov 13, 2025, at 08:13, Joel Jacobson wrote: >> Attached, please find a new version rebased on top of the bug fix >> patches that just got committed in 0bdc777, 797e9ea, 8eeb4a0, and >> 1b46990. > > To help reviewers, here is a new writ

Re: Use opresulttype instead of calling SearchSysCache1() in match_orclause_to_indexcol()

2025-11-15 Thread Tom Lane
Tender Wang writes: > Tom Lane 于2025年9月20日周六 00:16写道: >> I don't understand what purpose this check serves at all. >> We are looking at an arm of an OR clause, so it had better >> yield boolean. > Yeah, this check doesn't need any more. I removed this check in the > attached patch. > In match_i

Re: Early December Commitfest app release

2025-11-15 Thread Magnus Hagander
On Sat, Nov 15, 2025, 17:36 Jelte Fennema-Nio wrote: > On Sat, Nov 15, 2025, 07:05 Magnus Hagander wrote: > >> Yes, IIRC we had security complaints about people being able to enumerate >> all users without being logged in. Since it's not just users who submitted >> any data, it was enough to jus

Re: Early December Commitfest app release

2025-11-15 Thread Jelte Fennema-Nio
On Sat, Nov 15, 2025, 07:05 Magnus Hagander wrote: > Yes, IIRC we had security complaints about people being able to enumerate > all users without being logged in. Since it's not just users who submitted > any data, it was enough to just having clicked a link once... > I think the "without being

Re: regarding statistics retaining with 18 Upgrade

2025-11-15 Thread Greg Sabino Mullane
On Sat, Nov 15, 2025 at 9:32 AM Bruce Momjian wrote: > Uh, it is the _optimizer_ statistics that are preserved by pg_upgrade, > Specifically, check out the pg_stats view. Try this on your new cluster: select count(distinct tablename) from pg_stats where tablename !~ 'pg_|sql_'; Cheers, Greg -

Re: should we have a fast-path planning for OLTP starjoins?

2025-11-15 Thread Tom Lane
Nico Williams writes: > Some unsolicited advice: > ... > But here you can just use the order that the SQL uses. It gives the > author some power. If that's the approach you want, it's been possible for decades: "set join_collapse_limit = 1" and away you go. I don't feel a need to invent a diffe

Re: [Patch] Mention md5 is deprecated in postgresql.conf.sample

2025-11-15 Thread Michael Banck
Hi, On Sat, Nov 15, 2025 at 09:37:37AM -0500, Robert Treat wrote: > +1 to the general idea, though I think it should go the other way > around (it is a small enough grammatical point I'm sure some would > argue the other way around). > > # password_encryption = scram-sha-256 # scram-sha-256 or md

Re: [Patch] Mention md5 is deprecated in postgresql.conf.sample

2025-11-15 Thread Robert Treat
On Fri, Nov 14, 2025 at 5:48 AM Michael Banck wrote: > > Hi, > > while looking through postgresql.conf on PG18, I noticed that > password_encryption mentions md5 as valid alternative to scram-sha-256. > I think it would be useful to mention md5 is deprecated so that people > looking at it (but hav

Re: regarding statistics retaining with 18 Upgrade

2025-11-15 Thread Bruce Momjian
On Sat, Nov 15, 2025 at 06:02:53PM +0800, Rambabu V wrote: > Hi Team, > > seems stats are not retained after upgrade. Below are the artifacts , is it > expected? as per the release notes statistics should be retained. Uh, it is the _optimizer_ statistics that are preserved by pg_upgrade, not the

Re: Document NULL

2025-11-15 Thread David G. Johnston
On Saturday, November 15, 2025, Peter Eisentraut wrote: > On 11.11.25 16:34, Álvaro Herrera wrote: > >> On 2025-Jun-18, David G. Johnston wrote: >> >> Version 8. >>> >>> Marking this Ready to Commit in CF 2025-09 (CF PG19-1) >>> >> >> I have rebased this; here's v9. I haven't reviewed it in dept

Re: Early December Commitfest app release

2025-11-15 Thread Magnus Hagander
On Wed, Nov 12, 2025, 22:48 Jacob Champion wrote: > On Tue, Nov 11, 2025 at 2:12 AM Jelte Fennema-Nio wrote: > > 3. Make user dropdowns searchable when not logged in > > Adding Magnus -- Magnus, do you remember the rationale for re-adding > this protection back in 6ff8c6a52? Does it still apply?

Re: ON CONFLICT DO SELECT (take 3)

2025-11-15 Thread jian he
On Sat, Nov 15, 2025 at 5:24 AM jian he wrote: > > On Fri, Nov 14, 2025 at 10:34 PM Viktor Holmberg wrote: > > > > Here are some updates that needed to be done after the improvements to the > > RLS docs / tests in 7dc4fa & 2e8424. > > hi. I did some simple tests, found out that SELECT FOR UPDA

Re: Asynchronous MergeAppend

2025-11-15 Thread Alexander Pyhalov
Matheus Alcantara писал(а) 2025-11-12 00:00: On Wed Nov 5, 2025 at 3:30 AM -03, Alexander Pyhalov wrote: So I'm +1 for the idea. I know it's been while since the last patch, and unfortunully it hasn't received reviews since then. Do you still plan to work on it? I still need to take a look on th

Re: doc: add missing "id" attributes to extension packaging page

2025-11-15 Thread Brar Piening
On 2025-11-14 at 11:59 Alvaro Herrera wrote: On 2023-Apr-13, Karl O. Pinc wrote: Dagfinn Ilmari Mannsåker wrote: Another side note: I notice the links don't appear on elements (e.g. https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH), only . This we know. Working with elements

Re: Comments on Custom RMGRs

2025-11-15 Thread Andrei Lepikhov
On 14/10/2025 11:11, Andrei Lepikhov wrote: For me, the ideal place for such a hook is CheckPointGuts, right between the CheckPointBuffers call and fsyncs. I think that to demonstrate how this hook can work, the pg_stat_statements storage may need to be redesigned slightly. There are two patche

Re: Implement waiting for wal lsn replay: reloaded

2025-11-15 Thread Alexander Korotkov
Hi, Xuneng! On Fri, Nov 14, 2025 at 3:50 AM Xuneng Zhou wrote: > > On Fri, Nov 14, 2025 at 4:32 AM Tomas Vondra wrote: > > > > On 11/5/25 10:51, Alexander Korotkov wrote: > > > Hi! > > > > > > On Mon, Nov 3, 2025 at 5:13 PM Andres Freund wrote: > > >> On 2025-11-03 16:06:58 +0100, Álvaro Herrer

regarding statistics retaining with 18 Upgrade

2025-11-15 Thread Rambabu V
Hi Team, seems stats are not retained after upgrade. Below are the artifacts , is it expected? as per the release notes statistics should be retained. before upgrade: postgres=# select * from pg_stat_user_tables; -[ RECORD 1 ]---+-- relid | 16384

Re: Document NULL

2025-11-15 Thread Peter Eisentraut
On 11.11.25 16:34, Álvaro Herrera wrote: On 2025-Jun-18, David G. Johnston wrote: Version 8. Marking this Ready to Commit in CF 2025-09 (CF PG19-1) I have rebased this; here's v9. I haven't reviewed it in depth, but intend to give it a read and get it pushed sometime in the not-too-distant