Re: Skipping schema changes in publication

2025-11-16 Thread Peter Smith
Hi Shlok, A comment about patch v27-0003 == doc/src/sgml/logical-replication.sgml All references to tables "t1" and "t2" should use the tag in the SGML. The current patch has broken this in multiple places: e.g. -Create a table t1 to be used in the following example. +Create tables

Re: Use exact nullingrels matches for NestLoopParams

2025-11-16 Thread Richard Guo
On Tue, Nov 11, 2025 at 3:58 PM Richard Guo wrote: > Here is a patch that makes that change. It also removes the > NRM_SUBSET enum value, along with all remaining checks for it, since > it is no longer used. With the changes in 0001, we should now be able to use exact nullingrels matches in all

Re: Fix GetOperatorFromCompareType

2025-11-16 Thread Neil Chen
Hi Paul, On Mon, Nov 17, 2025 at 2:34 PM Paul A Jungwirth < [email protected]> wrote: > Hi Hackers, > > I found a few problems with GetOperatorFromCompareType and fixed them here. > > First of all, the comment was out of date: we never return > InvalidStrategy; instead we ereport. > >

Re: Optimize LISTEN/NOTIFY

2025-11-16 Thread Joel Jacobson
On Sat, Nov 15, 2025, at 22:53, Joel Jacobson wrote: > On Fri, Nov 14, 2025, at 17:01, Joel Jacobson wrote: >> On Thu, Nov 13, 2025, at 08:13, Joel Jacobson wrote: >>> Attached, please find a new version rebased on top of the bug fix >>> patches that just got committed in 0bdc777, 797e9ea, 8eeb4a0,

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

2025-11-16 Thread Chao Li
> On Nov 17, 2025, at 08:30, Peter Smith wrote: > > On Fri, Nov 14, 2025 at 7:02 PM Chao Li wrote: >> >> >> >>> On Nov 14, 2025, at 15:47, Fujii Masao wrote: >>> >>> On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote: A rebase was needed. Here is patch v3. >>> >>> Thanks for

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-11-16 Thread Sutou Kouhei
Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Fri, 14 Nov 2025 12:19:47 -0800, Masahiko Sawada wrote: > This thread has involved extensive discussion, and the patch needs to > be rebased. I'd like to summarize the current status of this patch and > our

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

2025-11-16 Thread Amit Kapila
On Fri, Nov 14, 2025 at 3:14 PM Masahiko Sawada wrote: > > On Fri, Nov 14, 2025 at 1:25 AM shveta malik wrote: > > > > In an offline discussion with Kuroda-san, we realized that TRUNCATE > > may hit Assert(XLogLogicalInfoActive()) in ExecuteTruncateGuts() under > > our current implementation, whe

Re: Proposal: Conflict log history table for Logical Replication

2025-11-16 Thread Dilip Kumar
On Thu, Nov 13, 2025 at 9:17 PM Dilip Kumar wrote: > > On Thu, Nov 13, 2025 at 2:39 PM shveta malik wrote: > > > > > Few observations related to publication. > > > -- > > Thanks Shveta, for testing and sharing your thoughts. IMHO for > conflict log tables it should be

Re: Skipping schema changes in publication

2025-11-16 Thread Peter Smith
Hi Shlok, Here are a few ad-hoc comments for patch v27-0002. == doc/src/sgml/logical-replication.sgml 1. - To add tables to a publication, the user must have ownership rights on the - table. To add all tables in schema to a publication, the user must be a - superuser. To create a p

Re: Skipping schema changes in publication

2025-11-16 Thread Peter Smith
On Tue, Nov 11, 2025 at 9:22 PM Shlok Kyal wrote: > > On Fri, 7 Nov 2025 at 09:34, Peter Smith wrote: > > > > Hi Shlok. > > > > This is a general comment about the content of these patches. > > > > IIUC, the v25* patches currently are currently arranged like this: > > > > 0001 > > - New command

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

2025-11-16 Thread Amit Kapila
On Fri, Nov 14, 2025 at 5:10 PM Masahiko Sawada wrote: > > On Fri, Nov 14, 2025 at 3:12 AM Amit Kapila wrote: > > > > On Fri, Nov 14, 2025 at 4:15 PM Masahiko Sawada > > wrote: > > > > > > On Fri, Nov 14, 2025 at 1:38 AM Amit Kapila > > > wrote: > > > > > > > > On Fri, Nov 14, 2025 at 5:01 AM

Re: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY)

2025-11-16 Thread Ashutosh Bapat
On Fri, Nov 14, 2025 at 8:51 PM Boris Mironov wrote: > > Hi Ashutosh, > > > If there is one method that is better than all others, community will > > be more willing to accept implementation of that one method than > > multiple implementations so as to reduce maintenance burden. > > Ok then. I'll

Re: pg_waldump: support decoding of WAL inside tarfile

2025-11-16 Thread Amul Sul
On Thu, Nov 6, 2025 at 2:33 PM Amul Sul wrote: > > On Mon, Oct 20, 2025 at 8:05 PM Robert Haas wrote: > > > > On Thu, Oct 16, 2025 at 7:49 AM Amul Sul wrote: > > [] > Kindly have a look at the attached version. Thank you ! > Attached is the rebased version against the latest master head (e7

Re: Patch: dumping tables data in multiple chunks in pg_dump

2025-11-16 Thread Dilip Kumar
On Tue, Nov 11, 2025 at 9:00 PM Hannu Krosing wrote: > > Attached is a patch that adds the ability to dump table data in multiple > chunks. > > Looking for feedback at this point: > 1) what have I missed > 2) should I implement something to avoid single-page chunks > > The flag --huge-table-chu

misleading error message in DefineIndex

2025-11-16 Thread jian he
hi. while working on virtual generated column as partition key, I found below errmsg the constraint type is hardcoded. if (!found) { Form_pg_attribute att; att = TupleDescAttr(RelationGetDescr(rel), key->p

Re: Compile error on the aarch64 platform: Missing asm/hwcap.h

2025-11-16 Thread Steven Niu
Hi, John, Thomas, IvorySQL team found the same build issue on our building machine when we built IvorySQL code which is based on PG 18.0. pg_crc32c_armv8_choose.c:58:32:error:'HWCAP CRC32' undeclared(first use in this function) 58 | return (getauxval(AT_HWCAP) & HWCAP_CRC32) != θ;

Re: Use opresulttype instead of calling SearchSysCache1() in match_orclause_to_indexcol()

2025-11-16 Thread Tender Wang
Tom Lane 于2025年11月17日周一 01:27写道: > Tender Wang writes: > > Tom Lane 于2025年11月16日周日 04:45写道: > >> Yeah. In fact, I think it's outright wrong to do that here. > >> It'd result in building a SAOP expression that lacks the RelabelType, > >> which seems incorrect since the operator is one that expe

Re: fallocate() causes btrfs to never compress postgresql files

2025-11-16 Thread Thomas Munro
On Mon, Nov 17, 2025 at 4:23 PM Bráulio Oliveira wrote: > Are there any plans to merge the file_extend_method soon? BTRFS > compressed the original > database to 36% of the original size, but now with the DB running it is using > a lot of space crazily, not sure if running VACUUM and ANALYSE is >

Re: fallocate() causes btrfs to never compress postgresql files

2025-11-16 Thread Bráulio Oliveira
On Sun, Nov 16, 2025 at 11:38 PM Dimitrios Apostolou wrote: > > Hi, > > this is just a heads-up about files being generated by PostgreSQL 17 not > being compressed by Btrfs, even when mounted with the force-compress mount > option. I have this occuring aggressively when restoring a database via >

Re: PartitionKeyData->partattrs, refactor some 0 to InvalidAttrNumber

2025-11-16 Thread jian he
On Sat, Nov 15, 2025 at 12:59 AM Bertrand Drouvot wrote: > > Hi, > > On Fri, Nov 14, 2025 at 11:47:35PM +0800, jian he wrote: > > hi. > > > > if PartitionKeyData->partattrs is 0, then it means that partition key is > > expression, else it's column reference. > > > > we can change from > > if (key-

Re: GNU/Hurd portability patches

2025-11-16 Thread Thomas Munro
On Tue, Nov 11, 2025 at 10:49 AM Michael Banck wrote: > |login: task ./test_signalhandler(767) looked up a bogus port 23 for3205, > most probably a bug. . o O { An absurdly far-fetched thought while browsing glibc/hurd glue code: if synchronous I/O is implemented as RPC on Mach ports, could that

Re: Report oldest xmin source when autovacuum cannot remove tuples

2025-11-16 Thread Dilip Kumar
On Sat, Nov 15, 2025 at 5:56 AM Sami Imseih wrote: > > Thanks for starting this thread! This is a very useful > feature that users will find beneficial to easily narrow > down the reason the xmin horizon is being held back, > and take action. +1 for the idea. In BackendXidFindCutOffReason() you

Re: Report oldest xmin source when autovacuum cannot remove tuples

2025-11-16 Thread wenhui qiu
Hi Sami > Thinking about point 3 above, I began to wonder if this > whole thing can be simplified with inspiration. Looking at the > existing BackendXidGetPid(), I think it can. > Based on BackendXidGetPid(), I tried a new routine called > BackendXidFindCutOffReason() which can take in the cutof

Re: Use opresulttype instead of calling SearchSysCache1() in match_orclause_to_indexcol()

2025-11-16 Thread Alexander Korotkov
On Sun, Nov 16, 2025 at 7:27 PM Tom Lane wrote: > Tender Wang writes: > > Tom Lane 于2025年11月16日周日 04:45写道: > >> Yeah. In fact, I think it's outright wrong to do that here. > >> It'd result in building a SAOP expression that lacks the RelabelType, > >> which seems incorrect since the operator is

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

2025-11-16 Thread Peter Smith
On Fri, Nov 14, 2025 at 7:02 PM Chao Li wrote: > > > > > On Nov 14, 2025, at 15:47, Fujii Masao wrote: > > > > On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote: > >> > >> A rebase was needed. Here is patch v3. > > > > Thanks for the patch! LGTM. > > > > For example, in the CREATE PUBLICATION s

Re: Dead code in ps_status.c

2025-11-16 Thread Thomas Munro
On Tue, Nov 11, 2025 at 11:04 AM Thomas Munro wrote: > https://www.postgresql.org/message-id/68adbcd3.500a0220.8d4c9.9460%40mx.google.com > > Sorry I missed this. I had some trouble with your messages being > deleted as spam, which I've hopefully fixed now... > > -#elif defined(__linux__) || defi

Re: Some efforts to get rid of "long" in our codebase

2025-11-16 Thread David Rowley
On Mon, 10 Nov 2025 at 13:53, David Rowley wrote: > v2-0001 wraps the format string as suggested by Heikki, v3-0001 uses > unsigned long long as suggested by Peter. > > v2-0002 is updated to use size_t instead of Size, per Heikki > > Any further opinions or votes on v2-0001 vs v3-0001? Nobody see

Re: pgsql: Drop unnamed portal immediately after execution to completion

2025-11-16 Thread Michael Paquier
On Fri, Nov 14, 2025 at 03:10:32PM +, Mircea Cadariu wrote: > What's interesting about the holdable cursors scenario is that as far as I > can tell the temp files are cleaned up during PersistHoldablePortal instead > of PortalDrop. Done this one as e7cde9dad285. -- Michael signature.asc Desc

Re: Improve error reporting in 027_stream_regress test

2025-11-16 Thread Michael Paquier
On Sat, Nov 15, 2025 at 04:58:17PM -0500, Tom Lane wrote: > I just marked the CF entry for this thread committed [1], because I > saw that the cfbot was reporting its patch-of-record as committed. Thanks. I've had this item in my bucket of things to do for some time but got drifted away. I am no

Re: Use opresulttype instead of calling SearchSysCache1() in match_orclause_to_indexcol()

2025-11-16 Thread Tom Lane
Tender Wang writes: > Tom Lane 于2025年11月16日周日 04:45写道: >> Yeah. In fact, I think it's outright wrong to do that here. >> It'd result in building a SAOP expression that lacks the RelabelType, >> which seems incorrect since the operator is one that expects the >> relabeled type. >> >> The Relabel

Re: System views for versions reporting

2025-11-16 Thread Dmitry Dolgov
> On Tue, Apr 01, 2025 at 09:27:23PM +0200, Dmitry Dolgov wrote: > > On Sun, Mar 23, 2025 at 06:21:33PM GMT, Tom Lane wrote: > > > > FWIW, I think the 0004 patch is about to be mostly obsoleted by > > Andrei's proposal at [1]. To the extent that it's not obsoleted, > > I question whether it's some

[PATCH] Add memory usage reporting to VACUUM VERBOSE

2025-11-16 Thread 河田達也
Hi, I would like to propose a patch that adds memory usage reporting to VACUUM VERBOSE output. This helps users understand how much memory is being used for dead tuple tracking and whether memory limits are being hit during vacuum operations. I have tested this patch with both serial and paralle

Re: Implement waiting for wal lsn replay: reloaded

2025-11-16 Thread Alexander Korotkov
On Sun, Nov 16, 2025 at 3:25 PM Xuneng Zhou wrote: > On Sat, Nov 15, 2025 at 6:29 PM Alexander Korotkov > wrote: > > Thank you so much for your patches! > > Pushed with minor corrections. > > Thanks for pushing! It appears I should be running pgindent more regularly :). Thank you. pgindent is

Re: Implement waiting for wal lsn replay: reloaded

2025-11-16 Thread Xuneng Zhou
Hi! On Sun, Nov 16, 2025 at 8:37 PM Alexander Korotkov wrote: > > On Wed, Nov 12, 2025 at 9:20 AM Xuneng Zhou wrote: > > On Wed, Nov 5, 2025 at 5:51 PM Alexander Korotkov > > wrote: > > > On Mon, Nov 3, 2025 at 5:13 PM Andres Freund wrote: > > > > On 2025-11-03 16:06:58 +0100, Álvaro Herrera

Re: Implement waiting for wal lsn replay: reloaded

2025-11-16 Thread Xuneng Zhou
Hi! On Sun, Nov 16, 2025 at 8:09 PM Alexander Korotkov wrote: > > On Sat, Nov 8, 2025 at 12:02 AM Alexander Korotkov > wrote: > > On Wed, Nov 5, 2025 at 4:03 PM Xuneng Zhou wrote: > > > On Wed, Nov 5, 2025 at 5:51 PM Alexander Korotkov > > > wrote: > > > > On Mon, Nov 3, 2025 at 5:13 PM Andr

Re: Implement waiting for wal lsn replay: reloaded

2025-11-16 Thread Xuneng Zhou
Hi Alexander, On Sat, Nov 15, 2025 at 6:29 PM Alexander Korotkov wrote: > > Hi, Xuneng! > > On Fri, Nov 14, 2025 at 3:50 AM Xuneng Zhou wrote: > > > > On Fri, Nov 14, 2025 at 4:32 AM Tomas Vondra wrote: > > > > > > On 11/5/25 10:51, Alexander Korotkov wrote: > > > > Hi! > > > > > > > > On Mon,

Re: Use opresulttype instead of calling SearchSysCache1() in match_orclause_to_indexcol()

2025-11-16 Thread Tender Wang
Tom Lane 于2025年11月16日周日 04:45写道: > Tender Wang writes: > > Tom Lane 于2025年9月20日周六 00:16写道: > >> I don't understand what purpose this check serves at all. > >> We are looking at an arm of an OR clause, so it had better > >> yield boolean. > > > Yeah, this check doesn't need any more. I removed t

Re: Implement waiting for wal lsn replay: reloaded

2025-11-16 Thread Alexander Korotkov
On Wed, Nov 12, 2025 at 9:20 AM Xuneng Zhou wrote: > On Wed, Nov 5, 2025 at 5:51 PM Alexander Korotkov > wrote: > > On Mon, Nov 3, 2025 at 5:13 PM Andres Freund wrote: > > > On 2025-11-03 16:06:58 +0100, Álvaro Herrera wrote: > > > > On 2025-Nov-03, Alexander Korotkov wrote: > > > > > > > > > I

Re: Implement waiting for wal lsn replay: reloaded

2025-11-16 Thread Alexander Korotkov
On Sat, Nov 8, 2025 at 12:02 AM Alexander Korotkov wrote: > On Wed, Nov 5, 2025 at 4:03 PM Xuneng Zhou wrote: > > On Wed, Nov 5, 2025 at 5:51 PM Alexander Korotkov > > wrote: > > > On Mon, Nov 3, 2025 at 5:13 PM Andres Freund wrote: > > > > On 2025-11-03 16:06:58 +0100, Álvaro Herrera wrote: >