On 2023-03-14 09:29:56 +0900, Michael Paquier wrote:
> The emulation of waitpid() for WIN32 is now in postmaster.c. Could it
> make sense for some of the frontend code to be able to rely on that,
> as well?
Please not as part of this bugfix. It's intricately tied to postmaster.c
specific code,
uct a reproduction of the case, but it seems to me that
> the race condition is not impossible here.
I suspect the issue could be made much more likely by adding a sleep before
the pg_queue_signal(SIGCHLD) in pgwin32_deadchild_callback().
Greetings,
Andres Freund
> I suppose we could also consider an interface with an absolute timeout
> instead, and then stop thinking about the units so much.
That seesm pretty awful to use, and we'd just end up with the same question at
the callsites.
Greetings,
Andres Freund
Hi,
On 2023-03-13 23:46:41 +0300, Nazir Bilal Yavuz wrote:
> Thanks for the patch, I understand the problem now and your patch fixes this.
Pushed the patch.
Greetings,
Andres Freund
Hi,
On 2023-03-13 13:41:19 -0700, Andres Freund wrote:
> On 2023-03-13 21:22:29 +0100, Peter Eisentraut wrote:
> > On 12.03.23 01:11, Andres Freund wrote:
> > > Have you done benchmarks of some simple workloads to verify this doesn't
> > > cause
> > >
Hi,
On 2023-03-13 21:22:29 +0100, Peter Eisentraut wrote:
> On 12.03.23 01:11, Andres Freund wrote:
> > Have you done benchmarks of some simple workloads to verify this doesn't
> > cause
> > slowdowns (when not using encryption, obviously)? printtup.c is a
> > perfor
are not present?
>
> Yes, I tested again and it is working as expected on my end. It
> shouldn't fail like that unless the 'ssl' option is set to 'openssl'.
> Is it possible that it has been set to 'openssl' without you noticing?
It worked for the dependency() path, but not the cc.find_library() path. See
the patch I just sent.
Greetings,
Andres Freund
l_int wouldn't exist.
Maybe something like the attached?
Greetings,
Andres Freund
>From b8bd0200667bac16674e40e769a9fb4bc4f54306 Mon Sep 17 00:00:00 2001
From: Andres Freund
Date: Mon, 13 Mar 2023 13:11:37 -0700
Subject: [PATCH v1] meson: fix openssl detection issues in 6a30027
Reported-by: N
ke a good idea to me.
Greetings,
Andres Freund
hey return multiple
columns.
And making tupledescs even wider is likely to have some price, both due to the
increase in memory usage, and due to the lower cache density - and that's code
where we're already hurting noticeably.
Greetings,
Andres Freund
Hi,
On 2023-03-11 15:34:55 -0800, Mark Dilger wrote:
> > On Mar 11, 2023, at 3:22 PM, Andres Freund wrote:
> >
> > Something like the attached.
>
> I like that your patch doesn't make the test longer. I assume you've already
> run the tests and that it works.
I
?
That still leaves a few logline, from before the config file parsing, but it's
a lot better than all requests getting logged.
Obviously I also could reconfigure syslog to just filter this stuff, but it
seems that the tests shouldn't spam like that.
Greetings,
Andres Freund
r 500ms.
>
> I don't recall the reasoning. Feel free to optimize the tests.
Something like the attached.
I don't know enough perl to know how to interpolate something like
use constant ROWCOUNT => 17;
so I just made it a variable.
Greetings,
Andres Freund
>From a01e1481505e74097112c0ea3
gt; do)
Yea, that was just wrong. It happened to work on debian and a few other OSs,
but ossp's .pc puts whatever the right directory is into the include
path. Pushed the fairly obvious fix.
Greetings,
Andres Freund
ve the following in my
~/.ssh/config to work around that:
Host gcc210.fsffrance.org
PubkeyAcceptedKeyTypes +ssh-rsa
KexAlgorithms +diffie-hellman-group1-sha1
Host gcc211.fsffrance.org
PubkeyAcceptedKeyTypes +ssh-rsa
Greetings,
Andres Freund
Hi,
On 2023-03-10 19:37:27 -0800, Andres Freund wrote:
> On 2022-03-23 08:56:17 -0700, Andres Freund wrote:
> > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote:
> > > On 3/22/22 22:23, Andres Freund wrote:
> > > That only helps when running the CI/cfbot setup. Fixing
Hi,
On 2022-03-23 08:56:17 -0700, Andres Freund wrote:
> On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote:
> > On 3/22/22 22:23, Andres Freund wrote:
> > That only helps when running the CI/cfbot setup. Fixing it for other
> > (manual or buildfarm) users would be nice
Hi,
On 2023-03-09 11:55:57 -0800, Andres Freund wrote:
> On 2023-03-09 14:47:36 -0500, Andrew Dunstan wrote:
> > On 2023-03-09 Th 08:28, Andrew Dunstan wrote:
> > > At this stage I think I'm prepared to turn this loose on a couple of my
> > > buildfarm animal
at, but the make situation is
overly complicated. I don't really want to emulate having randomly differing
database names just because a test is in contrib/ rather than src/.
Greetings,
Andres Freund
Hi,
On 2023-03-09 06:51:31 -0600, Justin Pryzby wrote:
> On Tue, Mar 07, 2023 at 10:18:44AM -0800, Andres Freund wrote:
> > Hi,
> >
> > On 2023-03-06 15:21:14 -0500, Melanie Plageman wrote:
> > > Good point. Attached is what you suggested. I committed the transacti
Hi,
On 2023-03-09 09:36:52 +0900, Michael Paquier wrote:
> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
> >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
> >> it's
Hi,
On 2023-03-08 12:55:34 +0100, Drouvot, Bertrand wrote:
> On 3/7/23 7:47 PM, Andres Freund wrote:
> > On 2023-03-07 13:43:28 -0500, Melanie Plageman wrote:
> > > > Now I've a second thought: what do you think about resetting the
> > > > related number
> &
ange and honoring it for future attempts to grow the memory
> and on future passes through the heap would be plenty.
>
> All that said, don't let these suggestions get in the way of committing
> this. Just having the ability to tweak cost parameters would be a win.
Nobody said anything about it not being useful to react to m_w_m changes, just
that it's not required to make some progress . So I really don't understand
what the point of your comment is.
Greetings,
Andres Freund
Hi,
On 2023-02-06 13:02:05 -0800, Andres Freund wrote:
> I didn't quite feel confident pushing a fix for this just before a minor
> release, so I'll push once the minor releases are tagged. A quite minimal fix
> to GetFullRecentGlobalXmin() in 12-13 (returning FirstNormalTransactionId i
Hi,
On 2023-02-07 16:56:55 -0500, Robert Haas wrote:
> On Wed, Feb 1, 2023 at 4:02 PM Andres Freund wrote:
> > > + /* Is the use of a password mandatory? */
> > > + must_use_password = MySubscription->passwordrequired &&
> > > +
a simple nested loop self-join, that'll prevent
the page being evicted, because it'll still be pinned on the outer side, while
generating hits on the inner side.
Greetings,
Andres Freund
Hi,
On 2023-03-02 17:35:26 -0500, Andrew Dunstan wrote:
> On 2023-03-02 Th 17:06, Andres Freund wrote:
> > Hi
> >
> > On 2023-03-02 17:00:47 -0500, Andrew Dunstan wrote:
> > > On 2023-03-01 We 16:32, Andres Freund wrote:
> > > > > This is now working
Hi,
On 2023-03-08 09:41:57 -0500, Andrew Dunstan wrote:
> On 2023-03-08 We 08:57, Andrew Dunstan wrote:
> > On 2023-03-07 Tu 20:29, Andres Freund wrote:
> > > On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote:
> > > Here's a prototype for that.
> > >
> &
On 2023-03-07 18:26:21 -0800, Andres Freund wrote:
> On 2023-02-23 06:27:23 -0500, Andrew Dunstan wrote:
> > Yeah. For touch I think we can probably just get rid of this line in the
> > root meson.build:
> >
> > touch = find_program('touch', native: true)
>
>
eplace with something else
- tar, gzip - just for tests
I'm not sure it's worth working on not requiring those.
There's also flex, bison, perl, but those will stay a hard requirement for a
while longer... :)
Greetings,
Andres Freund
>From 564092bfb4c108c387cac3562a7dbad8c3126fea Mon Sep 17 00
Hi,
On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote:
> On 2023-03-07 Tu 14:37, Andres Freund wrote:
> > The failures are like this:
> >
> > +ERROR: extension "dummy_index_am" is not available
> > +DETAIL: Could not open extension control file
> >
actually improves. Introducing
even infrastructure to get a not that big win, in a not particularly
interesting, extreme, workload...
What is motivating this?
Greetings,
Andres Freund
Hi,
On 2023-03-07 08:22:45 +0530, Amit Kapila wrote:
> On Tue, Mar 7, 2023 at 1:34 AM Andres Freund wrote:
> > I think even as-is it's reasonable to just use it. The sequential scan
> > approach is O(N^2), which, uh, is not good. And having an index over
> > thousands
Hi,
LGTM. The only comment I have is that a small test wouldn't hurt... Compared
to the other things it should be fairly easy...
Greetings,
Andres Freund
Hi,
On 2023-03-01 13:32:58 -0800, Andres Freund wrote:
> On 2023-03-01 16:21:32 -0500, Andrew Dunstan wrote:
> > Perhaps the latest version will be more to your taste.
>
> I'll check it out.
A simple conversion from an existing config failed with:
Can't use an undefined va
n basis.
I think we simply shouldn't do anything here. This is a pre-existing issue. I
also think that loosing stats when turning track_io_timing on/off would not be
helpful.
Greetings,
Andres Freund
getting worse with this change.
> typedef struct PgStat_BktypeIO
> {
> - PgStat_Counter
> data[IOOBJECT_NUM_TYPES][IOCONTEXT_NUM_TYPES][IOOP_NUM_TYPES];
> + PgStat_Counter
> counts[IOOBJECT_NUM_TYPES][IOCONTEXT_NUM_TYPES][IOOP_NUM_TYPES];
> + instr_time
> times[IOOBJECT_NUM_TYPES][IOCONTEXT_NUM_TYPES][IOOP_NUM_TYPES];
> } PgStat_BktypeIO;
Ah, you're going to hate me. We can't store instr_time on disk. There's
another patch that gets substantial peformance gains by varying the frequency
at which instr_time keeps track of time based on the CPU frequency... It also
just doesn't have enough range to keep track of system wide time on a larger
system. A single backend won't run for 293 years, but with a few thousand
backends that's a whole different story.
I think we need to accumulate in instr_time, but convert to floating point
when flushing stats.
Greetings,
Andres Freund
guchi-san, Melanie.
Greetings,
Andres Freund
-T 600 -j 5 -c 50)
>
> Result: Both patches and master are the same within a tolerance of
> less than 0.7%.
What exactly does that mean? I would definitely not want to accept a 0.7%
regression of the uncontended case to benefit the contended case here...
Greetings,
Andres Freund
Hi,
On 2023-03-03 15:09:18 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-03-02 13:00:31 -0800, Andres Freund wrote:
> >> I'm not opposed to EXPR_PARAM_SET, to be clear. I'll send an updated
> >> version later. I was just thinking about the correctnes
pg_pwrite_zeros(), I have applied v3 after
> switches the size and offset parameters to be the same way as in v4.
Thanks.
Greetings,
Andres Freund
cal replicas and that
> there was consensus that as long as single-user mode worked that it
> was ok?
I don't think it's OK with just single user mode as an scape hatch. We need
the GUC that was discussed as part of the thread (and I think there's a patch
for that too).
Greetings,
Andres Freund
think the case in which the patch regresses performance in is irrelevant in
practice. It's good to not regress unnecessarily for easily avoidable reason,
even in such cases, but it's not worth holding anything up due to it.
Greetings,
Andres Freund
Hi,
On 2023-03-01 14:10:07 +0530, Amit Kapila wrote:
> On Wed, Mar 1, 2023 at 12:09 AM Andres Freund wrote:
> >
> > > I see this as a way to provide this feature for users but I would
> > > prefer to proceed with this if we can get some more buy-in from senior
> &
Hi,
On 2023-03-06 14:24:09 -0500, Melanie Plageman wrote:
> On Mon, Mar 06, 2023 at 11:09:19AM -0800, Andres Freund wrote:
> > On 2023-03-06 10:09:24 -0500, Melanie Plageman wrote:
> > > On Mon, Mar 6, 2023 at 1:48 AM Kyotaro Horiguchi
> > > wrote:
> > > &g
action? Then there couldn't be any other accesses in
just that section. I'm not convinced it's good to disallow all concurrent
activity in other parts of the test.
Greetings,
Andres Freund
he buffer, we should copy the portion that is still in the buffer, and then
send/receive directly from the data to be sent/received.
Greetings,
Andres Freund
ng one member better than introducing one new parameter
> in multiple calls?
Reducing the member isn't important, needing to set it before each
callback however makes sense.
Greetings,
Andres Freund
On 2023-03-02 14:41:26 -0500, reid.thomp...@crunchydata.com wrote:
> Patch has been rebased to master.
Quite a few prior review comments seem to not have been
addressed. There's not much point in posting new versions without that.
I think there's zero chance 0002 can make it into 16. If 0001 is
Hi,
On 2023-03-02 13:00:31 -0800, Andres Freund wrote:
> I'm not opposed to EXPR_PARAM_SET, to be clear. I'll send an updated
> version later. I was just thinking about the correctness in the current
> world.
Attached.
I named the set EEOP_PARAM_SET EEOP_PARAM_EXEC_SET or such,
Hi
On 2023-03-02 17:00:47 -0500, Andrew Dunstan wrote:
>
> On 2023-03-01 We 16:32, Andres Freund wrote:
> > > This is now working
> > > on my MSVC test rig (WS2019, VS2019, Strawberry Perl), including TAP
> > > tests.
> > > I do
Hi,
On 2023-03-02 15:10:31 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-03-02 14:33:35 -0500, Tom Lane wrote:
> >> I looked through this, and there is one point that is making me really
> >> uncomfortable. This bit is assuming t
Hi,
On 2023-03-02 14:33:35 -0500, Tom Lane wrote:
> Andres Freund writes:
> > Around
> > https://www.postgresql.org/message-id/20230224015417.75yimxbksejpffh3%40awork3.anarazel.de
> > I suggested that we should evaluate the arguments of correlated SubPlans as
>
includes user defined functions.
This basically proposes that we can implement a safe sandbox for executing
arbitrary code in a privileged context. IMO history suggests that that's a
hard thing to do.
Am I missing something?
Greetings,
Andres Freund
Hi,
On 2023-02-28 11:16:45 +0900, Masahiko Sawada wrote:
> On Tue, Feb 28, 2023 at 10:21 AM Andres Freund wrote:
> > On 2023-02-27 23:11:53 +0900, Masahiko Sawada wrote:
> > > As far as I know there are not such GUC parameters in the core but
> > > there might
Hi,
On 2023-02-28 12:36:38 -0800, Jeff Davis wrote:
> On Tue, 2023-02-28 at 11:28 -0800, Andres Freund wrote:
> > I can only repeat myself in stating that SECURITY DEFINER solves none
> > of the
> > relevant issues. I included several examples of why it doesn't in the
> &
t_group(2) = ?
+++ exited with 2 +++
We do way too many non-signal safe things in quickdie(). But I'm not sure what
the alternative is, given we probably do want to send something to the client.
Greetings,
Andres Freund
Hi,
On 2023-02-28 13:45:41 +0900, Michael Paquier wrote:
> On Tue, Feb 14, 2023 at 12:47:12PM -0800, Andres Freund wrote:
> > Just naively hacking this behaviour change into the current code, would
> > yield
> > sending SIGQUIT to postgres, and then SIGTERM to the whole pro
Hi,
On 2023-03-01 14:47:51 -0800, Nathan Bossart wrote:
> On Tue, Feb 28, 2023 at 08:36:03PM -0800, Nathan Bossart wrote:
> > On Sun, Feb 26, 2023 at 12:12:27PM -0800, Andres Freund wrote:
> >> Partially I just want something that can easily be searched for, that can
>
essages like this:
>
> Unknown TAP version. The first line MUST be `TAP version `. Assuming
> version 12.
The newest minor version has fixed that, it was a misunderstanding about /
imprecision in the tap 14 specification.
Greetings,
Andres Freund
Hi,
On 2023-03-01 09:02:00 -0800, Andres Freund wrote:
> On 2023-03-01 11:12:35 +0200, Heikki Linnakangas wrote:
> > On 27/02/2023 23:45, Andres Freund wrote:
> > > But, uh, isn't this code racy? Because this doesn't go through shared
> > > buffers,
> > > th
Hi,
On 2023-03-01 11:12:35 +0200, Heikki Linnakangas wrote:
> On 27/02/2023 23:45, Andres Freund wrote:
> > But, uh, isn't this code racy? Because this doesn't go through shared
> > buffers,
> > there's no IO_IN_PROGRESS interlocking against a concurrent reader. We know
&
oncurrent relation
extension.
The reason EB_CREATE_FORK_IF_NEEDED exists is to remove the duplicated,
gnarly, code to do so from vm_extend(), fsm_extend().
I'm not sure about the function naming pattern. I do like 'By' a lot more than
the Bulk prefix I used before.
What do you think?
Greetings,
Andres Freund
ECURITY INVOKER". E.g. that default arguments of
SECDEF functions are evaluated with the current user's privileges, not the
function owner's privs:
https://postgr.es/m/20230113032943.iyxdu7bnxe4cmbld%40awork3.anarazel.de
Greetings,
Andres Freund
on.
I'd prefer not having an option, because we figure out the cause of the
performance regression (reducing it to be small enough to not care). After
that an option defaulting to using indexes. I don't think an option defaulting
to false makes sense.
I don't care whether it's subscription or relation level option.
Greetings,
Andres Freund
autovacuum processes but also for manual vacuum/analyze processes. Both
> processes can update them accordingly in vacuum_delay_point().
I don't think this is a good idea. It'd introduce a fair amount of complexity
without, as far as I can tell, a benefit.
Greetings,
Andres Freund
On 2023-02-27 14:58:30 -0500, Tom Lane wrote:
> Agreed. I'll push this along with the earlier patch if there are
> not objections.
None here.
urns an IO-in-progress buffer that you can initialize any way you
> want.
I'd much rather encapsulate that in additional functions, or perhaps a
callback that can make decisions about what to do.
Greetings,
Andres Freund
> + strategy_name);
> + }
> +
> + // TODO: DEBUG logging message for dev?
> + if (buffers == 0)
> + btype = BAS_NORMAL;
GetAccessStrategy() often can be executed hundreds of thousands of times a
second, so I'm very sceptical that adding log messages to it useful.
Greetings,
Andres Freund
tion handling if the
terminations were required. So even leaving other things aside, I prefer this
version.
Greetings,
Andres Freund
promoting these or other warnings to
> fatal?
You mean the perl warnings?
Greetings,
Andres Freund
s seem fairly complicated...
*If* we wanted to rescue it, we probably could just use a transaction around
the SELECT and the termination, which ought to prevent sinval issues.
Not that I understand why that tries to terminate connections, instead of just
looking at application name.
Greetings,
Andres Freund
On 2023-02-26 15:08:33 -0500, Tom Lane wrote:
> Andres Freund writes:
> > They're all animals for testing older LLVM versions. They're using
> > pretty old clang versions. phycodurus and dragonet are clang 3.9, petalura
> > and
> > desmoxytes is clang 4, idiacan
Hi,
On 2023-02-26 11:39:00 -0800, Nathan Bossart wrote:
> On Sun, Feb 26, 2023 at 10:00:29AM -0800, Andres Freund wrote:
> > On 2023-02-25 14:06:29 -0800, Nathan Bossart wrote:
> >> On Sat, Feb 25, 2023 at 11:52:53AM -0800, Andres Freund wrote:
> >> > I think I
Hi,
On 2023-02-26 14:51:45 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-12-08 16:15:11 -0800, Andres Freund wrote:
> >> The most frequent case is postgres_fdw, which somewhat regularly fails
> >> with a
> >> regression.diff like this:
> >&
Hi,
On 2023-02-26 14:40:00 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-02-26 13:20:00 -0500, Tom Lane wrote:
> >> I hadn't run my buildfarm-compile-warning scraper for a little while,
> >> but I just did, and I find that this commit is causing warnin
Hi,
On 2022-12-08 16:15:11 -0800, Andres Freund wrote:
> The most frequent case is postgres_fdw, which somewhat regularly fails with a
> regression.diff like this:
>
> diff -U3 /tmp/cirrus-ci-build/contrib/postgres_fdw/expected/postgres_fdw.out
> /tmp/cirrus-ci-build/build/testr
Hi,
On 2023-02-26 13:20:00 -0500, Tom Lane wrote:
> Andres Freund writes:
> > Pushed the first (and biggest) commit. More tomorrow.
>
> I hadn't run my buildfarm-compile-warning scraper for a little while,
> but I just did, and I find that this commit is causing warnings on
Hi,
On 2023-02-25 14:06:29 -0800, Nathan Bossart wrote:
> On Sat, Feb 25, 2023 at 11:52:53AM -0800, Andres Freund wrote:
> > I think I opined on this before, but we really ought to have a function to
> > do
> > some minimal signal safe output. Implemented centrally, inste
to rerun the
test in a precise way.
Greetings,
Andres Freund
also work. -Dpkg_config_path=...
Does that suffice?
Greetings,
Andres Freund
ined. The way the warning is triggered it seems to have to be
predefined somewhere in/below postgres.h.
It might be that we'll get more information after disabling precompiled headers.
Greetings,
Andres Freund
the arguments are a single Var, which end up with a
slot_getattr() via ExecJust*Var, we also elide redundant slot_getattr()
checks. I think we already avoided redundant tuple deforming, because the
parent ExprState will have done that already.
Greetings,
Andres Freund
>F
Hi,
On 2023-02-25 11:28:25 -0800, Nathan Bossart wrote:
> On Sat, Feb 25, 2023 at 11:07:42AM -0800, Andres Freund wrote:
> > Why do we need that rc variable? Don't we normally get away with (void)
> > write(...)?
>
> My compiler complains about that. :/
>
>
e if forked by
> system(), etc. */
>
> auxproc = [proctype];
>
> --
> 2.25.1
I think the much more interesting assertion here would be to check that
MyProc->pid equals the current pid.
Greetings,
Andres Freund
Hi,
On 2023-02-19 20:06:24 +0530, Robert Haas wrote:
> On Sun, Feb 19, 2023 at 2:45 AM Andres Freund wrote:
> > To me that seems even simpler? Nothing but the archiver is supposed to
> > create
> > .done files and nothing is supposed to remove .ready files without archiv
Hi,
On 2023-02-22 10:09:10 +0100, Peter Eisentraut wrote:
> On 20.02.23 20:48, Andres Freund wrote:
> > On 2023-02-20 19:43:56 +0100, Peter Eisentraut wrote:
> > > I don't think any callers try to copy a directory source, so the
> > > shutil.copytree() stuff isn't n
Hi,
On 2022-12-28 17:44:47 -0800, Andres Freund wrote:
> On 2022-12-28 18:35:38 -0600, Justin Pryzby wrote:
> > Since a few days ago, the windows/meson task has been spewing messages for
> > each tap
> > test:
> >
> > | Unknown TAP version. The first line
implementing
the default expression in case of a failure.
So I'm not sure we even need a reserror field in ExprState.
Greetings,
Andres Freund
, cachelines: 1, members: 4 */
};
We don't have memory to spare in the "general" portion of ExprEvalStep
(currently 24 bytes), as several of the type-specific portions are already 40
bytes large.
Greetings,
Andres Freund
On 2023-02-23 06:27:23 -0500, Andrew Dunstan wrote:
>
> On 2023-02-22 We 20:20, Andres Freund wrote:
> >
> > > There is work to do to make sure we pick up the right log files, and maybe
> > > adjust a module or two. I have adopted a design where instead of tr
the
> regression tests, which don't like setting lc_time to 'de_DE'. Not sure
> what's going on there.
Huh, that's odd.
> meson apparently wants touch and cp installed, although I can't see why at
> first glance. For Windows I just copied them into the path from an msys2
> installation.
Those should probably be fixed.
Greetings,
Andres Freund
Hi,
On 2023-02-22 17:01:47 -0800, Andres Freund wrote:
> One way to to defend against this would be to make mdextend(), whenever it
> extends into the last block of a segment, unlink the next segment - it can't
> be a validly existing contents. But it seems scary to just unlink entire
&
an't
be a validly existing contents. But it seems scary to just unlink entire
segments.
Greetings,
Andres Freund
Hi,
On 2023-02-22 16:34:44 -0500, Tom Lane wrote:
> I wrote:
> > Andres Freund writes:
> >> Maybe it's worth sticking a StaticAssert() for the struct size
> >> somewhere.
>
> > Indeed. I thought we had one already.
>
> >> I'm a bit wary abo
hs would be too painful,
IDK.
> And no, deduplication isn't on the table at all here.
+1
Greetings,
Andres Freund
Hi,
On 2023-02-21 11:22:26 -0800, Andres Freund wrote:
> On 2023-02-21 18:18:02 +0200, Heikki Linnakangas wrote:
> > Do other ReadBufferModes than RBM_ZERO_AND_LOCK make sense with
> > ExtendRelationBuffered?
>
> Hm. That's a a good point. Probably not. Perhaps it could
ny reordering
/ added aggregate would lead to everything else changing as well.
Greetings,
Andres Freund
Hi,
On 2023-02-20 16:08:00 +0100, Peter Eisentraut wrote:
> On 11.02.23 20:24, Andres Freund wrote:
> I think we should just do it and not care about what breaks. There has
> never been any guarantee about these.
>
> FWIW, "most" other SQL implementations appear to g
and printing.
>
> Rebased patch to handle breakage of v2 due to bd8d453e9b.
I think we probably should just apply this? The current behaviour doesn't seem
right, and I don't see a downside of the new behaviour?
Greetings,
Andres Freund
1301 - 1400 of 8902 matches
Mail list logo
