Hi,
I am unable to apply the patch on master. Can you please confirm if the patch
is rebased?
Regards,
Akshat Jaimini
Hi,
I think there is still some problem with the patch. I am not able to apply it
to the master branch.
Can you please take another look at it?
Thanks,
Akshat Jaimini
Hi Jacob,
Thanks a lot for this! We have been trying to come up with a similar
feature for the new commitfest app [0].
> If we like this, I'm happy to help port a version of it over to the
commitfest app.
I would love to help you out in porting this to the commitfest app.
Regards
This seems like a great idea !
Maybe we can start out by adding some basic CI tests on the mirror
repository to sort of 'dry run' the new process?
I'll be happy to submit a PR with some basic tests on the repository.
Regards,
Akshat Jaimini
On Thu, Jan 23, 2025 at 6:48 PM Je
Hi,
Quick question, are there any more revisions left to be done on this patch from
the previous feedback?
Or should I continue with reviewing the current patch?
Regards,
Akshat Jaimini
ription for
a patch explaining its history and need in brief would be really helpful
for people to get started instead of trying to make sense of a very large
email thread. This is a small addition but it would definitely make it
easier for new reviewers and contributors.
Regards,
Akshat Jaimin
Hi apologies for the late reply.
> Maybe you forgot to recompile/reinstall after updating past that commit?
I did recompile it earlier but just to be sure I followed the steps again
and now its working!
Regards,
Akshat Jaimini
On Wed, Apr 3, 2024 at 12:34 AM Tom Lane wrote:
> Akshat J
reviews.
Changing the status to 'Ready for Committer'.
Regards,
Akshat Jaimini
The new status of this patch is: Ready for Committer
Hii,
I am currently trying to review the submitted patch but I am not able to apply
it to the master branch.
Regards,
Akshat Jaimini
I think we should move this patch to the next CF as I believe that work is
still going on resolving the last reported bug.
Hello!
I was going through the previous conversations for this particular patch and it
seems that this patch failed some tests previously?
Imo we should move it to the next CF so that the remaining issues can be
resolved accordingly.
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Passes the default cases; Does not make any trivial changes to th
The patch looks fine and passes all the tests. I am using Arch Linux on an
x86_64 system.
The patch does not cause any unnecessary bugs and does not make any non trivial
changes to the source code.
I believe it is ready to be committed!
The new status of this patch is: Ready for Committer
13 matches
Mail list logo
