Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters

2025-09-08 Thread Andrei Klychkov
Hello, On 05.09.25 23:06, Tom Lane wrote: > I remain unsure which way I like better. The NULL approach has the > advantage of not foreclosing use of empty-string list elements, which > we might want someday even if there's no obvious value today. (And > for the same reason, it's less of a behavi

Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters

2025-09-05 Thread Andrei Klychkov
As it solves the initial issue, it SGTM too. I applied v3, updated the docs and added some tests in attached v4. Hopefully it's OK. Please take a look Thanks Regards On Fri, Sep 5, 2025 at 9:33 AM Jim Jones wrote: > > > On 04.09.25 23:52, Tom Lane wrote: > > Note that the patch includes changin

Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters

2025-09-04 Thread Andrei Klychkov
I'd be happy to update the patch as you put it, test it (as much as I can), and re-submit v3. Otherwise, I'd be happy with the v2 implementation that seemingly solves my specific issue. Thanks Regards Andrew On Wed, Sep 3, 2025 at 4:48 PM Fujii Masao wrote: > On Wed, Sep 3, 2025 at

Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters

2025-09-03 Thread Andrei Klychkov
_file(): more details in v2_README.md Looking forward to your feedback, thanks! Regards Andrew On Tue, Sep 2, 2025 at 2:16 PM Jim Jones wrote: > Hi Andrew > > On 28.08.25 11:29, Andrei Klychkov wrote: > > I'm submitting a patch to fix a bug where ALTER SYSTEM SET w

[PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters

2025-08-28 Thread Andrei Klychkov
Hi Hackers, I'm submitting a patch to fix a bug where ALTER SYSTEM SET with empty strings for GUC_LIST_QUOTE parameters (like shared_preload_libraries) results in malformed configuration entries that cause server crashes on restart. Please take a look, Thanks Andrew # Fix for ALTER SYSTEM Empty