Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.

tgresql.org/46/4671/ Regards Bowen Shi

Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.

word. RFC 7677 and RFC 5802 don't specify the maximum number of iterations. > If we want to add CHECK_FOR_INTERRUPTS inside the loop I think a brief > comment would be appropriate. This has been completed in patch v2 and it's ready for review. Regards Bowen Shi From 89c4de0a814d53

Re: [HACKERS] make async slave to wait for lsn to be replayed

Hi, I used the latest code and found some conflicts while applying. Which PG version did you rebase? Regards Bowen Shi

[PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.

s received during this period may be a good choice. I wrote a patch to solve this problem. What's your suggestions? Dears Bowen Shi 0001-Add-CHECK_FOR_INTERRUPTS-in-scram_SaltedPassword-loo.patch Description: Binary data

Re: Requiring recovery.signal or standby.signal when recovering with a backup_label

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed It looks good to me. I have reviewed the code and tested the

Re: Comparing two double values method

You're right, I made a mistake. Thanks for your explanation.

Comparing two double values method

Dears, I noticed that in the `check_GUC_init` function, there is a direct comparison using the != operator for two double values, which seems problematic. I wrote this patch to fix this. -- Regard, Bowen Shi v1-0001-Fix-double-value-compare-problem.patch Description: Binary data

Re: Requiring recovery.signal or standby.signal when recovering with a backup_label

quot;Be careful: removing \"%s/backup_label\" will result in a corrupt cluster if restoring from a backup.", DataDir, DataDir, DataDir))); There are two similar error messages in xlogrecovery.c. Maybe we can modify the error messages to be similar. -- Bowen Shi On Thu, 21 S

Re: Optimize walsender handling invalid messages of 'drop publication'

interested in this issue can help with the review. Regards! BowenShi On Mon, 27 Feb 2023 at 16:12, Bowen Shi wrote: > > Hi all, > > Before PG 14, walsender process has to handle invalid message in one > XLOG (PG 14 provide a particular XLOG type: XLOG_XACT_INVALIDATIONS). > T

Optimize walsender handling invalid messages of 'drop publication'

Hi all, Before PG 14, walsender process has to handle invalid message in one XLOG (PG 14 provide a particular XLOG type: XLOG_XACT_INVALIDATIONS). This may bring some problems which has been discussed in previous mail: https://www.postgresql.org/message-id/flat/CAM_vCufO3eeRZ_O04z9reiE%2BB644%2BR