Re: [PATCH] psql: Add tab-complete for optional view parameters

2023-08-12 Thread Christoph Heiss
On Fri, Aug 11, 2023 at 12:48:17PM -0700, David Zhang wrote: > > Applied v3 patch to master and verified it with below commands, Thanks for testing! > [..] > > For below changes, > > else if (TailMatches("CREATE", "VIEW", MatchAny, "AS") || > -             TailMatches("CREATE", "OR",

Re: [PATCH] psql: Add tab-complete for optional view parameters

2023-08-08 Thread Christoph Heiss
On Tue, Aug 08, 2023 at 09:17:51AM +0100, Dean Rasheed wrote: > > On Mon, 7 Aug 2023 at 19:49, Christoph Heiss wrote: > > > > On Fri, Jan 06, 2023 at 12:18:44PM +, Dean Rasheed wrote: > > > Hmm, I don't think we should be offering "check_option" as a

Re: [PATCH] psql: Add tab-complete for optional view parameters

2023-08-07 Thread Christoph Heiss
that part in for now. I would argue that it is a well-documented combination and as such users would expect it to turn up in the tab-complete as well. OTOH not against removing it either, if there are others voicing the same opinion .. Thanks, Christoph >From 3663eb0b5008d632972d4b66a105fc08cfff13fb M

Re: [PATCH] psql: Add tab-complete for optional view parameters

2022-12-09 Thread Christoph Heiss
ssing words. That is already contained in the patch: @@ -2139,7 +2146,7 @@ psql_completion(const char *text, int start, int end) /* ALTER VIEW */ else if (Matches("ALTER", "VIEW", MatchAny)) COMPLETE_WITH("ALTER COLUMN", "OWNER TO", &quo

[PATCH] psql: Add tab-complete for optional view parameters

2022-12-07 Thread Christoph Heiss
Hi all! This adds tab-complete for optional parameters (as can be specified using WITH) for views, similarly to how it works for storage parameters of tables. Thanks, Christoph HeissFrom bd12c08a80b5973fdcac59def213216d06f150b0 Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Wed, 7 Dec

Re: [PATCH] Add sortsupport for range types and btree_gist

2022-08-31 Thread Christoph Heiss
che the typcache entry. - inet sortsupport now uses network_cmp() directly Thanks, Christoph HeissFrom 667779bc0761c1356141722181c5a54ac46d96b9 Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Wed, 31 Aug 2022 19:20:43 +0200 Subject: [PATCH v2 1/1] Add sortsupport for range types and btree_g

[PATCH] Add sortsupport for range types and btree_gist

2022-06-15 Thread Christoph Heiss
py`. Depends on matplotlib and pandas. Additionally, if needed, the sample dataset used to benchmark this is available to independently verify the results [1]. Thanks, Christoph Heiss --- [1] https://drive.google.com/file/d/1SKRiUYd78_zl7CeD8pLDoggzCCh0wj39From 22e1b60929c39309e06c2477d8d

Re: [PATCH] Add reloption for views to enable RLS

2022-03-14 Thread Christoph Heiss
7e98f31fdbf1bcd1929309a14b1fd99fd6ec1 Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Mon, 14 Mar 2022 13:32:28 +0100 Subject: [PATCH v11 1/1] Add new boolean reloption "security_invoker" to views When this reloption is set to "true", all permissions on the underlying r

Re: [PATCH] Add reloption for views to enable RLS

2022-03-08 Thread Christoph Heiss
xplicitly mentioning that "security_invoker=false" is _not_ the same as "security definer", based on the earlier discussions. This should hopefully avoid any implicit associations. Thanks, ChristophFrom 89efb198694f7ff6e05068662a72a0bdcb43e13d Mon Sep 17 00:00:00 2001 From: C

Re: [PATCH] Add reloption for views to enable RLS

2022-03-01 Thread Christoph Heiss
what you had in mind. Thanks, ChristophFrom a7e84c92761881419bf8d63ebfcc528417dc8d24 Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Tue, 1 Mar 2022 17:36:42 +0100 Subject: [PATCH v9 1/1] Add new boolean reloption "check_permissions_owner" to views When this reloption is set to "false&

Re: [PATCH] Add reloption for views to enable RLS

2022-02-15 Thread Christoph Heiss
Hi, On 2/15/22 09:37, walt...@technowledgy.de wrote: Christoph Heiss: xxx_owner=true would be the default and xxx_owner=false could be set explicitly to get the behavior we are looking for in this patch? I'm not sure if an option which is on by default would be best, IMHO. I would rather

Re: [PATCH] Add reloption for views to enable RLS

2022-02-14 Thread Christoph Heiss
[...] but since it exposes this in new ways, it might as well clarify how all this works. I tried to clarify this situation in the documentation in a concise matter, I'd appreciate further feedback on that. Thanks, Christoph HeissFrom 7d8f8e1cb27a3d22d049a5d820ddd66ec77a3297 Mon Sep 17 00:00:

Re: [PATCH] Add reloption for views to enable RLS

2022-02-02 Thread Christoph Heiss
urrent security context.", + RELOPT_KIND_VIEW, + AccessExclusiveLock + }, + false + }, That doesn't seem to be proper English. Yes, that happened when rewriting this for v1 -> v2. Fixed. Thanks, Christoph HeissFrom 01437a45bfd069080ffe0eb45288bfddd3de6009 Mon Sep 17 00:0

Re: [PATCH] Add reloption for views to enable RLS

2022-01-19 Thread Christoph Heiss
Hi, On 1/19/22 09:30, Julien Rouhaud wrote: Hi, On Tue, Jan 18, 2022 at 04:16:53PM +0100, Christoph Heiss wrote: I've attached a v2 where I addressed the things you mentioned. This version unfortunately doesn't apply anymore: http://cfbot.cputube.org/patch_36_3466.log === Applying patches

Re: [PATCH] Add reloption for views to enable RLS

2022-01-18 Thread Christoph Heiss
his seems like a more appropriate place. Please review further. Thanks, Christoph HeissFrom 25267e6b8a2ffd81f14acbee95ef08d9edf3d31c Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Tue, 18 Jan 2022 15:42:58 +0100 Subject: [PATCH 1/3] [PATCH v2 1/3] Add new boolean reloption security_invok

[PATCH] Add reloption for views to enable RLS

2021-12-17 Thread Christoph Heiss
e0fafbe904a2 Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Fri, 17 Dec 2021 17:17:54 +0100 Subject: [PATCH 3/3] Add documentation for new 'security' reloption on views --- doc/src/sgml/ddl.sgml | 4 doc/src/sgml/ref/alter_view.sgml | 9 + doc/src/sgml/ref/crea