Re: Convert varatt.h macros to static inline functions

2025-07-31 Thread Greg Burd
> On Jul 31, 2025, at 10:06 AM, Tom Lane wrote: > > Peter Eisentraut writes: >> I had this lying around as a draft patch, as part of my ongoing campaign  >> to convert many complicated macros to static inline functions.  Since  >> the topic was mentioned in another thread [0], I cleaned up the

Re: Enable data checksums by default

2025-07-31 Thread Greg Burd
> On Jul 30, 2025, at 8:09 AM, Daniel Gustafsson wrote: > >> On 30 Jul 2025, at 11:58, Laurenz Albe wrote: >> >> On Tue, 2025-07-29 at 20:24 +0200, Tomas Vondra wrote: >>> So, what should we do with the PG18 open item? We (the RMT team) would >>> like to know if we shall keep the checksums e

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-27 Thread Greg Burd
On 7/25/25 15:02, Greg Burd wrote: > Patch set is now: > > 1) remove freelist > > 2) remove buffer_strategy_lock > > 3) abstract clock-sweep to type and API > > > > -greg Somehow including the test.c file as an attachment on my last email confused the CI and

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-25 Thread Greg Burd
On 7/22/25 14:43, Greg Burd wrote: > On 7/21/25 14:35, Andres Freund wrote: >> Hi, >> >> On 2025-07-21 13:37:04 -0400, Greg Burd wrote: >>> On 7/18/25 13:03, Andres Freund wrote: >>> Hello.  Thanks again for taking the time to review the email and patch, >

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-22 Thread Greg Burd
On 7/21/25 14:35, Andres Freund wrote: > Hi, > > On 2025-07-21 13:37:04 -0400, Greg Burd wrote: >> On 7/18/25 13:03, Andres Freund wrote: >> Hello.  Thanks again for taking the time to review the email and patch, >> I think we're onto something good here. >>

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-21 Thread Greg Burd
in autoprewarm, it's a rather trivial > patch. And I really couldn't measure regressions above the noise level, even > if absurdly extreme use cases. Hmmm... was "argue for keeping the clock sweep" supposed to read "argue for keeping the freelist"? > On 2025-0

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-17 Thread Greg Burd
On Fri, Jul 11, 2025, at 2:52 PM, Andres Freund wrote: Hi, On 2025-07-11 13:26:53 -0400, Greg Burd wrote: In conversations [1] recently about considering how best to adapt the code to become NUMA-aware Andres commented, "FWIW, I've started to wonder if we shouldn't just

Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-11 Thread Greg Burd
On Fri, Jul 11, 2025, at 2:50 PM, Nathan Bossart wrote: > On Fri, Jul 11, 2025 at 01:26:53PM -0400, Greg Burd wrote: >> This change does remove the have_free_buffer() function used by the >> contrib/pg_prewarm module. On the surface this doesn't seem to cause any >>

[PATCH] Let's get rid of the freelist and the buffer_strategy_lock

2025-07-11 Thread Greg Burd
Hello, In conversations [1] recently about considering how best to adapt the code to become NUMA-aware Andres commented, "FWIW, I've started to wonder if we shouldn't just get rid of the freelist entirely" and because I'm a glutton for punishment (and I think this idea has some merit) I took hi

Re: Adding basic NUMA awareness

2025-07-09 Thread Greg Burd
On Jul 9 2025, at 12:35 pm, Andres Freund wrote: > FWIW, I've started to wonder if we shouldn't just get rid of the freelist > entirely. While clocksweep is perhaps minutely slower in a single > thread than > the freelist, clock sweep scales *considerably* better [1]. As it's rather > rare to