Re: [PATCH] libpq: Wrap out-of-memory error messages with libpq_gettext()

2025-11-10 Thread Joshua Shanks
sao wrote: > On Sun, Nov 9, 2025 at 5:21 AM Joshua Shanks wrote: > > > > Hi, > > > > The recent patch for passwordFromFile() error handling highlighted that > many other out-of-memory error messages in libpq still aren't wrapped with > libpq_gettext(). > >

[PATCH] libpq: Wrap out-of-memory error messages with libpq_gettext()

2025-11-08 Thread Joshua Shanks
Hi, The recent patch for passwordFromFile() error handling highlighted that many other out-of-memory error messages in libpq still aren't wrapped with libpq_gettext(). Attached is a patch that systematically wraps the remaining bare "out of memory" strings across libpq with libpq_gettext() to ens

Re: [PATCH] Add error message for out-of-memory in passwordFromFile()

2025-11-03 Thread Joshua Shanks
On Mon, Nov 3, 2025 at 2:35 AM Michael Paquier wrote: > The point would be to have pqConnectOptions2() take its oom_error path > in the case you are pointing at. It seems to me that the correct > answer would be to extend passwordFromFile() with an extra "const char > **errmsg", where an error i

Re: Fix typo in Vietnamese translation file

2025-11-02 Thread Joshua Shanks
Thanks for the clarification. On Sun, Nov 2, 2025 at 2:52 PM Tom Lane wrote: > Chao Li writes: > > Looks like the po file has been out of date, the msgid string cannot be > found in the source file. > > Yeah, I was surprised not to see a fuzz marker there. Apparently > that file hasn't been to

Fix typo in Vietnamese translation file

2025-11-02 Thread Joshua Shanks
Hi, I was poking around and found a typo Change "occured" to "occurred" in pg_basebackup error message. Cheers, Joshua 0001-Fix-typo-in-Vietnamese-translation-file.patch Description: Binary data

[PATCH] Add error message for out-of-memory in passwordFromFile()

2025-11-01 Thread Joshua Shanks
Hi, I noticed a XXX comment in fe-connect.c at line 8064 indicating that an error message would be nice when strdup() fails while reading the password file. Currently, passwordFromFile() silently returns NULL on allocation failure, leaving users without feedback on what went wrong. This patch add