Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

seem user friendly to me. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/

Correct the documentation of extension building infrastructure

there that it should not be backpatched. How about fixing the documentation for v12 and v13 then? [1]: https://www.postgresql.org/docs/12/extend-pgxs.html [2]: https://www.postgresql.org/message-id/flat/CAMsr%2BYFsCMH3B4uOPFE%2B2qWM6k%3Do%3Dhf9LGiPNCfwqKdUPz_BsQ%40mail.gmail.com Best regards, Karina Litskevich

Re: BufferUsage counters' values have changed

ime) [2] > > > > I think [0] is the same path as [1] but [2] is new. 'fsm extends' > > wasn't counted in local_blks_written in PG_15. Calling > > ExtendBufferedRelTo() from fsm_extend() caused 'fsm extends' to be > > counted in local_blks_written. I am not sure whi

Re: BufferUsage counters' values have changed

On Mon, Sep 11, 2023 at 9:08 AM Karina Litskevich < litskevichkar...@gmail.com> wrote: > I found a bug that causes one of the differences. Wrong counter is > incremented > in ExtendBufferedRelLocal(). The attached patch fixes it and should be > applied > to REL_16_STABLE

BufferUsage counters' values have changed

to understand whether it's a bug in computing the counters or just changes in how many blocks are read/written during the query execution. If anyone can help me, I would be grateful. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/

Re: Avoid unused value (src/fe_utils/print.c)

On Tue, Jul 25, 2023 at 1:04 AM Ranier Vilela wrote: > Checked today, Coverity does not complain about need_recordsep. > Great! Thanks. So v2 patch makes Coverity happy, and as for me doesn't make the code less readable. Does anyone have any objections? Best regards, Karina Litskevich Po

Re: Avoid unused value (src/fe_utils/print.c)

no-op. I attached a patch that removes only one assignment. Could you please try it and check whether Coverity is still complaining about need_recordsep variable? Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/ From 92c86657181c13c48a4b4176bf4ad1d6221cf9b5 Mon Sep 17 00:0

Re: Avoid unused value (src/fe_utils/print.c)

more readable. Moreover, removing the line will possibly complicate the future maintenance. As I wrote in the part you just quoted, if the function changes in the way that need_recordsep is not true right before printing footers any more, then output will be unexpected. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/

MarkGUCPrefixReserved() doesn't check all options

it, but at least I can't reproduce the bug on master. I attached a bugfix for PG 15. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/ From 5f0e59b225ebb408a0c971bc78e22050b296ae9a Mon Sep 17 00:00:00 2001 From: Karina Litskevich Date: Thu, 6 Jul 2023 11:00:36 +0300 Subject

Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)

nd might have extended the relation by the time * we get the lock. I attached the new version of the patch as I see it. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/ From 7425d5b1b9d30f0da75aabd94e862906f9635a60 Mon Sep 17 00:00:00 2001 From: Karina Litskevich Date

Re: Avoid unused value (src/fe_utils/print.c)

also have doubts about removing this line. If someday print options are changed, for example to support printing footers and not printing headers, or anything else changes in this function, the output might be unexpected with this line removed. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/

Re: Possible false valgrind error reports

need to adjust trailing bytes" if RANDOMIZE_ALLOCATED_MEMORY isn't defined. I reflected it in v2 of 0001 too. From 009ef9bbabcd71e0d5f2b60799c0b71d21fb9767 Mon Sep 17 00:00:00 2001 From: Karina Litskevich Date: Fri, 17 Feb 2023 15:32:05 +0300 Subject: [PATCH v2 2/2] Change variable name in AllocSetR

Possible false valgrind error reports

it's better to rename "oldsize" into "oldchksize". Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/ From 9556b7918e6abccb2dc19f20dbf572d41cd35cb4 Mon Sep 17 00:00:00 2001 From: Karina Litskevich Date: Tue, 14 Feb 2023 17:13:17 +0300 Subject: [PATCH v1

Re: Error for WITH options on partitioned tables

we also should check weather some other functions become useless. Maybe that is the right way, but it looks much harder than the existing solutions, so I believe, before anyone began going this way, it's better to know whether there are any pitfalls there. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/

Re: Error for WITH options on partitioned tables

st to change the error code. Best regards, Karina Litskevich Postgres Professional: http://postgrespro.com/ From 6407538f0bfd3eb56f5a4574d8893f9494f2a810 Mon Sep 17 00:00:00 2001 From: Karina Litskevich Date: Fri, 14 Oct 2022 17:48:27 +0300 Subject: [PATCH v2 2/2] better error message for setting paramete

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

Hi, I also would like to suggest a cosmetic change. In v15 a new field checkunique is added after heapallindexed and before no_btree_expansion fields in struct definition, but in initialisation it is added after no_btree_expansion: --- a/src/bin/pg_amcheck/pg_amcheck.c +++