Re: Add CHECK_FOR_INTERRUPTS in polling loop code path in XactLockTableWait

2025-05-28 Thread Kevin K Biju
Hi Fujii, The WaitEvent sounds good to me, I will submit a separate patch for that when I find time. Kevin On Wed, May 28, 2025 at 5:06 PM Fujii Masao wrote: > > > On 2025/05/27 4:43, Kevin K Biju wrote: > > Hi Fujii, > > > > Thanks for the review. > > So unl

Re: Add CHECK_FOR_INTERRUPTS in polling loop code path in XactLockTableWait

2025-05-26 Thread Kevin K Biju
actLockTableWait seem to be used in other places including in heapam so I'm hesitant on changing this behaviour for all of them. Should we have a different "wait logic" for this case? Kevin On Mon, May 26, 2025 at 9:02 AM Fujii Masao wrote: > > > On 2025/05/24 5:41, K

Add CHECK_FOR_INTERRUPTS in polling loop code path in XactLockTableWait

2025-05-23 Thread Kevin K Biju
Hi, While creating a logical replication slot, we wait for older transactions to complete to reach a "consistent point", which can take a while on busy databases. If we're creating a slot on a primary instance, it's pretty clear that we're waiting on a transaction: postgres=# SELECT pid,wait_eve

Fix infinite loop from setting scram_iterations to INT_MAX

2025-03-23 Thread Kevin K Biju
Hi, I stumbled upon a problem with the scram_iterations GUC where setting scram_iterations to INT_MAX and then creating a user causes the command to hang indefinitely. postgres=# SET scram_iterations=2147483647; SET postgres=# CREATE ROLE maxscram WITH PASSWORD 'forever'; I looked into the rele