be
combined with --table to dump specific tables if needed. If the user has
different foreign servers in the database has to make the conscious decision of
dumping each one of them. Without this option the user is totally unable to do
it.
> On 2020-01-21 10:36, Luis Carril wrote:
>>>
Thanks for working on the comments. I noticed one behavior is
different when --table option is specified. When --table is specified
the following are not getting dumped:
CREATE SERVER foreign_server
I felt the above also should be included as part of the dump when
include-foreign-data option is
Yes we can support --include-foreign-data without parallel option and
later add support for parallel option as a different patch.
Hi,
I've attached a new version of the patch in which an error is emitted if
the parallel backup is used with the --include-foreign-data option.
Cheers
Luis
On Tue, Jan 14, 2020 at 5:22 PM Luis Carril
mailto:luis.car...@swarm64.com>> wrote:
Can you have a look at dump with parallel option. Parallel option will
take a lock on table while invoking lockTableForWorker. May be this is
not required for foreign tables.
Thoughts?
I tried with -j and
to modify it while is being dumped.
Cheers,
Luis M Carril
From: vignesh C
Sent: Tuesday, January 14, 2020 1:48 AM
To: Luis Carril
Cc: Alvaro Herrera ; Daniel Gustafsson
; Laurenz Albe ; PostgreSQL Hackers
Subject: Re: Option to dump foreign data in pg_dump
On Fri
Sent: Thursday, November 28, 2019 3:31 PM
To: Luis Carril
Cc: Daniel Gustafsson ; Laurenz Albe
; vignesh C ; PostgreSQL Hackers
Subject: Re: Option to dump foreign data in pg_dump
On 2019-Nov-12, Luis Carril wrote:
> The nitpicks have been addressed. However, it seems that the new f
The nitpicks have been addressed. However, it seems that the new file
containing the test FDW seems missing from the new version of the patch. Did
you forget to git add the file?
Yes, I forgot, thanks for noticing. New patch attached again.
Cheers
Luis M Carril
diff --git
Hello
a new version of the patch with the tests from Daniel (thanks!) and the
nitpicks.
I don't feel good about this feature.
pg_dump should not dump any data that are not part of the database
being dumped.
If you restore such a dump, the data will be inserted into the foreign table,
I don't disagree with adding FOREIGN, though.
Your patch is failing the pg_dump TAP tests. Please use
configure --enable-tap-tests, fix the problems, then resubmit.
Fixed, I've attached a new version.
Cheers
Luis M Carril
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
On Fri, Sep 20, 2019 at 6:20 PM Luis Carril
mailto:luis.car...@swarm64.com>> wrote:
Hello,
thanks for the comments!
* + if (tdinfo->filtercond || tbinfo->relkind == RELKIND_FOREIGN_TABLE)
filter condition is not implemented completely yet so the logic only work on
foreign tabl
On 15.07.19 12:06, Daniel Gustafsson wrote:
On 12 Jul 2019, at 16:08, Luis Carril wrote:
On 28 Jun 2019, at 19:55, Luis Carril wrote:
What about providing a list of FDW servers instead of an all or nothing option?
In that way the user really has to do a conscious decision to dump
> > On 28 Jun 2019, at 19:55, Luis Carril wrote:
> > What about providing a list of FDW servers instead of an all or nothing
> > option? In that way the user really has to do a conscious decision to dump
> > the content of the foreign tables for > > a specific
the indentation? Maybe, am I using pgindent wrong?
Cheers
Luis M Carril
From a5b439b7dfdc1f9bab8d2cf1fc95a8eaedb1d83e Mon Sep 17 00:00:00 2001
From: Luis Carril
Date: Fri, 12 Jul 2019 12:51:17 +0200
Subject: [PATCH] Add FOREIGN to ALTER statements
---
src/bin/pg_dump/pg_dump.c | 40
>Restoring content of FDW table via pg_restore or psql can be dangerous -
>there I see a risk, and can be nice to allow it only >with some form of
>safeguard.
>
>I think so important questions is motivation for dumping FDW - a) clonning
>(has sense for me and it is safe), b) real backup
Hello,
pg_dump ignores the dumping of data in foreign tables
on purpose, this patch makes it optional as the user maybe
wants to manage the data in the foreign servers directly from
Postgres. Opinions?
Cheers
Luis M Carril
diff --git a/src/bin/pg_dump/pg_backup.h
15 matches
Mail list logo
