Re: GUC-ify walsender MAX_SEND_SIZE constant

Hi, > Now Majid stated that he uses "RBD" - Majid, any chance to specify > what that RBD really is ? What's the tech? What fs? Any ioping or fio > results? What's the blockdev --report /dev/XXX output ? (you stated > "high" latency and "high" bandwidth , but it is relative, for me 15ms+ > is high

Re: GUC-ify walsender MAX_SEND_SIZE constant

Hey folks, Any news, comments, etc. about this thread? Best regards Majid Garoosi On Mon, 12 Feb 2024 at 01:10, Michael Paquier wrote: > On Sun, Feb 11, 2024 at 04:32:20PM +0330, Majid Garoosi wrote: > > On Fri, 9 Feb 2024 at 22:33, Andres Freund wrote: > >> The way we

Re: GUC-ify walsender MAX_SEND_SIZE constant

Hi Andres, On Fri, 9 Feb 2024 at 22:33, Andres Freund wrote: > On 2024-01-19 23:04:50 +0330, Majid Garoosi wrote: > > Following is the description which is also written in the commit message: > > MAX_SEND_SIZE parameter was used in WALSender to limit maximum size of > > a

Re: GUC-ify walsender MAX_SEND_SIZE constant

On Fri, 9 Feb 2024 at 08:50, Michael Paquier wrote: > Something to be aware of, but the community lists use bottom-posting > for replies because it is easier to follow the logic of a thread this > way. See here: > https://en.wikipedia.org/wiki/Posting_style#Bottom-posting > Oh, sorry for not

Re: GUC-ify walsender MAX_SEND_SIZE constant

Thank you very much for your review. I generally agree with your suggestions, so just applied them. You can find the new patch in the attached file. Best Majid On Tue, 6 Feb 2024 at 09:26, Michael Paquier wrote: > On Fri, Jan 19, 2024 at 11:04:50PM +0330, Majid Garoosi wrote: > >

GUC-ify walsender MAX_SEND_SIZE constant

00 2001 From: Majid Garoosi Date: Fri, 19 Jan 2024 22:48:23 +0330 Subject: [PATCH v1] GUC-ify MAX_SEND_SIZE constant in WALSender MAX_SEND_SIZE parameter was used in WALSender to limit maximum size of a WAL data packet sent to a WALReceiver during replication. Although its default value (128kB) was

GUCifying MAX_WAL_SEND

Hello all, *TL; DR* There has been a discussion about GUCifying the MAX_WAL_SEND constant in walsender.c in here nearly 7 years ago, but resulting in nothing in the end. Today, I found out the configurability of this parameter can be very helpful. So, I