On Thu, Nov 13, 2025 at 12:07 AM Chao Li wrote:
> Hi Manni,
>
> I just reviewed and tested the patch, just got a few small comments:
>
> > On Nov 13, 2025, at 00:15, Álvaro Herrera wrote:
> >
> > On 2025-Nov-12, Manni Wood wrote:
> >
> >> Than
Manni Wood
[image: Attachments]8:09 AM (13 minutes ago)
to *Álvaro*, *psql-hackers*, *Chao*, *Nishant*, *Jim*
Hello! After waiting all weekend, my Friday e-mail did not get through
psql-hackers, so I am sending again, using Álvaro's advice to send to
lists.postgresql.org rather than
On Wed, Nov 12, 2025 at 8:44 AM KAZAR Ayoub wrote:
> On Tue, Nov 11, 2025 at 11:23 PM Manni Wood
> wrote:
>
>> Hello!
>>
>> I wanted reproduce the results using files attached by Shinya Kato and
>> Ayoub Kazar. I installed a postgres compiled from master, a
On Wed, Nov 12, 2025 at 10:15 AM Álvaro Herrera
wrote:
> On 2025-Nov-12, Manni Wood wrote:
>
> > Thanks, Álvaro, for your continued help with this.
> >
> > I have attached v11 patches that use all of the fixes from your
> > review.patch.txt.
>
> OK, thanks
e es un cobarde" (Fernandel)
>
Thanks, Álvaro, for your continued help with this.
I have attached v11 patches that use all of the fixes from your
review.patch.txt.
I have built and tested this using both make/autotools and meson, and I had
Nishant (thanks, Nishant!) look at these before
rom master) to 2 seconds (Ayoub
Kazar's t_4096_none.csv copied into postgres compiled from master plus
Nazir's v3 patches).
Perhaps I need to fiddle with the provided SQL to produce larger files to
get longer run times? Maybe sub-second differences won't tell as
interesting a story as minutes-long copy commands?
Thanks for reading this.
--
-- Manni Wood EDB: https://www.enterprisedb.com
be considered a feature and not a bug, because we
should be encouraged to write our SQL like so:
select name, default_version, installed_version, comment from
pg_available_extensions
and not like so:
select * from pg_available_extensions
I'm curious to know if this is a legitimate consideration or not.
Also, there were no surprises when I compiled and tested this: the location
shows correctly for a superuser, and "" shows
correctly for a non-superuser.
--
-- Manni Wood EDB: https://www.enterprisedb.com
On Mon, Nov 10, 2025 at 5:27 AM Álvaro Herrera wrote:
> On 2025-Nov-08, Manni Wood wrote:
>
> > However, I see that this
> > https://cirrus-ci.com/task/6437176629526528?logs=clone#L214 checks out a
> > specific commit on a specific bran
On Fri, Nov 7, 2025 at 10:46 PM Manni Wood
wrote:
>
>
> On Fri, Nov 7, 2025 at 10:19 PM Manni Wood
> wrote:
>
>>
>>
>> On Fri, Nov 7, 2025 at 6:03 PM Jim Jones
>> wrote:
>>
>>>
>>>
>>> On 08/11/2025 00:38, Manni Wood w
On Fri, Nov 7, 2025 at 10:19 PM Manni Wood
wrote:
>
>
> On Fri, Nov 7, 2025 at 6:03 PM Jim Jones
> wrote:
>
>>
>>
>> On 08/11/2025 00:38, Manni Wood wrote:
>> > Alas, the build https://commitfest.postgresql.org/patch/6175/ > > commitfest.pos
On Fri, Nov 7, 2025 at 6:03 PM Jim Jones wrote:
>
>
> On 08/11/2025 00:38, Manni Wood wrote:
> > Alas, the build https://commitfest.postgresql.org/patch/6175/ > commitfest.postgresql.org/patch/6175/> now fails, and I cannot reproduce
> > on my machine. Obviously th
On Fri, Nov 7, 2025 at 4:38 PM Manni Wood
wrote:
>
>
> On Fri, Nov 7, 2025 at 10:16 AM Jim Jones
> wrote:
>
>>
>>
>> On 07/11/2025 02:27, Manni Wood wrote:
>> > Attached v7 fixes problems in tests due to whitespace.
>>
>>
>> Since get_
On Fri, Nov 7, 2025 at 10:16 AM Jim Jones wrote:
>
>
> On 07/11/2025 02:27, Manni Wood wrote:
> > Attached v7 fixes problems in tests due to whitespace.
>
>
> Since get_tablespace_loc_string returns a palloc'd string, I guess you
> could pfree it after the if bloc
On Thu, Nov 6, 2025 at 4:08 PM Manni Wood
wrote:
>
>
> On Wed, Nov 5, 2025 at 5:54 AM Nishant Sharma <
> [email protected]> wrote:
>
>> Thanks Álvaro for the review comments on v4!
>>
>> PFA, v5 patch set. I have included all your review
.c(311): fatal error C1051: program database file,
'C:\cirrus\build\src\port\libpgport_srv.pdb', has an obsolete format,
delete it and recompile", which I don't think is related to our patch.
--
-- Manni Wood EDB: https://www.enterprisedb.com
From 11831687a0324aa88d13716ec7f051a80
On Tue, Nov 4, 2025 at 5:25 AM Jim Jones wrote:
> Hi Nishant
>
> On 04/11/2025 11:37, Nishant Sharma wrote:
> > Using name as parameter is more user friendly than OID.
> > Because users usually do not know the oids. Constructing
> > the DDL from the name appears better as it contains a name
> > i
On Fri, Oct 31, 2025 at 10:36 AM Jim Jones
wrote:
> Hi Manni,
>
> Thanks for the patch!
>
> On 29/10/2025 02:23, Manni Wood wrote:
> > This patch creates a function pg_get_tablespace_ddl, designed to
> > retrieve the full DDL statement for a tablespace. Users can obta
espace_ddl
---
CREATE TABLESPACE regress_owner_tblsp OWNER regress_user LOCATION ''
WITH (random_page_cost = 3);
This patch includes documentation, comments, and regression tests, all of
which pass successfully.
--
Best,
Manni Wo
18 matches
Mail list logo
