Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-10-28 Thread Maxime Schoemans
> On 28 Oct 2025, at 10:20, Peter Eisentraut wrote: > > I have committed the first patch. Great, thank you for looking at this. > The test suite is probably a bit too bulky for testing this particular niche > behavior. Also, it doesn't work with assertions enabled because of the > hardcode

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-10-18 Thread Maxime Schoemans
y scan) as it tries to use the index in get_actual_variable_range, which shouldn’t be the case. Best, Maxime Schoemans v2-0001-Check-that-index-can-return-in-get_actual_variabl.patch Description: Binary data v2-0002-Add-btree_noreturn-module-as-example-of-a-non-ret.patch Description: Binary data

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-09-18 Thread Maxime Schoemans
On 18 Sep 2025, at 15:36, Mark Dilger wrote: > > Testing with the src/test/modules/treeb work in the patch series at [1], > modifying treebcanreturn() to always return false and modifying > _treeb_first(), _treeb_next(), and _treeb_endpoint() to set scan->xs_itup to > NULL rather than to a t

Re: [PATCH] Check that index can return in get_actual_variable_range()

2025-09-18 Thread Maxime Schoemans
would pass. Best, Maxime Schoemans

[PATCH] Check that index can return in get_actual_variable_range()

2025-09-17 Thread Maxime Schoemans
they should be rejected since get_actual_variable_range() uses the index-only-scan machinery in get_actual_variable_endpoint(). Attached is a small patch that adds a check in get_actual_variable_range() to reject indices that do not allow index-only scans. Regards, Maxime Schoemans v1-0001