Re: Parallel copy

2020-02-18 Thread Mike Blackwell
on the actual use case. If we > expect to be parallel loading humungous CSVs then that won't fly. Loading large CSV files is pretty common here. I hope this can be supported. MIKE BLACKWELL * * >

Re: [PATCH] Clear up perlcritic 'missing return' warning

2018-05-22 Thread Mike Blackwell
On Tue, May 22, 2018 at 3:32 AM, Michael Paquier wrote: > > And this > maps with any C code. > The important differences here are: *) Declaring a C function as void prevents returning a value. The intent not to return a value is clear to any caller and is enforced by the compiler. There is

[PATCH] Clear up perlcritic 'missing return' warning

2018-05-21 Thread Mike Blackwell
ng my environment set up. Mike Blackwell From d3ec3cbeb496ea9d2b285aaa32359cae528a983b Mon Sep 17 00:00:00 2001 From: Mike Blackwell Date: Tue, 15 May 2018 16:38:59 -0500 Subject: [PATCH] add returns to Perl files where missing diff --git a/contrib/bloom/t/001_wal.pl b/contrib/bloom/t/001_wal.pl

perlcritic: Missing "return"

2018-05-11 Thread Mike Blackwell
After applying the perlcritic overrides Andrew used for the buildfarm, one of the most common remaining level 4 warnings in the PostgreSQL source, with 186 occurrences, is 'Subroutine does not end with "return"'. The point of this warning is that, in Perl, falling off the end of a subroutine retur

Re: perlcritic (was Re: pgsql: Fix precedence problem in new Perl code.)

2018-05-04 Thread Mike Blackwell
Alvaro, I didn't mean to imply otherwise. Our settings here are probably different. Good point on the git log --grep. I'll try to remember that in the future. Mike ______ *Mike Blackwell | Technic