Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762

2020-06-24 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > On 2020-Jun-24, Kyotaro Horiguchi wrote: > > > In logical replication, a replication role is intended to be > > accessible only to the GRANTed databases. On the other hand the same > > role can create a dead copy of the whole

Re: Recording test runtimes with the buildfarm

2020-06-11 Thread Stephen Frost
Greetings, * David Rowley (dgrowle...@gmail.com) wrote: > On Thu, 11 Jun 2020 at 10:02, Tom Lane wrote: > > Thomas Munro writes: > > > I've been doing that in a little database that pulls down the results > > > and analyses them with primitive regexes. First I wanted to know the > > >

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

2020-06-11 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Wed, Jun 10, 2020 at 01:23:37PM +0900, Michael Paquier wrote: > > Okay. After sleeping on it, it looks like would be better to move > > this new fe_archive.c to src/fe_utils/. I'll try to do that tomorrow, > > and added an open item

Re: Recording test runtimes with the buildfarm

2020-06-10 Thread Stephen Frost
Greetings, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 6/10/20 10:13 AM, Tom Lane wrote: > > Andrew Dunstan writes: > >> Alternatively, people with access to the database could extract the logs > >> and post-process them using perl or python. That would involve no work > >> on

Re: Recording test runtimes with the buildfarm

2020-06-10 Thread Stephen Frost
Greetings, * David Rowley (dgrowle...@gmail.com) wrote: > 1. We could quickly identify when someone adds some overly complex > test and slows down the regression tests too much. Sure, makes sense to me. We do track the individual 'stage_duration' but we don't track things down to a

Re: WIP: WAL prefetch (another approach)

2020-06-05 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > I wonder if we can collect some stats to measure how effective the > prefetching actually is. Ultimately we want something like cache hit > ratio, but we're only preloading into page cache, so we can't easily > measure that.

Re: Read access for pg_monitor to pg_replication_origin_status view

2020-06-02 Thread Stephen Frost
Greetings, * Martín Marqués (mar...@2ndquadrant.com) wrote: > > > $ git diff > > > diff --git a/src/backend/catalog/system_views.sql > > > b/src/backend/catalog/system_views.sql > > > index c16061f8f00..97ee72a9cfc 100644 > > > --- a/src/backend/catalog/system_views.sql > > > +++

Re: password_encryption default

2020-05-29 Thread Stephen Frost
Greetings, * Jonathan S. Katz (jk...@postgresql.org) wrote: > On 5/29/20 3:33 AM, Michael Paquier wrote: > > On Thu, May 28, 2020 at 02:53:17PM +0200, Peter Eisentraut wrote: > >> More along these lines: We could also remove the ENCRYPTED and UNENCRYPTED > >> keywords from CREATE and ALTER ROLE.

Re: password_encryption default

2020-05-29 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Thu, May 28, 2020 at 02:53:17PM +0200, Peter Eisentraut wrote: > > More along these lines: We could also remove the ENCRYPTED and UNENCRYPTED > > keywords from CREATE and ALTER ROLE. AFAICT, these have never been emitted > > by

Re: password_encryption default

2020-05-28 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, May 28, 2020 at 8:53 AM Peter Eisentraut > wrote: > > More along these lines: We could also remove the ENCRYPTED and > > UNENCRYPTED keywords from CREATE and ALTER ROLE. AFAICT, these have > > never been emitted by pg_dump or

Re: password_encryption default

2020-05-27 Thread Stephen Frost
Greetings, * Jonathan S. Katz (jk...@postgresql.org) wrote: > On 5/27/20 9:13 AM, Michael Paquier wrote: > > On Wed, May 27, 2020 at 02:56:34PM +0200, Magnus Hagander wrote: > >> Seems like the better choice yeah. Since we're changing the default anyway, > >> maybe now is the time to do that? Or

Re: Default gucs for EXPLAIN

2020-05-26 Thread Stephen Frost
Greetings, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > the partial solution can be custom psql statements. Now, it can be just > workaround > > \set explain 'explain (analyze, buffers)' > :explain select * from pg_class ; > > and anybody can prepare customized statements how he likes

Re: Default gucs for EXPLAIN

2020-05-26 Thread Stephen Frost
Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > On Monday, May 25, 2020, Stephen Frost wrote: > > * Michael Paquier (mich...@paquier.xyz) wrote: > > > On Mon, May 25, 2020 at 09:36:50PM -0400, Bruce Momjian wrote: > > > > I am not excited a

Re: Default gucs for EXPLAIN

2020-05-26 Thread Stephen Frost
Greetings, * Guillaume Lelarge (guilla...@lelarge.info) wrote: > Le mar. 26 mai 2020 à 04:27, Stephen Frost a écrit : > > To that end- what if this was done client-side with '\explain' or > > similar? Basically, it'd work like \watch or \g but we'd have options >

Re: Default gucs for EXPLAIN

2020-05-25 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, May 25, 2020 at 09:36:50PM -0400, Bruce Momjian wrote: > > I am not excited about this new feature. Why do it only for EXPLAIN? Would probably help to understand what your thinking is here regarding how it could be done for

Re: password_encryption default

2020-05-22 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> I'm +1 for changing both of these things as soon as we branch for v14, > >> but I feel like it's a bit late for v13. If we aren't feature-fr

Re: password_encryption default

2020-05-22 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> As far as that last goes, we *did* get the buildfarm fixed to be all > >> v11 scripts, so I thought we were ready to move forward on trying >

Re: password_encryption default

2020-05-22 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Magnus Hagander (mag...@hagander.net) wrote: > >> On Fri, May 22, 2020 at 4:13 PM Tom Lane wrote: > >>> Peter Eisentraut writes: > >>>> We didn't get anywhere

Re: password_encryption default

2020-05-22 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Fri, May 22, 2020 at 4:13 PM Tom Lane wrote: > > Peter Eisentraut writes: > > > We didn't get anywhere with making the default authentication method in > > > a source build anything other than trust. But perhaps we should change >

Re: factorial function/phase out postfix operators?

2020-05-19 Thread Stephen Frost
Greetings, * Vik Fearing (v...@postgresfriends.org) wrote: > On 5/19/20 4:03 AM, Tom Lane wrote: > > Peter Eisentraut writes: > >> What are the thoughts about then marking the postfix operator deprecated > >> and eventually removing it? > > > > If we do this it'd require a plan. We'd have to

Re: pgindent && weirdness

2020-05-18 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Thomas Munro writes: > > It seems I cannot. Please go ahead. > > [ yawn... ] It's about bedtime here, but I'll take care of it in the > morning. > > Off the critical path, we oughta figure out why the repo wouldn't > let you commit. What I

Re: Logical replication subscription owner

2020-05-09 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Michael Paquier writes: > > Not to make the life of everybody more complicated here, but I don't > > agree. LOGIN and REPLICATION are in my opinion completely orthogonal > > and it sounds more natural IMO that a REPLICATION user should be able

Re: pg_basebackup misses to report checksum error

2020-05-07 Thread Stephen Frost
Greetings, * Ashwin Agrawal (aagra...@pivotal.io) wrote: > On Wed, May 6, 2020 at 3:02 PM Robert Haas wrote: > > On Wed, May 6, 2020 at 5:48 PM Ashwin Agrawal wrote: > > > If pg_basebackup is not able to read BLCKSZ content from file, then it > > > just emits a warning "could not verify

Re: Problems with GSS encryption and SSL in libpq in 12~

2020-05-02 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Apr 06, 2020 at 04:25:57PM +0900, Michael Paquier wrote: > > It is possible to enforce this flag to false by using > > gssencmode=disable, but that's not really user-friendly in my opinion > > because nobody is going to remember

Re: Problems with GSS encryption and SSL in libpq in 12~

2020-05-02 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > A quick make check with Postgres 11 and 12 for src/test/ssl/ shows a > lot of difference in run time, using the same set of options with SSL > and the same compilation flags (OpenSSL 1.1.1f, with debugging and > assertions enabled among

Re: Protocol problem with GSSAPI encryption?

2020-05-02 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Andrew Gierth (and...@tao11.riddles.org.uk) wrote: > > >>>>> "Peter" == Peter Eisentraut writes: > > > > >> It seems to me that this is a bug in ProcessStartupPacket, which > &

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

2020-04-30 Thread Stephen Frost
Greetings, This seems to have died out, and that's pretty unfortunate because this is awfully useful SQL standard syntax that people look for and wish we had. * Andrew Gierth (and...@tao11.riddles.org.uk) wrote: > So I've tried to rough out a decision tree for the various options on > how this

Re: Proposing WITH ITERATIVE

2020-04-28 Thread Stephen Frost
Greetings Jonah! * Jonah H. Harris (jonah.har...@gmail.com) wrote: > On Tue, Apr 28, 2020 at 6:19 AM Andreas Karlsson wrote: > > > Do you have any examples of queries where it would help? It is pretty > > hard to say how much value some new syntax adds without seeing how it > > improves an

Re: Binary COPY IN size reduction

2020-04-28 Thread Stephen Frost
Greetings, * Lőrinc Pap (lor...@gradle.com) wrote: > Thanks for the quick response, Tom! We prefer to not top-post on these lists, just fyi. > What about implementing only the first part of my proposal, i.e. BINARY > COPY without the redundant column count & size info? For my part, at least, I

Re: More efficient RI checks - take 2

2020-04-28 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Apr 23, 2020 at 10:35 AM Tom Lane wrote: > > I think we're failing to communicate here. I agree that if the goal > > is simply to re-implement what the RI triggers currently do --- that > > is, retail one-row-at-a-time checks ---

Re: Raw device on PostgreSQL

2020-04-28 Thread Stephen Frost
Greetings, * Benjamin Schaller (benjamin.schal...@s2018.tu-chemnitz.de) wrote: > for an university project I'm currently doing some research on PostgreSQL. I > was wondering if hypothetically it would be possible to implement a raw > device system to PostgreSQL. I know that the disadvantages

Re: More efficient RI checks - take 2

2020-04-23 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Apr 22, 2020 at 6:40 PM Tom Lane wrote: > > But it's not entirely clear to me that we know the best plan for a > > statement-level RI action with sufficient certainty to go that way. > > Is it really the case that the plan would

Re: Allow pg_read_all_stats to read pg_stat_progress_*

2020-04-20 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Apr 20, 2020 at 12:43 PM Andrey M. Borodin > wrote: > > > 16 апр. 2020 г., в 17:46, Magnus Hagander > > написал(а): > > > If we do that, it may be better that we define "PGSTAT_VIEW_PRIV()" or > > > something like and replace

Re: where should I stick that backup?

2020-04-14 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Apr 12, 2020 at 8:27 PM Andres Freund wrote: > > I really think we want the option to eventually do this server-side. And > > I don't quite see it as viable to go for an API that allows to specify > > shell fragments that are

Re: where should I stick that backup?

2020-04-12 Thread Stephen Frost
Greetings, Answering both in one since they're largely the same. * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Apr 10, 2020 at 10:54:10AM -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Thu, Apr 9, 2020 at 6:44 PM Bruce Momjian w

Re: where should I stick that backup?

2020-04-12 Thread Stephen Frost
Greetings, * David Steele (da...@pgmasters.net) wrote: > On 4/12/20 6:37 PM, Andres Freund wrote: > >On 2020-04-12 17:57:05 -0400, David Steele wrote: > >>On 4/12/20 3:17 PM, Andres Freund wrote: > >>>There's various ways we could address the issue for how the subcommand > >>>can access the file

Re: pg_basebackup, manifests and backends older than ~12

2020-04-10 Thread Stephen Frost
Greetings, * David Steele (da...@pgmasters.net) wrote: > On 4/10/20 4:09 AM, Michael Paquier wrote: > >I have noticed that attempting to use pg_basebackup from HEAD leads to > >failures when using it with backend versions from 12 and older: > >$ pg_basebackup -D hoge > >pg_basebackup: error:

Re: pg_validatebackup -> pg_verifybackup?

2020-04-10 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-04-10 14:56:48 -0400, David Steele wrote: > > On 4/10/20 11:37 AM, Tom Lane wrote: > > > Robert Haas writes: > > > > Over at > > > > https://www.postgresql.org/message-id/172c9d9b-1d0a-1b94-1456-376b1e017...@2ndquadrant.com > > >

Re: where should I stick that backup?

2020-04-10 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Apr 9, 2020 at 6:44 PM Bruce Momjian wrote: > > Good point, but if there are multiple APIs, it makes shell script > > flexibility even more useful. > > This is really the key point for me. There are so many existing tools > that

Re: where should I stick that backup?

2020-04-10 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Apr 9, 2020 at 04:15:07PM -0400, Stephen Frost wrote: > > * Bruce Momjian (br...@momjian.us) wrote: > > > I think we need to step back and look at the larger issue. The real > > > argument goes back to t

Re: where should I stick that backup?

2020-04-09 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > I think we need to step back and look at the larger issue. The real > argument goes back to the Unix command-line API vs the VMS/Windows API. > The former has discrete parts that can be stitched together, while the > VMS/Windows API

Re: backup manifests

2020-04-09 Thread Stephen Frost
Greetings, * Fujii Masao (masao.fu...@oss.nttdata.com) wrote: > On 2020/04/09 2:35, Robert Haas wrote: > >On Wed, Apr 8, 2020 at 1:15 AM Fujii Masao > >wrote: > >>When there is a backup_manifest in the database cluster, it's included in > >>the backup even when --no-manifest is specified. ISTM

Re: where should I stick that backup?

2020-04-08 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Apr 8, 2020 at 2:06 PM Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Wed, Apr 8, 2020 at 1:05 PM Stephen Frost wrote: > > > > What if %f.bz2 already exists?

Re: where should I stick that backup?

2020-04-08 Thread Stephen Frost
Greeitngs, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Apr 8, 2020 at 1:05 PM Stephen Frost wrote: > > What if %f.bz2 already exists? > > That cannot occur in the scenario I described. Of course it can. > > How about if %f has a space in it? > > For

Re: where should I stick that backup?

2020-04-08 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Apr 6, 2020 at 2:23 PM Stephen Frost wrote: > > So, instead of talking about 'bzip2 > %f.bz2', and then writing into our > > documentation that that's how this feature can be used, what about > > propos

Re: where should I stick that backup?

2020-04-06 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Apr 6, 2020 at 4:45 PM Stephen Frost wrote: > > * Noah Misch (n...@leadboat.com) wrote: > > > On Fri, Apr 03, 2020 at 10:19:21AM -0400, Robert Haas wrote: > > > > What I'm thinking abou

Re: where should I stick that backup?

2020-04-06 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Apr 6, 2020 at 10:45 AM Stephen Frost wrote: > > For my 2c, at least, introducing more shell commands into critical parts > > of the system is absolutely the wrong direction to go in. > > archive_command c

Re: where should I stick that backup?

2020-04-06 Thread Stephen Frost
Greetings, * Noah Misch (n...@leadboat.com) wrote: > On Fri, Apr 03, 2020 at 10:19:21AM -0400, Robert Haas wrote: > > What I'm thinking about is: suppose we add an option to pg_basebackup > > with a name like --pipe-output. This would be mutually exclusive with > > -D, but would work at least

Re: backup manifests and contemporaneous buildfarm failures

2020-04-03 Thread Stephen Frost
Greetings, * Thomas Munro (thomas.mu...@gmail.com) wrote: > On Sat, Apr 4, 2020 at 11:13 AM Tom Lane wrote: > > Fabien COELHO writes: > > > The only strange thing under buildroot I found is: > > > > >

Re: backup manifests

2020-03-31 Thread Stephen Frost
Greetings, * Amit Kapila (amit.kapil...@gmail.com) wrote: > On Tue, Mar 31, 2020 at 11:10 AM Noah Misch wrote: > > On Mon, Mar 30, 2020 at 12:16:31PM -0700, Andres Freund wrote: > > > On 2020-03-30 15:04:55 -0400, Robert Haas wrote: > > > > I guess I'd like to be clear here that I have no

Re: GSoC Proposal

2020-03-29 Thread Stephen Frost
Greetings, * Kartik Ohri (kartikohr...@gmail.com) wrote: > Hi! Can I get some review on my GSoC proposal ? > > https://docs.google.com/document/d/1EiIHZjOjf6yWfGzKeHCbu8bJ6K1tCEcmPsD3i8lPXbg/edit?usp=sharing >

Re: [GSoC 2020] applicant proposal v2, Denis Volkov

2020-03-29 Thread Stephen Frost
Greetings, * Denis Volkov (volkov.denis@yandex.ru) wrote: > I want to apply to GSoC and this is my proposal draft. Please give me a > feedback. Great, thanks! I'd suggest you reach out to the mentors listed for this proposal directly also to make sure they see your interest, and to chat

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, On Fri, Mar 27, 2020 at 18:36 Bruce Momjian wrote: > On Thu, Mar 26, 2020 at 12:34:52PM -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > This is where I feel like I'm trying to make decisions in a vacuum. If > > > we had

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-03-27 16:57:46 -0400, Stephen Frost wrote: > > I really don't know what to say to this. WAL is absolutely critical to > > a backup being valid. pgBackRest doesn't have a way to *just* validate > > a backup

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-03-27 17:44:07 -0400, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2020-03-27 15:20:27 -0400, Robert Haas wrote: > > > > On Fri, Mar 27, 2020 at 2:29 AM Andres Freund

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-03-27 15:20:27 -0400, Robert Haas wrote: > > On Fri, Mar 27, 2020 at 2:29 AM Andres Freund wrote: > > > Hm. Should this warn if the directory's permissions are set too openly > > > (world writable?)? > > > > I don't think so, but

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-03-27 14:34:19 -0400, Robert Haas wrote: > > I think #2 is an interesting idea and could possibly reduce the danger > > of user confusion on this point considerably - because, let's face it, > > not everyone is going to read the

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Mar 27, 2020 at 11:26 AM Stephen Frost wrote: > > > Seems better to (later?) add support for generating manifests for WAL > > > files, and then have a tool that can verify all the manifests required > >

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Mar 26, 2020 at 4:44 PM Stephen Frost wrote: > > Is it actually possible, today, in PG, to have a 4GB WAL record? > > Judging this based on the WAL record size doesn't seem quite right. > > I'm not sure.

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Mar 26, 2020 at 4:37 PM David Steele wrote: > > I agree with Stephen that this should be done, but I agree with you that > > it can wait for a future commit. However, I do think: > > > > 1) It should be called out rather plainly

Re: backup manifests

2020-03-27 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-03-26 11:37:48 -0400, Robert Haas wrote: > > I'm sorry that you can't see how that's sensible, but it doesn't mean > > that it isn't sensible. It is totally unrealistic to expect that any > > backup verification tool can verify that

Re: backup manifests

2020-03-26 Thread Stephen Frost
Greetings, * Mark Dilger (mark.dil...@enterprisedb.com) wrote: > > On Mar 26, 2020, at 12:37 PM, Stephen Frost wrote: > > * Mark Dilger (mark.dil...@enterprisedb.com) wrote: > >>> On Mar 26, 2020, at 9:34 AM, Stephen Frost wrote: > >>> I'm not actually ar

Re: backup manifests

2020-03-26 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Mar 26, 2020 at 12:34 PM Stephen Frost wrote: > > I do agree with excluding things like md5 and others that aren't good > > options. I wasn't saying we should necessarily exclude crc32c either.. > &

Re: backup manifests

2020-03-26 Thread Stephen Frost
Greetings, * Mark Dilger (mark.dil...@enterprisedb.com) wrote: > > On Mar 26, 2020, at 9:34 AM, Stephen Frost wrote: > > I'm not actually argueing about which hash functions we should support, > > but rather what the default is and if crc32c, specifically, is actually >

Re: backup manifests

2020-03-26 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Mar 25, 2020 at 4:54 PM Stephen Frost wrote: > > > That's a fair argument, but I think the other relevant principle is > > > that we try to give people useful defaults for things. I think that > > >

Re: backup manifests

2020-03-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Mar 25, 2020 at 9:31 AM Stephen Frost wrote: > > I get that the default for manifest is 'no', but I don't really see how > > that means that the lack of saying anything about checksums should mean > > &quo

Re: Applying for GSOC 2020 | Need review of proposal

2020-03-25 Thread Stephen Frost
Greetings, * Gyati Mittal (gmitt...@horizon.csueastbay.edu) wrote: > I am trying to submit a draft proposal for this task: > > Develop Performance Farm Benchmarks and Website (2020) Great! I'd suggest you reach out to the mentor listed on the wiki page for that project to chat about what a

Re: backup manifests

2020-03-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Mar 23, 2020 at 6:42 PM Stephen Frost wrote: > > While I get the desire to have a default here that includes checksums, > > the way the command is structured, it strikes me as odd that the lack of > &g

Re: GSoC chat link not working

2020-03-23 Thread Stephen Frost
Greetings, * Ananya Srivastava (ananyavsrivat...@gmail.com) wrote: > irc://irc.freenode.net/postgresql link is not working and I am not able to > use the chat option to clear some doubt. here is an ss if you require it. You simply need a client that works with irc links to utilize that link.

Re: backup manifests

2020-03-23 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > I think I forgot an initializer. Try this version. Just took a quick look through this. I'm pretty sure David wants to look at it too. Anyway, some comments below. > diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml

Re: GSoC applicant proposal, Uday PB

2020-03-19 Thread Stephen Frost
Greetings, * Chapman Flack (c...@anastigmatix.net) wrote: > On 3/19/20 2:03 PM, Alexander Korotkov wrote: > > Does your project imply any coding? AFAIR, GSoC doesn't allow pure > > documentation projects. > > That's a good question. The idea as I proposed it is more of an > infrastructure

Re: GSoC applicant proposal, Uday PB

2020-03-19 Thread Stephen Frost
Greetings, * Alexander Korotkov (a.korot...@postgrespro.ru) wrote: > On Wed, Mar 18, 2020 at 8:13 AM p.b uday wrote: > > Hi PostgreSQL team, > > I am looking forward to participating in the GSoC with PostgreSQL this > > summer. Below is my draft proposal for your review. Any feedback would be

Re: [PATCH] Connection time for \conninfo

2020-03-10 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Anyway, I don't anticipate having time to do anything with this patch > > but I disagree that this is a "we don't want it" kind of thing, rather > > we maybe want it, since someon

Re: [PATCH] Connection time for \conninfo

2020-03-10 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2020-03-10 18:38, Stephen Frost wrote: > >>On 2/27/20 4:21 AM, Peter Eisentraut wrote: > >>>My opinion is that this is not particularly useful and not appropriate to > >>>pi

Re: [PATCH] Connection time for \conninfo

2020-03-10 Thread Stephen Frost
Greetings, * David Steele (da...@pgmasters.net) wrote: > On 2/27/20 4:21 AM, Peter Eisentraut wrote: > >My opinion is that this is not particularly useful and not appropriate to > >piggy-back onto \conninfo.  Connection information including host, port, > >database, user name is a

Re: Setting ACL

2020-03-04 Thread Stephen Frost
Greetings, * Vik Fearing (v...@postgresfriends.org) wrote: > So I have to manually do a diff of the two acls and generate > GRANT/REVOKE statements? That's not encouraging. :( Not sure if it's helpful to you, but pg_dump has code that generates SQL to do more-or-less exactly this. Thanks,

Re: [GsoC] Read/write transaction-level routing in Odyssey Project Idea

2020-02-27 Thread Stephen Frost
Greetings, * koschasia...@gmail.com (koschasia...@gmail.com) wrote: > I send this response to remind you of my initial email because it might have > been lost among others. Andrey is the one listed as a possible mentor for that project- I've added him to the CC list. Hopefully he'll get back

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Stephen Frost
Greetings, * Sandro Santilli (s...@kbt.io) wrote: > On pgsql-hackers we only want to find a future-proof way to "package > existing objects into an extension". If the syntax > `CREATE EXTENSION FROM UNPACKAGED` > has gone, would it be ok for just: > `CREATE EXTENSION ` > to intercept

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Stephen Frost
Greetings, * Darafei "Komяpa" Praliaskouski (m...@komzpa.net) wrote: > PostGIS 2.5 had raster and vector blended together in single extension. > In PostGIS 3, they were split out into postgis and postgis_raster extensions. For my 2c, at least, I still don't really get why that split was done. >

Re: Marking some contrib modules as trusted extensions

2020-02-18 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Andres Freund writes: > > On 2020-01-29 14:41:16 -0500, Tom Lane wrote: > >> pgcrypto > > > FWIW, given the code quality, I'm doubtful about putting itq into the > > trusted > > section. > > I don't particularly have an opinion about that

Re: Marking some contrib modules as trusted extensions

2020-02-08 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Julien Rouhaud writes: > >>> Probably NO, if only because you'd need additional privileges > >>> to use these anyway: > >>> pg_stat_statements > > > But the additional privileges are global, so assuming the extension > > has been properly

Re: pg_basebackup and snapshots

2020-02-07 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-02-07 14:56:47 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > Maybe that's looking too far into the future, but I'd like to see > > > improvements to pg_basebackup that

pg_basebackup and snapshots

2020-02-07 Thread Stephen Frost
Greetings, (Moving to -hackers, changing thread title) * Andres Freund (and...@anarazel.de) wrote: > Maybe that's looking too far into the future, but I'd like to see > improvements to pg_basebackup that make it integrate with root requiring > tooling, to do more efficient base backups. E.g.

Re: Complete data erasure

2020-02-03 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Tue, Jan 28, 2020 at 02:34:07PM -0500, Stephen Frost wrote: > >We certainly can't run external commands during transaction COMMIT, so > >this can't be part of a regular DROP TABLE. > > IMO th

Re: Removing pg_pltemplate and creating "trustable" extensions

2020-01-28 Thread Stephen Frost
Greetings, On Tue, Jan 28, 2020 at 16:17 Tom Lane wrote: > Robert Haas writes: > > On Tue, Jan 28, 2020 at 3:52 PM Tom Lane wrote: > >> I continue to think that allowing DB owners to decide this is, if not > >> fundamentally the wrong thing, at least not a feature that anybody has > >> asked

Re: Removing pg_pltemplate and creating "trustable" extensions

2020-01-28 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> The patch as I'm proposing it has nothing to do with "CREATE" rights. > >> You're attacking something different from what I actually wan

Re: Complete data erasure

2020-01-28 Thread Stephen Frost
Greetings, * asaba.takan...@fujitsu.com (asaba.takan...@fujitsu.com) wrote: > From: Stephen Frost > > * asaba.takan...@fujitsu.com (asaba.takan...@fujitsu.com) wrote: > > > This feature erases data area just before it is returned to the OS > > > (“erase” > &g

Re: our checks for read-only queries are not great

2020-01-27 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Mon, Jan 13, 2020 at 01:56:30PM -0500, Stephen Frost wrote: > > > I think that having ALTER SYSTEM commands in pg_dumpall output > > > would be a problem. It would cause all kinds of problems whenever > > >

Re: Complete data erasure

2020-01-17 Thread Stephen Frost
Greetings, * asaba.takan...@fujitsu.com (asaba.takan...@fujitsu.com) wrote: > This feature erases data area just before it is returned to the OS (“erase” > means that overwrite data area to hide its contents here) > because there is a risk that the data will be restored by attackers if it is >

Re: our checks for read-only queries are not great

2020-01-16 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Tue, Jan 14, 2020 at 1:46 PM Stephen Frost wrote: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > > Robert Haas writes: > > > > Speaking of sensible progress, I think we've drifted off on a tangent &

Re: our checks for read-only queries are not great

2020-01-15 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Jan 15, 2020 at 10:25 AM Peter Eisentraut > wrote: > > Well, if the transaction was declared read-only, then committing it > > (directly or 2PC) shouldn't change anything. This appears to be a > > circular argument. > > I don't

Re: Complete data erasure

2020-01-15 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Tomas Vondra writes: > > But let's assume it makes sense - is this really the right solution? I > > think what I'd prefer is encryption + rotation of the keys. Which should > > work properly even on COW filesystems, the performance impact is

Re: Complete data erasure

2020-01-15 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Wed, Jan 15, 2020 at 10:23:22AM -0500, Stephen Frost wrote: > >I disagree entirely. If the operating system and hardware level provide > >a way for this to work, which is actually rather common when you > &

Re: Complete data erasure

2020-01-15 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > "asaba.takan...@fujitsu.com" writes: > > I want to add the feature to erase data so that it cannot be restored > > because it prevents attackers from stealing data from released data area. > > I think this is fairly pointless, unfortunately.

Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?)

2020-01-14 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> ... We must remember how much data we encrypted > >> and then discount that much of the caller's supplied data next time. > >> Ther

Re: backup manifests

2020-01-14 Thread Stephen Frost
Greetings, * David Fetter (da...@fetter.org) wrote: > On Tue, Jan 14, 2020 at 12:53:04PM -0500, Tom Lane wrote: > > Robert Haas writes: > > > ... I would also expect that depending on an external package > > > would provoke significant opposition. If we suck the code into core, > > > then we

Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?)

2020-01-14 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > I wrote: > > Here's a draft patch that cleans up all the logic errors I could find. > > So last night I was assuming that this problem just requires more careful > attention to what to return in the error exit paths. In the light of > morning,

Re: Add pg_file_sync() to adminpack

2020-01-14 Thread Stephen Frost
Greetings, * Julien Rouhaud (rjuju...@gmail.com) wrote: > On Fri, Jan 10, 2020 at 10:50 AM Fujii Masao wrote: > > On Thu, Jan 9, 2020 at 10:39 PM Julien Rouhaud wrote: > > > I think that pg_write_server_files should be allowed to call that > > > function by default. > > > > But

Re: our checks for read-only queries are not great

2020-01-14 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > Speaking of sensible progress, I think we've drifted off on a tangent > > here about ALTER SYSTEM. > > Agreed, that's not terribly relevant for the proposed patch. I agree that the proposed patch seems alright by

Re: Removing pg_pltemplate and creating "trustable" extensions

2020-01-13 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> In the meantime, though, this idea as stated doesn't do anything except > >> let a DB owner grant install privileges to someone else. I'm not

<    5   6   7   8   9   10   11   12   13   14   >