Re: ON CONFLICT DO SELECT (take 3)

On 19 Nov 2025 at 18:19 +0100, Dean Rasheed , wrote: > On Wed, 19 Nov 2025 at 16:51, Viktor Holmberg wrote: > > > > For the CASE default, elog(ERROR, "unrecognized LockClauseStrength %d” that > > was removed. > > Would this now trigger a compile time error/warni

Re: warning on the current head

On 6 Nov 2025 at 17:59 +0100, Álvaro Herrera , wrote: > On 2025-Nov-06, Rafia Sabih wrote: > > > I am seeing following warning, > > > > In file included from specscanner.c:11: > > In file included from ../../../src/include/postgres_fe.h:28: > > ../../../src/include/c.h:113:9: warning: 'pg_restrict'

Re: ON CONFLICT DO SELECT (take 3)

On 19 Nov 2025 at 15:08 +0100, Dean Rasheed , wrote: > I made a quick pass over the code, and I'm attaching a few more > suggested updates. This is mostly cosmetic stuff (e.g., fixing a few > code comments that were overlooked), plus some minor refactoring to > reduce code duplication. Neat! For th

Re: Running a single test

On 18 Nov 2025 at 10:11 +0100, Daniel Gustafsson , wrote: > > On 18 Nov 2025, at 09:55, Viktor Holmberg wrote: > > FWIW, that doc patch would have helped me! > > > > Maybe we should resurrect it then, I tweaked it a fraction to better match > > th

Re: Running a single test

Thank you both. I was not aware of meson at all, I had some idea that it was something used exclusively by the CI server. FWIW, that doc patch would have helped me! /Viktor

Running a single test

touching the code. /Viktor Holmberg

Re: ON CONFLICT DO SELECT (take 3)

Ah, must’ve been that I added the previous thread for referene on the commitfest entry. Thanks for sorting that out. Looking forward to your review! /Viktor On 10 Nov 2025 at 10:21 +0100, Dean Rasheed , wrote: > On Tue, 7 Oct 2025 at 12:57, Viktor Holmberg wrote: > > > > This p

Re: Docs and tests for RLS policies applied by command type

Looks great. The test is easy to understand now. I’ve set the commitfest entry to “ready for committer”. /Viktor On 20 Oct 2025 at 15:29 +0200, Dean Rasheed , wrote: > While looking at the INSERT ... ON CONFLICT DO SELECT patch, I noticed > that the "Policies Applied by Command Type" table on the

Re: Docs and tests for RLS policies applied by command type

Oops, looks like CI got mad as I didn’t include all patch files - trying again. /Viktor On 20 Oct 2025 at 16:02 +0200, Viktor Holmberg , wrote: > I’ve had a look at this. > > • The doc updates make it much clearer how things work. > • For the new test, I’ve verified that they pass.

Re: Docs and tests for RLS policies applied by command type

I’ve had a look at this. • The doc updates make it much clearer how things work. • For the new test, I’ve verified that they pass. I also think that having them is very good, considering the complexity of the RLS system. I found the added test quite hectic to follow, but this could just be a me

Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2

I’ve fixed the remaining issues mentioned here, and submitted a new thread here:  https://www.postgresql.org/message-id/d631b406-13b7-433e-8c0b-c6040c4b4663%40Spark Would appreciate any help in reviewing! /Viktor On 2 Sep 2025 at 20:56 +0200, [email protected] , wrote: > Hello, I was working on my

Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values

I’ve looked through this patch. As far as I can tell, everything looks good, working and well commented. The only nitpick I could find is a mispelling "EXLCUDED" → "EXCLUDED" in src/test/regress/expected/returning.out:464. A maybe bigger question, is it nice that EXCLUDED is null when no conflic