Re: On login trigger: take three

2022-04-01 Thread a . sokolov
Daniel Gustafsson писал 2022-03-30 16:48: On 30 Mar 2022, at 13:21, Ivan Panchenko wrote: Maybe side-effects is a bit too general? Emitting a log message, rejecting a login, setting some GUCs, etc are all side-effects too. Something like this: I've reworded the docs close to what you suggest

Re: On login trigger: take three

2022-03-28 Thread a . sokolov
Daniel Gustafsson писал 2022-03-22 11:43: On 22 Mar 2022, at 04:48, Andres Freund wrote: docs fail to build: https://cirrus-ci.com/task/5556234047717376?logs=docs_build#L349 Ugh, that one was on me and not the original author. Fixed. +data initialization. It is vital that any event t

Re: On login trigger: take three

2022-03-18 Thread a . sokolov
Daniel Gustafsson писал 2022-03-15 23:52: Yeah, that was the previously posted v25 from the author (who adopted it from the original author). I took the liberty to quickly poke at the review comments you had left as well as the ones that I had found to try and progress the patch. 0001 should